[Mahara-contributors] [Bug 1927661] A patch has been submitted for review

2021-05-11 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11766

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1927661

Title:
  Mahara ends up with multiple site 'public' folders

Status in Mahara:
  Fix Committed

Bug description:
  To test:

  Make sure you have 2 other languages installed so from command line:

  sudo -u www-data php htdocs/admin/cli/sync_langpacks.php -l=es -l=de

  Then create a brand new Mahara site and login

  Check in database:

select id,title,description from artefact where artefacttype =
  'folder' and institution = 'mahara';

  You should see one row with title = 'public';

  Now change the site's language from English to Spanish in Site options
  form (not the language chooser)

  Then go to Site configuration -> Files page you should see the
  'public' folder

  Click on it then refresh the page

  You now see two 'public' folders with description in each language

  Now change the site's language from Spanish to German in Site options
  form (not the language chooser)

  Then go to Site configuration -> Files page you should see the
  'public' folder

  Click on it then refresh the page

  You now see three 'public' folders with description in each language

  ---

  What is needed is some way of recording which is the 'public' folder
  once it's first made and then rename the folder if we set a new site
  language

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1927661/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1928150] A patch has been submitted for review

2021-05-11 Thread Mahara Bot
Patch for "20.10_STABLE" branch: https://reviews.mahara.org/11765

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1928150

Title:
  Retractable blocks are cutting off the title when adding / removing
  quick edit

Status in Mahara:
  In Progress
Status in Mahara 20.10 series:
  New
Status in Mahara 21.04 series:
  New
Status in Mahara 21.10 series:
  In Progress

Bug description:
  When you load a page with retractable blocks on it and then turn on
  quick edit (magnifying glass)

  And then expand and then contract block you see heading cut off

  A follow on for the issues in bug 1927900

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1928150/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1928150] A patch has been submitted for review

2021-05-11 Thread Mahara Bot
Patch for "21.04_STABLE" branch: https://reviews.mahara.org/11764

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1928150

Title:
  Retractable blocks are cutting off the title when adding / removing
  quick edit

Status in Mahara:
  In Progress
Status in Mahara 20.10 series:
  New
Status in Mahara 21.04 series:
  New
Status in Mahara 21.10 series:
  In Progress

Bug description:
  When you load a page with retractable blocks on it and then turn on
  quick edit (magnifying glass)

  And then expand and then contract block you see heading cut off

  A follow on for the issues in bug 1927900

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1928150/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1928150] A change has been merged

2021-05-11 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/11763
Committed: 
https://git.mahara.org/mahara/mahara/commit/291297fe75f74a3d84f5e3833b75425fcb0ade22
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 291297fe75f74a3d84f5e3833b75425fcb0ade22
Author: Robert Lyon 
Date:   Wed May 12 11:32:33 2021 +1200

Bug 1928150: Fixing the grid adjustment when turning on quickedit

Change-Id: I3639ced9ae2f4f82ac571e185c813a0294dd40d9
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1928150

Title:
  Retractable blocks are cutting off the title when adding / removing
  quick edit

Status in Mahara:
  In Progress
Status in Mahara 20.10 series:
  New
Status in Mahara 21.04 series:
  New
Status in Mahara 21.10 series:
  In Progress

Bug description:
  When you load a page with retractable blocks on it and then turn on
  quick edit (magnifying glass)

  And then expand and then contract block you see heading cut off

  A follow on for the issues in bug 1927900

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1928150/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1913362] Re: Profile icons not displayed in html/pdf export's comments area

2021-05-11 Thread Doris Tam
After discussing with Kristina, there are three ways of approaching the
export of comments.

Context: Profile icons do not add value to the export comments, they're
an accessory.

1. Show the custom profile pictures
2. Use the default profile picture in place of custom profile icons
3. Don't show icons at all when exporting comments

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1913362

Title:
  Profile icons not displayed in html/pdf export's comments area

Status in Mahara:
  Confirmed

Bug description:
  When exporting a portfolio with 'Include comments' switched on, we
  expect to see the profile icon of the account holder who had made the
  comments. If the account holder customises their profile icon
  different from default placeholder, the thumbnail appears broken on
  the export.

  Steps to reproduce the bug:
  - customise your profile icon
  - create a portfolio page
  - add a page comment
  - export the page
  - check the HTML/pdf

  Expect: to see the profile icon
  Actual: broken image

  This bug also applies to artefact comments where feedback given by the
  portfolio owner and replies by other commenters have broken images
  displayed as their customised profile icons.

  I'm not sure if it depends on the filetype, however, I know that PNGs
  doesn't appear on exports.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1913362/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1928150] A patch has been submitted for review

2021-05-11 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11763

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1928150

Title:
  Retractable blocks are cutting off the title when adding / removing
  quick edit

Status in Mahara:
  In Progress
Status in Mahara 20.10 series:
  New
Status in Mahara 21.04 series:
  New
Status in Mahara 21.10 series:
  In Progress

Bug description:
  When you load a page with retractable blocks on it and then turn on
  quick edit (magnifying glass)

  And then expand and then contract block you see heading cut off

  A follow on for the issues in bug 1927900

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1928150/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1928150] [NEW] Retractable blocks are cutting off the title when adding / removing quick edit

2021-05-11 Thread Robert Lyon
Public bug reported:

When you load a page with retractable blocks on it and then turn on
quick edit (magnifying glass)

And then expand and then contract block you see heading cut off

A follow on for the issues in bug 1927900

** Affects: mahara
 Importance: Medium
 Status: In Progress

** Affects: mahara/20.10
 Importance: Undecided
 Status: New

** Affects: mahara/21.04
 Importance: Undecided
 Status: New

** Affects: mahara/21.10
 Importance: Medium
 Status: In Progress

** Attachment added: "Screenshot from 2021-05-11 10-00-56.png"
   
https://bugs.launchpad.net/bugs/1928150/+attachment/5496473/+files/Screenshot%20from%202021-05-11%2010-00-56.png

** Also affects: mahara/20.10
   Importance: Undecided
   Status: New

** Also affects: mahara/21.04
   Importance: Undecided
   Status: New

** Also affects: mahara/21.10
   Importance: Undecided
   Status: New

** Changed in: mahara/21.10
   Status: New => In Progress

** Changed in: mahara/21.10
   Importance: Undecided => Medium

** Changed in: mahara/21.10
Milestone: None => 21.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1928150

Title:
  Retractable blocks are cutting off the title when adding / removing
  quick edit

Status in Mahara:
  In Progress
Status in Mahara 20.10 series:
  New
Status in Mahara 21.04 series:
  New
Status in Mahara 21.10 series:
  In Progress

Bug description:
  When you load a page with retractable blocks on it and then turn on
  quick edit (magnifying glass)

  And then expand and then contract block you see heading cut off

  A follow on for the issues in bug 1927900

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1928150/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1916648] Re: blocktype/externalfeed/lib.php:84 count(): Parameter must be an array or an object that implements Countable

2021-05-11 Thread Robert Lyon
** Changed in: mahara/21.10
   Status: In Progress => Fix Committed

** Changed in: mahara/21.04
   Status: Confirmed => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1916648

Title:
  blocktype/externalfeed/lib.php:84  count(): Parameter must be an array
  or an object that implements Countable

Status in Mahara:
  Fix Committed
Status in Mahara 21.04 series:
  Fix Committed
Status in Mahara 21.10 series:
  Fix Committed

Bug description:
  We need to check that the variable is not empty and is an array before
  we can do the counting

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1916648/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1916648] A change has been merged

2021-05-11 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/11569
Committed: 
https://git.mahara.org/mahara/mahara/commit/9b172dc9bc772bf3dcb5308bf92b8d6e0b32aff4
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 9b172dc9bc772bf3dcb5308bf92b8d6e0b32aff4
Author: Lisa Seeto 
Date:   Wed Feb 24 09:47:06 2021 +1300

Bug 1916648: Param must implement countable

- if count has been supplied, use that otherwise default to 10

Change-Id: I754a070198b4cff2b294a2326ccf6ae83932e73c
Signed-off-by: Lisa Seeto 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1916648

Title:
  blocktype/externalfeed/lib.php:84  count(): Parameter must be an array
  or an object that implements Countable

Status in Mahara:
  Fix Committed
Status in Mahara 21.04 series:
  Fix Committed
Status in Mahara 21.10 series:
  Fix Committed

Bug description:
  We need to check that the variable is not empty and is an array before
  we can do the counting

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1916648/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1916648] A patch has been submitted for review

2021-05-11 Thread Mahara Bot
Patch for "21.04_STABLE" branch: https://reviews.mahara.org/11762

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1916648

Title:
  blocktype/externalfeed/lib.php:84  count(): Parameter must be an array
  or an object that implements Countable

Status in Mahara:
  Fix Committed
Status in Mahara 21.04 series:
  Fix Committed
Status in Mahara 21.10 series:
  Fix Committed

Bug description:
  We need to check that the variable is not empty and is an array before
  we can do the counting

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1916648/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1916648] A change has been merged

2021-05-11 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/11762
Committed: 
https://git.mahara.org/mahara/mahara/commit/a6c39472af7252910a260f53c6f74ce13c5bb8d4
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:21.04_STABLE

commit a6c39472af7252910a260f53c6f74ce13c5bb8d4
Author: Lisa Seeto 
Date:   Wed Feb 24 09:47:06 2021 +1300

Bug 1916648: Param must implement countable

- if count has been supplied, use that otherwise default to 10

Change-Id: I754a070198b4cff2b294a2326ccf6ae83932e73c
Signed-off-by: Lisa Seeto 
(cherry picked from commit 9b172dc9bc772bf3dcb5308bf92b8d6e0b32aff4)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1916648

Title:
  blocktype/externalfeed/lib.php:84  count(): Parameter must be an array
  or an object that implements Countable

Status in Mahara:
  Fix Committed
Status in Mahara 21.04 series:
  Fix Committed
Status in Mahara 21.10 series:
  Fix Committed

Bug description:
  We need to check that the variable is not empty and is an array before
  we can do the counting

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1916648/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1906558] Re: Mahara docker for Behat requires css and initcomposer make targets to run

2021-05-11 Thread Robert Lyon
** Also affects: mahara/21.04
   Importance: Undecided
   Status: New

** Changed in: mahara/21.04
Milestone: None => 21.04.1

** Changed in: mahara/21.04
   Importance: Undecided => Medium

** Changed in: mahara/21.04
   Status: New => Confirmed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1906558

Title:
  Mahara docker for Behat requires css and initcomposer make targets to
  run

Status in Mahara:
  Confirmed
Status in Mahara 21.04 series:
  Confirmed
Status in Mahara 21.10 series:
  In Progress

Bug description:
  Running the Behat tests in docker fails if the ccs and initcomposer
  make targets are not made first.

  This needs to be added to the docker/README. Also these targets should
  be added as make dependencies.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1906558/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp