[Mahara-contributors] [Bug 1901256] Re: Can't set plan task completion date to today's date
** Changed in: mahara/21.10 Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1901256 Title: Can't set plan task completion date to today's date Status in Mahara: Fix Committed Status in Mahara 21.10 series: Fix Committed Bug description: It is not possible to create a plan task with today's date as completion date because (I think) it uses midnight as time and that will have already passed. This may need to be a general fix, i.e. when we use the date picker and there is no time displayed, we always assume it is the end of the day, e.g. date at 23:59 instead of date at 00:00. To replicate: 1. Create a plan and a task. 2. In the date picker for 'Completion date' select today's date. 3. Save. Expected result: The form is saved correctly. Actual result: Error message "The completion date must be in the future." is displayed. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1901256/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1901256] A change has been merged
Reviewed: https://reviews.mahara.org/11408 Committed: https://git.mahara.org/mahara/mahara/commit/bc02d8d88b24db0de6dc84b7308acebfa7a172d6 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit bc02d8d88b24db0de6dc84b7308acebfa7a172d6 Author: Robert Lyon Date: Thu Oct 29 10:45:32 2020 +1300 Bug 1901256: Allow today's date to be used as completion date Change-Id: Iaa7bb4ad5b0322af3efc7de4be6ed16e2ab46f3d Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1901256 Title: Can't set plan task completion date to today's date Status in Mahara: Fix Committed Status in Mahara 21.10 series: Fix Committed Bug description: It is not possible to create a plan task with today's date as completion date because (I think) it uses midnight as time and that will have already passed. This may need to be a general fix, i.e. when we use the date picker and there is no time displayed, we always assume it is the end of the day, e.g. date at 23:59 instead of date at 00:00. To replicate: 1. Create a plan and a task. 2. In the date picker for 'Completion date' select today's date. 3. Save. Expected result: The form is saved correctly. Actual result: Error message "The completion date must be in the future." is displayed. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1901256/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1931879] Re: Null block records in watchlist_queue causing cannot delete group
** Description changed:
Version of Mahara: 20.04
Step to reproduce:
- User create group and then add a public page.
- Other user add this page to watchlist
- User create some new blocks
- User delete a block
User/administration cannot delete group and show error:
Mahara: Site unavailable
A nonrecoverable error occurred. This probably means you have encountered a
bug in the system
Please consider the following code lines when delete blockinstance, Are
- the lines of code inside the if statement really necessary?
+ the lines of code inside the if statement really necessary? Is there any
+ business here that i don't really understand them?
function watchlist_block_deleted(BlockInstance $block) {
global $USER;
// don't catch root's changes, especially not when installing...
if ($USER->get('id') <= 0) {
return;
}
delete_records('watchlist_queue', 'block', $block->get('id'));
if (record_exists('usr_watchlist_view', 'view', $block->get('view'))) {
$whereobj = new stdClass();
$whereobj->view = $block->get('view');
$whereobj->block = null;
$whereobj->usr = $USER->get('id');
$dataobj = clone $whereobj;
$dataobj->changed_on = date('Y-m-d H:i:s');
ensure_record_exists('watchlist_queue', $whereobj, $dataobj);
}
}
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1931879
Title:
Null block records in watchlist_queue causing cannot delete group
Status in Mahara:
New
Bug description:
Version of Mahara: 20.04
Step to reproduce:
- User create group and then add a public page.
- Other user add this page to watchlist
- User create some new blocks
- User delete a block
User/administration cannot delete group and show error:
Mahara: Site unavailable
A nonrecoverable error occurred. This probably means you have encountered a
bug in the system
Please consider the following code lines when delete blockinstance,
Are the lines of code inside the if statement really necessary? Is
there any business here that i don't really understand them?
function watchlist_block_deleted(BlockInstance $block) {
global $USER;
// don't catch root's changes, especially not when installing...
if ($USER->get('id') <= 0) {
return;
}
delete_records('watchlist_queue', 'block', $block->get('id'));
if (record_exists('usr_watchlist_view', 'view', $block->get('view'))) {
$whereobj = new stdClass();
$whereobj->view = $block->get('view');
$whereobj->block = null;
$whereobj->usr = $USER->get('id');
$dataobj = clone $whereobj;
$dataobj->changed_on = date('Y-m-d H:i:s');
ensure_record_exists('watchlist_queue', $whereobj, $dataobj);
}
}
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1931879/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1931883] [NEW] Bug while viewing submissions and feedback (submissions plugin)
Public bug reported: Hello from Bonn, We found a bug within the submissions Plug-In from Alex. When opening an assignment as a User or with a Group-Administrator, in the Plan tab. Clicking either button "Assignment Preview" or "Open Portfolio" all content is displayed twice. http:///mahara/artefact/plans/plan/view.php?group=25&id=99425 See attached screenshot for more info. Using Mahara 21.04.1 in a subdirectory. Greetings, Jochen and Philippe ** Affects: mahara Importance: Undecided Status: New ** Attachment added: "submission_and_feedback_error.png" https://bugs.launchpad.net/bugs/1931883/+attachment/5504538/+files/submission_and_feedback_error.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1931883 Title: Bug while viewing submissions and feedback (submissions plugin) Status in Mahara: New Bug description: Hello from Bonn, We found a bug within the submissions Plug-In from Alex. When opening an assignment as a User or with a Group-Administrator, in the Plan tab. Clicking either button "Assignment Preview" or "Open Portfolio" all content is displayed twice. http:///mahara/artefact/plans/plan/view.php?group=25&id=99425 See attached screenshot for more info. Using Mahara 21.04.1 in a subdirectory. Greetings, Jochen and Philippe To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1931883/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1931879] [NEW] Null block records in watchlist_queue causing cannot delete group
Public bug reported:
Version of Mahara: 20.04
Step to reproduce:
- User create group and then add a public page.
- Other user add this page to watchlist
- User create some new blocks
- User delete a block
User/administration cannot delete group and show error:
Mahara: Site unavailable
A nonrecoverable error occurred. This probably means you have encountered a bug
in the system
Please consider the following code lines when delete blockinstance, Are
the lines of code inside the if statement really necessary?
function watchlist_block_deleted(BlockInstance $block) {
global $USER;
// don't catch root's changes, especially not when installing...
if ($USER->get('id') <= 0) {
return;
}
delete_records('watchlist_queue', 'block', $block->get('id'));
if (record_exists('usr_watchlist_view', 'view', $block->get('view'))) {
$whereobj = new stdClass();
$whereobj->view = $block->get('view');
$whereobj->block = null;
$whereobj->usr = $USER->get('id');
$dataobj = clone $whereobj;
$dataobj->changed_on = date('Y-m-d H:i:s');
ensure_record_exists('watchlist_queue', $whereobj, $dataobj);
}
}
** Affects: mahara
Importance: Undecided
Status: New
** Summary changed:
- Currently when a person adds a page to their watchlist and page owner remove
a exsiting block in page or create a block then remove it causing adminstration
or group owner cannot delete this group.
+ Null block records causing cannot delete group
** Summary changed:
- Null block records causing cannot delete group
+ Null block records in watchlist_queue causing cannot delete group
** Description changed:
- Currently when a person adds a page to their watchlist and page owner remove
a exsiting block in page or create a block then remove it causing adminstration
or group owner cannot delete this group.
- Please consider the following code lines when delete blockinstance, Are the
lines of code inside the if statement really necessary?
-
- function watchlist_block_deleted(BlockInstance $block) {
- global $USER;
- // don't catch root's changes, especially not when installing...
- if ($USER->get('id') <= 0) {
- return;
- }
+ Step to reproduce:
+ - User create group and then add a public page.
+ - Other user add this page to watchlist
+ - User create some new blocks
+ - User delete a block
+ User/administration cannot delete group and show error.
- delete_records('watchlist_queue', 'block', $block->get('id'));
+ Please consider the following code lines when delete blockinstance, Are
+ the lines of code inside the if statement really necessary?
- if (record_exists('usr_watchlist_view', 'view', $block->get('view'))) {
- $whereobj = new stdClass();
- $whereobj->view = $block->get('view');
- $whereobj->block = null;
- $whereobj->usr = $USER->get('id');
- $dataobj = clone $whereobj;
- $dataobj->changed_on = date('Y-m-d H:i:s');
- ensure_record_exists('watchlist_queue', $whereobj, $dataobj);
- }
+ function watchlist_block_deleted(BlockInstance $block) {
+ global $USER;
+
+ // don't catch root's changes, especially not when installing...
+ if ($USER->get('id') <= 0) {
+ return;
+ }
+
+ delete_records('watchlist_queue', 'block', $block->get('id'));
+
+ if (record_exists('usr_watchlist_view', 'view', $block->get('view'))) {
+ $whereobj = new stdClass();
+ $whereobj->view = $block->get('view');
+ $whereobj->block = null;
+ $whereobj->usr = $USER->get('id');
+ $dataobj = clone $whereobj;
+ $dataobj->changed_on = date('Y-m-d H:i:s');
+ ensure_record_exists('watchlist_queue', $whereobj, $dataobj);
+ }
}
** Description changed:
-
Step to reproduce:
- User create group and then add a public page.
- Other user add this page to watchlist
- User create some new blocks
- User delete a block
- User/administration cannot delete group and show error.
+ User/administration cannot delete group and show error:
+
+ ahara: Site unavailable
+ A nonrecoverable error occurred. This probably means you have encountered a
bug in the system
Please consider the following code lines when delete blockinstance, Are
the lines of code inside the if statement really necessary?
function watchlist_block_deleted(BlockInstance $block) {
global $USER;
// don't catch root's changes, especially not when installing...
if ($USER->get('id') <= 0) {
return;
}
delete_records('watchlist_queue', 'block', $block->get('id'));
if (record_exists('usr_watchlist_view', 'view', $block->get('view'))) {
$whereobj = new stdClass();
$whereobj->view = $block->get('view');
$whereobj->block = null;
$whereobj->usr = $USER->get('id');
$dataobj = clone $whereobj;
$dataobj->chan
