[Mahara-contributors] [Bug 1997308] [NEW] SAML affiliated emails can cause email drift
Public bug reported: Where the primary email in artefact_internal_profile_email is different to the email listed in usr.email field This is because the $user->email value is updated with the 'email' field from SAML and is not overridden by the affiliate email value when logging in and updating a user record ** Affects: mahara Importance: High Status: In Progress ** Affects: mahara/22.10 Importance: High Status: Confirmed ** Affects: mahara/23.04 Importance: High Status: In Progress ** Changed in: mahara Status: New => In Progress ** Also affects: mahara/22.10 Importance: Undecided Status: New ** Also affects: mahara/23.04 Importance: Undecided Status: In Progress ** Changed in: mahara/22.10 Status: New => Confirmed ** Changed in: mahara/23.04 Importance: Undecided => Medium ** Changed in: mahara/22.10 Importance: Undecided => Medium ** Changed in: mahara/22.10 Importance: Medium => High ** Changed in: mahara/23.04 Milestone: None => 23.04.0 ** Changed in: mahara/22.10 Milestone: None => 22.10.1 ** Changed in: mahara/23.04 Importance: Medium => High -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1997308 Title: SAML affiliated emails can cause email drift Status in Mahara: In Progress Status in Mahara 22.10 series: Confirmed Status in Mahara 23.04 series: In Progress Bug description: Where the primary email in artefact_internal_profile_email is different to the email listed in usr.email field This is because the $user->email value is updated with the 'email' field from SAML and is not overridden by the affiliate email value when logging in and updating a user record To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1997308/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1991604] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13489 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1991604 Title: Outcomes portfolio (4): Activity page infrastructure Status in Mahara: Confirmed Bug description: Part of the outcomes portfolio blueprint: https://blueprints.launchpad.net/mahara/+spec/outcomes-portfolio Better formatting: https://wiki.mahara.org/wiki/Proposals/Outcomes_portfolio/Activity_page_infrastructure # Activity page infrastructure ## High level overview * Add activity information to the page settings → Create a new portfolio page type * Pull in information from tables and people to auto-populate information * Display activity information set up on the page settings page * Update certain information directly while editing or viewing the activity page * Dealing with 'signing off' / completing activities ## Details ### Mock-up reference: 'Set up activity page – group tutor and group admin' **Who?** As group tutor or group admin... **What?** I want to set up activites for the group member... **Why?** So that all admin work is collected in one place and then available when I work with the group member on a particular activity. The numbered list refers to the bullets in the mock-up 'Set up activity page – group tutors and group admin'. This page is only accessible to group tutors and group admins. Students cannot get to it. 1. [no change] Page title: It's a short title of the activity to avoid that the heading of a page is longer than one line and therefore fits better into a navigation menu. This title is pulled into the outcomes overview page automatically. Mandatory field. 2. Activity information panel: automatically uncollapsed as information needs to be entered. 3. Activity description: Long title of the activity. Mandatory field. 4. Subject: Select list with hard-coded items (phase 1). 5. Responsible staff: Select list comprised of all group tutors and group admins from this group. The person filling in the form is automatically displayed as default choice. 6. Start date: Date picker. 7. End date: Date picker. Check that the end date is greater or equal to the start date. 8. Levels of achievement: Three single-line text entry fields. The fourth level is predefined. * Icons are assigned automatically. * Level 1 is the highest achievement and level 4 the lowest. * Suggested icons: Font Awesome number corresponding to the level with a circle around it in primary theme link colour but with a new variable set up if a different colour should be used. This will need to be achieved with stacked icons, e.g. icon-1 and icon-circle. * New table 'view_activity_achievement_levels' with ID, view_activity_ID (i.e. the view ID), priority column (1-4), value and level 4 always being the same (via hidden value). 9. Clicking 'Save' takes you to the 'Edit' screen of the activity page. > Notes: > > * The page buttons have changed slightly in Mahara 22.10 and thus will be used instead of the ones pictured on the mock-up. > * This settings page is only available to group tutors and group admins. > * The rest of the page settings stay as they are in the 'Advanced' panel. > * 'Prevent removing of blocks' in the 'Advanced' panel is automatically set to 'Yes' (see section 'Group changes') but can be changed to 'No'. ### Mock-up reference: 'Edit activity page – group tutor and group admin' **Who?** As group tutor or group admin... **What?** I want to add content to the activity page... **Why?** To assist the learner with their evidence collection and mark checkpoints as completed to illustrate progress. The numbered list refers to the bullets in the mock-up 'Edit activity page – group tutor and group admin'. This page is accessible to group tutors, group admins, and learners. 1. 'Settings' button: Available to group tutor and group admins to change information about the activity. It's not accessible to regular group members. 2. Activity information: * is displayed at the top of the page and cannot be moved. * is displayed collapsed so that you only see the long-form activity, outcomes, outcome type, and whether the outcome has been achieved or not in the panel header. * is a full-page width block. → Change the default width of blocks in Mahara when they are put on a page into full-page width blocks 3. Activity description: Long 'title' of the activity. 4. Outcome: Short title of the outcome to which this activity belongs. 5. Outcome type: Pulled from the outcome, i.e. short name with the predefined background colour. 6. Achieved: Switch to decide whether an outcome has been achieved or not. This can always be changed. A modal is displayed to c
[Mahara-contributors] [Bug 1997291] Re: DOMDocument::loadHTML() expecting '; '
** Changed in: mahara Milestone: None => 23.04.0 ** Changed in: mahara Milestone: 23.04.0 => 22.10.1 ** Also affects: mahara/23.04 Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1997291 Title: DOMDocument::loadHTML() expecting ';' Status in Mahara: New Status in Mahara 23.04 series: New Bug description: While running /lib/cron.php I noticed a lot of PHP Warnings on the next page load. These are also in the error log. My current suspicion is that these are triggered when trying to send e-mail about forum activity. The actual error: DOMDocument::loadHTML(): htmlParseEntityRef: expecting ';' in Entity. While this is a PHP Warning it isn't causing crashes. However, it will be filling up error logs and may be causing unexpected behaviour in other places. This error is occurring whenever html2text() is called. This is calling HtmltoText which calls DOMDocument and this is where the error happens. When DOMDocument::loadHTML() is called the errors are thrown whenever a non-encoded ampersand is found in the document. i.e. & rather than & Showing the error in an interactive shell: php > # Example 1: php > $s = 'Forum topichttps://dev.mahara.local/artefact/file/download.php?file=193&embedded=1&group=1&topic=1&post=1";>'; php > php > # Example 2 is to demonstrate a working version of the string: php > $t = 'Forum topichttps://dev.mahara.local/artefact/file/download.php?file=193&embedded=1&group=1&topic=1&post=1";>'; php > php > $doc = new DOMDocument; php > $doc->loadHTML($s); PHP Warning: DOMDocument::loadHTML(): htmlParseEntityRef: expecting ';' in Entity, line: 2 in php shell code on line 1 PHP Warning: DOMDocument::loadHTML(): htmlParseEntityRef: expecting ';' in Entity, line: 2 in php shell code on line 1 PHP Warning: DOMDocument::loadHTML(): htmlParseEntityRef: expecting ';' in Entity, line: 2 in php shell code on line 1 PHP Warning: DOMDocument::loadHTML(): htmlParseEntityRef: expecting ';' in Entity, line: 2 in php shell code on line 1 php > $doc->loadHTML($t); php > The examples I've been finding are in interaction_forum_post's with images in them. The specific code that causes this to come about looks to be in in prepare_post_body() in htdocs/interaction/forum/lib.php. This is explicitly stripping out & and leaving just the & character in any tags that have a call to download.php when a post is saved. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1997291/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1997298] [NEW] Copying a Collection with SmartEvidence throws errors
Public bug reported: When copying a Collection with SmartEvidence the attached errors show up. This appears to be from the foreach ($evidences as $evidence) loop when $newartefact does not appear as a key in $newblocks. To replicate: * Create a Collection * Add SmarteEvidence * Add an Annotation block * Copy the Collection. ** Affects: mahara Importance: Undecided Status: New ** Tags: smartevidence ** Attachment added: "Screenshot from 2022-11-22 15-33-30.png" https://bugs.launchpad.net/bugs/1997298/+attachment/5631966/+files/Screenshot%20from%202022-11-22%2015-33-30.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1997298 Title: Copying a Collection with SmartEvidence throws errors Status in Mahara: New Bug description: When copying a Collection with SmartEvidence the attached errors show up. This appears to be from the foreach ($evidences as $evidence) loop when $newartefact does not appear as a key in $newblocks. To replicate: * Create a Collection * Add SmarteEvidence * Add an Annotation block * Copy the Collection. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1997298/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1997291] [NEW] DOMDocument::loadHTML() expecting '; '
Public bug reported: While running /lib/cron.php I noticed a lot of PHP Warnings on the next page load. These are also in the error log. My current suspicion is that these are triggered when trying to send e-mail about forum activity. The actual error: DOMDocument::loadHTML(): htmlParseEntityRef: expecting ';' in Entity. While this is a PHP Warning it isn't causing crashes. However, it will be filling up error logs and may be causing unexpected behaviour in other places. This error is occurring whenever html2text() is called. This is calling HtmltoText which calls DOMDocument and this is where the error happens. When DOMDocument::loadHTML() is called the errors are thrown whenever a non-encoded ampersand is found in the document. i.e. & rather than & Showing the error in an interactive shell: php > # Example 1: php > $s = 'Forum topichttps://dev.mahara.local/artefact/file/download.php?file=193&embedded=1&group=1&topic=1&post=1";>'; php > php > # Example 2 is to demonstrate a working version of the string: php > $t = 'Forum topichttps://dev.mahara.local/artefact/file/download.php?file=193&embedded=1&group=1&topic=1&post=1";>'; php > php > $doc = new DOMDocument; php > $doc->loadHTML($s); PHP Warning: DOMDocument::loadHTML(): htmlParseEntityRef: expecting ';' in Entity, line: 2 in php shell code on line 1 PHP Warning: DOMDocument::loadHTML(): htmlParseEntityRef: expecting ';' in Entity, line: 2 in php shell code on line 1 PHP Warning: DOMDocument::loadHTML(): htmlParseEntityRef: expecting ';' in Entity, line: 2 in php shell code on line 1 PHP Warning: DOMDocument::loadHTML(): htmlParseEntityRef: expecting ';' in Entity, line: 2 in php shell code on line 1 php > $doc->loadHTML($t); php > The examples I've been finding are in interaction_forum_post's with images in them. The specific code that causes this to come about looks to be in in prepare_post_body() in htdocs/interaction/forum/lib.php. This is explicitly stripping out & and leaving just the & character in any tags that have a call to download.php when a post is saved. ** Affects: mahara Importance: Undecided Status: New ** Attachment added: "Example of the error when presented on screen." https://bugs.launchpad.net/bugs/1997291/+attachment/5631956/+files/Screenshot%20from%202022-11-22%2012-59-56.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1997291 Title: DOMDocument::loadHTML() expecting ';' Status in Mahara: New Bug description: While running /lib/cron.php I noticed a lot of PHP Warnings on the next page load. These are also in the error log. My current suspicion is that these are triggered when trying to send e-mail about forum activity. The actual error: DOMDocument::loadHTML(): htmlParseEntityRef: expecting ';' in Entity. While this is a PHP Warning it isn't causing crashes. However, it will be filling up error logs and may be causing unexpected behaviour in other places. This error is occurring whenever html2text() is called. This is calling HtmltoText which calls DOMDocument and this is where the error happens. When DOMDocument::loadHTML() is called the errors are thrown whenever a non-encoded ampersand is found in the document. i.e. & rather than & Showing the error in an interactive shell: php > # Example 1: php > $s = 'Forum topichttps://dev.mahara.local/artefact/file/download.php?file=193&embedded=1&group=1&topic=1&post=1";>'; php > php > # Example 2 is to demonstrate a working version of the string: php > $t = 'Forum topichttps://dev.mahara.local/artefact/file/download.php?file=193&embedded=1&group=1&topic=1&post=1";>'; php > php > $doc = new DOMDocument; php > $doc->loadHTML($s); PHP Warning: DOMDocument::loadHTML(): htmlParseEntityRef: expecting ';' in Entity, line: 2 in php shell code on line 1 PHP Warning: DOMDocument::loadHTML(): htmlParseEntityRef: expecting ';' in Entity, line: 2 in php shell code on line 1 PHP Warning: DOMDocument::loadHTML(): htmlParseEntityRef: expecting ';' in Entity, line: 2 in php shell code on line 1 PHP Warning: DOMDocument::loadHTML(): htmlParseEntityRef: expecting ';' in Entity, line: 2 in php shell code on line 1 php > $doc->loadHTML($t); php > The examples I've been finding are in interaction_forum_post's with images in them. The specific code that causes this to come about looks to be in in prepare_post_body() in htdocs/interaction/forum/lib.php. This is explicitly stripping out & and leaving just the & character in any tags that have a call to download.php when a post is saved. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1997291/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-
[Mahara-contributors] [Bug 1991604] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13488 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1991604 Title: Outcomes portfolio (4): Activity page infrastructure Status in Mahara: Confirmed Bug description: Part of the outcomes portfolio blueprint: https://blueprints.launchpad.net/mahara/+spec/outcomes-portfolio Better formatting: https://wiki.mahara.org/wiki/Proposals/Outcomes_portfolio/Activity_page_infrastructure # Activity page infrastructure ## High level overview * Add activity information to the page settings → Create a new portfolio page type * Pull in information from tables and people to auto-populate information * Display activity information set up on the page settings page * Update certain information directly while editing or viewing the activity page * Dealing with 'signing off' / completing activities ## Details ### Mock-up reference: 'Set up activity page – group tutor and group admin' **Who?** As group tutor or group admin... **What?** I want to set up activites for the group member... **Why?** So that all admin work is collected in one place and then available when I work with the group member on a particular activity. The numbered list refers to the bullets in the mock-up 'Set up activity page – group tutors and group admin'. This page is only accessible to group tutors and group admins. Students cannot get to it. 1. [no change] Page title: It's a short title of the activity to avoid that the heading of a page is longer than one line and therefore fits better into a navigation menu. This title is pulled into the outcomes overview page automatically. Mandatory field. 2. Activity information panel: automatically uncollapsed as information needs to be entered. 3. Activity description: Long title of the activity. Mandatory field. 4. Subject: Select list with hard-coded items (phase 1). 5. Responsible staff: Select list comprised of all group tutors and group admins from this group. The person filling in the form is automatically displayed as default choice. 6. Start date: Date picker. 7. End date: Date picker. Check that the end date is greater or equal to the start date. 8. Levels of achievement: Three single-line text entry fields. The fourth level is predefined. * Icons are assigned automatically. * Level 1 is the highest achievement and level 4 the lowest. * Suggested icons: Font Awesome number corresponding to the level with a circle around it in primary theme link colour but with a new variable set up if a different colour should be used. This will need to be achieved with stacked icons, e.g. icon-1 and icon-circle. * New table 'view_activity_achievement_levels' with ID, view_activity_ID (i.e. the view ID), priority column (1-4), value and level 4 always being the same (via hidden value). 9. Clicking 'Save' takes you to the 'Edit' screen of the activity page. > Notes: > > * The page buttons have changed slightly in Mahara 22.10 and thus will be used instead of the ones pictured on the mock-up. > * This settings page is only available to group tutors and group admins. > * The rest of the page settings stay as they are in the 'Advanced' panel. > * 'Prevent removing of blocks' in the 'Advanced' panel is automatically set to 'Yes' (see section 'Group changes') but can be changed to 'No'. ### Mock-up reference: 'Edit activity page – group tutor and group admin' **Who?** As group tutor or group admin... **What?** I want to add content to the activity page... **Why?** To assist the learner with their evidence collection and mark checkpoints as completed to illustrate progress. The numbered list refers to the bullets in the mock-up 'Edit activity page – group tutor and group admin'. This page is accessible to group tutors, group admins, and learners. 1. 'Settings' button: Available to group tutor and group admins to change information about the activity. It's not accessible to regular group members. 2. Activity information: * is displayed at the top of the page and cannot be moved. * is displayed collapsed so that you only see the long-form activity, outcomes, outcome type, and whether the outcome has been achieved or not in the panel header. * is a full-page width block. → Change the default width of blocks in Mahara when they are put on a page into full-page width blocks 3. Activity description: Long 'title' of the activity. 4. Outcome: Short title of the outcome to which this activity belongs. 5. Outcome type: Pulled from the outcome, i.e. short name with the predefined background colour. 6. Achieved: Switch to decide whether an outcome has been achieved or not. This can always be changed. A modal is displayed to c
[Mahara-contributors] [Bug 1997199] Re: Group tutors cannot create new pages - page stays loading
Unable to replicate :/ ** Changed in: mahara/22.10 Status: Confirmed => Invalid ** Changed in: mahara/23.04 Status: Confirmed => Invalid ** No longer affects: mahara/22.10 ** No longer affects: mahara/23.04 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1997199 Title: Group tutors cannot create new pages - page stays loading Status in Mahara: Invalid Bug description: Set up: 1. Create a controlled group and change the type to 'Course' so that the role 'Tutor' is available. 2. Add a member to the group as a tutor 3. Log in as the tutor and create a new page Expectation: Page is created Reality: The page stays loading and never finishes Dev: the function 'role_has_permission' gets called when a group 'member' creates a page. However, when tutors create a page, this is skipped. It might be missing some checks. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1997199/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1997280] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13487 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1997280 Title: LTI/LTI_Advantage and webservice check Status in Mahara: New Bug description: Now that we pair up webservice auth instances to the thing that required them it means we can have more than one auth instance where the institution and authmethod are the same. But in LTI / LTI_Advantage we do a get_field() check that expects only one record to be returned. We need to adjust this check to make sure at least one record exists. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1997280/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1997280] [NEW] LTI/LTI_Advantage and webservice check
Public bug reported: Now that we pair up webservice auth instances to the thing that required them it means we can have more than one auth instance where the institution and authmethod are the same. But in LTI / LTI_Advantage we do a get_field() check that expects only one record to be returned. We need to adjust this check to make sure at least one record exists. ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1997280 Title: LTI/LTI_Advantage and webservice check Status in Mahara: New Bug description: Now that we pair up webservice auth instances to the thing that required them it means we can have more than one auth instance where the institution and authmethod are the same. But in LTI / LTI_Advantage we do a get_field() check that expects only one record to be returned. We need to adjust this check to make sure at least one record exists. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1997280/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1997199] Re: Group tutors cannot create new pages - page stays loading
** Changed in: mahara/22.10 Importance: Undecided => Medium ** Changed in: mahara/23.04 Importance: Undecided => Medium ** No longer affects: mahara/22.04 ** Changed in: mahara/23.04 Status: New => Confirmed ** Changed in: mahara/22.10 Status: New => Confirmed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1997199 Title: Group tutors cannot create new pages - page stays loading Status in Mahara: Confirmed Status in Mahara 22.10 series: Confirmed Status in Mahara 23.04 series: Confirmed Bug description: Set up: 1. Create a controlled group and change the type to 'Course' so that the role 'Tutor' is available. 2. Add a member to the group as a tutor 3. Log in as the tutor and create a new page Expectation: Page is created Reality: The page stays loading and never finishes Dev: the function 'role_has_permission' gets called when a group 'member' creates a page. However, when tutors create a page, this is skipped. It might be missing some checks. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1997199/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
