[Mahara-contributors] [Bug 1997298] A patch has been submitted for review

2022-11-24 Thread Mahara Bot
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13520

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1997298

Title:
  Copying a Collection with SmartEvidence throws errors

Status in Mahara:
  In Progress

Bug description:
  When copying a Collection with SmartEvidence the attached errors show
  up.

  This appears to be from the foreach ($evidences as $evidence) loop
  when $newartefact does not appear as a key in $newblocks.

  To replicate:

  * Create a Collection
* Add SmarteEvidence
* Add an Annotation block 
  * Copy the Collection.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1997298/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1997298] Re: Copying a Collection with SmartEvidence throws errors

2022-11-24 Thread Doris Tam
** Changed in: mahara
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1997298

Title:
  Copying a Collection with SmartEvidence throws errors

Status in Mahara:
  In Progress

Bug description:
  When copying a Collection with SmartEvidence the attached errors show
  up.

  This appears to be from the foreach ($evidences as $evidence) loop
  when $newartefact does not appear as a key in $newblocks.

  To replicate:

  * Create a Collection
* Add SmarteEvidence
* Add an Annotation block 
  * Copy the Collection.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1997298/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1997298] Re: Copying a Collection with SmartEvidence throws errors

2022-11-24 Thread Robert Lyon
Here are some testing instructions to replicate the issue:

1) Create site and login as admin
2) Turn on annotation blocktype in Extensions -> Plugin administration  (if 
it's not active)
3) In Institutions -> Settings enable Smart Evidence for 'mahara' institution
Login as normal user
4) make a blank page (Create button)
5) make a collection (Create button) and choose a 'SmartEvidence framework' 
then save and add the page to it
6) Go to the collection an on the Smart Evidence page of collection click a spot
7) add annotation text AND embed an image by uploading a new image
8) go to the normal page of the collection
9) copy the collection via the 3 dots menu on right and choose 'collection'

Get the error

[WAR] 1a (lib/collection.php:711) Undefined offset: 184
[WAR] 1a (lib/collection.php:711) Trying to get property 'view' of non-object

The reason for this (I believe) is the SQL to match up the evidence
finds not only the annotation artefact attached to the block (the block
id found in the annotation column in framework_evidence table) but also
the embedded image artefact associated with the block (vie view_artefact
table) and it's trying to handle this artefact as an annotation artefact
too and failing

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1997298

Title:
  Copying a Collection with SmartEvidence throws errors

Status in Mahara:
  New

Bug description:
  When copying a Collection with SmartEvidence the attached errors show
  up.

  This appears to be from the foreach ($evidences as $evidence) loop
  when $newartefact does not appear as a key in $newblocks.

  To replicate:

  * Create a Collection
* Add SmarteEvidence
* Add an Annotation block 
  * Copy the Collection.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1997298/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1997918] Re: Message "send message" page has broken layout due to nested tags

2022-11-24 Thread Robert Lyon
** Description changed:

  Currently under certain conditions the previous message display looks
- broken.
+ broken in the collapsible area part.
  
  This is due to a  tag being nested within another  tag.
  
  Coding standards say "Nested links are illegal - The a element can be wrapped 
around entire
  paragraphs, lists, tables, and so forth, even entire sections, so long
  as there is no interactive content within (e.g., buttons or other links)."
  
- We need to fix this up so that it follows html guidelines and also
- doesn't lose any information
+ We need to fix this up so that it follows html guidelines and also keeps
+ the info we want

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1997918

Title:
  Message "send message" page has broken layout due to nested  tags

Status in Mahara:
  New

Bug description:
  Currently under certain conditions the previous message display looks
  broken in the collapsible area part.

  This is due to a  tag being nested within another  tag.

  Coding standards say "Nested links are illegal - The a element can be wrapped 
around entire
  paragraphs, lists, tables, and so forth, even entire sections, so long
  as there is no interactive content within (e.g., buttons or other links)."

  We need to fix this up so that it follows html guidelines and also
  keeps the info we want

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1997918/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1997918] Re: Message "send message" page has broken layout due to nested tags

2022-11-24 Thread Robert Lyon
** Attachment added: "Screenshot 2022-11-25 at 13-53-44 Send message - 
Mahara.png"
   
https://bugs.launchpad.net/mahara/+bug/1997918/+attachment/5632732/+files/Screenshot%202022-11-25%20at%2013-53-44%20Send%20message%20-%20Mahara.png

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1997918

Title:
  Message "send message" page has broken layout due to nested  tags

Status in Mahara:
  New

Bug description:
  Currently under certain conditions the previous message display looks
  broken.

  This is due to a  tag being nested within another  tag.

  Coding standards say "Nested links are illegal - The a element can be wrapped 
around entire
  paragraphs, lists, tables, and so forth, even entire sections, so long
  as there is no interactive content within (e.g., buttons or other links)."

  We need to fix this up so that it follows html guidelines and also
  doesn't lose any information

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1997918/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1997918] [NEW] Message "send message" page has broken layout due to nested tags

2022-11-24 Thread Robert Lyon
Public bug reported:

Currently under certain conditions the previous message display looks
broken.

This is due to a  tag being nested within another  tag.

Coding standards say "Nested links are illegal - The a element can be wrapped 
around entire
paragraphs, lists, tables, and so forth, even entire sections, so long
as there is no interactive content within (e.g., buttons or other links)."

We need to fix this up so that it follows html guidelines and also
doesn't lose any information

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1997918

Title:
  Message "send message" page has broken layout due to nested  tags

Status in Mahara:
  New

Bug description:
  Currently under certain conditions the previous message display looks
  broken.

  This is due to a  tag being nested within another  tag.

  Coding standards say "Nested links are illegal - The a element can be wrapped 
around entire
  paragraphs, lists, tables, and so forth, even entire sections, so long
  as there is no interactive content within (e.g., buttons or other links)."

  We need to fix this up so that it follows html guidelines and also
  doesn't lose any information

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1997918/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1997298] Re: Copying a Collection with SmartEvidence throws errors

2022-11-24 Thread Doris Tam
** Changed in: mahara
 Assignee: (unassigned) => Doris Tam (doristam)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1997298

Title:
  Copying a Collection with SmartEvidence throws errors

Status in Mahara:
  New

Bug description:
  When copying a Collection with SmartEvidence the attached errors show
  up.

  This appears to be from the foreach ($evidences as $evidence) loop
  when $newartefact does not appear as a key in $newblocks.

  To replicate:

  * Create a Collection
* Add SmarteEvidence
* Add an Annotation block 
  * Copy the Collection.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1997298/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1997906] [NEW] LDAP not working in correctly in 22.10

2022-11-24 Thread Robert Lyon
Public bug reported:

We now get a:

PHP Fatal error:  Cannot redeclare group_user_access() (previously
declared in /var/www/html/lib/group.php:38) in
/var/www/html/lib/group.php on line 38

This is because we are already including the lib/group.php file earlier
in the chain of loading things in some instances.

We need to adjust the require() calls to require_once()

** Affects: mahara
 Importance: High
 Status: In Progress

** Affects: mahara/22.10
 Importance: High
 Status: In Progress

** Affects: mahara/23.04
 Importance: High
 Status: In Progress

** Changed in: mahara
   Status: New => In Progress

** Changed in: mahara
   Importance: Undecided => High

** Also affects: mahara/23.04
   Importance: High
   Status: In Progress

** Also affects: mahara/22.10
   Importance: Undecided
   Status: New

** Changed in: mahara/22.10
   Importance: Undecided => High

** Changed in: mahara/23.04
Milestone: None => 23.04.0

** Changed in: mahara/22.10
Milestone: None => 22.10.1

** Changed in: mahara/22.10
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1997906

Title:
  LDAP not working in  correctly in 22.10

Status in Mahara:
  In Progress
Status in Mahara 22.10 series:
  In Progress
Status in Mahara 23.04 series:
  In Progress

Bug description:
  We now get a:

  PHP Fatal error:  Cannot redeclare group_user_access() (previously
  declared in /var/www/html/lib/group.php:38) in
  /var/www/html/lib/group.php on line 38

  This is because we are already including the lib/group.php file
  earlier in the chain of loading things in some instances.

  We need to adjust the require() calls to require_once()

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1997906/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1991603] A patch has been submitted for review

2022-11-24 Thread Mahara Bot
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13497

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1991603

Title:
  Outcomes portfolio (3): 'Outcomes' infrastructure in the group
  collection

Status in Mahara:
  In Progress

Bug description:
  Part of the outcomes portfolio blueprint:
  https://blueprints.launchpad.net/mahara/+spec/outcomes-portfolio

  Better formatting:
  
https://wiki.mahara.org/wiki/Proposals/Outcomes_portfolio/Outcomes_infrastructure_in_a_group_collection

  ## High level overview

  * Create the 'Manage outcomes' page infrastructure ('Manage outcomes – group 
admin only' mock-up)
  * Create the outcomes overview page and infrastructure
  * Allow for the direct editing of fields
  * Allow for the clicking of icons to complete outcomes and activities
  * Create new pages (activities) from this page and set them up
  * Pull in activity information from the individual pages
  * Respect permissions for the different types of group members and who can 
edit or only see what

  ## Details

  ### Mock-up reference: 'Set up the outcomes collection - group admin
  only'

  **Who?** As a group admin...

  **What?** I want to be able to set up an outcomes collection...

  **Why?** So that group tutors or I can add activities and prepare
  everything for the group member to get started.

  The collection is set up in a group for a particular group member by a
  group admin. The numbered list refers to the bullets in the mock-up
  'Set up the outcomes collection - group admin only'.

  1. [no change] Collection name: Title of the outcomes portfolio. You can 
choose that freely, but might want to establish a convention to differentiate 
between the different plans that a group member may have.
  2. Per default, the option 'Outcomes portfolio' is set to 'Yes'. This is done 
automatically when the institution selected to work with outcomes portfolios 
(see section 'Outcomes portfolio setting and database tables').
  3. You can select the outcomes category from which all outcomes within the 
collection shall take their outcome type. If there is only one category, the 
category is displayed without the drop-down menu.
  4. Clicking the 'Continue' button takes you to a new page where you can 
manage the outcomes.
  Additional changes (not pictured):

  5. Option 'Manage outcomes' is accessible from the collection settings screen 
and also on the 'Portfolios' overview page when clicking the 'More options' 
icon on a collection for group admins only.
  6. Option 'Manage pages' is not available from the collection settings screen 
or via the 'More options' icon on a collection on the 'Portfolios' overview 
page to avoid pages from being added to or removed from the collection outside 
of the outcomes framework. It can also not be reached by URL.

  > Out of scope: Be able to add regular portfolio pages to the
  collection and not only activity pages.

  ### Mock-up reference: 'Manage outcomes - group admin only'

  **Who?** As a group admin...

  **What?** I want to enter the outcomes for a group member's outcomes
  portfolio...

  **Why?** To prepare the collaboration space for group tutors and group
  members.

  * The Mahara collection creation process will be used.
  * Outcomes are set up and modified, but interactions primarily performed by 
group tutors are done in 'Display' mode.
  * In phase 1, we don't anticipate being able to move outcomes around but 
would expect that they are set up in order.
  * Outcomes can be deleted.

  The numbered list refers to the bullets in the mock-up 'Manage
  outcomes - group admin only'. Group tutors and group members do not
  have access to this page.

  > Notes:
  > * One outcome field set is set up per default as that is the minimum that 
is required.
  > * collection_outcome table: ID, collection ID, short title, full title, 
outcome type ID, support (boolean), progress (text), completed (boolean), 
section that shows the ID from the 'collection_view' table of the 'section' 
there. This 'section' is needed in here in case we delete an outcome or in 
future want to re-order outcomes.
  > * Collection_view table: create new column 'section' that in this case 
states the outcome ID to which the page belongs (section ID is the ID of the ID 
from the collection_outcome table.
  > * Each outcome is its own Pieform and has its own 'Save' button that is not 
displayed though.

  1. Outcomes are auto numbered to distinguish them. When an outcome is 
deleted, the number is automatically updated (on page load).
  2. Short title: Short title for the outcome as that becomes the page title. 
Suggested: 70 character limit. This field is mandatory.
  3. Full title: The full name of the outcome text. Suggested: 255 character 
limit.
  4. Outcome type: Select list with the abbreviation of the outcome and the 

[Mahara-contributors] [Bug 1997206] Re: Portfolio pdf export not working in Mahara 22.04.3

2022-11-24 Thread Nitin Mishra
[ISSUE FIXED] 
For centos 7 -
There is an incorrect $browsertype value in public_html/export/pdf/lib.php, use 
'chromium' instead of 'chromium-browser'. If we run the command 'rpm -qa | grep 
chromium-browser' on the terminal it through as error 'Need to have a Chrome 
browser installed to use the headless pdf option'.

So please use 'chromium' instead of 'chromium-browser' for pdf export.
It works for me.

Also, I installed npm & gulp on the centos server before these settings.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1997206

Title:
  Portfolio pdf export not working in Mahara 22.04.3

Status in Mahara:
  New

Bug description:
  After disabling the extensions pdf export & pdf lite, export is
  working fine. But after enabling the same extensions the portfolio
  export stops in the middle of the portfolio export.

  Application detail is below:
  Mahara version - 22.04.3
  Server - centos 7.9

  We installed headless Chrome and then we tried 'make all' & 'make
  pdfexport' commands on /home/x/public_html/ through the terminal,
  but not working. As Kristina Hoeppner suggested a solution on
  https://mahara.org/interaction/forum/topic.php?id=8977, I
  tried to follow the same process but failed to get result.

  Error logs are below(path- public_html/export/error_log):
  [20-Nov-2022 20:34:36 America/Adak] [WAR] a0 (export/html/lib.php:1652) 
Undefined property: HtmlExportOutputFilter::$rootdir
  [20-Nov-2022 20:34:36 America/Adak] Call stack (most recent first):
  [20-Nov-2022 20:34:36 America/Adak]   * log_message(string(size 52), integer, 
true, true, string(size 53), integer) at 
/home//public_html/lib/errors.php:515
  [20-Nov-2022 20:34:36 America/Adak]   * error(integer, string(size 52), 
string(size 53), integer, array(size 9)) at 
/home//public_html/export/html/lib.php:1652
  [20-Nov-2022 20:34:36 America/Adak]   * 
HtmlExportOutputFilter->replace_thumbnail_link(array(size 4)) at Unknown:0
  [20-Nov-2022 20:34:36 America/Adak]   * preg_replace_callback(string(size 
113), array(size 2), string(size 942)) at 
/home//public_html/export/html/lib.php:1402
  [20-Nov-2022 20:34:36 America/Adak]   * 
HtmlExportOutputFilter->filter(string(size 942)) at 
/home//public_html/export/html/lib.php:605
  [20-Nov-2022 20:34:36 America/Adak]   * 
PluginExportHtml->dump_view_export_data() at 
/home//public_html/export/html/lib.php:274
  [20-Nov-2022 20:34:36 America/Adak]   * PluginExportHtml->export(false) at 
/home//public_html/export/pdf/lib.php:169
  [20-Nov-2022 20:34:36 America/Adak]   * PluginExportPdf->export() at 
/home//public_html/export/lib.php:1102
  [20-Nov-2022 20:34:36 America/Adak]   * PluginExportAll->export() at 
/home//public_html/export/download.php:105
  [20-Nov-2022 20:34:36 America/Adak]
  [20-Nov-2022 20:34:36 America/Adak] [WAR] a0 (lib/errors.php:537) Need to 
have a Chrome browser installed to use the headless pdf option. at 
/home//public_html/export/pdf/lib.php:219
  [20-Nov-2022 20:34:36 America/Adak] Call stack (most recent first):
  [20-Nov-2022 20:34:36 America/Adak]   * exception(object(MaharaException)) at 
Unknown:0

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1997206/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp