[Mahara-contributors] [Bug 1991605] A patch has been submitted for review

2022-11-29 Thread Mahara Bot
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13525

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1991605

Title:
  Outcomes portfolio (5): Checkpoint block infrastructure

Status in Mahara:
  Confirmed

Bug description:
  Part of the outcomes portfolio blueprint:
  https://blueprints.launchpad.net/mahara/+spec/outcomes-portfolio

  This is especially closely linked to bug #1991604

  Better formatting:
  
https://wiki.mahara.org/wiki/Proposals/Outcomes_portfolio/Checkpoint_block_infrastructure

  # Checkpoint block infrastructure

  ## High level overview

  * Create a new block type
  * Pull information through from the activity page setup for levels of 
achievement
  * Deal with achievements and rules of what shall happen once a checkpoint has 
been achieved
  * Resembles the peer assessment block
  * No restriction though who can add comments
  * No draft option
  * No instructions

  * Page comments are still kept separate and could still be used.

  ## Details

  ### Mock-up reference: 'Edit activity page – group tutor and group
  admin'

  **Who?** As group tutor or group admin...

  **What?** I want to add content to the activity page...

  **Why?** To assist the learner with their evidence collection and mark
  checkpoints as completed to illustrate progress.

  The numbered list refers to the bullets in the mock-up 'Edit activity
  page – group tutor and group admin'. This page is accessible to group
  tutors, group admins, and learners.

  Items 1-13 are part of the 'Activity page infrastructure' (see section
  there for details). Here are only the items listed that pertain to the
  'Checkpoint' block, which is a new block type.

  14. Checkpoint block is added in full width. When a checkpoint block is 
deleted by a group tutor or group admin, there is logic that renames all 
subsequent blocks.
  15. Click 'Add comment' to add a comment to the checkpoint. Comments are 
displayed in reverse chronological order.
  16. When a comment was made, the profile picture, the name, the time the 
comment was made and the comment itself are displayed.
  Comments can be saved as draft and then published, similarly to the 'Peer 
assessment'. Comments can be added no matter whether a checkpoint has been 
achieved or not.
  17. [no change] Additional blocks can be pulled onto the page.
  18. Set the achievement level with the drop-down menu. The help icon displays 
the long-form text for the levels. The menu itself only displays 'Level 1', 
'Level 2', 'Level 3', and 'Level 4'.
  19. Once the level has been set, a number icon represents the achievement 
level and below it is a help icon that contains the name of the person who set 
the level and when they did it. It also contains the long description of the 
achieved level.
  20. Group tutors and group admins can delete comments. Editing of comments is 
possible for 10 minutes after posting or until somebody adds a new comment, 
whichever comes first. Group members cannot delete comments.

  > Note: It is possible to add new comments no matter whether an
  achievement level has been set or not.

  * New block type but block config is just the normal things that we record 
for blocks: block type, view, config data, dimensions
  * new table: ID, blockID, achievement level ID, userID, ctime
  * New table to record checkpoint results for future proofing in case things 
do need to be reported over it
  * Fetches achievement levels from the view_activity_achievement_level table
  * Levels: Lang string 'Level' added automatically to the priority number of 
the level
  * Actual name of the levels is in the help icon
  * New artefact table similar to peer assessment table

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1991605/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1991605] A patch has been submitted for review

2022-11-29 Thread Mahara Bot
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13524

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1991605

Title:
  Outcomes portfolio (5): Checkpoint block infrastructure

Status in Mahara:
  Confirmed

Bug description:
  Part of the outcomes portfolio blueprint:
  https://blueprints.launchpad.net/mahara/+spec/outcomes-portfolio

  This is especially closely linked to bug #1991604

  Better formatting:
  
https://wiki.mahara.org/wiki/Proposals/Outcomes_portfolio/Checkpoint_block_infrastructure

  # Checkpoint block infrastructure

  ## High level overview

  * Create a new block type
  * Pull information through from the activity page setup for levels of 
achievement
  * Deal with achievements and rules of what shall happen once a checkpoint has 
been achieved
  * Resembles the peer assessment block
  * No restriction though who can add comments
  * No draft option
  * No instructions

  * Page comments are still kept separate and could still be used.

  ## Details

  ### Mock-up reference: 'Edit activity page – group tutor and group
  admin'

  **Who?** As group tutor or group admin...

  **What?** I want to add content to the activity page...

  **Why?** To assist the learner with their evidence collection and mark
  checkpoints as completed to illustrate progress.

  The numbered list refers to the bullets in the mock-up 'Edit activity
  page – group tutor and group admin'. This page is accessible to group
  tutors, group admins, and learners.

  Items 1-13 are part of the 'Activity page infrastructure' (see section
  there for details). Here are only the items listed that pertain to the
  'Checkpoint' block, which is a new block type.

  14. Checkpoint block is added in full width. When a checkpoint block is 
deleted by a group tutor or group admin, there is logic that renames all 
subsequent blocks.
  15. Click 'Add comment' to add a comment to the checkpoint. Comments are 
displayed in reverse chronological order.
  16. When a comment was made, the profile picture, the name, the time the 
comment was made and the comment itself are displayed.
  Comments can be saved as draft and then published, similarly to the 'Peer 
assessment'. Comments can be added no matter whether a checkpoint has been 
achieved or not.
  17. [no change] Additional blocks can be pulled onto the page.
  18. Set the achievement level with the drop-down menu. The help icon displays 
the long-form text for the levels. The menu itself only displays 'Level 1', 
'Level 2', 'Level 3', and 'Level 4'.
  19. Once the level has been set, a number icon represents the achievement 
level and below it is a help icon that contains the name of the person who set 
the level and when they did it. It also contains the long description of the 
achieved level.
  20. Group tutors and group admins can delete comments. Editing of comments is 
possible for 10 minutes after posting or until somebody adds a new comment, 
whichever comes first. Group members cannot delete comments.

  > Note: It is possible to add new comments no matter whether an
  achievement level has been set or not.

  * New block type but block config is just the normal things that we record 
for blocks: block type, view, config data, dimensions
  * new table: ID, blockID, achievement level ID, userID, ctime
  * New table to record checkpoint results for future proofing in case things 
do need to be reported over it
  * Fetches achievement levels from the view_activity_achievement_level table
  * Levels: Lang string 'Level' added automatically to the priority number of 
the level
  * Actual name of the levels is in the help icon
  * New artefact table similar to peer assessment table

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1991605/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1867975] Re: Submit group portfolios for assessment

2022-11-29 Thread Paul Richardson
I had to write a speech about the dilemma of what a student's portfolio
should look like and it was hard to find info. Over time, when I already
went through this task, I discovered a service that is
https://edubirdie.com/dissertation-proposal-help as my roommates
suggested this source. These writing professionals create brilliant
papers and offer dissertation proposal help on topics from literature to
programming. It seems to me the most reliable.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1867975

Title:
  Submit group portfolios for assessment

Status in Mahara:
  Confirmed

Bug description:
  When students work on a project collaboratively and create a group
  portfolio, they cannot submit that for assessment, neither in a Mahara
  group nor via LTI into a LMS. It would be good to remedy that to allow
  for more flexibility.

  There are a number of things that will need to be looked into in this
  context, amongst them:

  - How to indicate who contributed to a group portfolio when submitting in 
Mahara? Currently, everything is owned by the group, but the group could 
consist of multiple student groups.
  - I think in Moodle, groups are formed and then one student submits the 
portfolio. That would mean that the students should be able to see group 
portfolios in their submission options when submitting of group work is allowed 
in an assignment and at the same time others are not allowed to submit the same 
under their name.
  - Can group portfolio submissions be supported by LTI via the basic 
integration or does it require something like the Mahara assignment submission 
plugin for Moodle to handle? Not every LMS may have the capability. 
  - Does the homework capability of the newer version of LTI handle some of 
that and could be leveraged?

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1867975/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1991605] Re: Outcomes portfolio (5): Checkpoint block infrastructure

2022-11-29 Thread Doris Tam
** Changed in: mahara
 Assignee: (unassigned) => Doris Tam (doristam)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1991605

Title:
  Outcomes portfolio (5): Checkpoint block infrastructure

Status in Mahara:
  Confirmed

Bug description:
  Part of the outcomes portfolio blueprint:
  https://blueprints.launchpad.net/mahara/+spec/outcomes-portfolio

  This is especially closely linked to bug #1991604

  Better formatting:
  
https://wiki.mahara.org/wiki/Proposals/Outcomes_portfolio/Checkpoint_block_infrastructure

  # Checkpoint block infrastructure

  ## High level overview

  * Create a new block type
  * Pull information through from the activity page setup for levels of 
achievement
  * Deal with achievements and rules of what shall happen once a checkpoint has 
been achieved
  * Resembles the peer assessment block
  * No restriction though who can add comments
  * No draft option
  * No instructions

  * Page comments are still kept separate and could still be used.

  ## Details

  ### Mock-up reference: 'Edit activity page – group tutor and group
  admin'

  **Who?** As group tutor or group admin...

  **What?** I want to add content to the activity page...

  **Why?** To assist the learner with their evidence collection and mark
  checkpoints as completed to illustrate progress.

  The numbered list refers to the bullets in the mock-up 'Edit activity
  page – group tutor and group admin'. This page is accessible to group
  tutors, group admins, and learners.

  Items 1-13 are part of the 'Activity page infrastructure' (see section
  there for details). Here are only the items listed that pertain to the
  'Checkpoint' block, which is a new block type.

  14. Checkpoint block is added in full width. When a checkpoint block is 
deleted by a group tutor or group admin, there is logic that renames all 
subsequent blocks.
  15. Click 'Add comment' to add a comment to the checkpoint. Comments are 
displayed in reverse chronological order.
  16. When a comment was made, the profile picture, the name, the time the 
comment was made and the comment itself are displayed.
  Comments can be saved as draft and then published, similarly to the 'Peer 
assessment'. Comments can be added no matter whether a checkpoint has been 
achieved or not.
  17. [no change] Additional blocks can be pulled onto the page.
  18. Set the achievement level with the drop-down menu. The help icon displays 
the long-form text for the levels. The menu itself only displays 'Level 1', 
'Level 2', 'Level 3', and 'Level 4'.
  19. Once the level has been set, a number icon represents the achievement 
level and below it is a help icon that contains the name of the person who set 
the level and when they did it. It also contains the long description of the 
achieved level.
  20. Group tutors and group admins can delete comments. Editing of comments is 
possible for 10 minutes after posting or until somebody adds a new comment, 
whichever comes first. Group members cannot delete comments.

  > Note: It is possible to add new comments no matter whether an
  achievement level has been set or not.

  * New block type but block config is just the normal things that we record 
for blocks: block type, view, config data, dimensions
  * new table: ID, blockID, achievement level ID, userID, ctime
  * New table to record checkpoint results for future proofing in case things 
do need to be reported over it
  * Fetches achievement levels from the view_activity_achievement_level table
  * Levels: Lang string 'Level' added automatically to the priority number of 
the level
  * Actual name of the levels is in the help icon
  * New artefact table similar to peer assessment table

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1991605/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1993079] Re: MNet not saving expiry date correctly on insert of new instance

2022-11-29 Thread Robert Lyon
To test:

Edit an institution
Add auth method XML-RPC 
Set the required config values to:
  Authority name:  Moodle
  WWW root: https://webservices-moodle.catalystdemo.co.nz
  Site name: MoodleInstance
And save the form

Then edit the instance again (by clicking on MoodleInstance) and you should see:
  Public key expires  with a valid date

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1993079

Title:
  MNet not saving expiry date correctly on insert of new instance

Status in Mahara:
  Confirmed
Status in Mahara 22.10 series:
  Confirmed
Status in Mahara 23.04 series:
  In Progress

Bug description:
  Also not saving on update of MNet instance in some cases.

  To test have a moodle to connect to and then in mahara make a MNet
  connection in an institution by adding an xmlrpc auth method.

  On saving the form it should set an expiry for the certificate.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1993079/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1990981] A change has been merged

2022-11-29 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/c/mahara/+/13503
Committed: 
https://git.mahara.org/mahara/mahara/commit/6ccbfc1f0d55da182b2888f59c46bed045725980
Submitter: "Robert Lyon "
Branch:22.10_DEV

commit 6ccbfc1f0d55da182b2888f59c46bed045725980
Author: Stefan Bäcker 
Date:   Thu Nov 10 14:25:19 2022 +1300

Bug 1990981: Appending parameters correctly again to copy portfolios
into group

There was an error in commit c830632494ef914ae26a07142e7ee35cb8074483
on line 6453 (now line 6516)

Before:

!empty($params)

After

!$params

Should be

$params

Change-Id: I61779f9b3bd65ae802362e7c839b8e6a5c55b0bc
Signed-off-by: Robert Lyon 
(cherry picked from commit b8762df369d815ee6eefac14e72d149f5ad1e70b)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1990981

Title:
  Unable to copy pages or collections into group

Status in Mahara:
  Fix Committed
Status in Mahara 22.04 series:
  Fix Committed
Status in Mahara 22.10 series:
  Fix Committed
Status in Mahara 23.04 series:
  Fix Committed

Bug description:
  When trying to copy a page or collection into a group, the group
  information gets lost when moving away from the first page of
  candidates. Collections will be copied, but into the personal area,
  not into the desired group.

  Debugging shows line 6504 in lib/view.php to be the culprit. Adding
  params only when there are none makes no sense. Removing the negation
  seems to solve the problem. Please find patch included.

  First part of patch solves a type mismatch error related to copying pages 
with certain artefacts.
  Second part solves this actual bug.

  Mahara version 22.04.2
  Ubuntu 20.04
  MariaDB 10.3

  Reproducible on current demo.mahara.org

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1990981/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1990981] A patch has been submitted for review

2022-11-29 Thread Mahara Bot
Patch for "22.04_DEV" branch:
https://reviews.mahara.org/c/mahara/+/13504

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1990981

Title:
  Unable to copy pages or collections into group

Status in Mahara:
  Fix Committed
Status in Mahara 22.04 series:
  Fix Committed
Status in Mahara 22.10 series:
  Fix Committed
Status in Mahara 23.04 series:
  Fix Committed

Bug description:
  When trying to copy a page or collection into a group, the group
  information gets lost when moving away from the first page of
  candidates. Collections will be copied, but into the personal area,
  not into the desired group.

  Debugging shows line 6504 in lib/view.php to be the culprit. Adding
  params only when there are none makes no sense. Removing the negation
  seems to solve the problem. Please find patch included.

  First part of patch solves a type mismatch error related to copying pages 
with certain artefacts.
  Second part solves this actual bug.

  Mahara version 22.04.2
  Ubuntu 20.04
  MariaDB 10.3

  Reproducible on current demo.mahara.org

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1990981/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1990981] A change has been merged

2022-11-29 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/c/mahara/+/13504
Committed: 
https://git.mahara.org/mahara/mahara/commit/157f59979d14a361ba03562223ce91a6d5df72b4
Submitter: "Robert Lyon "
Branch:22.04_DEV

commit 157f59979d14a361ba03562223ce91a6d5df72b4
Author: Stefan Bäcker 
Date:   Thu Nov 10 14:25:19 2022 +1300

Bug 1990981: Appending parameters correctly again to copy portfolios
into group

There was an error in commit c830632494ef914ae26a07142e7ee35cb8074483
on line 6453 (now line 6516)

Before:

!empty($params)

After

!$params

Should be

$params

Change-Id: I61779f9b3bd65ae802362e7c839b8e6a5c55b0bc
Signed-off-by: Robert Lyon 
(cherry picked from commit b8762df369d815ee6eefac14e72d149f5ad1e70b)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1990981

Title:
  Unable to copy pages or collections into group

Status in Mahara:
  Fix Committed
Status in Mahara 22.04 series:
  Fix Committed
Status in Mahara 22.10 series:
  Fix Committed
Status in Mahara 23.04 series:
  Fix Committed

Bug description:
  When trying to copy a page or collection into a group, the group
  information gets lost when moving away from the first page of
  candidates. Collections will be copied, but into the personal area,
  not into the desired group.

  Debugging shows line 6504 in lib/view.php to be the culprit. Adding
  params only when there are none makes no sense. Removing the negation
  seems to solve the problem. Please find patch included.

  First part of patch solves a type mismatch error related to copying pages 
with certain artefacts.
  Second part solves this actual bug.

  Mahara version 22.04.2
  Ubuntu 20.04
  MariaDB 10.3

  Reproducible on current demo.mahara.org

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1990981/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1990981] Re: Unable to copy pages or collections into group

2022-11-29 Thread Robert Lyon
** Changed in: mahara/22.10
   Status: Confirmed => Fix Committed

** Changed in: mahara/22.04
   Status: Confirmed => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1990981

Title:
  Unable to copy pages or collections into group

Status in Mahara:
  Fix Committed
Status in Mahara 22.04 series:
  Fix Committed
Status in Mahara 22.10 series:
  Fix Committed
Status in Mahara 23.04 series:
  Fix Committed

Bug description:
  When trying to copy a page or collection into a group, the group
  information gets lost when moving away from the first page of
  candidates. Collections will be copied, but into the personal area,
  not into the desired group.

  Debugging shows line 6504 in lib/view.php to be the culprit. Adding
  params only when there are none makes no sense. Removing the negation
  seems to solve the problem. Please find patch included.

  First part of patch solves a type mismatch error related to copying pages 
with certain artefacts.
  Second part solves this actual bug.

  Mahara version 22.04.2
  Ubuntu 20.04
  MariaDB 10.3

  Reproducible on current demo.mahara.org

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1990981/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1990981] A patch has been submitted for review

2022-11-29 Thread Mahara Bot
Patch for "22.10_DEV" branch:
https://reviews.mahara.org/c/mahara/+/13503

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1990981

Title:
  Unable to copy pages or collections into group

Status in Mahara:
  Fix Committed
Status in Mahara 22.04 series:
  Fix Committed
Status in Mahara 22.10 series:
  Fix Committed
Status in Mahara 23.04 series:
  Fix Committed

Bug description:
  When trying to copy a page or collection into a group, the group
  information gets lost when moving away from the first page of
  candidates. Collections will be copied, but into the personal area,
  not into the desired group.

  Debugging shows line 6504 in lib/view.php to be the culprit. Adding
  params only when there are none makes no sense. Removing the negation
  seems to solve the problem. Please find patch included.

  First part of patch solves a type mismatch error related to copying pages 
with certain artefacts.
  Second part solves this actual bug.

  Mahara version 22.04.2
  Ubuntu 20.04
  MariaDB 10.3

  Reproducible on current demo.mahara.org

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1990981/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1990981] A change has been merged

2022-11-29 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/c/mahara/+/13461
Committed: 
https://git.mahara.org/mahara/mahara/commit/b8762df369d815ee6eefac14e72d149f5ad1e70b
Submitter: "Robert Lyon "
Branch:main

commit b8762df369d815ee6eefac14e72d149f5ad1e70b
Author: Stefan Bäcker 
Date:   Thu Nov 10 14:25:19 2022 +1300

Bug 1990981: Appending parameters correctly again to copy portfolios
into group

There was an error in commit c830632494ef914ae26a07142e7ee35cb8074483
on line 6453 (now line 6516)

Before:

!empty($params)

After

!$params

Should be

$params

Change-Id: I61779f9b3bd65ae802362e7c839b8e6a5c55b0bc
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1990981

Title:
  Unable to copy pages or collections into group

Status in Mahara:
  Fix Committed
Status in Mahara 22.04 series:
  Fix Committed
Status in Mahara 22.10 series:
  Fix Committed
Status in Mahara 23.04 series:
  Fix Committed

Bug description:
  When trying to copy a page or collection into a group, the group
  information gets lost when moving away from the first page of
  candidates. Collections will be copied, but into the personal area,
  not into the desired group.

  Debugging shows line 6504 in lib/view.php to be the culprit. Adding
  params only when there are none makes no sense. Removing the negation
  seems to solve the problem. Please find patch included.

  First part of patch solves a type mismatch error related to copying pages 
with certain artefacts.
  Second part solves this actual bug.

  Mahara version 22.04.2
  Ubuntu 20.04
  MariaDB 10.3

  Reproducible on current demo.mahara.org

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1990981/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1990981] Re: Unable to copy pages or collections into group

2022-11-29 Thread Robert Lyon
** Changed in: mahara/23.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1990981

Title:
  Unable to copy pages or collections into group

Status in Mahara:
  Fix Committed
Status in Mahara 22.04 series:
  Fix Committed
Status in Mahara 22.10 series:
  Fix Committed
Status in Mahara 23.04 series:
  Fix Committed

Bug description:
  When trying to copy a page or collection into a group, the group
  information gets lost when moving away from the first page of
  candidates. Collections will be copied, but into the personal area,
  not into the desired group.

  Debugging shows line 6504 in lib/view.php to be the culprit. Adding
  params only when there are none makes no sense. Removing the negation
  seems to solve the problem. Please find patch included.

  First part of patch solves a type mismatch error related to copying pages 
with certain artefacts.
  Second part solves this actual bug.

  Mahara version 22.04.2
  Ubuntu 20.04
  MariaDB 10.3

  Reproducible on current demo.mahara.org

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1990981/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp