[Mahara-contributors] [Bug 1998874] [NEW] Fix up showcomments for non page comments causing JS error 'author_link'

2022-12-05 Thread Doris Tam
Public bug reported:

1. Create a page
2. Add a peer assessment block
3. Share the page to an account with peer/manager access
4. As a peer/manager, make an assessment and save

Expectation: on save, the page reloads with a new url parameter 'showcomment' 
with an id and focuses on the comment
Reality: the page comments dropdown opens, and nothing is focused.

** Affects: mahara
 Importance: Undecided
 Assignee: Doris Tam (doristam)
 Status: New

** Summary changed:

- Peerassessment comments JS error 'author_link'
+ Fix up showcomments for non page comments causing JS error 'author_link'

** Description changed:

  1. Create a page
  2. Add a peer assessment block
  3. Share the page to an account with peer/manager access
  4. As a peer/manager, make an assessment and save
  
- Expectation: on save, the page loads and focuses on the comment
+ Expectation: on save, the page reloads with a new url parameter 'showcomment' 
with an id and focuses on the comment
  Reality: the page comments dropdown opens, and nothing is focused.

** Changed in: mahara
 Assignee: (unassigned) => Doris Tam (doristam)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1998874

Title:
  Fix up showcomments for non page comments causing JS error
  'author_link'

Status in Mahara:
  New

Bug description:
  1. Create a page
  2. Add a peer assessment block
  3. Share the page to an account with peer/manager access
  4. As a peer/manager, make an assessment and save

  Expectation: on save, the page reloads with a new url parameter 'showcomment' 
with an id and focuses on the comment
  Reality: the page comments dropdown opens, and nothing is focused.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1998874/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1998860] Re: Problems with deleting a page / person when page is on a watchlist

2022-12-05 Thread Robert Lyon
** Changed in: mahara/23.04
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1998860

Title:
  Problems with deleting a page / person when page is on a watchlist

Status in Mahara:
  In Progress
Status in Mahara 21.10 series:
  New
Status in Mahara 22.04 series:
  New
Status in Mahara 22.10 series:
  New
Status in Mahara 23.04 series:
  In Progress

Bug description:
  There are couple of issues around watchlists and queued items
   
  To test - problem one:

  1) Create a site and add some people to it
  2) Create a group and add some people as members
  3) As group creator add a page to the group and add a block to the page
  4) Masquerade as another group member and view the page - add page to 
watchlist
  5) As this group member edit the page and add a block
  6) Then straight away delete the block and go to the group portfolios page 
and delete the page (do this quickly to beat cron)

  You get an error:
  ERROR:  update or delete on table "view" violates foreign key constraint 
"watcqueu_vie_fk" on table "watchlist_queue"

  This is because when you edit a page that is being watched the
  watchlist_queue table gets populated with changes and when you delete
  the block the line isn't removed from the watchlist_queue just the
  block ID (as it is still a valid view change - the block deletion) so
  when you try and delete the page it's still referenced.

  We need to remove the reference on page deletion

  
  To test - problem two:

  1-5) The same steps as above
  6) Stop masquerading as other person and delete person

  Person deletes successfully but they are still referenced in the
  watchlist_queue table - we need to remove those references on person
  deletion so we don't try and send a notification to a deleted person

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1998860/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1998733] Re: Retain SmartEvidence and portfolio completion statuses with new submission copy

2022-12-05 Thread Kristina Hoeppner
** Description changed:

  This is a follow-on from bug #1996475
  
  Normally, when a copy is made, certain tracking elements are reset as
  it's a new portfolio. However, when we make a copy for a submission to a
  group or via LTI, all statuses need to be retained so that the portfolio
  can be assessed with all the information available.
  
  SmartEvidence needs to keep without any changes to dates and times and owners:
  - Annotation
  - Assessment status
  - Feedback
  
  We should also expand the SmartEvidence report by the optional column
  'Submission' to make it easier to filter the report in particular for
  active submissions or those that still have the flag 'Submission' set.
  
  Portfolio completion needs to keep:
  - Sign-off status and time
  - Verification status (part of the sign-off functionality) and time and 
person who verified
  - Information and statuses stored in the 'Portfolio review' blocks
+ 
+ 
+ Peer assessments also need to be retained.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1998733

Title:
  Retain SmartEvidence and portfolio completion statuses with new
  submission copy

Status in Mahara:
  In Progress

Bug description:
  This is a follow-on from bug #1996475

  Normally, when a copy is made, certain tracking elements are reset as
  it's a new portfolio. However, when we make a copy for a submission to
  a group or via LTI, all statuses need to be retained so that the
  portfolio can be assessed with all the information available.

  SmartEvidence needs to keep without any changes to dates and times and owners:
  - Annotation
  - Assessment status
  - Feedback

  We should also expand the SmartEvidence report by the optional column
  'Submission' to make it easier to filter the report in particular for
  active submissions or those that still have the flag 'Submission' set.

  Portfolio completion needs to keep:
  - Sign-off status and time
  - Verification status (part of the sign-off functionality) and time and 
person who verified
  - Information and statuses stored in the 'Portfolio review' blocks

  
  Peer assessments also need to be retained.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1998733/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1991603] A patch has been submitted for review

2022-12-05 Thread Mahara Bot
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13543

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1991603

Title:
  Outcomes portfolio (3): 'Outcomes' infrastructure in the group
  collection

Status in Mahara:
  In Progress

Bug description:
  Part of the outcomes portfolio blueprint:
  https://blueprints.launchpad.net/mahara/+spec/outcomes-portfolio

  Better formatting:
  
https://wiki.mahara.org/wiki/Proposals/Outcomes_portfolio/Outcomes_infrastructure_in_a_group_collection

  ## High level overview

  * Create the 'Manage outcomes' page infrastructure ('Manage outcomes – group 
admin only' mock-up)
  * Create the outcomes overview page and infrastructure
  * Allow for the direct editing of fields
  * Allow for the clicking of icons to complete outcomes and activities
  * Create new pages (activities) from this page and set them up
  * Pull in activity information from the individual pages
  * Respect permissions for the different types of group members and who can 
edit or only see what

  ## Details

  ### Mock-up reference: 'Set up the outcomes collection - group admin
  only'

  **Who?** As a group admin...

  **What?** I want to be able to set up an outcomes collection...

  **Why?** So that group tutors or I can add activities and prepare
  everything for the group member to get started.

  The collection is set up in a group for a particular group member by a
  group admin. The numbered list refers to the bullets in the mock-up
  'Set up the outcomes collection - group admin only'.

  1. [no change] Collection name: Title of the outcomes portfolio. You can 
choose that freely, but might want to establish a convention to differentiate 
between the different plans that a group member may have.
  2. Per default, the option 'Outcomes portfolio' is set to 'Yes'. This is done 
automatically when the institution selected to work with outcomes portfolios 
(see section 'Outcomes portfolio setting and database tables').
  3. You can select the outcomes category from which all outcomes within the 
collection shall take their outcome type. If there is only one category, the 
category is displayed without the drop-down menu.
  4. Clicking the 'Continue' button takes you to a new page where you can 
manage the outcomes.
  Additional changes (not pictured):

  5. Option 'Manage outcomes' is accessible from the collection settings screen 
and also on the 'Portfolios' overview page when clicking the 'More options' 
icon on a collection for group admins only.
  6. Option 'Manage pages' is not available from the collection settings screen 
or via the 'More options' icon on a collection on the 'Portfolios' overview 
page to avoid pages from being added to or removed from the collection outside 
of the outcomes framework. It can also not be reached by URL.

  > Out of scope: Be able to add regular portfolio pages to the
  collection and not only activity pages.

  ### Mock-up reference: 'Manage outcomes - group admin only'

  **Who?** As a group admin...

  **What?** I want to enter the outcomes for a group member's outcomes
  portfolio...

  **Why?** To prepare the collaboration space for group tutors and group
  members.

  * The Mahara collection creation process will be used.
  * Outcomes are set up and modified, but interactions primarily performed by 
group tutors are done in 'Display' mode.
  * In phase 1, we don't anticipate being able to move outcomes around but 
would expect that they are set up in order.
  * Outcomes can be deleted.

  The numbered list refers to the bullets in the mock-up 'Manage
  outcomes - group admin only'. Group tutors and group members do not
  have access to this page.

  > Notes:
  > * One outcome field set is set up per default as that is the minimum that 
is required.
  > * collection_outcome table: ID, collection ID, short title, full title, 
outcome type ID, support (boolean), progress (text), completed (boolean), 
section that shows the ID from the 'collection_view' table of the 'section' 
there. This 'section' is needed in here in case we delete an outcome or in 
future want to re-order outcomes.
  > * Collection_view table: create new column 'section' that in this case 
states the outcome ID to which the page belongs (section ID is the ID of the ID 
from the collection_outcome table.
  > * Each outcome is its own Pieform and has its own 'Save' button that is not 
displayed though.

  1. Outcomes are auto numbered to distinguish them. When an outcome is 
deleted, the number is automatically updated (on page load).
  2. Short title: Short title for the outcome as that becomes the page title. 
Suggested: 70 character limit. This field is mandatory.
  3. Full title: The full name of the outcome text. Suggested: 255 character 
limit.
  4. Outcome type: Select list with the abbreviation of the outcome and the 
colo

[Mahara-contributors] [Bug 1998860] [NEW] Problems with deleting a page / person when page is on a watchlist

2022-12-05 Thread Robert Lyon
Public bug reported:

There are couple of issues around watchlists and queued items
 
To test - problem one:

1) Create a site and add some people to it
2) Create a group and add some people as members
3) As group creator add a page to the group and add a block to the page
4) Masquerade as another group member and view the page - add page to watchlist
5) As this group member edit the page and add a block
6) Then straight away delete the block and go to the group portfolios page and 
delete the page (do this quickly to beat cron)

You get an error:
ERROR:  update or delete on table "view" violates foreign key constraint 
"watcqueu_vie_fk" on table "watchlist_queue"

This is because when you edit a page that is being watched the
watchlist_queue table gets populated with changes and when you delete
the block the line isn't removed from the watchlist_queue just the block
ID (as it is still a valid view change - the block deletion) so when you
try and delete the page it's still referenced.

We need to remove the reference on page deletion


To test - problem two:

1-5) The same steps as above
6) Stop masquerading as other person and delete person

Person deletes successfully but they are still referenced in the
watchlist_queue table - we need to remove those references on person
deletion so we don't try and send a notification to a deleted person

** Affects: mahara
 Importance: High
 Status: New

** Affects: mahara/21.10
 Importance: High
 Status: New

** Affects: mahara/22.04
 Importance: High
 Status: New

** Affects: mahara/22.10
 Importance: High
 Status: New

** Affects: mahara/23.04
 Importance: High
 Status: New

** Also affects: mahara/21.10
   Importance: Undecided
   Status: New

** Also affects: mahara/23.04
   Importance: Undecided
   Status: New

** Also affects: mahara/22.04
   Importance: Undecided
   Status: New

** Also affects: mahara/22.10
   Importance: Undecided
   Status: New

** Changed in: mahara/23.04
   Importance: Undecided => High

** Changed in: mahara/22.10
   Importance: Undecided => High

** Changed in: mahara/22.04
   Importance: Undecided => High

** Changed in: mahara/21.10
   Importance: Undecided => High

** Changed in: mahara/23.04
Milestone: None => 23.04.0

** Changed in: mahara/22.10
Milestone: None => 22.10.1

** Changed in: mahara/22.04
Milestone: None => 22.04.4

** Changed in: mahara/21.10
Milestone: None => 21.10.6

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1998860

Title:
  Problems with deleting a page / person when page is on a watchlist

Status in Mahara:
  New
Status in Mahara 21.10 series:
  New
Status in Mahara 22.04 series:
  New
Status in Mahara 22.10 series:
  New
Status in Mahara 23.04 series:
  New

Bug description:
  There are couple of issues around watchlists and queued items
   
  To test - problem one:

  1) Create a site and add some people to it
  2) Create a group and add some people as members
  3) As group creator add a page to the group and add a block to the page
  4) Masquerade as another group member and view the page - add page to 
watchlist
  5) As this group member edit the page and add a block
  6) Then straight away delete the block and go to the group portfolios page 
and delete the page (do this quickly to beat cron)

  You get an error:
  ERROR:  update or delete on table "view" violates foreign key constraint 
"watcqueu_vie_fk" on table "watchlist_queue"

  This is because when you edit a page that is being watched the
  watchlist_queue table gets populated with changes and when you delete
  the block the line isn't removed from the watchlist_queue just the
  block ID (as it is still a valid view change - the block deletion) so
  when you try and delete the page it's still referenced.

  We need to remove the reference on page deletion

  
  To test - problem two:

  1-5) The same steps as above
  6) Stop masquerading as other person and delete person

  Person deletes successfully but they are still referenced in the
  watchlist_queue table - we need to remove those references on person
  deletion so we don't try and send a notification to a deleted person

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1998860/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1993079] A change has been merged

2022-12-05 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/c/mahara/+/13560
Committed: 
https://git.mahara.org/mahara/mahara/commit/764531eb5a4cd0b0449076fd5ee39cd72c69c592
Submitter: "Robert Lyon "
Branch:22.10_DEV

commit 764531eb5a4cd0b0449076fd5ee39cd72c69c592
Author: Robert Lyon 
Date:   Wed Oct 12 14:08:59 2022 +1300

Bug 1993079: Need to save the xmlrpc expiry date on insert

Also need to save changes on update

Change-Id: I5917769153aaf645ff45e5ea691e327323f2b370
Signed-off-by: Robert Lyon 
(cherry picked from commit 9de606003cc79c5405fbb7e085796adc974efb0f)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1993079

Title:
  MNet not saving expiry date correctly on insert of new instance

Status in Mahara:
  Fix Committed
Status in Mahara 22.10 series:
  Fix Committed
Status in Mahara 23.04 series:
  Fix Committed

Bug description:
  Also not saving on update of MNet instance in some cases.

  To test have a moodle to connect to and then in mahara make a MNet
  connection in an institution by adding an xmlrpc auth method.

  On saving the form it should set an expiry for the certificate.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1993079/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1993079] A patch has been submitted for review

2022-12-05 Thread Mahara Bot
Patch for "22.10_DEV" branch:
https://reviews.mahara.org/c/mahara/+/13560

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1993079

Title:
  MNet not saving expiry date correctly on insert of new instance

Status in Mahara:
  Fix Committed
Status in Mahara 22.10 series:
  Fix Committed
Status in Mahara 23.04 series:
  Fix Committed

Bug description:
  Also not saving on update of MNet instance in some cases.

  To test have a moodle to connect to and then in mahara make a MNet
  connection in an institution by adding an xmlrpc auth method.

  On saving the form it should set an expiry for the certificate.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1993079/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1995811] A change has been merged

2022-12-05 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/c/mahara/+/13429
Committed: 
https://git.mahara.org/mahara/mahara/commit/1c131a1566dcdad19e4e468afaf7534d20822901
Submitter: "Robert Lyon "
Branch:main

commit 1c131a1566dcdad19e4e468afaf7534d20822901
Author: Robert Lyon 
Date:   Mon Nov 7 09:38:48 2022 +1300

Bug 1995811: Mark XML-RPC as deprecated / to be removed in the future

Eventually we will remove this auth method and have people use LTI /
LTI_Advantage

Change-Id: Ic6c66e78f4f757eeb71743c5c30697741cf5305f
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1995811

Title:
  Mark XML-RPC as deprecated

Status in Mahara:
  Fix Committed

Bug description:
  As we are now wanting people to use LTI / LTI_Advantage and don't want
  to support legacy XML-RPC anymore we should begin by marking the
  plugin as deprecated so site owners can see that it will soon be
  removed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1995811/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1995811] Re: Mark XML-RPC as deprecated

2022-12-05 Thread Robert Lyon
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1995811

Title:
  Mark XML-RPC as deprecated

Status in Mahara:
  Fix Committed

Bug description:
  As we are now wanting people to use LTI / LTI_Advantage and don't want
  to support legacy XML-RPC anymore we should begin by marking the
  plugin as deprecated so site owners can see that it will soon be
  removed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1995811/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1993079] Re: MNet not saving expiry date correctly on insert of new instance

2022-12-05 Thread Robert Lyon
** Changed in: mahara/23.04
   Status: In Progress => Fix Committed

** Changed in: mahara/22.10
   Status: Confirmed => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1993079

Title:
  MNet not saving expiry date correctly on insert of new instance

Status in Mahara:
  Fix Committed
Status in Mahara 22.10 series:
  Fix Committed
Status in Mahara 23.04 series:
  Fix Committed

Bug description:
  Also not saving on update of MNet instance in some cases.

  To test have a moodle to connect to and then in mahara make a MNet
  connection in an institution by adding an xmlrpc auth method.

  On saving the form it should set an expiry for the certificate.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1993079/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1993079] A change has been merged

2022-12-05 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/c/mahara/+/13224
Committed: 
https://git.mahara.org/mahara/mahara/commit/9de606003cc79c5405fbb7e085796adc974efb0f
Submitter: "Robert Lyon "
Branch:main

commit 9de606003cc79c5405fbb7e085796adc974efb0f
Author: Robert Lyon 
Date:   Wed Oct 12 14:08:59 2022 +1300

Bug 1993079: Need to save the xmlrpc expiry date on insert

Also need to save changes on update

Change-Id: I5917769153aaf645ff45e5ea691e327323f2b370
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1993079

Title:
  MNet not saving expiry date correctly on insert of new instance

Status in Mahara:
  Fix Committed
Status in Mahara 22.10 series:
  Fix Committed
Status in Mahara 23.04 series:
  Fix Committed

Bug description:
  Also not saving on update of MNet instance in some cases.

  To test have a moodle to connect to and then in mahara make a MNet
  connection in an institution by adding an xmlrpc auth method.

  On saving the form it should set an expiry for the certificate.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1993079/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1998725] A change has been merged

2022-12-05 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/c/mahara/+/13542
Committed: 
https://git.mahara.org/mahara/mahara/commit/71c8e78b45c4be05476844d8388712c22f897041
Submitter: "Robert Lyon "
Branch:21.10_DEV

commit 71c8e78b45c4be05476844d8388712c22f897041
Author: Robert Lyon 
Date:   Mon Dec 5 13:06:09 2022 +1300

Bug 1998725: Correcting path to profile icon in HTML export

The rootdir value was not fetched correctly

Change-Id: I817af27606a94c4edfb3966cf93b85d12b041b60
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1998725

Title:
  Incorrect root path for export of profileicon by id

Status in Mahara 21.10 series:
  Fix Committed
Status in Mahara 22.04 series:
  Fix Committed

Bug description:
  We sometimes get this error when doing an HTML (or PDF) export

 * log_message("Undefined property: HtmlExportOutputFilter::$rootd...", 8, 
true, true, "/home/robertl/code/mahara-devel/mahara/htdocs/expo...", 1652)
 * error(8, "Undefined property: HtmlExportOutputFilter::$rootd...", 
"/home/robertl/code/mahara-devel/mahara/htdocs/expo...", 1652, array(size 9))
 * HtmlExportOutputFilter->replace_thumbnail_link(array(size 4))

  
  To test:
  Create a person and add a profile icon to the person
  Create a page and add comment to the page
  Export the person

  Expected result
   In report bar the message - Export generated successfully.

  Actual result
   In report bar the message - Export generated with some errors.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/21.10/+bug/1998725/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1998725] A patch has been submitted for review

2022-12-05 Thread Mahara Bot
Patch for "21.10_DEV" branch:
https://reviews.mahara.org/c/mahara/+/13542

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1998725

Title:
  Incorrect root path for export of profileicon by id

Status in Mahara 21.10 series:
  Fix Committed
Status in Mahara 22.04 series:
  Fix Committed

Bug description:
  We sometimes get this error when doing an HTML (or PDF) export

 * log_message("Undefined property: HtmlExportOutputFilter::$rootd...", 8, 
true, true, "/home/robertl/code/mahara-devel/mahara/htdocs/expo...", 1652)
 * error(8, "Undefined property: HtmlExportOutputFilter::$rootd...", 
"/home/robertl/code/mahara-devel/mahara/htdocs/expo...", 1652, array(size 9))
 * HtmlExportOutputFilter->replace_thumbnail_link(array(size 4))

  
  To test:
  Create a person and add a profile icon to the person
  Create a page and add comment to the page
  Export the person

  Expected result
   In report bar the message - Export generated successfully.

  Actual result
   In report bar the message - Export generated with some errors.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/21.10/+bug/1998725/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1998725] Re: Incorrect root path for export of profileicon by id

2022-12-05 Thread Robert Lyon
** Changed in: mahara/21.10
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1998725

Title:
  Incorrect root path for export of profileicon by id

Status in Mahara 21.10 series:
  Fix Committed
Status in Mahara 22.04 series:
  Fix Committed

Bug description:
  We sometimes get this error when doing an HTML (or PDF) export

 * log_message("Undefined property: HtmlExportOutputFilter::$rootd...", 8, 
true, true, "/home/robertl/code/mahara-devel/mahara/htdocs/expo...", 1652)
 * error(8, "Undefined property: HtmlExportOutputFilter::$rootd...", 
"/home/robertl/code/mahara-devel/mahara/htdocs/expo...", 1652, array(size 9))
 * HtmlExportOutputFilter->replace_thumbnail_link(array(size 4))

  
  To test:
  Create a person and add a profile icon to the person
  Create a page and add comment to the page
  Export the person

  Expected result
   In report bar the message - Export generated successfully.

  Actual result
   In report bar the message - Export generated with some errors.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/21.10/+bug/1998725/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1998725] A change has been merged

2022-12-05 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/c/mahara/+/13541
Committed: 
https://git.mahara.org/mahara/mahara/commit/e92e6d172df04b02aa4e2daf7ee4e4fc2e9f8513
Submitter: "Robert Lyon "
Branch:22.04_DEV

commit e92e6d172df04b02aa4e2daf7ee4e4fc2e9f8513
Author: Robert Lyon 
Date:   Mon Dec 5 13:06:09 2022 +1300

Bug 1998725: Correcting path to profile icon in HTML export

The rootdir value was not fetched correctly

Change-Id: I817af27606a94c4edfb3966cf93b85d12b041b60
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1998725

Title:
  Incorrect root path for export of profileicon by id

Status in Mahara 21.10 series:
  In Progress
Status in Mahara 22.04 series:
  Fix Committed

Bug description:
  We sometimes get this error when doing an HTML (or PDF) export

 * log_message("Undefined property: HtmlExportOutputFilter::$rootd...", 8, 
true, true, "/home/robertl/code/mahara-devel/mahara/htdocs/expo...", 1652)
 * error(8, "Undefined property: HtmlExportOutputFilter::$rootd...", 
"/home/robertl/code/mahara-devel/mahara/htdocs/expo...", 1652, array(size 9))
 * HtmlExportOutputFilter->replace_thumbnail_link(array(size 4))

  
  To test:
  Create a person and add a profile icon to the person
  Create a page and add comment to the page
  Export the person

  Expected result
   In report bar the message - Export generated successfully.

  Actual result
   In report bar the message - Export generated with some errors.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/21.10/+bug/1998725/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1998725] Re: Incorrect root path for export of profileicon by id

2022-12-05 Thread Robert Lyon
** Changed in: mahara/22.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1998725

Title:
  Incorrect root path for export of profileicon by id

Status in Mahara 21.10 series:
  In Progress
Status in Mahara 22.04 series:
  Fix Committed

Bug description:
  We sometimes get this error when doing an HTML (or PDF) export

 * log_message("Undefined property: HtmlExportOutputFilter::$rootd...", 8, 
true, true, "/home/robertl/code/mahara-devel/mahara/htdocs/expo...", 1652)
 * error(8, "Undefined property: HtmlExportOutputFilter::$rootd...", 
"/home/robertl/code/mahara-devel/mahara/htdocs/expo...", 1652, array(size 9))
 * HtmlExportOutputFilter->replace_thumbnail_link(array(size 4))

  
  To test:
  Create a person and add a profile icon to the person
  Create a page and add comment to the page
  Export the person

  Expected result
   In report bar the message - Export generated successfully.

  Actual result
   In report bar the message - Export generated with some errors.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/21.10/+bug/1998725/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp