[Mahara-contributors] [Bug 2037565] A patch has been submitted for review
Patch for "22.10_STABLE" branch: https://reviews.mahara.org/c/mahara/+/13900 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2037565 Title: Display problem with search label in Portfolios page (lang french) Status in Mahara: New Bug description: To reproduce : * Navigate to the 'Portfolios' (page view/index.php or Main menu > create > Portfolios) * Click the "Language chooser" to switch to french language. Actual : the two Drop-down labels of 'Search' and 'Sort by' are overlapped. Expected : spacing between them To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2037565/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2006512] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13895 Committed: https://git.mahara.org/mahara/mahara/commit/5426af6971ba9284b963ba93ef99f9fc87c2c64b Submitter: "Robert Lyon " Branch:main commit 5426af6971ba9284b963ba93ef99f9fc87c2c64b Author: Kristina Hoeppner Date: Wed Apr 5 14:18:40 2023 +1200 Bug 2006512: Consolidate 'Manage access' and 'Share' and icons Use the lock / unlock icon only for indicating the state on the portfolios overview page, and use the 'share' icon, i.e. the 'share-nodes' FontAwesome icon for all the other areas. Strings are also adjusted. Change-Id: Ic22cf76fb3f6a8173fcd880114064765df0fd2e4 Signed-off-by: Doris Tam -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2006512 Title: 'Manage access' or 'Sharing' - which is it? Status in Mahara: Fix Committed Bug description: The page which displays management of sharing pages is currently called 'Share'. However, on the 'Portfolios' page, the card dropdown says ' Manage access' http://mahara/view/accessurl.php?collection=1 goes to a page called ' Edit access' See images for more. Titles, buttons, and links that go to the same functionality should be called the same otherwise it creates complexity in people learning to use Mahara. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2006512/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2013246] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13897 Committed: https://git.mahara.org/mahara/mahara/commit/27fcacf9d36d998b38cda5eaf0b74655aadc85ce Submitter: "Robert Lyon " Branch:main commit 27fcacf9d36d998b38cda5eaf0b74655aadc85ce Author: Robert Lyon Date: Thu Apr 6 16:17:53 2023 +1200 Bug 2013246: Disable copy page link - regression issue Still need the copy link in 'More' menu on normal page within a collection to prompt with modal to choose copy collection or copy page Signed-off-by: Robert Lyon Change-Id: Id5ed8af41195a842892d68fcf8c6e508f9c00159 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2013246 Title: Disable copy page link when link is an tag Status in Mahara: Fix Committed Bug description: Normally the 'copy' option is a button set by pieforms and so has a built in disable/processing system so we can only click it once. But if we have an link tag that hits the copying page directly with the view/collection id there is no disable mechanism on the link once it is clicked. This can cause people to click the link multiple times when the portfolio being copied is large because there is a delay after the clicking and before the finishing of process/redirection to new copy. We need some javascript to disable the link after the first click / show a processing icon so that people can only click it once before the process finishes/redirects To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2013246/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2006632] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13889 Committed: https://git.mahara.org/mahara/mahara/commit/03543dff93e0b98f3be85462dbad5dea00363d33 Submitter: "Robert Lyon " Branch:main commit 03543dff93e0b98f3be85462dbad5dea00363d33 Author: Robert Lyon Date: Fri Mar 31 13:40:47 2023 +1300 Bug 2006632: Allow config.php set the PHP and SELENIUM ports >From the $cfg->behat_wwwroot and $cfg->behat_selenium2 values if they specify a port number Signed-off-by: Robert Lyon Change-Id: Ia243a5224723079980788710239c69246cd95bb3 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2006632 Title: PHP port in use for behat Status in Mahara: Fix Committed Bug description: I had an issue running mahara_behat.sh and tracked it down to port 8000 already being used. We should check for the port being in use and incrementing if so. The attached patch resolved this for me. This uses nc (netcat) to test the port. From what I've seen, netcat is installed on more distros than not. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2006632/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007457] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13896 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007457 Title: Third party library updates for 23.04 Status in Mahara: Fix Committed Bug description: Third-party investigation and updates. To be discussed which ones will get into the next release. Things to note: No security issues. We are 3 major versions behind in Gridstack, Patches available (break-free changes) for: Gridstack, ClipboardJS, CSSTidy, TinyMCE Minor updates available (should not have breaking changes) for: Gridstack, ChartJS, ElasticSearch, MomentJS, PDFJS, VideoJS, Bootstrap, Dragondrop, Datatables, Dropzone, HTMLPurifier, jQuery, JSColor, JSON Editor, MarkedJS, PHPMailer, Popper, SSPHP, FontAwesome Major (will have breaking changes) upgrades requiring migration available for: DateTimePicker, VideoJS, PDFJS, MomentJS, Elasticsearch, ChartJS, and Gridstack To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007457/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1987709] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13882 Committed: https://git.mahara.org/mahara/mahara/commit/0f9421dbf33d2d4a5ca57b8b53e5008594170c44 Submitter: "Doris Tam " Branch:main commit 0f9421dbf33d2d4a5ca57b8b53e5008594170c44 Author: Robert Lyon Date: Wed Mar 29 16:04:16 2023 +1300 Bug 1987709: Allow setting of lastlastlogin to work as expected The $USER->reanimate() function does the actual setting of the lastlogin and lastlastlogin values Signed-off-by: Robert Lyon Change-Id: I05c226a5f2eb6e7b51cb9e26b8655a09a3a472cf -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1987709 Title: Authentication via SAML looks to cause improper setting of 'lastlastlogin' Status in Mahara: Fix Committed Bug description: It looks like we set it in the auth/saml/lib.php file but also call the $USER->reanimate() function that then calls $USER->authenticate() that also look to set it. We need to check if we actually need to set it in the saml file or just leave it to the reanimate function To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1987709/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2003378] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13869 Committed: https://git.mahara.org/mahara/mahara/commit/5c38878d2ca9c34086b618afdaa817041d38de26 Submitter: "Robert Lyon " Branch:main commit 5c38878d2ca9c34086b618afdaa817041d38de26 Author: Doris Tam Date: Thu Mar 23 16:12:56 2023 +1300 Bug 2003378: Add PHP code sniffer into GrumPHP - Add custom rule to enforce un-cuddled control structures with phpcsfixer - General fixes will use phpcbf Change-Id: Ifad05cfc983bd0f059fc03b391cd1605c1c02e1f Signed-off-by: Doris Tam -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2003378 Title: PHP 8 Compatibility: phpcs Status in Mahara: Fix Committed Bug description: We're getting close to finishing this. We are currently working through the output of PHP CodeSniffer. This bug is a catchall bug to cover this work. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2003378/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2008956] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13893 Committed: https://git.mahara.org/mahara/mahara/commit/846ce66c55a5bc70d7bccc1992a55be9bd3ecefe Submitter: "Robert Lyon " Branch:main commit 846ce66c55a5bc70d7bccc1992a55be9bd3ecefe Author: Doris Tam Date: Wed Apr 5 10:33:56 2023 +1200 Bug 2008956: Make the first behat test folder a quick run This is so that in Jenkins, Behat can fail early and we can test the config without waiting for a huge folder of features to run first. Change-Id: I75e4cfabbf6707bbb95c7977e7bc742f567dbfde -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2008956 Title: PHP 8 deprecations to fix behat tests Status in Mahara: In Progress Bug description: Fixes to get tests running on PHP 8 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2008956/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1966154] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13891 Committed: https://git.mahara.org/mahara/mahara/commit/375e732e172dd0a59ef37948e1f42077962542f3 Submitter: "Doris Tam " Branch:main commit 375e732e172dd0a59ef37948e1f42077962542f3 Author: Doris Tam Date: Mon Apr 3 10:54:31 2023 +1200 Bug 1966154: Get table config back for mobile view of TinyMCE Change-Id: I95aba78f3c00b78be24703448497dec0a5fa26bb Signed-off-by: Doris Tam -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1966154 Title: TinyMCE on mobile doesn't allow for the adding of table rows / editing table properties Status in Mahara: Fix Committed Bug description: It is not possible to add more rows to a table when you want to edit text via tinyMCE on a mobile device, e.g. phone. The current mobile interface of tinyMCE prevents the editing of table properties. I checked the online demo of tinyMCE and there it is possible to edit tables in both the basic and fully featured examples https://www.tiny.cloud/docs/demo/ but it doesn't look like those examples are using the mobile tinyMCE interface. We'd need to investigate: - Is the mobile interface we use still supported? There were some deprecations? - Do we still need a special mobile interface or can tinyMCE 5 be used on mobile as is? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1966154/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2013246] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13884 Committed: https://git.mahara.org/mahara/mahara/commit/1e5bdee1f934a8342d6bdbbee724678d4a1998fb Submitter: "Doris Tam " Branch:main commit 1e5bdee1f934a8342d6bdbbee724678d4a1998fb Author: Robert Lyon Date: Thu Mar 30 10:20:43 2023 +1300 Bug 2013246: Adding a way to disable copy links when via tags Signed-off-by: Robert Lyon Change-Id: I9b0b516b3b85aa324a481fd7a0596216adf0fa1c -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2013246 Title: Disable copy page link when link is an tag Status in Mahara: Fix Committed Bug description: Normally the 'copy' option is a button set by pieforms and so has a built in disable/processing system so we can only click it once. But if we have an link tag that hits the copying page directly with the view/collection id there is no disable mechanism on the link once it is clicked. This can cause people to click the link multiple times when the portfolio being copied is large because there is a delay after the clicking and before the finishing of process/redirection to new copy. We need some javascript to disable the link after the first click / show a processing icon so that people can only click it once before the process finishes/redirects To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2013246/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007457] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13894 Committed: https://git.mahara.org/mahara/mahara/commit/a853555af4e10739272d05ac698d3516f4f280ef Submitter: "Doris Tam " Branch:main commit a853555af4e10739272d05ac698d3516f4f280ef Author: Doris Tam Date: Wed Apr 5 12:38:30 2023 +1200 Bug 2007457: Change FA copy icon to clone icon *FontAwesome icon Change-Id: I34969ef105a7dbac8615debf81facbf6ef3569f8 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007457 Title: Third party library updates for 23.04 Status in Mahara: Fix Committed Bug description: Third-party investigation and updates. To be discussed which ones will get into the next release. Things to note: No security issues. We are 3 major versions behind in Gridstack, Patches available (break-free changes) for: Gridstack, ClipboardJS, CSSTidy, TinyMCE Minor updates available (should not have breaking changes) for: Gridstack, ChartJS, ElasticSearch, MomentJS, PDFJS, VideoJS, Bootstrap, Dragondrop, Datatables, Dropzone, HTMLPurifier, jQuery, JSColor, JSON Editor, MarkedJS, PHPMailer, Popper, SSPHP, FontAwesome Major (will have breaking changes) upgrades requiring migration available for: DateTimePicker, VideoJS, PDFJS, MomentJS, Elasticsearch, ChartJS, and Gridstack To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007457/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007457] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13839 Committed: https://git.mahara.org/mahara/mahara/commit/d7e1077a84fe0c558348ba4e0829556b9656feb2 Submitter: "Doris Tam " Branch:main commit d7e1077a84fe0c558348ba4e0829556b9656feb2 Author: Doris Tam Date: Fri Mar 3 15:14:25 2023 +1300 Bug 2007457: Move bootstrap to NPM Run in the htdocs folder: npm install to get files we need from JS libraries. In the same way that composer install will pull in our customisations for PHP, npm install will pull in our customisations for JavaScript. Post install script - patch-package to manage customisations - new /patches folder for managing npm patches Change-Id: Ic174d28870480564fccbe7b04d70c9de7a2547c5 Signed-off-by: Doris Tam -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007457 Title: Third party library updates for 23.04 Status in Mahara: Fix Committed Bug description: Third-party investigation and updates. To be discussed which ones will get into the next release. Things to note: No security issues. We are 3 major versions behind in Gridstack, Patches available (break-free changes) for: Gridstack, ClipboardJS, CSSTidy, TinyMCE Minor updates available (should not have breaking changes) for: Gridstack, ChartJS, ElasticSearch, MomentJS, PDFJS, VideoJS, Bootstrap, Dragondrop, Datatables, Dropzone, HTMLPurifier, jQuery, JSColor, JSON Editor, MarkedJS, PHPMailer, Popper, SSPHP, FontAwesome Major (will have breaking changes) upgrades requiring migration available for: DateTimePicker, VideoJS, PDFJS, MomentJS, Elasticsearch, ChartJS, and Gridstack To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007457/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2006512] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13895 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2006512 Title: 'Manage access' or 'Sharing' - which is it? Status in Mahara: In Progress Bug description: The page which displays management of sharing pages is currently called 'Share'. However, on the 'Portfolios' page, the card dropdown says ' Manage access' http://mahara/view/accessurl.php?collection=1 goes to a page called ' Edit access' See images for more. Titles, buttons, and links that go to the same functionality should be called the same otherwise it creates complexity in people learning to use Mahara. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2006512/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007457] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13894 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007457 Title: Third party library updates for 23.04 Status in Mahara: Fix Committed Bug description: Third-party investigation and updates. To be discussed which ones will get into the next release. Things to note: No security issues. We are 3 major versions behind in Gridstack, Patches available (break-free changes) for: Gridstack, ClipboardJS, CSSTidy, TinyMCE Minor updates available (should not have breaking changes) for: Gridstack, ChartJS, ElasticSearch, MomentJS, PDFJS, VideoJS, Bootstrap, Dragondrop, Datatables, Dropzone, HTMLPurifier, jQuery, JSColor, JSON Editor, MarkedJS, PHPMailer, Popper, SSPHP, FontAwesome Major (will have breaking changes) upgrades requiring migration available for: DateTimePicker, VideoJS, PDFJS, MomentJS, Elasticsearch, ChartJS, and Gridstack To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007457/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007431] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13883 Committed: https://git.mahara.org/mahara/mahara/commit/b537989311a6a87d99018fb3680613dcd4895406 Submitter: "Robert Lyon " Branch:main commit b537989311a6a87d99018fb3680613dcd4895406 Author: Robert Lyon Date: Thu Mar 30 09:45:13 2023 +1300 Bug 2007431: Set the annotation to default width/height When adding via matrix point Signed-off-by: Robert Lyon Change-Id: If8e1bda5ce54bbfb0b29f5cde00e79658fd0a716 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007431 Title: Annotation blocks are not added in full width via matrix page Status in Mahara: Fix Committed Bug description: For Mahara 23.04 we changed the default width of blocks to full width. However, an annotation block is still only 1/3 of that width. To replicate: 1. Enable SmartEvidence for the institution. 2. Create a collection with one page and select a SmartEvidence framework. 3. Place an annotation via the SmartEvidence matrix page. 4. Go to the page for which the annotation was added. Results: - Expected: The annotation block is added in full width. - Actual: It's not. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007431/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2008956] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13893 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2008956 Title: PHP 8 deprecations to fix behat tests Status in Mahara: In Progress Bug description: Fixes to get tests running on PHP 8 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2008956/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1991604] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13887 Committed: https://git.mahara.org/mahara/mahara/commit/416276590ce4b027ae8ad5ee025043bfda67082d Submitter: "Doris Tam " Branch:main commit 416276590ce4b027ae8ad5ee025043bfda67082d Author: Robert Lyon Date: Thu Mar 30 14:08:22 2023 +1300 Bug 1991604: Fixing missing language string In the Profile -> settings -> notifications section Signed-off-by: Robert Lyon Change-Id: I8e66d6b894cfd4be1745dba3441bb3d803a44b30 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1991604 Title: Outcomes portfolio (4): Activity page infrastructure Status in Mahara: Fix Committed Bug description: Part of the outcomes portfolio blueprint: https://blueprints.launchpad.net/mahara/+spec/outcomes-portfolio Better formatting: https://wiki.mahara.org/wiki/Proposals/Outcomes_portfolio/Activity_page_infrastructure # Activity page infrastructure ## High level overview * Add activity information to the page settings → Create a new portfolio page type * Pull in information from tables and people to auto-populate information * Display activity information set up on the page settings page * Update certain information directly while editing or viewing the activity page * Dealing with 'signing off' / completing activities ## Details ### Mock-up reference: 'Set up activity page – group tutor and group admin' **Who?** As group tutor or group admin... **What?** I want to set up activites for the group member... **Why?** So that all admin work is collected in one place and then available when I work with the group member on a particular activity. The numbered list refers to the bullets in the mock-up 'Set up activity page – group tutors and group admin'. This page is only accessible to group tutors and group admins. Students cannot get to it. 1. [no change] Page title: It's a short title of the activity to avoid that the heading of a page is longer than one line and therefore fits better into a navigation menu. This title is pulled into the outcomes overview page automatically. Mandatory field. 2. Activity information panel: automatically uncollapsed as information needs to be entered. 3. Activity description: Long title of the activity. Mandatory field. 4. Subject: Select list with hard-coded items (phase 1). 5. Responsible staff: Select list comprised of all group tutors and group admins from this group. The person filling in the form is automatically displayed as default choice. 6. Start date: Date picker. 7. End date: Date picker. Check that the end date is greater or equal to the start date. 8. Levels of achievement: Three single-line text entry fields. The fourth level is predefined. * Icons are assigned automatically. * Level 1 is the highest achievement and level 4 the lowest. * Suggested icons: Font Awesome number corresponding to the level with a circle around it in primary theme link colour but with a new variable set up if a different colour should be used. This will need to be achieved with stacked icons, e.g. icon-1 and icon-circle. * New table 'view_activity_achievement_levels' with ID, view_activity_ID (i.e. the view ID), priority column (1-4), value and level 4 always being the same (via hidden value). 9. Clicking 'Save' takes you to the 'Edit' screen of the activity page. > Notes: > > * The page buttons have changed slightly in Mahara 22.10 and thus will be used instead of the ones pictured on the mock-up. > * This settings page is only available to group tutors and group admins. > * The rest of the page settings stay as they are in the 'Advanced' panel. > * 'Prevent removing of blocks' in the 'Advanced' panel is automatically set to 'Yes' (see section 'Group changes') but can be changed to 'No'. ### Mock-up reference: 'Edit activity page – group tutor and group admin' **Who?** As group tutor or group admin... **What?** I want to add content to the activity page... **Why?** To assist the learner with their evidence collection and mark checkpoints as completed to illustrate progress. The numbered list refers to the bullets in the mock-up 'Edit activity page – group tutor and group admin'. This page is accessible to group tutors, group admins, and learners. 1. 'Settings' button: Available to group tutor and group admins to change information about the activity. It's not accessible to regular group members. 2. Activity information: * is displayed at the top of the page and cannot be moved. * is displayed collapsed so that you only see the long-form activity, outcomes, outcome type, and whether the outcome has been achieved or not in the panel header. * is a full-page width block. → Change the default width of blocks in Mahara
[Mahara-contributors] [Bug 2013001] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13886 Committed: https://git.mahara.org/mahara/mahara/commit/6adf4fe845d9fc0298dd852ef080d0f17d64d421 Submitter: "Doris Tam " Branch:main commit 6adf4fe845d9fc0298dd852ef080d0f17d64d421 Author: Robert Lyon Date: Thu Mar 30 14:03:13 2023 +1300 Bug 2013001: Have the reply-to set on contact us form Whether the person is logged in or not Signed-off-by: Robert Lyon Change-Id: I6d07cd10fcb9672a4406d5edd8ce4115de854d11 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2013001 Title: Change email header in 'logged in' contact us from 'From' to 'Reply- to' Status in Mahara: Fix Committed Bug description: When you send a 'Contact us' message while you are not logged in, Mahara sends it correctly: From: [Site name] Reply-to: [Sender name] However, when you are logged in, it puts the sender's details in the 'From' field and thus the 'Reply-to' field is ignored. We need to follow the logged out sender format so that email providers don't put our mails into spam because they think we are pretending to send from a domain we don't control. So instead of having a customisation to do things differently for 'Contact us', we should have one rule that follows what we currently do for emails when people are not logged in. How to differentiate the notifications when logged in and when not? - The notification when someone is logged in includes a link to their profile URL via 'See...' after the main body of the message. The scenario that should be covered: 1. You are not logged into Mahara. 2. Send a message via 'Contact us'. 3. Existing behaviour:The email sent to the site admin has the no-reply email address for the site in 'From' and the sender's email in 'Reply-to'. 4. Log into Mahara as a regular account holder. 5. Send a message via 'Contact us'. 6. The email sent to the site admin has the no-reply email address for the site in 'From' and the sender's email in 'Reply-to'. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2013001/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1969539] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13888 Committed: https://git.mahara.org/mahara/mahara/commit/d79addd956630c83ee8037289b1575a5e4136cd1 Submitter: "Doris Tam " Branch:main commit d79addd956630c83ee8037289b1575a5e4136cd1 Author: Robert Lyon Date: Thu Mar 30 18:07:30 2023 +1300 Bug 1969539: Behat test for portfolio completion page Signed-off-by: Robert Lyon Change-Id: I9646ae6fac165ae735eee20d7e018d1caaeb433b -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1969539 Title: Behat test for the portfolio completion page Status in Mahara: Fix Committed Bug description: Related to this bug here: https://bugs.launchpad.net/mahara/+bug/1857933 Test steps (from Release Testing spreadsheet) 1. Admin turns Portfolio completion on in the institution settings 2. Log in as institution member. 3. Create a collection with Portfolio completion turned on. Add 3 pages with the following blocks: P1. Sign-off block P2. Sign-off block with verification enabled P3. No sign-off block 4. Page owner ticks off the pages on the front page of the collection. Portfolio completion shows 67% 5. Owner shares collection with a specific person who they assign the manager role to. 6. Log in as the manager. They should see the following on the collection front page: P1. Sign off block ticked, nothing to do for verifier P2. Sign off block ticked; red dot for verification P3. No sign-off or verification. 7. Manager ticks off the Verification. It becomes a tick and the completion becomes 100% To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1969539/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2015016] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13892 Committed: https://git.mahara.org/mahara/mahara/commit/21541afdc107891fc2310912118f70dc8c35ac8f Submitter: "Robert Lyon " Branch:main commit 21541afdc107891fc2310912118f70dc8c35ac8f Author: Mitsuhiro Yoshida Date: Mon Apr 3 07:56:26 2023 +0900 Bug #2015016: Small fix for 'Submitted status' help file. Change-Id: I70267163342af52996982b5113fba4c9c2dcf350 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2015016 Title: Small fix for 'Submitted status' help file. Status in Mahara: Fix Committed Bug description: I think the period after the colon may not be necessary. Langfile to modify: lang/en.utf8/help/forms/ANY.submittedstatus.html [Before] Submitted status The submission status of the page can be one of the following:. [After] Submitted status The submission status of the page can be one of the following: To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2015016/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1966154] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13891 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1966154 Title: TinyMCE on mobile doesn't allow for the adding of table rows / editing table properties Status in Mahara: In Progress Bug description: It is not possible to add more rows to a table when you want to edit text via tinyMCE on a mobile device, e.g. phone. The current mobile interface of tinyMCE prevents the editing of table properties. I checked the online demo of tinyMCE and there it is possible to edit tables in both the basic and fully featured examples https://www.tiny.cloud/docs/demo/ but it doesn't look like those examples are using the mobile tinyMCE interface. We'd need to investigate: - Is the mobile interface we use still supported? There were some deprecations? - Do we still need a special mobile interface or can tinyMCE 5 be used on mobile as is? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1966154/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2015016] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13892 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2015016 Title: Small fix for 'Submitted status' help file. Status in Mahara: New Bug description: I think the period after the colon may not be necessary. Langfile to modify: lang/en.utf8/help/forms/ANY.submittedstatus.html [Before] Submitted status The submission status of the page can be one of the following:. [After] Submitted status The submission status of the page can be one of the following: To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2015016/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007457] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13788 Committed: https://git.mahara.org/mahara/mahara/commit/cf6040c6d4039ecd370d18f2f0d79e001865c8ec Submitter: "Robert Lyon " Branch:main commit cf6040c6d4039ecd370d18f2f0d79e001865c8ec Author: Doris Tam Date: Mon Feb 20 11:20:37 2023 +1300 Bug 2007457: Update Gridstack to 4.4.1 Change-Id: If09c10ec9085cf1ef03b1c8a7e9f4cc11e1f1b1f Signed-off-by: Doris Tam -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007457 Title: Third party library updates for 23.04 Status in Mahara: Fix Committed Bug description: Third-party investigation and updates. To be discussed which ones will get into the next release. Things to note: No security issues. We are 3 major versions behind in Gridstack, Patches available (break-free changes) for: Gridstack, ClipboardJS, CSSTidy, TinyMCE Minor updates available (should not have breaking changes) for: Gridstack, ChartJS, ElasticSearch, MomentJS, PDFJS, VideoJS, Bootstrap, Dragondrop, Datatables, Dropzone, HTMLPurifier, jQuery, JSColor, JSON Editor, MarkedJS, PHPMailer, Popper, SSPHP, FontAwesome Major (will have breaking changes) upgrades requiring migration available for: DateTimePicker, VideoJS, PDFJS, MomentJS, Elasticsearch, ChartJS, and Gridstack To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007457/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1996475] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13890 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1996475 Title: Allow submissions to create a duplicate page/collection and submit that leaving the original still editable Status in Mahara: Fix Committed Bug description: ## High level functionality summary When a student submits a portfolio for assessment, a **copy** is made in their Mahara account, which is submitted rather than the original portfolio. That copy is available through Mahara. If the student accidentally deletes the submission link from an external LTI submission, e.g. Brightspace assignment, before they submit the assignment, they can return to the Brightspace 'Quicklink 'option and select their portfolio again for submission and a new copy is made. The previous copy is still available in Mahara, but not shown to the student in the 'Quicklink' option. All changes are made on the Mahara side to which parts LTI will 'call' and how we deal with submissions to ensure that no changes are needed on the LMS that wouldn't be LTI calls. ## Workflow 1. The student selects portfolio via the Brightspace 'Quicklink' menu. 2. The student confirms that they want to submit the portfolio. The submission confirmation screen message changes from 'If you submit "Title of the portfolio" for assessment, you will not be able to edit its content until marking has finished. Are you sure you want to submit this portfolio now?' to 'If you submit “Title of the portfolio” for assessment, a copy of that portfolio will be made and submitted. Do not remove the link that is inserted into the 'Text Submission' box. If you do, select your portfolio again via the 'Quicklink' and submit it again. You can continue working on the portfolio itself, but changes you make to it will not be reflected in your submitted portfolio.' 3. Student must click the 'Confirm' button to continue or the 'Cancel' button to select another portfolio. The following assumes that the student confirmed the submission. 4. A copy of the portfolio that is being submitted is made without adding a 'Copy of' at the start of the portfolio or a version number at the end to any page or collection title. Instead, the portfolio title (either title of the collection if the portfolio is a collection or title of the page if the portfolio is a single page; pages within a collection do not change their page title) is appended with '; submitted at DDMMYY, HH:MM', e.g. 'Assessment portfolio; submitted at 09/09/2022, 11:59'. The short date version is used so as not to make the title longer than necessary. A suffix is chosen so if portfolios are all listed in one area, all related portfolios are grouped together alphabetically. 5. A link to the original portfolio is added to the collection and page settings to find the original more easily later on. This is similar to the link added when a template is copied. The same logic will apply, i.e. if the original still exists, it is linked, if it was deleted, no link will be provided. 6. The submission copy is flagged as 'Submission' so it can be filtered from the list of portfolios a student sees on their 'Pages and collections' overview page and also wherever portfolios are selected for submission so they are not displayed when viewing portfolios available for submission. 7. On the 'Pages and collections' overview page an option is added to include submitted portfolios in the display. Per default, they are excluded. 8. Submitted copies behave like submitted portfolios right now: They are marked in yellow on the 'Pages and collections' overview page and an icon added to the left of the 'More options' menu to indicate that it's a submission. The submission time is mentioned in the 'More options' menu. The portfolio cannot be deleted and artefacts are locked. Page comments are added to this copy and stay with it. They are not added to the original portfolio. Artefact comments are visible on other pages when the artefact is added there. 9. When the instructor finished grading and the portfolio is unlocked, it is still flagged as 'Submission' but is not marked in yellow any more and the student can remove the 'Submission' flag from the page settings or collection settings if they want to 'promote' this portfolio to a regular portfolio so they can continue working on it and maybe even re-submit that copy if the original already diverged. 10. Submissions that have been returned to the student can be deleted through the normal deletion process and students can change anything else in them, including portfolio title, artefacts, etc. 11. Students cannot revoke a submission on their own. However, a site administrator can do so in Admin menu → Groups → Submissions through
[Mahara-contributors] [Bug 2006632] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13889 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2006632 Title: PHP port in use for behat Status in Mahara: Triaged Bug description: I had an issue running mahara_behat.sh and tracked it down to port 8000 already being used. We should check for the port being in use and incrementing if so. The attached patch resolved this for me. This uses nc (netcat) to test the port. From what I've seen, netcat is installed on more distros than not. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2006632/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1996475] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13822 Committed: https://git.mahara.org/mahara/mahara/commit/e56fcd8e0651d8d094a6c6137833735d852eeba1 Submitter: "Robert Lyon " Branch:main commit e56fcd8e0651d8d094a6c6137833735d852eeba1 Author: Robert Lyon Date: Wed Feb 22 17:19:50 2023 +1300 Bug 1996475: Submitted portfolios appear as column on reports in the Admin → Reports section Fixed for: - page activity report - page access report - SmartEvidence summary report 'Submission status' column added and all three statuses are listed for portfolios so it's clear which ones are currently submitted, released, or not submitted. Change-Id: I1ce7f11f053742b6d32c279e19401aafe3d74ac7 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1996475 Title: Allow submissions to create a duplicate page/collection and submit that leaving the original still editable Status in Mahara: Fix Committed Bug description: ## High level functionality summary When a student submits a portfolio for assessment, a **copy** is made in their Mahara account, which is submitted rather than the original portfolio. That copy is available through Mahara. If the student accidentally deletes the submission link from an external LTI submission, e.g. Brightspace assignment, before they submit the assignment, they can return to the Brightspace 'Quicklink 'option and select their portfolio again for submission and a new copy is made. The previous copy is still available in Mahara, but not shown to the student in the 'Quicklink' option. All changes are made on the Mahara side to which parts LTI will 'call' and how we deal with submissions to ensure that no changes are needed on the LMS that wouldn't be LTI calls. ## Workflow 1. The student selects portfolio via the Brightspace 'Quicklink' menu. 2. The student confirms that they want to submit the portfolio. The submission confirmation screen message changes from 'If you submit "Title of the portfolio" for assessment, you will not be able to edit its content until marking has finished. Are you sure you want to submit this portfolio now?' to 'If you submit “Title of the portfolio” for assessment, a copy of that portfolio will be made and submitted. Do not remove the link that is inserted into the 'Text Submission' box. If you do, select your portfolio again via the 'Quicklink' and submit it again. You can continue working on the portfolio itself, but changes you make to it will not be reflected in your submitted portfolio.' 3. Student must click the 'Confirm' button to continue or the 'Cancel' button to select another portfolio. The following assumes that the student confirmed the submission. 4. A copy of the portfolio that is being submitted is made without adding a 'Copy of' at the start of the portfolio or a version number at the end to any page or collection title. Instead, the portfolio title (either title of the collection if the portfolio is a collection or title of the page if the portfolio is a single page; pages within a collection do not change their page title) is appended with '; submitted at DDMMYY, HH:MM', e.g. 'Assessment portfolio; submitted at 09/09/2022, 11:59'. The short date version is used so as not to make the title longer than necessary. A suffix is chosen so if portfolios are all listed in one area, all related portfolios are grouped together alphabetically. 5. A link to the original portfolio is added to the collection and page settings to find the original more easily later on. This is similar to the link added when a template is copied. The same logic will apply, i.e. if the original still exists, it is linked, if it was deleted, no link will be provided. 6. The submission copy is flagged as 'Submission' so it can be filtered from the list of portfolios a student sees on their 'Pages and collections' overview page and also wherever portfolios are selected for submission so they are not displayed when viewing portfolios available for submission. 7. On the 'Pages and collections' overview page an option is added to include submitted portfolios in the display. Per default, they are excluded. 8. Submitted copies behave like submitted portfolios right now: They are marked in yellow on the 'Pages and collections' overview page and an icon added to the left of the 'More options' menu to indicate that it's a submission. The submission time is mentioned in the 'More options' menu. The portfolio cannot be deleted and artefacts are locked. Page comments are added to this copy and stay with it. They are not added to the original portfolio. Artefact comments are visible on other pages when the artefact is added there. 9. When the instructor finished grading and the portfolio is unlocked, it is still flagged as
[Mahara-contributors] [Bug 2006514] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13881 Committed: https://git.mahara.org/mahara/mahara/commit/dda62ed4b86ca3188db95febbd6efb2fe044a6fc Submitter: "Robert Lyon " Branch:main commit dda62ed4b86ca3188db95febbd6efb2fe044a6fc Author: Robert Lyon Date: Wed Mar 29 14:39:18 2023 +1300 Bug 2006514: Fixing mistake in upgrade step for sign-off functionality Using the wrong variable Signed-off-by: Robert Lyon Change-Id: I69ddf131dc74a47a48f4abf02ff4c160e6b4541e -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2006514 Title: Inconsistent Sign-off blocks after upgrade Status in Mahara: In Progress Bug description: When rebasing a patchset on main I noticed a Page had lost the Sign- off block. This Page **was not** in a signed off state. The other Page in the Collection also had the block, **was** in a Signed off state, and did still have the new form of the block. I think the upgrade step here needs to be updated. It's working for block instances that are signed off, but not for those that aren't. https://git.mahara.org/mahara/mahara/-/blob/main/htdocs/lib/db/upgrade.php#L975 Testing: Checkout 22.10_RELEASE and install the site Create an account As that account, create 2 Pages and add them to a Collection Add Progress Completion to the Collection Sign-off blocks to both pages Mark the first Page as Signed off. Back up the DB for handy restoring during development. Checkout main Run the upgrade Look at the Collection and pages. Expected result: * A Collection with a Progress Completion page * The Progress Completion page to shows the first Page with the Sign-off state with a signed off indicator * The Progress Completion page to shows the second Page with the Sign-off state with a not signed off indicator * The first Page to have the new form of the Sign-off block in a signed off state * The second Page to have the new form of the Sign-off block in a not signed off state The current result: * A Collection with a Progress Completion page * The Progress Completion page to shows the first Page with the Sign-off state with a signed off indicator * The Progress Completion page to shows the second Page **with no** Sign-off state indicator * The first Page has the new form of the Sign-off block in a signed off state * The second Page **does not have have** the new form of the Sign-off block in a not signed off state To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2006514/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1969539] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13888 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1969539 Title: Behat test for the portfolio completion page Status in Mahara: In Progress Bug description: Related to this bug here: https://bugs.launchpad.net/mahara/+bug/1857933 Test steps (from Release Testing spreadsheet) 1. Admin turns Portfolio completion on in the institution settings 2. Log in as institution member. 3. Create a collection with Portfolio completion turned on. Add 3 pages with the following blocks: P1. Sign-off block P2. Sign-off block with verification enabled P3. No sign-off block 4. Page owner ticks off the pages on the front page of the collection. Portfolio completion shows 67% 5. Owner shares collection with a specific person who they assign the manager role to. 6. Log in as the manager. They should see the following on the collection front page: P1. Sign off block ticked, nothing to do for verifier P2. Sign off block ticked; red dot for verification P3. No sign-off or verification. 7. Manager ticks off the Verification. It becomes a tick and the completion becomes 100% To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1969539/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1991604] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13887 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1991604 Title: Outcomes portfolio (4): Activity page infrastructure Status in Mahara: Fix Committed Bug description: Part of the outcomes portfolio blueprint: https://blueprints.launchpad.net/mahara/+spec/outcomes-portfolio Better formatting: https://wiki.mahara.org/wiki/Proposals/Outcomes_portfolio/Activity_page_infrastructure # Activity page infrastructure ## High level overview * Add activity information to the page settings → Create a new portfolio page type * Pull in information from tables and people to auto-populate information * Display activity information set up on the page settings page * Update certain information directly while editing or viewing the activity page * Dealing with 'signing off' / completing activities ## Details ### Mock-up reference: 'Set up activity page – group tutor and group admin' **Who?** As group tutor or group admin... **What?** I want to set up activites for the group member... **Why?** So that all admin work is collected in one place and then available when I work with the group member on a particular activity. The numbered list refers to the bullets in the mock-up 'Set up activity page – group tutors and group admin'. This page is only accessible to group tutors and group admins. Students cannot get to it. 1. [no change] Page title: It's a short title of the activity to avoid that the heading of a page is longer than one line and therefore fits better into a navigation menu. This title is pulled into the outcomes overview page automatically. Mandatory field. 2. Activity information panel: automatically uncollapsed as information needs to be entered. 3. Activity description: Long title of the activity. Mandatory field. 4. Subject: Select list with hard-coded items (phase 1). 5. Responsible staff: Select list comprised of all group tutors and group admins from this group. The person filling in the form is automatically displayed as default choice. 6. Start date: Date picker. 7. End date: Date picker. Check that the end date is greater or equal to the start date. 8. Levels of achievement: Three single-line text entry fields. The fourth level is predefined. * Icons are assigned automatically. * Level 1 is the highest achievement and level 4 the lowest. * Suggested icons: Font Awesome number corresponding to the level with a circle around it in primary theme link colour but with a new variable set up if a different colour should be used. This will need to be achieved with stacked icons, e.g. icon-1 and icon-circle. * New table 'view_activity_achievement_levels' with ID, view_activity_ID (i.e. the view ID), priority column (1-4), value and level 4 always being the same (via hidden value). 9. Clicking 'Save' takes you to the 'Edit' screen of the activity page. > Notes: > > * The page buttons have changed slightly in Mahara 22.10 and thus will be used instead of the ones pictured on the mock-up. > * This settings page is only available to group tutors and group admins. > * The rest of the page settings stay as they are in the 'Advanced' panel. > * 'Prevent removing of blocks' in the 'Advanced' panel is automatically set to 'Yes' (see section 'Group changes') but can be changed to 'No'. ### Mock-up reference: 'Edit activity page – group tutor and group admin' **Who?** As group tutor or group admin... **What?** I want to add content to the activity page... **Why?** To assist the learner with their evidence collection and mark checkpoints as completed to illustrate progress. The numbered list refers to the bullets in the mock-up 'Edit activity page – group tutor and group admin'. This page is accessible to group tutors, group admins, and learners. 1. 'Settings' button: Available to group tutor and group admins to change information about the activity. It's not accessible to regular group members. 2. Activity information: * is displayed at the top of the page and cannot be moved. * is displayed collapsed so that you only see the long-form activity, outcomes, outcome type, and whether the outcome has been achieved or not in the panel header. * is a full-page width block. → Change the default width of blocks in Mahara when they are put on a page into full-page width blocks 3. Activity description: Long 'title' of the activity. 4. Outcome: Short title of the outcome to which this activity belongs. 5. Outcome type: Pulled from the outcome, i.e. short name with the predefined background colour. 6. Achieved: Switch to decide whether an outcome has been achieved or not. This can always be changed. A modal is displayed
[Mahara-contributors] [Bug 2013001] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13886 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2013001 Title: Change email header in 'logged in' contact us from 'From' to 'Reply- to' Status in Mahara: In Progress Bug description: When you send a 'Contact us' message while you are not logged in, Mahara sends it correctly: From: [Site name] Reply-to: [Sender name] However, when you are logged in, it puts the sender's details in the 'From' field and thus the 'Reply-to' field is ignored. We need to follow the logged out sender format so that email providers don't put our mails into spam because they think we are pretending to send from a domain we don't control. So instead of having a customisation to do things differently for 'Contact us', we should have one rule that follows what we currently do for emails when people are not logged in. How to differentiate the notifications when logged in and when not? - The notification when someone is logged in includes a link to their profile URL via 'See...' after the main body of the message. The scenario that should be covered: 1. You are not logged into Mahara. 2. Send a message via 'Contact us'. 3. Existing behaviour:The email sent to the site admin has the no-reply email address for the site in 'From' and the sender's email in 'Reply-to'. 4. Log into Mahara as a regular account holder. 5. Send a message via 'Contact us'. 6. The email sent to the site admin has the no-reply email address for the site in 'From' and the sender's email in 'Reply-to'. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2013001/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1979373] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13885 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1979373 Title: Deprecate SOAP support Status in Mahara: In Progress Bug description: While working through PHPStan issues I found that the SOAP implementation should have been reliably throwing errors. The lack of issues in this area suggests that this is not being used at all. Rather than supporting what is now quite old code we should just deprecate it and remove it from the codebase. The area that drew this to my attention is here: https://git.mahara.org/mahara/mahara/-/blob/main/htdocs/lib/mahara.php#L2640 $wsseSoapClient = new webservice_soap_client_wsse( array($client, '_doRequest'), $client->wsdlfile, $client->getOptions() ); The first parameter, which should declare our request, is unused in webservice_soap_client_wsse() The third parameter is unused also. In the webservice_soap_client_wsse() class there is a private $options, but this is never set. Also, webservice_soap_client(), which gives us $client, has no getOptions() method so this should also be erroring out loudly. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1979373/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2012988] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13874 Committed: https://git.mahara.org/mahara/mahara/commit/9f0fe1bea201443f963eaac614dbc1d25d4304fd Submitter: "Robert Lyon " Branch:main commit 9f0fe1bea201443f963eaac614dbc1d25d4304fd Author: Mitsuhiro Yoshida Date: Tue Mar 28 08:32:46 2023 +0900 Bug #2012988: Small fix for a typo on lang/en.utf8/mahara.php. Change-Id: Ibcab3e7177a05402ed97eaa8c37dda9c31f5c1b7 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2012988 Title: Small fix for a typo on lang/en.utf8/mahara.php. Status in Mahara: Fix Committed Bug description: I think it's better to fix a typo (capitalisation and lowercase) on lang/en.utf8/mahara.php as below. Langfile: lang/en.utf8/mahara.php String: releasedinfofor [Before] RElease options for "%s" [After] Release options for "%s" To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2012988/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2013246] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13884 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2013246 Title: Disable copy page link when link is an tag Status in Mahara: In Progress Bug description: Normally the 'copy' option is a button set by pieforms and so has a built in disable/processing system so we can only click it once. But if we have an link tag that hits the copying page directly with the view/collection id there is no disable mechanism on the link once it is clicked. This can cause people to click the link multiple times when the portfolio being copied is large because there is a delay after the clicking and before the finishing of process/redirection to new copy. We need some javascript to disable the link after the first click / show a processing icon so that people can only click it once before the process finishes/redirects To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2013246/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007431] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13883 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007431 Title: Annotation blocks are not added in full width via matrix page Status in Mahara: In Progress Bug description: For Mahara 23.04 we changed the default width of blocks to full width. However, an annotation block is still only 1/3 of that width. To replicate: 1. Enable SmartEvidence for the institution. 2. Create a collection with one page and select a SmartEvidence framework. 3. Place an annotation via the SmartEvidence matrix page. 4. Go to the page for which the annotation was added. Results: - Expected: The annotation block is added in full width. - Actual: It's not. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007431/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1987709] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13882 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1987709 Title: Authentication via SAML looks to cause improper setting of 'lastlastlogin' Status in Mahara: In Progress Bug description: It looks like we set it in the auth/saml/lib.php file but also call the $USER->reanimate() function that then calls $USER->authenticate() that also look to set it. We need to check if we actually need to set it in the saml file or just leave it to the reanimate function To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1987709/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2006514] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13881 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2006514 Title: Inconsistent Sign-off blocks after upgrade Status in Mahara: Confirmed Bug description: When rebasing a patchset on main I noticed a Page had lost the Sign- off block. This Page **was not** in a signed off state. The other Page in the Collection also had the block, **was** in a Signed off state, and did still have the new form of the block. I think the upgrade step here needs to be updated. It's working for block instances that are signed off, but not for those that aren't. https://git.mahara.org/mahara/mahara/-/blob/main/htdocs/lib/db/upgrade.php#L975 Testing: Checkout 22.10_RELEASE and install the site Create an account As that account, create 2 Pages and add them to a Collection Add Progress Completion to the Collection Sign-off blocks to both pages Mark the first Page as Signed off. Back up the DB for handy restoring during development. Checkout main Run the upgrade Look at the Collection and pages. Expected result: * A Collection with a Progress Completion page * The Progress Completion page to shows the first Page with the Sign-off state with a signed off indicator * The Progress Completion page to shows the second Page with the Sign-off state with a not signed off indicator * The first Page to have the new form of the Sign-off block in a signed off state * The second Page to have the new form of the Sign-off block in a not signed off state The current result: * A Collection with a Progress Completion page * The Progress Completion page to shows the first Page with the Sign-off state with a signed off indicator * The Progress Completion page to shows the second Page **with no** Sign-off state indicator * The first Page has the new form of the Sign-off block in a signed off state * The second Page **does not have have** the new form of the Sign-off block in a not signed off state To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2006514/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1938740] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13880 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1938740 Title: Auth remote user table causing problems with duplicate entries Status in Mahara: Confirmed Bug description: This is the problem: The function "find_by_instanceid_username()" can cause the SQL error "ERROR: more than one row returned by a subquery used as an expression" This happens because we check remote username against username by first converting it to lowercase. We do this because username is always saved / matched as lowercase. But we don't do the same for remoteusername. So if we have the scenario where an external system logs in, say SAML, as 'test01' it creates a new user with username = 'test01' and remoteusername = 'test01' (at this point all is fine) Then if another external system logs in, say LTI, with 'Test01' it won't match on the auth_remote_user table but will subsequently match on the user table (as it will try the lowercase version of the value) but it will save a new record in the auth_remote_user as 'Test01'. So then, on the next remote login, it will now find 2 records where the remoteusername = 'test01' and another row in the auth_remote_user table where remoteusername = 'Test01' then things break. We get ERROR: more than one row returned by a subquery used as an expression We need to: 1) adjust the places where we save data to "auth_remote_user" table, eg create_user() / LTI login etc so that we only save it as lowercase 2) Make sure all the places we query on it is done by matching lowercase values 3) Adjust the primary key on the auth_remote_user table so that we check the remoteusername as lowercase eg change to "authremouser_autrem_pk" PRIMARY KEY, btree (authinstance, lower(remoteusername::text)) So that if (1, 'test01') exists then (1, 'Test01') is trying to be added it should be rejected at db level as being a duplicate To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1938740/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2009760] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13861 Committed: https://git.mahara.org/mahara/mahara/commit/35e7926fe0f55ae435742de6e6836f5fcac1ac33 Submitter: "Doris Tam " Branch:main commit 35e7926fe0f55ae435742de6e6836f5fcac1ac33 Author: Robert Lyon Date: Thu Mar 9 12:22:52 2023 +1300 Bug 2009760: Fixing issue with ORDER BY in multirecipient code Signed-off-by: Robert Lyon Change-Id: I3bbde780780887ca76a579a5c1e31f91661f27fc -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2009760 Title: Issue with deleting multirecipient notifications in MySQL Status in Mahara: Fix Committed Bug description: When deleting a person one of the cleanup things that happens is any multi-recipient notifications for the person are delete also. But when using MySQL it could cause an issue (segmentation fault) when deleting then via the admin/cli/delete_inactive_users.php CLI script. The cause of this was the SQL for creating one of the queries was wrong. The query ordering syntax was ' ORDER BY ? ' but we can't pass in the value that way because ADODB will wrap it in quotations and cause things to fail. We need to have the query be like this ' ORDER BY ' . $sortby so that ADODB doesn't try to quote it. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2009760/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2012988] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13874 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2012988 Title: Small fix for a typo on lang/en.utf8/mahara.php. Status in Mahara: New Bug description: I think it's better to fix a typo (capitalisation and lowercase) on lang/en.utf8/mahara.php as below. Langfile: lang/en.utf8/mahara.php String: releasedinfofor [Before] RElease options for "%s" [After] Release options for "%s" To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2012988/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007897] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13864 Committed: https://git.mahara.org/mahara/mahara/commit/6960ea0d83dc54550e6f7592406fd5d1a5601c9c Submitter: "Doris Tam " Branch:main commit 6960ea0d83dc54550e6f7592406fd5d1a5601c9c Author: Robert Lyon Date: Tue Mar 21 10:10:11 2023 +1300 Bug 2007897: Use different icons for the sumbission states When viewing the portfolios on the index page Signed-off-by: Robert Lyon Change-Id: I8c0a9d4ac25dfabca22e163fbe9e865252ad5065 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007897 Title: Different icons on 'Portfolios' overview page when portfolio is submitted Status in Mahara: Fix Committed Bug description: In bug #1996475 we are changing the submission workflow so that copies of portfolios are submitted. Currently, the only differentiator between submitted portfolios and those that are ready to be turned into regular portfolios is colour: muted yellow (fully submitted) and muted green (not submitted any more, but still marked as submission so it doesn't clutter the regular portfolios screen). We should have another visual indicator for those that can't perceive colour. The idea is to use different icons in place of the 'More options' icon instead of having an information icon that is not clickable. That means, to tie in with the three different states that we have: 1. Regular portfolio: 'More options' icon of the ellipses 2. Submitted portfolio: Instead of the ellipses have icon check-to-slot that we already use for 'Submissions' in the admin area https://fontawesome.com/icons/check-to-slot?s=solid=classic ; tooltip / screenreader text: 'Submission information for "Title of the portfolio"' 3. Released portfolio but still flagged as submission: Instead of the ellipses have icon square-check https://fontawesome.com/icons/square-check?s=regular=classic ; tooltip / screenreader text: 'Portfolio "Title of the portfolio" released' Once we have the icons, check with Evonne if we should / could colorise them to match the muted colour states, but we'd need to check the contrast. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007897/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2003378] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13873 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2003378 Title: PHP 8 Compatibility: phpcs Status in Mahara: In Progress Bug description: We're getting close to finishing this. We are currently working through the output of PHP CodeSniffer. This bug is a catchall bug to cover this work. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2003378/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2012419] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13867
Committed:
https://git.mahara.org/mahara/mahara/commit/6112219aadb32ceb6cba270dd0bcdec414af414c
Submitter: "Robert Lyon "
Branch:22.10_DEV
commit 6112219aadb32ceb6cba270dd0bcdec414af414c
Author: Laurent David
Date: Tue Mar 21 18:50:14 2023 +0100
Bug 2012419: Error releasing submissions
Fix an issue with the $group parameter when calling group_external_group
with an integer identifier
Change-Id: I5acd1c1bcfb94f03947903acf88b2b97e40380f5
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/2012419
Title:
Error releasing submissions
Status in Mahara:
Fix Committed
Status in Mahara 22.10 series:
Fix Committed
Status in Mahara 23.04 series:
Fix Committed
Bug description:
To reproduce the issue, setup a new Mahara install (22.10.0 STABLE, Mysql).
* Create 2 users Student and Teacher
* Create an institution
* Add the two users in the institution
* Add a new group (Group 1) - With the 3 roles (Tutor, Member, Admin)
* Add Student as Member of Group 1 and Teacher as Tutor in Group 1
* As Student create a page and submit it for review in Group 1
* As Teacher release the Page
From this point an error will be displayed and the page will never be
released and will be marked as "Pending release after archiving."
The Error displayed is:
Failed to get a recordset: mysqli error: [1064: You have an error in
your SQL syntax; check the manual that corresponds to your MySQL
server version for the right syntax to use near '? LIMIT 1' at line
1] in EXECUTE("SELECT * FROM "lti_assessment" WHERE "group" = ?
LIMIT 1")Command was: SELECT * FROM "lti_assessment" WHERE "group" =
?
...
When examining the issue with a debugger it seems that
group_external_group($group) is called with an integer instead of a
string, so it means that record_exists('lti_assessment', 'group',
$group->id) is called with the wrong value (as $group->id does not
exist).
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/2012419/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2003378] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13872 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2003378 Title: PHP 8 Compatibility: phpcs Status in Mahara: In Progress Bug description: We're getting close to finishing this. We are currently working through the output of PHP CodeSniffer. This bug is a catchall bug to cover this work. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2003378/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2003378] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13871 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2003378 Title: PHP 8 Compatibility: phpcs Status in Mahara: In Progress Bug description: We're getting close to finishing this. We are currently working through the output of PHP CodeSniffer. This bug is a catchall bug to cover this work. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2003378/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2003378] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13870 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2003378 Title: PHP 8 Compatibility: phpcs Status in Mahara: In Progress Bug description: We're getting close to finishing this. We are currently working through the output of PHP CodeSniffer. This bug is a catchall bug to cover this work. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2003378/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2012419] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13868
Committed:
https://git.mahara.org/mahara/mahara/commit/94c6d0cbd526a505f6e9c631060cbc87eb973447
Submitter: "Robert Lyon "
Branch:main
commit 94c6d0cbd526a505f6e9c631060cbc87eb973447
Author: Laurent David
Date: Tue Mar 21 18:50:14 2023 +0100
Bug 2012419: Error releasing submissions
Fix an issue with the $group parameter when calling group_external_group
with an integer identifier
Change-Id: I5acd1c1bcfb94f03947903acf88b2b97e40380f5
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/2012419
Title:
Error releasing submissions
Status in Mahara:
Confirmed
Status in Mahara 22.10 series:
In Progress
Status in Mahara 23.04 series:
Confirmed
Bug description:
To reproduce the issue, setup a new Mahara install (22.10.0 STABLE, Mysql).
* Create 2 users Student and Teacher
* Create an institution
* Add the two users in the institution
* Add a new group (Group 1) - With the 3 roles (Tutor, Member, Admin)
* Add Student as Member of Group 1 and Teacher as Tutor in Group 1
* As Student create a page and submit it for review in Group 1
* As Teacher release the Page
From this point an error will be displayed and the page will never be
released and will be marked as "Pending release after archiving."
The Error displayed is:
Failed to get a recordset: mysqli error: [1064: You have an error in
your SQL syntax; check the manual that corresponds to your MySQL
server version for the right syntax to use near '? LIMIT 1' at line
1] in EXECUTE("SELECT * FROM "lti_assessment" WHERE "group" = ?
LIMIT 1")Command was: SELECT * FROM "lti_assessment" WHERE "group" =
?
...
When examining the issue with a debugger it seems that
group_external_group($group) is called with an integer instead of a
string, so it means that record_exists('lti_assessment', 'group',
$group->id) is called with the wrong value (as $group->id does not
exist).
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/2012419/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2003378] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13869 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2003378 Title: PHP 8 Compatibility: phpcs Status in Mahara: In Progress Bug description: We're getting close to finishing this. We are currently working through the output of PHP CodeSniffer. This bug is a catchall bug to cover this work. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2003378/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2012419] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13868
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/2012419
Title:
Error releasing submissions - Mahara 22.10.0
Status in Mahara:
New
Bug description:
To reproduce the issue, setup a new Mahara install (22.10.0 STABLE, Mysql).
* Create 2 users Student and Teacher
* Create an institution
* Add the two users in the institution
* Add a new group (Group 1) - With the 3 roles (Tutor, Member, Admin)
* Add Student as Member of Group 1 and Teacher as Tutor in Group 1
* As Student create a page and submit it for review in Group 1
* As Teacher release the Page
From this point an error will be displayed and the page will never be
released and will be marked as "Pending release after archiving."
The Error displayed is:
Failed to get a recordset: mysqli error: [1064: You have an error in
your SQL syntax; check the manual that corresponds to your MySQL
server version for the right syntax to use near '? LIMIT 1' at line
1] in EXECUTE("SELECT * FROM "lti_assessment" WHERE "group" = ?
LIMIT 1")Command was: SELECT * FROM "lti_assessment" WHERE "group" =
?
...
When examining the issue with a debugger it seems that
group_external_group($group) is called with an integer instead of a
string, so it means that record_exists('lti_assessment', 'group',
$group->id) is called with the wrong value (as $group->id does not
exist).
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/2012419/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1973249] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13865 Committed: https://git.mahara.org/mahara/mahara/commit/d43caef8727a540cf533532ad99f7250b222c10c Submitter: "Robert Lyon " Branch:22.10_DEV commit d43caef8727a540cf533532ad99f7250b222c10c Author: Robert Lyon Date: Mon May 16 11:51:39 2022 +1200 Bug 1973249: Show error if archiving failed - Shows need to retrigger archiving for fail on the page if admin/institution admin - Shows need to retrigger archiving for fail on the Admin current submissions list (at admin/groups/archives.php?current=1) - Also now shows a message on page for the owner when they have submitted the page Change-Id: I2d79f17eefadb4cb6fed602858bc4dcc547411c8 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1973249 Title: Releasing submissions: error message on failure Status in Mahara: Fix Committed Status in Mahara 22.04 series: Fix Committed Status in Mahara 22.10 series: Fix Committed Status in Mahara 23.04 series: Fix Committed Bug description: Linux/Ubuntu/Postgres When releasing a submission, if it fails, it's not evident that it needs to be re-queued in order for the cron to try releasing it again. We need an error message that tells people to go to the Admin > People > Export queue page, where you can requeue the submission. Or at least a message that says requeue. Currently, you can replicate a failed submission release by enabling the experimental PDF Export Plugin, as this causes an error when releasing a submission. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1973249/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1973249] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13866 Committed: https://git.mahara.org/mahara/mahara/commit/76c077a0ab5776007c9746c23147bb1d61fce576 Submitter: "Robert Lyon " Branch:22.04_DEV commit 76c077a0ab5776007c9746c23147bb1d61fce576 Author: Robert Lyon Date: Mon May 16 11:51:39 2022 +1200 Bug 1973249: Show error if archiving failed - Shows need to retrigger archiving for fail on the page if admin/institution admin - Shows need to retrigger archiving for fail on the Admin current submissions list (at admin/groups/archives.php?current=1) - Also now shows a message on page for the owner when they have submitted the page Change-Id: I2d79f17eefadb4cb6fed602858bc4dcc547411c8 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1973249 Title: Releasing submissions: error message on failure Status in Mahara: Fix Committed Status in Mahara 22.04 series: Fix Committed Status in Mahara 22.10 series: In Progress Status in Mahara 23.04 series: Fix Committed Bug description: Linux/Ubuntu/Postgres When releasing a submission, if it fails, it's not evident that it needs to be re-queued in order for the cron to try releasing it again. We need an error message that tells people to go to the Admin > People > Export queue page, where you can requeue the submission. Or at least a message that says requeue. Currently, you can replicate a failed submission release by enabling the experimental PDF Export Plugin, as this causes an error when releasing a submission. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1973249/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2012419] A patch has been submitted for review
Patch for "22.10_DEV" branch:
https://reviews.mahara.org/c/mahara/+/13867
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/2012419
Title:
Error releasing submissions - Mahara 22.10.0
Status in Mahara:
New
Bug description:
To reproduce the issue, setup a new Mahara install (22.10.0 STABLE, Mysql).
* Create 2 users Student and Teacher
* Create an institution
* Add the two users in the institution
* Add a new group (Group 1) - With the 3 roles (Tutor, Member, Admin)
* Add Student as Member of Group 1 and Teacher as Tutor in Group 1
* As Student create a page and submit it for review in Group 1
* As Teacher release the Page
From this point an error will be displayed and the page will never be
released and will be marked as "Pending release after archiving."
The Error displayed is:
Failed to get a recordset: mysqli error: [1064: You have an error in
your SQL syntax; check the manual that corresponds to your MySQL
server version for the right syntax to use near '? LIMIT 1' at line
1] in EXECUTE("SELECT * FROM "lti_assessment" WHERE "group" = ?
LIMIT 1")Command was: SELECT * FROM "lti_assessment" WHERE "group" =
?
...
When examining the issue with a debugger it seems that
group_external_group($group) is called with an integer instead of a
string, so it means that record_exists('lti_assessment', 'group',
$group->id) is called with the wrong value (as $group->id does not
exist).
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/2012419/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1973249] A patch has been submitted for review
Patch for "22.04_DEV" branch: https://reviews.mahara.org/c/mahara/+/13866 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1973249 Title: Releasing submissions: error message on failure Status in Mahara: Fix Committed Status in Mahara 22.04 series: In Progress Status in Mahara 22.10 series: In Progress Status in Mahara 23.04 series: Fix Committed Bug description: Linux/Ubuntu/Postgres When releasing a submission, if it fails, it's not evident that it needs to be re-queued in order for the cron to try releasing it again. We need an error message that tells people to go to the Admin > People > Export queue page, where you can requeue the submission. Or at least a message that says requeue. Currently, you can replicate a failed submission release by enabling the experimental PDF Export Plugin, as this causes an error when releasing a submission. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1973249/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1973249] A patch has been submitted for review
Patch for "22.10_DEV" branch: https://reviews.mahara.org/c/mahara/+/13865 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1973249 Title: Releasing submissions: error message on failure Status in Mahara: Fix Committed Status in Mahara 22.04 series: In Progress Status in Mahara 22.10 series: In Progress Status in Mahara 23.04 series: Fix Committed Bug description: Linux/Ubuntu/Postgres When releasing a submission, if it fails, it's not evident that it needs to be re-queued in order for the cron to try releasing it again. We need an error message that tells people to go to the Admin > People > Export queue page, where you can requeue the submission. Or at least a message that says requeue. Currently, you can replicate a failed submission release by enabling the experimental PDF Export Plugin, as this causes an error when releasing a submission. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1973249/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1973249] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/12783 Committed: https://git.mahara.org/mahara/mahara/commit/9f46df6be02f986f1fbf7f7ca236752ae4c1bd63 Submitter: "Robert Lyon " Branch:main commit 9f46df6be02f986f1fbf7f7ca236752ae4c1bd63 Author: Robert Lyon Date: Mon May 16 11:51:39 2022 +1200 Bug 1973249: Show error if archiving failed - Shows need to retrigger archiving for fail on the page if admin/institution admin - Shows need to retrigger archiving for fail on the Admin current submissions list (at admin/groups/archives.php?current=1) - Also now shows a message on page for the owner when they have submitted the page Change-Id: I2d79f17eefadb4cb6fed602858bc4dcc547411c8 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1973249 Title: Releasing submissions: error message on failure Status in Mahara: Fix Committed Status in Mahara 22.04 series: Confirmed Status in Mahara 22.10 series: Confirmed Status in Mahara 23.04 series: Fix Committed Bug description: Linux/Ubuntu/Postgres When releasing a submission, if it fails, it's not evident that it needs to be re-queued in order for the cron to try releasing it again. We need an error message that tells people to go to the Admin > People > Export queue page, where you can requeue the submission. Or at least a message that says requeue. Currently, you can replicate a failed submission release by enabling the experimental PDF Export Plugin, as this causes an error when releasing a submission. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1973249/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007897] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13864 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007897 Title: Different icons on 'Portfolios' overview page when portfolio is submitted Status in Mahara: Confirmed Bug description: In bug #1996475 we are changing the submission workflow so that copies of portfolios are submitted. Currently, the only differentiator between submitted portfolios and those that are ready to be turned into regular portfolios is colour: muted yellow (fully submitted) and muted green (not submitted any more, but still marked as submission so it doesn't clutter the regular portfolios screen). We should have another visual indicator for those that can't perceive colour. The idea is to use different icons in place of the 'More options' icon instead of having an information icon that is not clickable. That means, to tie in with the three different states that we have: 1. Regular portfolio: 'More options' icon of the ellipses 2. Submitted portfolio: Instead of the ellipses have icon check-to-slot that we already use for 'Submissions' in the admin area https://fontawesome.com/icons/check-to-slot?s=solid=classic ; tooltip / screenreader text: 'Submission information for "Title of the portfolio"' 3. Released portfolio but still flagged as submission: Instead of the ellipses have icon square-check https://fontawesome.com/icons/square-check?s=regular=classic ; tooltip / screenreader text: 'Portfolio "Title of the portfolio" released' Once we have the icons, check with Evonne if we should / could colorise them to match the muted colour states, but we'd need to check the contrast. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007897/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2011530] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13863 Committed: https://git.mahara.org/mahara/mahara/commit/58e650276ffc5c439155d411e3f0a839b2a316c8 Submitter: "Robert Lyon " Branch:main commit 58e650276ffc5c439155d411e3f0a839b2a316c8 Author: Mitsuhiro Yoshida Date: Tue Mar 14 17:18:21 2023 +0900 Bug #2011530: Adding license and copyright notices at the top of the "Show submitted portfolios" help file. Change-Id: I51cbc9ffd9820bc84086000a8da0685b205d127c -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2011530 Title: Adding license and copyright notices at the top of the "Show submitted portfolios" help file, Status in Mahara: Fix Committed Bug description: I think we need to add a license and copyright notice message to the top of the "Show submitted portfolios" help file as below. Help file to modify: lang/en.utf8/help/forms/searchviews.showsubmissions.html Line: 1 [ Before ] Show submitted portfolios When you select this option, portfolios that you submitted for assessment are displayed. This includes portfolios that are currently under review that you can't edit and portfolios that have been released recently. You can turn the latter into regular portfolios in the page or collection settings so you can edit them and continue working on them instead of the original portfolio. [ After ] Show submitted portfolios When you select this option, portfolios that you submitted for assessment are displayed. This includes portfolios that are currently under review that you can't edit and portfolios that have been released recently. You can turn the latter into regular portfolios in the page or collection settings so you can edit them and continue working on them instead of the original portfolio. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2011530/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2011530] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13863 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2011530 Title: Adding license and copyright notices at the top of the "Show submitted portfolios" help file, Status in Mahara: New Bug description: I think we need to add a license and copyright notice message to the top of the "Show submitted portfolios" help file as below. Help file to modify: lang/en.utf8/help/forms/searchviews.showsubmissions.html Line: 1 [ Before ] Show submitted portfolios When you select this option, portfolios that you submitted for assessment are displayed. This includes portfolios that are currently under review that you can't edit and portfolios that have been released recently. You can turn the latter into regular portfolios in the page or collection settings so you can edit them and continue working on them instead of the original portfolio. [ After ] Show submitted portfolios When you select this option, portfolios that you submitted for assessment are displayed. This includes portfolios that are currently under review that you can't edit and portfolios that have been released recently. You can turn the latter into regular portfolios in the page or collection settings so you can edit them and continue working on them instead of the original portfolio. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2011530/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1996475] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13583 Committed: https://git.mahara.org/mahara/mahara/commit/31027700c4f101b33f411f0d83b8ff93000129bc Submitter: "Robert Lyon " Branch:main commit 31027700c4f101b33f411f0d83b8ff93000129bc Author: Evonne Date: Wed Dec 21 12:51:40 2022 +1300 Bug 1996475 theming the submitted and released states behatnotneeded Change-Id: I2d613231b3492cf1508aea9fcc46f5ff517a -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1996475 Title: Allow submissions to create a duplicate page/collection and submit that leaving the original still editable Status in Mahara: In Progress Bug description: ## High level functionality summary When a student submits a portfolio for assessment, a **copy** is made in their Mahara account, which is submitted rather than the original portfolio. That copy is available through Mahara. If the student accidentally deletes the submission link from an external LTI submission, e.g. Brightspace assignment, before they submit the assignment, they can return to the Brightspace 'Quicklink 'option and select their portfolio again for submission and a new copy is made. The previous copy is still available in Mahara, but not shown to the student in the 'Quicklink' option. All changes are made on the Mahara side to which parts LTI will 'call' and how we deal with submissions to ensure that no changes are needed on the LMS that wouldn't be LTI calls. ## Workflow 1. The student selects portfolio via the Brightspace 'Quicklink' menu. 2. The student confirms that they want to submit the portfolio. The submission confirmation screen message changes from 'If you submit "Title of the portfolio" for assessment, you will not be able to edit its content until marking has finished. Are you sure you want to submit this portfolio now?' to 'If you submit “Title of the portfolio” for assessment, a copy of that portfolio will be made and submitted. Do not remove the link that is inserted into the 'Text Submission' box. If you do, select your portfolio again via the 'Quicklink' and submit it again. You can continue working on the portfolio itself, but changes you make to it will not be reflected in your submitted portfolio.' 3. Student must click the 'Confirm' button to continue or the 'Cancel' button to select another portfolio. The following assumes that the student confirmed the submission. 4. A copy of the portfolio that is being submitted is made without adding a 'Copy of' at the start of the portfolio or a version number at the end to any page or collection title. Instead, the portfolio title (either title of the collection if the portfolio is a collection or title of the page if the portfolio is a single page; pages within a collection do not change their page title) is appended with '; submitted at DDMMYY, HH:MM', e.g. 'Assessment portfolio; submitted at 09/09/2022, 11:59'. The short date version is used so as not to make the title longer than necessary. A suffix is chosen so if portfolios are all listed in one area, all related portfolios are grouped together alphabetically. 5. A link to the original portfolio is added to the collection and page settings to find the original more easily later on. This is similar to the link added when a template is copied. The same logic will apply, i.e. if the original still exists, it is linked, if it was deleted, no link will be provided. 6. The submission copy is flagged as 'Submission' so it can be filtered from the list of portfolios a student sees on their 'Pages and collections' overview page and also wherever portfolios are selected for submission so they are not displayed when viewing portfolios available for submission. 7. On the 'Pages and collections' overview page an option is added to include submitted portfolios in the display. Per default, they are excluded. 8. Submitted copies behave like submitted portfolios right now: They are marked in yellow on the 'Pages and collections' overview page and an icon added to the left of the 'More options' menu to indicate that it's a submission. The submission time is mentioned in the 'More options' menu. The portfolio cannot be deleted and artefacts are locked. Page comments are added to this copy and stay with it. They are not added to the original portfolio. Artefact comments are visible on other pages when the artefact is added there. 9. When the instructor finished grading and the portfolio is unlocked, it is still flagged as 'Submission' but is not marked in yellow any more and the student can remove the 'Submission' flag from the page settings or collection settings if they want to 'promote' this portfolio to a regular portfolio so they can continue working on it and maybe even re-submit that copy if the original already
[Mahara-contributors] [Bug 1996475] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13463 Committed: https://git.mahara.org/mahara/mahara/commit/82c931b8de1a7cdc59b6aefee425238d86b0b0d6 Submitter: "Robert Lyon " Branch:main commit 82c931b8de1a7cdc59b6aefee425238d86b0b0d6 Author: Gold Date: Fri Nov 11 14:38:13 2022 +1300 Bug 1996475: Submit a copy of a Portfolio Done: Copy creation for View and Collection Identification as a submission in View Index Link back to source Portfolio Link back to source if available on the Collection edit settings. Link back to source if available on the View edit settings. Link back to source if available on the view/index.php Portfolios summary page. Title is modified for submissions. Portfolio comments are copied. Submissions that have been released are still hidden as submissions A submission can be "Promoted" to being a normal portfolio Smart Evidence is copied Annotations are copied Feedback on Annotations are copied Assessments on Annotations are copied Progress Completion is copied Sign-off toggle and status are copied This is working when submitting to Groups. This is working when submitting to LTI Advantage. This is in testing for submitting to LTI 1.1. Signed-off-by: Gold Change-Id: I3d07bab6bd81e86f1cb9e1193af00820a65455db -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1996475 Title: Allow submissions to create a duplicate page/collection and submit that leaving the original still editable Status in Mahara: In Progress Bug description: ## High level functionality summary When a student submits a portfolio for assessment, a **copy** is made in their Mahara account, which is submitted rather than the original portfolio. That copy is available through Mahara. If the student accidentally deletes the submission link from an external LTI submission, e.g. Brightspace assignment, before they submit the assignment, they can return to the Brightspace 'Quicklink 'option and select their portfolio again for submission and a new copy is made. The previous copy is still available in Mahara, but not shown to the student in the 'Quicklink' option. All changes are made on the Mahara side to which parts LTI will 'call' and how we deal with submissions to ensure that no changes are needed on the LMS that wouldn't be LTI calls. ## Workflow 1. The student selects portfolio via the Brightspace 'Quicklink' menu. 2. The student confirms that they want to submit the portfolio. The submission confirmation screen message changes from 'If you submit "Title of the portfolio" for assessment, you will not be able to edit its content until marking has finished. Are you sure you want to submit this portfolio now?' to 'If you submit “Title of the portfolio” for assessment, a copy of that portfolio will be made and submitted. Do not remove the link that is inserted into the 'Text Submission' box. If you do, select your portfolio again via the 'Quicklink' and submit it again. You can continue working on the portfolio itself, but changes you make to it will not be reflected in your submitted portfolio.' 3. Student must click the 'Confirm' button to continue or the 'Cancel' button to select another portfolio. The following assumes that the student confirmed the submission. 4. A copy of the portfolio that is being submitted is made without adding a 'Copy of' at the start of the portfolio or a version number at the end to any page or collection title. Instead, the portfolio title (either title of the collection if the portfolio is a collection or title of the page if the portfolio is a single page; pages within a collection do not change their page title) is appended with '; submitted at DDMMYY, HH:MM', e.g. 'Assessment portfolio; submitted at 09/09/2022, 11:59'. The short date version is used so as not to make the title longer than necessary. A suffix is chosen so if portfolios are all listed in one area, all related portfolios are grouped together alphabetically. 5. A link to the original portfolio is added to the collection and page settings to find the original more easily later on. This is similar to the link added when a template is copied. The same logic will apply, i.e. if the original still exists, it is linked, if it was deleted, no link will be provided. 6. The submission copy is flagged as 'Submission' so it can be filtered from the list of portfolios a student sees on their 'Pages and collections' overview page and also wherever portfolios are selected for submission so they are not displayed when viewing portfolios available for submission. 7. On the 'Pages and collections' overview page an option is added to include submitted portfolios in the display. Per default, they are excluded. 8. Submitted copies behave like submitted portfolios right now: They are marked in yellow on
[Mahara-contributors] [Bug 2008972] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13837 Committed: https://git.mahara.org/mahara/mahara/commit/8e0a7b9bd5bebc3640fc059b028c88694370a182 Submitter: "Robert Lyon " Branch:main commit 8e0a7b9bd5bebc3640fc059b028c88694370a182 Author: Robert Lyon Date: Thu Mar 2 16:46:15 2023 +1300 Bug 2008972: Better error when artefact is missing from dataroot Currently gives confusing access denied to page message When really it should say an artefact not found message Signed-off-by: Robert Lyon Change-Id: Ib5913f3abf548914da1a460ed4b3313695af72cd -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2008972 Title: Confusing error message when an artefact file is missing from dataroot Status in Mahara: Fix Committed Bug description: Currently gives an error: Access denied You do not have access to view this page. But really the issue is the file is missing so we should give an error message conveying that. To test: 1) Upload an image file for a person in the files area and copy the URL link from the 'Name' column 2) Open this URL in a new window/tab - see the file get downloaded 3) Delete the file from the dataroot and reload the window See the error message To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2008972/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2003988] Re: glob-parent vulnerability
Reviewed: https://reviews.mahara.org/c/mahara/+/13662 Committed: https://git.mahara.org/mahara/mahara/commit/7b2a5f509f510dd13177edc78af7f3f0784bf6dd Submitter: "Robert Lyon " Branch:main commit 7b2a5f509f510dd13177edc78af7f3f0784bf6dd Author: Doris Tam Date: Wed Jan 25 15:09:41 2023 +1300 Bug 2003988: Compatible JS library updates and security for glob-parent for themes glob-parent before 5.1.2 vulnerable to Regular Expression Denial of Service in enclosure regex - https://github.com/advisories/GHSA-ww39-953v-wcq6 - https://nvd.nist.gov/vuln/detail/CVE-2020-28469 - https://cwe.mitre.org/data/definitions/400.html Yet to be fixed: gulp However, our CSS gets compiled from hard-coded SASS files before webpages get loaded. Change-Id: If36e9f5df6b749574bc63154eff818ec707c1dec ** CVE added: https://cve.mitre.org/cgi-bin/cvename.cgi?name=2020-28469 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2003988 Title: glob-parent vulnerability Status in Mahara: Fix Committed Bug description: glob-parent before 5.1.2 vulnerable to Regular Expression Denial of Service in enclosure regex - https://github.com/advisories/GHSA-ww39-953v-wcq6 - https://nvd.nist.gov/vuln/detail/CVE-2020-28469 - https://cwe.mitre.org/data/definitions/400.html In our third-party libraries, we are waiting for gulp to update their dependencies. However, it's been 3 years since their last update. Unsure if they will. Yet to be fixed: gulp - but not hopeful currently https://twitter.com/gulpjs/status/1564430489473077248?cxt=HHwWgMCqjbrP_LUr However, our CSS gets compiled from hardcoded sass files before webpages get loaded. mahara-themes@1.0.2 /.../.../code/mahara ├─┬ gulp@4.0.2 │ ├─┬ glob-watcher@5.0.5 │ │ └─┬ chokidar@2.1.8 │ │ └── glob-parent@3.1.0 │ └─┬ vinyl-fs@3.0.3 │ └─┬ glob-stream@6.1.0 │ └── glob-parent@3.1.0 deduped └─┬ sass@1.57.1 └─┬ chokidar@3.5.3 └── glob-parent@5.1.2 ✅ To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2003988/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007457] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13831 Committed: https://git.mahara.org/mahara/mahara/commit/3e3a9392a72c26f675d9b04316ab925a18750c13 Submitter: "Robert Lyon " Branch:main commit 3e3a9392a72c26f675d9b04316ab925a18750c13 Author: Doris Tam Date: Mon Feb 27 12:27:38 2023 +1300 Bug 2007457: Update themeing JS libraries - npm no longer supported 14->16 LTS - gulp-autoprefixer - yargs - sass Change-Id: Iaa51b08efc6cd5533b79b410799bcbcc2a88315d -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007457 Title: Third party library updates for 23.04 Status in Mahara: In Progress Bug description: Third-party investigation and updates. To be discussed which ones will get into the next release. Things to note: No security issues. We are 3 major versions behind in Gridstack, Patches available (break-free changes) for: Gridstack, ClipboardJS, CSSTidy, TinyMCE Minor updates available (should not have breaking changes) for: Gridstack, ChartJS, ElasticSearch, MomentJS, PDFJS, VideoJS, Bootstrap, Dragondrop, Datatables, Dropzone, HTMLPurifier, jQuery, JSColor, JSON Editor, MarkedJS, PHPMailer, Popper, SSPHP, FontAwesome Major (will have breaking changes) upgrades requiring migration available for: DateTimePicker, VideoJS, PDFJS, MomentJS, Elasticsearch, ChartJS, and Gridstack To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007457/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2008034] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13785 Committed: https://git.mahara.org/mahara/mahara/commit/e9b6e126f6b5a1a1d40e96fcb43f6dd57a30e2ff Submitter: "Robert Lyon " Branch:main commit e9b6e126f6b5a1a1d40e96fcb43f6dd57a30e2ff Author: Robert Lyon Date: Fri Feb 17 12:17:16 2023 +1300 Bug 2008034: Password toggle eye on certain password fields The patch adds a eye icon toggle to password fields that have 'toggledisplay' pieform element option: - Add an account - Edit account details as administrator - Personal account preferences - Forgot password screen Change-Id: I5919c89ef28a2f7bf66ed7ec2604a20214d1e8f4 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2008034 Title: Allow certian password fields to be toggled to display plain text Status in Mahara: Fix Committed Bug description: We don't want this for all fields but just certain fields where we'd want to copy/paste the password text, for example the forgot password form or the reset password field in admin section To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2008034/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007457] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13798 Committed: https://git.mahara.org/mahara/mahara/commit/69e347d008a1821e3e1555a11a6733bc18243c65 Submitter: "Robert Lyon " Branch:main commit 69e347d008a1821e3e1555a11a6733bc18243c65 Author: Doris Tam Date: Wed Feb 22 11:18:37 2023 +1300 Bug 2007457: Update TinyMCE to 5.10.7 Change-Id: Iead9e190154ec4cc26862ddb40319bd723a1a9c9 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007457 Title: Third party library updates for 23.04 Status in Mahara: In Progress Bug description: Third-party investigation and updates. To be discussed which ones will get into the next release. Things to note: No security issues. We are 3 major versions behind in Gridstack, Patches available (break-free changes) for: Gridstack, ClipboardJS, CSSTidy, TinyMCE Minor updates available (should not have breaking changes) for: Gridstack, ChartJS, ElasticSearch, MomentJS, PDFJS, VideoJS, Bootstrap, Dragondrop, Datatables, Dropzone, HTMLPurifier, jQuery, JSColor, JSON Editor, MarkedJS, PHPMailer, Popper, SSPHP, FontAwesome Major (will have breaking changes) upgrades requiring migration available for: DateTimePicker, VideoJS, PDFJS, MomentJS, Elasticsearch, ChartJS, and Gridstack To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007457/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007457] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13789 Committed: https://git.mahara.org/mahara/mahara/commit/3a0d107e0b9596233fbef19f67607b7ab6f341d0 Submitter: "Robert Lyon " Branch:main commit 3a0d107e0b9596233fbef19f67607b7ab6f341d0 Author: Doris Tam Date: Mon Feb 20 13:46:42 2023 +1300 Bug 2007457: Update jQuery from 3.6.0 to 3.6.3 Change-Id: I2742ed693bff42eaf30b07f2c79ad6c19ae10af7 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007457 Title: Third party library updates for 23.04 Status in Mahara: In Progress Bug description: Third-party investigation and updates. To be discussed which ones will get into the next release. Things to note: No security issues. We are 3 major versions behind in Gridstack, Patches available (break-free changes) for: Gridstack, ClipboardJS, CSSTidy, TinyMCE Minor updates available (should not have breaking changes) for: Gridstack, ChartJS, ElasticSearch, MomentJS, PDFJS, VideoJS, Bootstrap, Dragondrop, Datatables, Dropzone, HTMLPurifier, jQuery, JSColor, JSON Editor, MarkedJS, PHPMailer, Popper, SSPHP, FontAwesome Major (will have breaking changes) upgrades requiring migration available for: DateTimePicker, VideoJS, PDFJS, MomentJS, Elasticsearch, ChartJS, and Gridstack To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007457/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007457] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13840 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007457 Title: Third party library updates for 23.04 Status in Mahara: In Progress Bug description: Third-party investigation and updates. To be discussed which ones will get into the next release. Things to note: No security issues. We are 3 major versions behind in Gridstack, Patches available (break-free changes) for: Gridstack, ClipboardJS, CSSTidy, TinyMCE Minor updates available (should not have breaking changes) for: Gridstack, ChartJS, ElasticSearch, MomentJS, PDFJS, VideoJS, Bootstrap, Dragondrop, Datatables, Dropzone, HTMLPurifier, jQuery, JSColor, JSON Editor, MarkedJS, PHPMailer, Popper, SSPHP, FontAwesome Major (will have breaking changes) upgrades requiring migration available for: DateTimePicker, VideoJS, PDFJS, MomentJS, Elasticsearch, ChartJS, and Gridstack To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007457/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007457] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13839 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007457 Title: Third party library updates for 23.04 Status in Mahara: In Progress Bug description: Third-party investigation and updates. To be discussed which ones will get into the next release. Things to note: No security issues. We are 3 major versions behind in Gridstack, Patches available (break-free changes) for: Gridstack, ClipboardJS, CSSTidy, TinyMCE Minor updates available (should not have breaking changes) for: Gridstack, ChartJS, ElasticSearch, MomentJS, PDFJS, VideoJS, Bootstrap, Dragondrop, Datatables, Dropzone, HTMLPurifier, jQuery, JSColor, JSON Editor, MarkedJS, PHPMailer, Popper, SSPHP, FontAwesome Major (will have breaking changes) upgrades requiring migration available for: DateTimePicker, VideoJS, PDFJS, MomentJS, Elasticsearch, ChartJS, and Gridstack To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007457/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007457] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13820 Committed: https://git.mahara.org/mahara/mahara/commit/70ea8170978c137b8975b5beb92cc952536f022d Submitter: "Robert Lyon " Branch:main commit 70ea8170978c137b8975b5beb92cc952536f022d Author: Doris Tam Date: Wed Feb 22 12:23:13 2023 +1300 Bug 2007457: VideoJS customisations Added a .patch to apply next time Change-Id: I39606662018dbeb731033441befce7fe63b12f46 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007457 Title: Third party library updates for 23.04 Status in Mahara: In Progress Bug description: Third-party investigation and updates. To be discussed which ones will get into the next release. Things to note: No security issues. We are 3 major versions behind in Gridstack, Patches available (break-free changes) for: Gridstack, ClipboardJS, CSSTidy, TinyMCE Minor updates available (should not have breaking changes) for: Gridstack, ChartJS, ElasticSearch, MomentJS, PDFJS, VideoJS, Bootstrap, Dragondrop, Datatables, Dropzone, HTMLPurifier, jQuery, JSColor, JSON Editor, MarkedJS, PHPMailer, Popper, SSPHP, FontAwesome Major (will have breaking changes) upgrades requiring migration available for: DateTimePicker, VideoJS, PDFJS, MomentJS, Elasticsearch, ChartJS, and Gridstack To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007457/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007457] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13799 Committed: https://git.mahara.org/mahara/mahara/commit/a67f711c0bb163cffaa4bcf2541c704ae1f587c5 Submitter: "Robert Lyon " Branch:main commit a67f711c0bb163cffaa4bcf2541c704ae1f587c5 Author: Doris Tam Date: Wed Feb 22 11:57:25 2023 +1300 Bug 2007457: Update VideoJS to 7.21.1 Change-Id: Ic36da7db50ec480b399fdcc240319331199cb0ed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007457 Title: Third party library updates for 23.04 Status in Mahara: In Progress Bug description: Third-party investigation and updates. To be discussed which ones will get into the next release. Things to note: No security issues. We are 3 major versions behind in Gridstack, Patches available (break-free changes) for: Gridstack, ClipboardJS, CSSTidy, TinyMCE Minor updates available (should not have breaking changes) for: Gridstack, ChartJS, ElasticSearch, MomentJS, PDFJS, VideoJS, Bootstrap, Dragondrop, Datatables, Dropzone, HTMLPurifier, jQuery, JSColor, JSON Editor, MarkedJS, PHPMailer, Popper, SSPHP, FontAwesome Major (will have breaking changes) upgrades requiring migration available for: DateTimePicker, VideoJS, PDFJS, MomentJS, Elasticsearch, ChartJS, and Gridstack To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007457/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007457] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13794 Committed: https://git.mahara.org/mahara/mahara/commit/aa98379ca8abee5fe629ba8c187e53be5136d2a7 Submitter: "Robert Lyon " Branch:main commit aa98379ca8abee5fe629ba8c187e53be5136d2a7 Author: Doris Tam Date: Tue Feb 21 12:33:53 2023 +1300 Bug 2007457: Fontawesome customisations Change-Id: I6c29f5d6b2116e395092386ac750b6ae90d463fc -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007457 Title: Third party library updates for 23.04 Status in Mahara: In Progress Bug description: Third-party investigation and updates. To be discussed which ones will get into the next release. Things to note: No security issues. We are 3 major versions behind in Gridstack, Patches available (break-free changes) for: Gridstack, ClipboardJS, CSSTidy, TinyMCE Minor updates available (should not have breaking changes) for: Gridstack, ChartJS, ElasticSearch, MomentJS, PDFJS, VideoJS, Bootstrap, Dragondrop, Datatables, Dropzone, HTMLPurifier, jQuery, JSColor, JSON Editor, MarkedJS, PHPMailer, Popper, SSPHP, FontAwesome Major (will have breaking changes) upgrades requiring migration available for: DateTimePicker, VideoJS, PDFJS, MomentJS, Elasticsearch, ChartJS, and Gridstack To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007457/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007457] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13793 Committed: https://git.mahara.org/mahara/mahara/commit/540826de2a22bdb6114dacb1bef6bd62769074a6 Submitter: "Robert Lyon " Branch:main commit 540826de2a22bdb6114dacb1bef6bd62769074a6 Author: Doris Tam Date: Tue Feb 21 12:28:03 2023 +1300 Bug 2007457: Update Fontawesome to 3.6.0 Change-Id: I54058a36359188e0db15ef6a8cae35de8b670747 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007457 Title: Third party library updates for 23.04 Status in Mahara: In Progress Bug description: Third-party investigation and updates. To be discussed which ones will get into the next release. Things to note: No security issues. We are 3 major versions behind in Gridstack, Patches available (break-free changes) for: Gridstack, ClipboardJS, CSSTidy, TinyMCE Minor updates available (should not have breaking changes) for: Gridstack, ChartJS, ElasticSearch, MomentJS, PDFJS, VideoJS, Bootstrap, Dragondrop, Datatables, Dropzone, HTMLPurifier, jQuery, JSColor, JSON Editor, MarkedJS, PHPMailer, Popper, SSPHP, FontAwesome Major (will have breaking changes) upgrades requiring migration available for: DateTimePicker, VideoJS, PDFJS, MomentJS, Elasticsearch, ChartJS, and Gridstack To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007457/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1991604] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13684 Committed: https://git.mahara.org/mahara/mahara/commit/296f7d35891285cf8e79eee08a249de32b7a87dc Submitter: "Robert Lyon " Branch:main commit 296f7d35891285cf8e79eee08a249de32b7a87dc Author: Doris Tam Date: Thu Feb 2 17:51:52 2023 +1300 Bug 1991604: Outcomes portfolio (4) - Behat tests Run: outcomes_full_test.feature, outcomes_inst_config.feature, outcomes_permissions.feature Added to Behat setup: - outcomesubjects table - outcometypes table - grouptype: 'outcomes' for '"groups" exist' option - checkpoint for '"block" exist option' Shifted and generalise functionality out of CLI script so, it can be called for Behat setup Change-Id: Ie100ecb357f36c2c0c917739d2a16183a1d364f8 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1991604 Title: Outcomes portfolio (4): Activity page infrastructure Status in Mahara: Fix Committed Bug description: Part of the outcomes portfolio blueprint: https://blueprints.launchpad.net/mahara/+spec/outcomes-portfolio Better formatting: https://wiki.mahara.org/wiki/Proposals/Outcomes_portfolio/Activity_page_infrastructure # Activity page infrastructure ## High level overview * Add activity information to the page settings → Create a new portfolio page type * Pull in information from tables and people to auto-populate information * Display activity information set up on the page settings page * Update certain information directly while editing or viewing the activity page * Dealing with 'signing off' / completing activities ## Details ### Mock-up reference: 'Set up activity page – group tutor and group admin' **Who?** As group tutor or group admin... **What?** I want to set up activites for the group member... **Why?** So that all admin work is collected in one place and then available when I work with the group member on a particular activity. The numbered list refers to the bullets in the mock-up 'Set up activity page – group tutors and group admin'. This page is only accessible to group tutors and group admins. Students cannot get to it. 1. [no change] Page title: It's a short title of the activity to avoid that the heading of a page is longer than one line and therefore fits better into a navigation menu. This title is pulled into the outcomes overview page automatically. Mandatory field. 2. Activity information panel: automatically uncollapsed as information needs to be entered. 3. Activity description: Long title of the activity. Mandatory field. 4. Subject: Select list with hard-coded items (phase 1). 5. Responsible staff: Select list comprised of all group tutors and group admins from this group. The person filling in the form is automatically displayed as default choice. 6. Start date: Date picker. 7. End date: Date picker. Check that the end date is greater or equal to the start date. 8. Levels of achievement: Three single-line text entry fields. The fourth level is predefined. * Icons are assigned automatically. * Level 1 is the highest achievement and level 4 the lowest. * Suggested icons: Font Awesome number corresponding to the level with a circle around it in primary theme link colour but with a new variable set up if a different colour should be used. This will need to be achieved with stacked icons, e.g. icon-1 and icon-circle. * New table 'view_activity_achievement_levels' with ID, view_activity_ID (i.e. the view ID), priority column (1-4), value and level 4 always being the same (via hidden value). 9. Clicking 'Save' takes you to the 'Edit' screen of the activity page. > Notes: > > * The page buttons have changed slightly in Mahara 22.10 and thus will be used instead of the ones pictured on the mock-up. > * This settings page is only available to group tutors and group admins. > * The rest of the page settings stay as they are in the 'Advanced' panel. > * 'Prevent removing of blocks' in the 'Advanced' panel is automatically set to 'Yes' (see section 'Group changes') but can be changed to 'No'. ### Mock-up reference: 'Edit activity page – group tutor and group admin' **Who?** As group tutor or group admin... **What?** I want to add content to the activity page... **Why?** To assist the learner with their evidence collection and mark checkpoints as completed to illustrate progress. The numbered list refers to the bullets in the mock-up 'Edit activity page – group tutor and group admin'. This page is accessible to group tutors, group admins, and learners. 1. 'Settings' button: Available to group tutor and group admins to change information about the activity. It's not accessible to regular group members. 2. Activity information: * is displayed at the top of the page and
[Mahara-contributors] [Bug 2007457] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13825 Committed: https://git.mahara.org/mahara/mahara/commit/b916bb984b30eb60b2e8cdc10aa49c76713c8e56 Submitter: "Robert Lyon " Branch:main commit b916bb984b30eb60b2e8cdc10aa49c76713c8e56 Author: Gold Date: Thu Feb 23 11:29:58 2023 +1300 Bug 2007457: Move CSSTidy to Composer Signed-off-by: Gold Change-Id: I14fb290a8c117ad73104c89e49141132d666dc36 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007457 Title: Third party library updates for 23.04 Status in Mahara: In Progress Bug description: Third-party investigation and updates. To be discussed which ones will get into the next release. Things to note: No security issues. We are 3 major versions behind in Gridstack, Patches available (break-free changes) for: Gridstack, ClipboardJS, CSSTidy, TinyMCE Minor updates available (should not have breaking changes) for: Gridstack, ChartJS, ElasticSearch, MomentJS, PDFJS, VideoJS, Bootstrap, Dragondrop, Datatables, Dropzone, HTMLPurifier, jQuery, JSColor, JSON Editor, MarkedJS, PHPMailer, Popper, SSPHP, FontAwesome Major (will have breaking changes) upgrades requiring migration available for: DateTimePicker, VideoJS, PDFJS, MomentJS, Elasticsearch, ChartJS, and Gridstack To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007457/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007457] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13826 Committed: https://git.mahara.org/mahara/mahara/commit/cc24c09d6b54fed8408a17b2815cfda364cbaf34 Submitter: "Robert Lyon " Branch:main commit cc24c09d6b54fed8408a17b2815cfda364cbaf34 Author: Doris Tam Date: Thu Feb 23 12:36:24 2023 +1300 Bug 2007457: HTMLPurifier customisation patch for composer /maintenance and /extras files are required to generate the schema for our custom preserveCSS Filter. Download (from GitHub or .zip) /maintenance and /extras to the same level of /library and run `php generate-schema-cache.php` to generate the schema without custom Filter The version of htmlpurifier pulled in by composer does not come with maintenance/ and /extras Change-Id: If3e7f3d81b85238cefe141810423e0b034c67f7e Signed-off-by: Doris Tam -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007457 Title: Third party library updates for 23.04 Status in Mahara: In Progress Bug description: Third-party investigation and updates. To be discussed which ones will get into the next release. Things to note: No security issues. We are 3 major versions behind in Gridstack, Patches available (break-free changes) for: Gridstack, ClipboardJS, CSSTidy, TinyMCE Minor updates available (should not have breaking changes) for: Gridstack, ChartJS, ElasticSearch, MomentJS, PDFJS, VideoJS, Bootstrap, Dragondrop, Datatables, Dropzone, HTMLPurifier, jQuery, JSColor, JSON Editor, MarkedJS, PHPMailer, Popper, SSPHP, FontAwesome Major (will have breaking changes) upgrades requiring migration available for: DateTimePicker, VideoJS, PDFJS, MomentJS, Elasticsearch, ChartJS, and Gridstack To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007457/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007457] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13824 Committed: https://git.mahara.org/mahara/mahara/commit/cf37a11f934d289bc50229393226a6e916922d7b Submitter: "Robert Lyon " Branch:main commit cf37a11f934d289bc50229393226a6e916922d7b Author: Doris Tam Date: Thu Feb 23 10:46:54 2023 +1300 Bug 2007457: Move HTMLPurifier to Composer behatnotneeded For tests to pass, the customisation patch needs to be run Change-Id: Ic672b398be865b7feaf623590a3dfe7db8c90639 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007457 Title: Third party library updates for 23.04 Status in Mahara: In Progress Bug description: Third-party investigation and updates. To be discussed which ones will get into the next release. Things to note: No security issues. We are 3 major versions behind in Gridstack, Patches available (break-free changes) for: Gridstack, ClipboardJS, CSSTidy, TinyMCE Minor updates available (should not have breaking changes) for: Gridstack, ChartJS, ElasticSearch, MomentJS, PDFJS, VideoJS, Bootstrap, Dragondrop, Datatables, Dropzone, HTMLPurifier, jQuery, JSColor, JSON Editor, MarkedJS, PHPMailer, Popper, SSPHP, FontAwesome Major (will have breaking changes) upgrades requiring migration available for: DateTimePicker, VideoJS, PDFJS, MomentJS, Elasticsearch, ChartJS, and Gridstack To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007457/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007457] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13827 Committed: https://git.mahara.org/mahara/mahara/commit/1e02607f01d9a795d0331c43da9945da9dfe9c55 Submitter: "Robert Lyon " Branch:main commit 1e02607f01d9a795d0331c43da9945da9dfe9c55 Author: Doris Tam Date: Thu Feb 23 12:56:34 2023 +1300 Bug 2007457: Update HTMLPurifier to 4.16.0 Change-Id: I52ff77b01ea2edf92e30b55b8bb4d8d0e3ac126e -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007457 Title: Third party library updates for 23.04 Status in Mahara: In Progress Bug description: Third-party investigation and updates. To be discussed which ones will get into the next release. Things to note: No security issues. We are 3 major versions behind in Gridstack, Patches available (break-free changes) for: Gridstack, ClipboardJS, CSSTidy, TinyMCE Minor updates available (should not have breaking changes) for: Gridstack, ChartJS, ElasticSearch, MomentJS, PDFJS, VideoJS, Bootstrap, Dragondrop, Datatables, Dropzone, HTMLPurifier, jQuery, JSColor, JSON Editor, MarkedJS, PHPMailer, Popper, SSPHP, FontAwesome Major (will have breaking changes) upgrades requiring migration available for: DateTimePicker, VideoJS, PDFJS, MomentJS, Elasticsearch, ChartJS, and Gridstack To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007457/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1991604] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13835 Committed: https://git.mahara.org/mahara/mahara/commit/7173096a3b14e88210b63ae41c7003fa3965ec60 Submitter: "Robert Lyon " Branch:main commit 7173096a3b14e88210b63ae41c7003fa3965ec60 Author: Doris Tam Date: Thu Mar 2 10:56:58 2023 +1300 Bug 1991604: Fix group portfolios permission error Fix: Creating a new collection as a group member of a regular group without throwing permission error. Fix: PHP error for not an object on group porfolios screen Change-Id: I0d3dd458f1d35a3d8891acc92421cd5366574eb5 Signed-off-by: Doris Tam -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1991604 Title: Outcomes portfolio (4): Activity page infrastructure Status in Mahara: In Progress Bug description: Part of the outcomes portfolio blueprint: https://blueprints.launchpad.net/mahara/+spec/outcomes-portfolio Better formatting: https://wiki.mahara.org/wiki/Proposals/Outcomes_portfolio/Activity_page_infrastructure # Activity page infrastructure ## High level overview * Add activity information to the page settings → Create a new portfolio page type * Pull in information from tables and people to auto-populate information * Display activity information set up on the page settings page * Update certain information directly while editing or viewing the activity page * Dealing with 'signing off' / completing activities ## Details ### Mock-up reference: 'Set up activity page – group tutor and group admin' **Who?** As group tutor or group admin... **What?** I want to set up activites for the group member... **Why?** So that all admin work is collected in one place and then available when I work with the group member on a particular activity. The numbered list refers to the bullets in the mock-up 'Set up activity page – group tutors and group admin'. This page is only accessible to group tutors and group admins. Students cannot get to it. 1. [no change] Page title: It's a short title of the activity to avoid that the heading of a page is longer than one line and therefore fits better into a navigation menu. This title is pulled into the outcomes overview page automatically. Mandatory field. 2. Activity information panel: automatically uncollapsed as information needs to be entered. 3. Activity description: Long title of the activity. Mandatory field. 4. Subject: Select list with hard-coded items (phase 1). 5. Responsible staff: Select list comprised of all group tutors and group admins from this group. The person filling in the form is automatically displayed as default choice. 6. Start date: Date picker. 7. End date: Date picker. Check that the end date is greater or equal to the start date. 8. Levels of achievement: Three single-line text entry fields. The fourth level is predefined. * Icons are assigned automatically. * Level 1 is the highest achievement and level 4 the lowest. * Suggested icons: Font Awesome number corresponding to the level with a circle around it in primary theme link colour but with a new variable set up if a different colour should be used. This will need to be achieved with stacked icons, e.g. icon-1 and icon-circle. * New table 'view_activity_achievement_levels' with ID, view_activity_ID (i.e. the view ID), priority column (1-4), value and level 4 always being the same (via hidden value). 9. Clicking 'Save' takes you to the 'Edit' screen of the activity page. > Notes: > > * The page buttons have changed slightly in Mahara 22.10 and thus will be used instead of the ones pictured on the mock-up. > * This settings page is only available to group tutors and group admins. > * The rest of the page settings stay as they are in the 'Advanced' panel. > * 'Prevent removing of blocks' in the 'Advanced' panel is automatically set to 'Yes' (see section 'Group changes') but can be changed to 'No'. ### Mock-up reference: 'Edit activity page – group tutor and group admin' **Who?** As group tutor or group admin... **What?** I want to add content to the activity page... **Why?** To assist the learner with their evidence collection and mark checkpoints as completed to illustrate progress. The numbered list refers to the bullets in the mock-up 'Edit activity page – group tutor and group admin'. This page is accessible to group tutors, group admins, and learners. 1. 'Settings' button: Available to group tutor and group admins to change information about the activity. It's not accessible to regular group members. 2. Activity information: * is displayed at the top of the page and cannot be moved. * is displayed collapsed so that you only see the long-form activity, outcomes, outcome type, and whether the outcome has been achieved or
[Mahara-contributors] [Bug 2008972] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13837 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2008972 Title: Confusing error message when an artefact file is missing from dataroot Status in Mahara: In Progress Bug description: Currently gives an error: Access denied You do not have access to view this page. But really the issue is the file is missing so we should give an error message conveying that. To test: 1) Upload an image file for a person in the files area and copy the URL link from the 'Name' column 2) Open this URL in a new window/tab - see the file get downloaded 3) Delete the file from the dataroot and reload the window See the error message To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2008972/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2008956] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13836 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2008956 Title: PHP 8 deprecations to fix behat tests Status in Mahara: New Bug description: Fixes to get tests running on PHP 8 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2008956/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1991604] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13835 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1991604 Title: Outcomes portfolio (4): Activity page infrastructure Status in Mahara: In Progress Bug description: Part of the outcomes portfolio blueprint: https://blueprints.launchpad.net/mahara/+spec/outcomes-portfolio Better formatting: https://wiki.mahara.org/wiki/Proposals/Outcomes_portfolio/Activity_page_infrastructure # Activity page infrastructure ## High level overview * Add activity information to the page settings → Create a new portfolio page type * Pull in information from tables and people to auto-populate information * Display activity information set up on the page settings page * Update certain information directly while editing or viewing the activity page * Dealing with 'signing off' / completing activities ## Details ### Mock-up reference: 'Set up activity page – group tutor and group admin' **Who?** As group tutor or group admin... **What?** I want to set up activites for the group member... **Why?** So that all admin work is collected in one place and then available when I work with the group member on a particular activity. The numbered list refers to the bullets in the mock-up 'Set up activity page – group tutors and group admin'. This page is only accessible to group tutors and group admins. Students cannot get to it. 1. [no change] Page title: It's a short title of the activity to avoid that the heading of a page is longer than one line and therefore fits better into a navigation menu. This title is pulled into the outcomes overview page automatically. Mandatory field. 2. Activity information panel: automatically uncollapsed as information needs to be entered. 3. Activity description: Long title of the activity. Mandatory field. 4. Subject: Select list with hard-coded items (phase 1). 5. Responsible staff: Select list comprised of all group tutors and group admins from this group. The person filling in the form is automatically displayed as default choice. 6. Start date: Date picker. 7. End date: Date picker. Check that the end date is greater or equal to the start date. 8. Levels of achievement: Three single-line text entry fields. The fourth level is predefined. * Icons are assigned automatically. * Level 1 is the highest achievement and level 4 the lowest. * Suggested icons: Font Awesome number corresponding to the level with a circle around it in primary theme link colour but with a new variable set up if a different colour should be used. This will need to be achieved with stacked icons, e.g. icon-1 and icon-circle. * New table 'view_activity_achievement_levels' with ID, view_activity_ID (i.e. the view ID), priority column (1-4), value and level 4 always being the same (via hidden value). 9. Clicking 'Save' takes you to the 'Edit' screen of the activity page. > Notes: > > * The page buttons have changed slightly in Mahara 22.10 and thus will be used instead of the ones pictured on the mock-up. > * This settings page is only available to group tutors and group admins. > * The rest of the page settings stay as they are in the 'Advanced' panel. > * 'Prevent removing of blocks' in the 'Advanced' panel is automatically set to 'Yes' (see section 'Group changes') but can be changed to 'No'. ### Mock-up reference: 'Edit activity page – group tutor and group admin' **Who?** As group tutor or group admin... **What?** I want to add content to the activity page... **Why?** To assist the learner with their evidence collection and mark checkpoints as completed to illustrate progress. The numbered list refers to the bullets in the mock-up 'Edit activity page – group tutor and group admin'. This page is accessible to group tutors, group admins, and learners. 1. 'Settings' button: Available to group tutor and group admins to change information about the activity. It's not accessible to regular group members. 2. Activity information: * is displayed at the top of the page and cannot be moved. * is displayed collapsed so that you only see the long-form activity, outcomes, outcome type, and whether the outcome has been achieved or not in the panel header. * is a full-page width block. → Change the default width of blocks in Mahara when they are put on a page into full-page width blocks 3. Activity description: Long 'title' of the activity. 4. Outcome: Short title of the outcome to which this activity belongs. 5. Outcome type: Pulled from the outcome, i.e. short name with the predefined background colour. 6. Achieved: Switch to decide whether an outcome has been achieved or not. This can always be changed. A modal is displayed
[Mahara-contributors] [Bug 2007457] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13823 Committed: https://git.mahara.org/mahara/mahara/commit/db0581be525120927cc9986952f5c43ae83a6e5f Submitter: "Robert Lyon " Branch:main commit db0581be525120927cc9986952f5c43ae83a6e5f Author: Gold Date: Thu Feb 23 10:20:58 2023 +1300 Bug 2007457: ADODB without our SESSION patch. Testing if this patch is still needed. Do we actually have any tests that specifically test for what this is supposed to provide? Signed-off-by: Gold Change-Id: If852144d3675f4225cb80c7a9c2fb5216e514dcb -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007457 Title: Third party library updates for 23.04 Status in Mahara: In Progress Bug description: Third-party investigation and updates. To be discussed which ones will get into the next release. Things to note: No security issues. We are 3 major versions behind in Gridstack, Patches available (break-free changes) for: Gridstack, ClipboardJS, CSSTidy, TinyMCE Minor updates available (should not have breaking changes) for: Gridstack, ChartJS, ElasticSearch, MomentJS, PDFJS, VideoJS, Bootstrap, Dragondrop, Datatables, Dropzone, HTMLPurifier, jQuery, JSColor, JSON Editor, MarkedJS, PHPMailer, Popper, SSPHP, FontAwesome Major (will have breaking changes) upgrades requiring migration available for: DateTimePicker, VideoJS, PDFJS, MomentJS, Elasticsearch, ChartJS, and Gridstack To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007457/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007457] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13821 Committed: https://git.mahara.org/mahara/mahara/commit/2ff66f052ec2430f308a012d2bc7182c34453345 Submitter: "Robert Lyon " Branch:main commit 2ff66f052ec2430f308a012d2bc7182c34453345 Author: Gold Date: Wed Feb 22 13:09:54 2023 +1300 Bug 2007457: Move ADODB to Composer Signed-off-by: Gold Change-Id: I3f8d7b129b404c4af5311c3e2c1d36b6c4dba175 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007457 Title: Third party library updates for 23.04 Status in Mahara: In Progress Bug description: Third-party investigation and updates. To be discussed which ones will get into the next release. Things to note: No security issues. We are 3 major versions behind in Gridstack, Patches available (break-free changes) for: Gridstack, ClipboardJS, CSSTidy, TinyMCE Minor updates available (should not have breaking changes) for: Gridstack, ChartJS, ElasticSearch, MomentJS, PDFJS, VideoJS, Bootstrap, Dragondrop, Datatables, Dropzone, HTMLPurifier, jQuery, JSColor, JSON Editor, MarkedJS, PHPMailer, Popper, SSPHP, FontAwesome Major (will have breaking changes) upgrades requiring migration available for: DateTimePicker, VideoJS, PDFJS, MomentJS, Elasticsearch, ChartJS, and Gridstack To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007457/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007457] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13834 Committed: https://git.mahara.org/mahara/mahara/commit/81b91b0799442cf7fd3fae213dd3d015d805ce24 Submitter: "Robert Lyon " Branch:main commit 81b91b0799442cf7fd3fae213dd3d015d805ce24 Author: Doris Tam Date: Wed Mar 1 14:44:13 2023 +1300 Bug 2007457: Tie down Composer libraries to be both PHP 7/8 compatible Newer versions require PHP 8 at minimum Adding psr/log into our dependencies so that Elasticsearch's psr/log will only go with what we have to be PHP 7 and 8 compatible. Also fixing a few PHP 8 syntax errors for running behat tests. Change-Id: I2e04c71bc615b700a6695dd10afc4f6e19003d10 Signed-off-by: Doris Tam -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007457 Title: Third party library updates for 23.04 Status in Mahara: In Progress Bug description: Third-party investigation and updates. To be discussed which ones will get into the next release. Things to note: No security issues. We are 3 major versions behind in Gridstack, Patches available (break-free changes) for: Gridstack, ClipboardJS, CSSTidy, TinyMCE Minor updates available (should not have breaking changes) for: Gridstack, ChartJS, ElasticSearch, MomentJS, PDFJS, VideoJS, Bootstrap, Dragondrop, Datatables, Dropzone, HTMLPurifier, jQuery, JSColor, JSON Editor, MarkedJS, PHPMailer, Popper, SSPHP, FontAwesome Major (will have breaking changes) upgrades requiring migration available for: DateTimePicker, VideoJS, PDFJS, MomentJS, Elasticsearch, ChartJS, and Gridstack To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007457/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2003990] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13833 Committed: https://git.mahara.org/mahara/mahara/commit/93b46f59670e763e71f141dd65a9e17d02ef3799 Submitter: "Doris Tam " Branch:main commit 93b46f59670e763e71f141dd65a9e17d02ef3799 Author: Doris Tam Date: Wed Mar 1 12:52:26 2023 +1300 Bug 2003990: GrumPHP custom banners Change-Id: Ib33aa580cab0ab0f169542ce1437eaf794da2627 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2003990 Title: GrumPHP Mahara for linting on commits Status in Mahara: New Bug description: Currently pulls in our phpstan.neon file and runs phpstan on `git commit` related commands. Refer to https://github.com/phpro/grumphp Quick start: - composer require --dev phpro/grumphp - composer require --dev phpstan/phpstan In case SimpleSAMLPHP throws phpstan errors: run `make ssphp` To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2003990/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007457] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13791 Committed: https://git.mahara.org/mahara/mahara/commit/f9b6cd7bf2029083d1cbb3af62dd6fbf6680405b Submitter: "Robert Lyon " Branch:main commit f9b6cd7bf2029083d1cbb3af62dd6fbf6680405b Author: Doris Tam Date: Mon Feb 20 17:34:25 2023 +1300 Bug 2007457: Update PDFJs to 3.3.122 Change-Id: Ibd6c7d9daf1fbbc45c095c2750821d823a68c5a4 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007457 Title: Third party library updates for 23.04 Status in Mahara: In Progress Bug description: Third-party investigation and updates. To be discussed which ones will get into the next release. Things to note: No security issues. We are 3 major versions behind in Gridstack, Patches available (break-free changes) for: Gridstack, ClipboardJS, CSSTidy, TinyMCE Minor updates available (should not have breaking changes) for: Gridstack, ChartJS, ElasticSearch, MomentJS, PDFJS, VideoJS, Bootstrap, Dragondrop, Datatables, Dropzone, HTMLPurifier, jQuery, JSColor, JSON Editor, MarkedJS, PHPMailer, Popper, SSPHP, FontAwesome Major (will have breaking changes) upgrades requiring migration available for: DateTimePicker, VideoJS, PDFJS, MomentJS, Elasticsearch, ChartJS, and Gridstack To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007457/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007457] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13792 Committed: https://git.mahara.org/mahara/mahara/commit/2e540d78706d94d48e9105c160092aae00f66c59 Submitter: "Robert Lyon " Branch:main commit 2e540d78706d94d48e9105c160092aae00f66c59 Author: Doris Tam Date: Mon Feb 20 17:44:42 2023 +1300 Bug 2007457: Update PDFJs | Hide upload buttons Change-Id: I6b65f0aaaeb6f631e12c8ea8eb43d064216ce465 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007457 Title: Third party library updates for 23.04 Status in Mahara: In Progress Bug description: Third-party investigation and updates. To be discussed which ones will get into the next release. Things to note: No security issues. We are 3 major versions behind in Gridstack, Patches available (break-free changes) for: Gridstack, ClipboardJS, CSSTidy, TinyMCE Minor updates available (should not have breaking changes) for: Gridstack, ChartJS, ElasticSearch, MomentJS, PDFJS, VideoJS, Bootstrap, Dragondrop, Datatables, Dropzone, HTMLPurifier, jQuery, JSColor, JSON Editor, MarkedJS, PHPMailer, Popper, SSPHP, FontAwesome Major (will have breaking changes) upgrades requiring migration available for: DateTimePicker, VideoJS, PDFJS, MomentJS, Elasticsearch, ChartJS, and Gridstack To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007457/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007457] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13834 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007457 Title: Third party library updates for 23.04 Status in Mahara: In Progress Bug description: Third-party investigation and updates. To be discussed which ones will get into the next release. Things to note: No security issues. We are 3 major versions behind in Gridstack, Patches available (break-free changes) for: Gridstack, ClipboardJS, CSSTidy, TinyMCE Minor updates available (should not have breaking changes) for: Gridstack, ChartJS, ElasticSearch, MomentJS, PDFJS, VideoJS, Bootstrap, Dragondrop, Datatables, Dropzone, HTMLPurifier, jQuery, JSColor, JSON Editor, MarkedJS, PHPMailer, Popper, SSPHP, FontAwesome Major (will have breaking changes) upgrades requiring migration available for: DateTimePicker, VideoJS, PDFJS, MomentJS, Elasticsearch, ChartJS, and Gridstack To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007457/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2003990] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13833 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2003990 Title: GrumPHP Mahara for linting on commits Status in Mahara: New Bug description: Currently pulls in our phpstan.neon file and runs phpstan on `git commit` related commands. Refer to https://github.com/phpro/grumphp Quick start: - composer require --dev phpro/grumphp - composer require --dev phpstan/phpstan In case SimpleSAMLPHP throws phpstan errors: run `make ssphp` To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2003990/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2000277] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13795 Committed: https://git.mahara.org/mahara/mahara/commit/8e444868803250115f3b9baf6ec9f63a8a05d904 Submitter: "Robert Lyon " Branch:main commit 8e444868803250115f3b9baf6ec9f63a8a05d904 Author: Robert Lyon Date: Tue Feb 21 13:50:57 2023 +1300 Bug 2000277: Rewrite the configdata image link on page copy For the verification block Change-Id: I27c2f1f3326006c872eaec8fc5c3d832e79ff325 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2000277 Title: Images added to portfolio review block are not copied when template is copied Status in Mahara: Fix Committed Bug description: When you add an image into the review statement in the 'Portfolio review' block and then copy the portfolio into another account, the reference stays to the original image even though the image is transferred as far as I can tell. The fix should be similar to what was done for bug #1957725 To replicate: 1. Allow 'Portfolio completion' in the institution. 2. Set up a portfolio with at least one page and the portfolio completion page. 3. Add the block 'Portfolio review' to the portfolio completion page and add an image into the statement field. Note down the image ID. 4. Give others access and allow copying. 5. Log in as somebody else and copy the portfolio. Check the image ID referenced in the portfolio review block and check if the file was copied to your personal portfolio area. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2000277/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007457] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13796 Committed: https://git.mahara.org/mahara/mahara/commit/107eb1ea8758f246647d008a23478e49f1ec98f8 Submitter: "Robert Lyon " Branch:main commit 107eb1ea8758f246647d008a23478e49f1ec98f8 Author: Doris Tam Date: Tue Feb 21 14:01:50 2023 +1300 Bug 2007457: Update Elasticsearch to 7.17.1 Change-Id: Id8bcc07fb3369b96f405020fa7d1b8fcec3b0db5 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007457 Title: Third party library updates for 23.04 Status in Mahara: New Bug description: Third-party investigation and updates. To be discussed which ones will get into the next release. Things to note: No security issues. We are 3 major versions behind in Gridstack, Patches available (break-free changes) for: Gridstack, ClipboardJS, CSSTidy, TinyMCE Minor updates available (should not have breaking changes) for: Gridstack, ChartJS, ElasticSearch, MomentJS, PDFJS, VideoJS, Bootstrap, Dragondrop, Datatables, Dropzone, HTMLPurifier, jQuery, JSColor, JSON Editor, MarkedJS, PHPMailer, Popper, SSPHP, FontAwesome Major (will have breaking changes) upgrades requiring migration available for: DateTimePicker, VideoJS, PDFJS, MomentJS, Elasticsearch, ChartJS, and Gridstack To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007457/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2003990] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13830 Committed: https://git.mahara.org/mahara/mahara/commit/096381df4c4c96cb586547e80acc601044619f29 Submitter: "Robert Lyon " Branch:main commit 096381df4c4c96cb586547e80acc601044619f29 Author: Gold Date: Mon Feb 27 10:41:22 2023 +1300 Bug 2003990: GrumPHP v2 Adds the current change id commit hook to the commit message that GrumPHP over writes. The presence of a change id on this commit message is the actual test. Signed-off-by: Gold Change-Id: I4e5fbc11914a6d5886a197b6f14295688eb73e9b -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2003990 Title: GrumPHP Mahara for linting on commits Status in Mahara: New Bug description: Currently pulls in our phpstan.neon file and runs phpstan on `git commit` related commands. Refer to https://github.com/phpro/grumphp Quick start: - composer require --dev phpro/grumphp - composer require --dev phpstan/phpstan In case SimpleSAMLPHP throws phpstan errors: run `make ssphp` To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2003990/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2003990] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13668 Committed: https://git.mahara.org/mahara/mahara/commit/7c1df258261cf34e6eadd00869d6b5f69173c5f3 Submitter: "Robert Lyon " Branch:main commit 7c1df258261cf34e6eadd00869d6b5f69173c5f3 Author: Doris Tam Date: Fri Jan 27 15:35:13 2023 +1300 Bug 2003990: GrumPHP experimental Currently pulls in our phpstan.neon file and runs phpstan on `git commit` related commands. Refer to https://github.com/phpro/grumphp Quick start: - composer require --dev phpro/grumphp - composer require --dev phpstan/phpstan In case SimpleSAMLPHP throws phpstan errors Run... make ssphp Make changes, git add them, git commit Change-Id: Ifaae01b49d9c5e1d89aaf6f90dea02e74bb317b6 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2003990 Title: GrumPHP Mahara for linting on commits Status in Mahara: New Bug description: Currently pulls in our phpstan.neon file and runs phpstan on `git commit` related commands. Refer to https://github.com/phpro/grumphp Quick start: - composer require --dev phpro/grumphp - composer require --dev phpstan/phpstan In case SimpleSAMLPHP throws phpstan errors: run `make ssphp` To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2003990/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2008729] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13832 Committed: https://git.mahara.org/mahara/mahara/commit/e036c9c7c3ce781f7b67a6256f6d20ac9eb4f394 Submitter: "Robert Lyon " Branch:main commit e036c9c7c3ce781f7b67a6256f6d20ac9eb4f394 Author: Gold Date: Tue Feb 28 08:18:13 2023 +1300 Bug 2008729: Nail down recaptcha for php 7.x Also removed the patch that removes files that fails to reliably apply. Signed-off-by: Gold Change-Id: I0af7d4ec8ced6ef2ddef0cd88e8d3feaccf12b28 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2008729 Title: recaptcha for php7.4 Status in Mahara: Fix Committed Bug description: The new management of recaptcha downloads 1.3.0 by default. This requires PHP 8.x. Jenkins currently runs PHP 7.4 so this is rejected on automated testing. It will also be rejected on client sites running PHP 7.x. We need to nail the version to Recaptcha 1.2.x as this has a PHP requirement of >=5.5. While we are here, we could remove the patch that tries to clean up files we don't want as this isn't a concern any more. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2008729/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2006516] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13723 Committed: https://git.mahara.org/mahara/mahara/commit/7039ae286690b31de09b3418f9a5780ad5973a8c Submitter: "Robert Lyon " Branch:main commit 7039ae286690b31de09b3418f9a5780ad5973a8c Author: Robert Lyon Date: Wed Feb 8 11:06:15 2023 +1300 Bug 2006516: Fixes for CLI bulk export For comment block and for annotation block Change-Id: I39ce91d0fbab9deb7786f069839e02f0f36c8663 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2006516 Title: bulk export causing errors for comment / annotation block exports Status in Mahara: Fix Committed Bug description: The comment block problem is when you are doing a bulk export via CLI as the $exporter object is not in a global scope and so can't be 'seen' by the comment block renderer. The annotation problem is we are trying to create a pieform during export and it can't resolve the get_ip() function. But we shouldn't need the pieform as the exported information wouldn't be able to use it anyway. The following 2 problems can best be seen when doing an export via the CLI, eg: for 'Person One' Create a person called 'Person One' and log in as them (not masquerade so as to se lastlogin value) Create a page and add a comment block and an annotation block to the page - add a comment to the page and the annotation block. Export the person via the CLI sudo -u www-data php htdocs/admin/cli/portfolio_bulkexport.php -fk=lastname -fv=One -e=leap -d=false Expected result - export goes smoothly Actual result - get two errors To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2006516/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1945537] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/12478
Committed:
https://git.mahara.org/mahara/mahara/commit/6b3b10bdb28af000cf7f84fffee1c626e7562918
Submitter: "Robert Lyon "
Branch:main
commit 6b3b10bdb28af000cf7f84fffee1c626e7562918
Author: Robert Lyon
Date: Mon Mar 7 14:14:12 2022 +1300
Bug 1945537: format the time taken number
So it can be saved in the database correctly
Change-Id: Ida0bb13df0203bfa825bbac0a4123f0bfca9c9c3
Signed-off-by: Robert Lyon
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1945537
Title:
Problem with saving web service log message event when float is in
another language
Status in Mahara:
Fix Committed
Bug description:
Initially reported at
https://mahara.org/interaction/forum/topic.php?id=8930
So for example we try to save number as 1,2345 instead of 1.2345
We probably need to cast it via flotval somehow
Error looks like this
PHP Fatal error: Uncaught SQLException: Failed to get a recordset: postgres8
error: [-1: ERROR: invalid input syntax for type numeric: "0,12291693687439"]
in EXECUTE("INSERT INTO "external_services_logs" ("id", "timelogged", "userid",
"externalserviceid", "protocol", "auth", "functionname", "timetaken", "uri",
"info", "ip") VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)")Command was: INSERT
INTO "external_services_logs" ("id", "timelogged", "userid",
"externalserviceid", "protocol", "auth", "functionname", "timetaken", "uri",
"info", "ip") VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) and values was
(id:109,timelogged:1632941361,userid:23,externalserviceid:3,protocol:REST,auth:OTHER,functionname:module_mobileapi_upload_blog_post,timetaken:0,12291693687439,uri:/webservice/rest/server.php?alt=json,info:exception:SQLExceptionmessage:Failedtogetarecordset:postgres8error:[-1:ERROR:invalidinputsyntaxfortypenumeric:"0,11438679695129"]inEXECUTE("INSERTINTO"external_services_logs"("id","timelogged","userid","externalserviceid","protocol","auth"
The problem looks to be related to:
The variable "time_taken" in file:
htdocs/webservice/lib.php
$time_taken = $time_end - $WEBSERVICE_START;
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1945537/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2008729] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13832 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2008729 Title: recaptcha for php7.4 Status in Mahara: In Progress Bug description: The new management of recaptcha downloads 1.3.0 by default. This requires PHP 8.x. Jenkins currently runs PHP 7.4 so this is rejected on automated testing. It will also be rejected on client sites running PHP 7.x. We need to nail the version to Recaptcha 1.2.x as this has a PHP requirement of >=5.5. While we are here, we could remove the patch that tries to clean up files we don't want as this isn't a concern any more. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2008729/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007457] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13790 Committed: https://git.mahara.org/mahara/mahara/commit/5d5b25b51d1f7fd9d88b995e5525e59e3b7f1375 Submitter: "Gold " Branch:main commit 5d5b25b51d1f7fd9d88b995e5525e59e3b7f1375 Author: Doris Tam Date: Mon Feb 20 16:12:19 2023 +1300 Bug 2007457: Update PhpMailer to 6.7.1 Change-Id: Id2cd03f71b7240cf55b08dc0e855add934616e8f -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007457 Title: Third party library updates for 23.04 Status in Mahara: New Bug description: Third-party investigation and updates. To be discussed which ones will get into the next release. Things to note: No security issues. We are 3 major versions behind in Gridstack, Patches available (break-free changes) for: Gridstack, ClipboardJS, CSSTidy, TinyMCE Minor updates available (should not have breaking changes) for: Gridstack, ChartJS, ElasticSearch, MomentJS, PDFJS, VideoJS, Bootstrap, Dragondrop, Datatables, Dropzone, HTMLPurifier, jQuery, JSColor, JSON Editor, MarkedJS, PHPMailer, Popper, SSPHP, FontAwesome Major (will have breaking changes) upgrades requiring migration available for: DateTimePicker, VideoJS, PDFJS, MomentJS, Elasticsearch, ChartJS, and Gridstack To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007457/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007457] A change has been merged
Reviewed: https://reviews.mahara.org/c/mahara/+/13828 Committed: https://git.mahara.org/mahara/mahara/commit/81fe27a8470c24a161a10ff5a211af9acde3108f Submitter: "Gold " Branch:main commit 81fe27a8470c24a161a10ff5a211af9acde3108f Author: Doris Tam Date: Fri Feb 24 13:40:18 2023 +1300 Bug 2007457: Add PHP 8 to the require for extenal/ composer.json This will allow those on PHP to run make initcomposer Change-Id: I16625091333fc7c06ade04a63ca9f15a28a4323e -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007457 Title: Third party library updates for 23.04 Status in Mahara: New Bug description: Third-party investigation and updates. To be discussed which ones will get into the next release. Things to note: No security issues. We are 3 major versions behind in Gridstack, Patches available (break-free changes) for: Gridstack, ClipboardJS, CSSTidy, TinyMCE Minor updates available (should not have breaking changes) for: Gridstack, ChartJS, ElasticSearch, MomentJS, PDFJS, VideoJS, Bootstrap, Dragondrop, Datatables, Dropzone, HTMLPurifier, jQuery, JSColor, JSON Editor, MarkedJS, PHPMailer, Popper, SSPHP, FontAwesome Major (will have breaking changes) upgrades requiring migration available for: DateTimePicker, VideoJS, PDFJS, MomentJS, Elasticsearch, ChartJS, and Gridstack To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007457/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007457] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13831 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007457 Title: Third party library updates for 23.04 Status in Mahara: New Bug description: Third-party investigation and updates. To be discussed which ones will get into the next release. Things to note: No security issues. We are 3 major versions behind in Gridstack, Patches available (break-free changes) for: Gridstack, ClipboardJS, CSSTidy, TinyMCE Minor updates available (should not have breaking changes) for: Gridstack, ChartJS, ElasticSearch, MomentJS, PDFJS, VideoJS, Bootstrap, Dragondrop, Datatables, Dropzone, HTMLPurifier, jQuery, JSColor, JSON Editor, MarkedJS, PHPMailer, Popper, SSPHP, FontAwesome Major (will have breaking changes) upgrades requiring migration available for: DateTimePicker, VideoJS, PDFJS, MomentJS, Elasticsearch, ChartJS, and Gridstack To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007457/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2003990] A patch has been submitted for review
Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13830 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2003990 Title: GrumPHP Mahara for linting on commits Status in Mahara: New Bug description: Currently pulls in our phpstan.neon file and runs phpstan on `git commit` related commands. Refer to https://github.com/phpro/grumphp Quick start: - composer require --dev phpro/grumphp - composer require --dev phpstan/phpstan In case SimpleSAMLPHP throws phpstan errors: run `make ssphp` To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2003990/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
