[Mahara-contributors] [Bug 1432641] [NEW] Changing view layout causes an error
Public bug reported: Steps to reproduce: 1. Create a new view 2. Select the layout with one column in first row and three columns in second 3. Add two textboxes to each column, 8 textboxes total 4. Change the layout to one row & one column This results in following error: [WAR] d1 (lib/dml.php:890) Failed to get a recordset: mysqli error: [1062: Duplicate entry '593-2-1-0' for key 'blocinst_vierowcolord_uk'] in adodb_throw(UPDATE "block_instance" SET "order" = 0 WHERE "order" = '1' AND "view" = '593' AND "row" = '2' AND "column" = 1, ) Command was: UPDATE "block_instance" SET "order" = ? WHERE "order" = ? AND "view" = ? AND "row" = ? AND "column" = ? and values was (0,1,593,2,1) Tested in 1.9.1 (Ubuntu 14.04.2 / MySQL 5.5.35 / Chrome 41.0.2272.89 (64-bit)) and Mahara Demo (currently 1.10). ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1432641 Title: Changing view layout causes an error Status in Mahara ePortfolio: New Bug description: Steps to reproduce: 1. Create a new view 2. Select the layout with one column in first row and three columns in second 3. Add two textboxes to each column, 8 textboxes total 4. Change the layout to one row & one column This results in following error: [WAR] d1 (lib/dml.php:890) Failed to get a recordset: mysqli error: [1062: Duplicate entry '593-2-1-0' for key 'blocinst_vierowcolord_uk'] in adodb_throw(UPDATE "block_instance" SET "order" = 0 WHERE "order" = '1' AND "view" = '593' AND "row" = '2' AND "column" = 1, ) Command was: UPDATE "block_instance" SET "order" = ? WHERE "order" = ? AND "view" = ? AND "row" = ? AND "column" = ? and values was (0,1,593,2,1) Tested in 1.9.1 (Ubuntu 14.04.2 / MySQL 5.5.35 / Chrome 41.0.2272.89 (64-bit)) and Mahara Demo (currently 1.10). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1432641/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1432635] [NEW] Changing view layout causes block removal
Public bug reported: Steps to reproduce: 1. Create a new view 2. Select layout with one column in first row and three columns in second 3. Add one textbox to each column, 4 textboxes total 4. Go to layout-tab again and change the layout to one row & one column (the first) Result: The block(s) in the first column of the second row is gone. Tested in 1.9.1 and Mahara Demo (1.10 at the moment). ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1432635 Title: Changing view layout causes block removal Status in Mahara ePortfolio: New Bug description: Steps to reproduce: 1. Create a new view 2. Select layout with one column in first row and three columns in second 3. Add one textbox to each column, 4 textboxes total 4. Go to layout-tab again and change the layout to one row & one column (the first) Result: The block(s) in the first column of the second row is gone. Tested in 1.9.1 and Mahara Demo (1.10 at the moment). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1432635/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1429871] [NEW] Link underlining in skins doesn't work
Public bug reported: If the user edits a skin (Edit skin > Fonts and colours) and checks the Underline link -option, the link doesn't get underlined on a page with the skin applied. There seems to be a bug in skin/style.php#38 with the comparison if ($option == 'transparent') because when a checkbox is selected, the $option value is a boolean TRUE and when using PHP's loose comparison operator, (true == 'transparent') = true. Therefore for example $skin->viewskin['view_link_normal_underline'] (and a few others) value changes to an empty string and the value assigned to template is 'none' instead of 'underline'. A simple fix is to use strict comparison: if ($option === 'transparent') --- Mahara version: 1.9.1 Browser: Chrome (Linux) 40.0.2214.115 (64-bit) ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1429871 Title: Link underlining in skins doesn't work Status in Mahara ePortfolio: New Bug description: If the user edits a skin (Edit skin > Fonts and colours) and checks the Underline link -option, the link doesn't get underlined on a page with the skin applied. There seems to be a bug in skin/style.php#38 with the comparison if ($option == 'transparent') because when a checkbox is selected, the $option value is a boolean TRUE and when using PHP's loose comparison operator, (true == 'transparent') = true. Therefore for example $skin->viewskin['view_link_normal_underline'] (and a few others) value changes to an empty string and the value assigned to template is 'none' instead of 'underline'. A simple fix is to use strict comparison: if ($option === 'transparent') --- Mahara version: 1.9.1 Browser: Chrome (Linux) 40.0.2214.115 (64-bit) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1429871/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1371460] [NEW] Missing translations in js/customlayout.js
Public bug reported:
Version 1.9.1
The following rows contain untranslated strings:
Row 11: $(newrow).find('.customrowtitle').html('Row ' + (numrows + 1) +
'');
Row 39: $(this).find('.customrowtitle').html('Row ' + inc +
'');
Row 112: rowtitlediv.html('' + numrows + ' rows');
Row 224: $('#custompreview').html('Generating preview...');
** Affects: mahara
Importance: Undecided
Status: New
** Tags: translations
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1371460
Title:
Missing translations in js/customlayout.js
Status in Mahara ePortfolio:
New
Bug description:
Version 1.9.1
The following rows contain untranslated strings:
Row 11: $(newrow).find('.customrowtitle').html('Row ' + (numrows + 1)
+ '');
Row 39: $(this).find('.customrowtitle').html('Row ' + inc +
'');
Row 112: rowtitlediv.html('' + numrows + ' rows');
Row 224: $('#custompreview').html('Generating preview...');
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1371460/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1314012] Re: Document local/lib.php functions
Small error in the documentation. It says, that "local_header_top_content(): Returned data is printed at top of ", when in fact the returned data is printed (almost) at top of . -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1314012 Title: Document local/lib.php functions Status in Mahara ePortfolio: Fix Committed Bug description: See forum post: https://mahara.org/interaction/forum/editpost.php?parent=26592 There are quite a few local hooks that have been added to Mahara but are not documented in one central location. I've located these in the code, and added comments to local/lib.php that document the existence of these methods, so that a developer looking under /local/lib.php will know what their options are. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1314012/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1305481] [NEW] Adding content to page buggy on Firefox
Public bug reported: When adding a block by clicking an element from the content editor sidebar after a menu from the sidebar was expanded, the block gets added twice and the overlay doesn't go away. Steps to reproduce: 1. Create a new page 2. Go to Edit content -tab 3. Expand a menu from the sidebar, for example Media 4. Click "Text box" from the sidebar 5. Click Save from the popup 6. Click Save from the "Text box: Configure" popup Expected result: The popup and the overlay disappears and the Text box block is added to page. Actual result: The popup disappears, but the overlay remains and the block is added twice to page. In file js/views.js, the function ViewManager.makeNewBlocksDraggable is called on ViewManager initialization and also when the change event of the accordion is fired. So each div.blocktype gets a new click (and keydown) handler when the accordion is expanded and that's why ViewManager.startAddBlock is called multiple times and multiple overlays are created. We have made some customizations to views.js, but they don't seem to affect this part of the code. Mahara version: Latest from git (1.9rc2dev) Browser: Mozilla Firefox for Ubuntu (28.0) ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1305481 Title: Adding content to page buggy on Firefox Status in Mahara ePortfolio: New Bug description: When adding a block by clicking an element from the content editor sidebar after a menu from the sidebar was expanded, the block gets added twice and the overlay doesn't go away. Steps to reproduce: 1. Create a new page 2. Go to Edit content -tab 3. Expand a menu from the sidebar, for example Media 4. Click "Text box" from the sidebar 5. Click Save from the popup 6. Click Save from the "Text box: Configure" popup Expected result: The popup and the overlay disappears and the Text box block is added to page. Actual result: The popup disappears, but the overlay remains and the block is added twice to page. In file js/views.js, the function ViewManager.makeNewBlocksDraggable is called on ViewManager initialization and also when the change event of the accordion is fired. So each div.blocktype gets a new click (and keydown) handler when the accordion is expanded and that's why ViewManager.startAddBlock is called multiple times and multiple overlays are created. We have made some customizations to views.js, but they don't seem to affect this part of the code. Mahara version: Latest from git (1.9rc2dev) Browser: Mozilla Firefox for Ubuntu (28.0) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1305481/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1305451] [NEW] Content editor sidebar doesn't work on Chrome
Public bug reported: Adding content by clicking an item from the sidebar fails on Chrome. Steps to repeat: 1. Create a new page 2. Go to Edit content -tab 3. Click on Text box Expected result: "Add block: Text box" -popup appears. Actual result: Nothing happens. In file js/views.js, in function ViewManager.makeNewBlocksDraggable the event handler of the .blocktypelink -elements is assumed that event.buttons -property exists and that it is a number. However, as you can see from https://developer.mozilla.org/en- US/docs/Web/API/MouseEvent.buttons#Browser_compatibility, Chrome doesn't seem to support the property. Mahara version: Latest from git (1.9rc2dev) Browser: Chrome (Linux) 33.0.1750.152 ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1305451 Title: Content editor sidebar doesn't work on Chrome Status in Mahara ePortfolio: New Bug description: Adding content by clicking an item from the sidebar fails on Chrome. Steps to repeat: 1. Create a new page 2. Go to Edit content -tab 3. Click on Text box Expected result: "Add block: Text box" -popup appears. Actual result: Nothing happens. In file js/views.js, in function ViewManager.makeNewBlocksDraggable the event handler of the .blocktypelink -elements is assumed that event.buttons -property exists and that it is a number. However, as you can see from https://developer.mozilla.org/en- US/docs/Web/API/MouseEvent.buttons#Browser_compatibility, Chrome doesn't seem to support the property. Mahara version: Latest from git (1.9rc2dev) Browser: Chrome (Linux) 33.0.1750.152 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1305451/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
