[Mahara-contributors] [Bug 1898955] Re: Add collection process missing button styles
Bug report for other incorrect button styling: https://bugs.launchpad.net/mahara/+bug/1899120 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1898955 Title: Add collection process missing button styles Status in Mahara: Fix Committed Bug description: This not a problem in 20.10+ But is a problem in 20.04 See attached image To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1898955/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1899120] [NEW] Incorrect button classes on submitcancel buttons 20.04
Public bug reported: Related to: https://bugs.launchpad.net/mahara/+bug/1898955 While testing the above fix I looked for "submitcancel" in .tpl files to see whether there were other cases with "btn-primary" and without "btn" class. I found the following: /htdocs/theme/raw/plugintype/artefact/file/templates/form/editfile.tpl /htdocs/theme/raw/plugintype/module/framework/templates/jsoneditor.tpl /htdocs/theme/raw/plugintype/module/multirecipientnotification/templates/indexsearch.tpl /htdocs/theme/raw/templates/privacy_modal.tpl I confirmed the first three do display incorrect styling for the submitcancel button group. Screenshots below. Limitations Note: This affects 20.04, but not 20.10+ Only buttons using the "submitcancel" class have been searched for. It is possible there are other similar issues with other button classes. ** Affects: mahara Importance: Undecided Status: New ** Attachment added: "filebrowserin edit modal for fileblock.png" https://bugs.launchpad.net/bugs/1899120/+attachment/5419841/+files/filebrowserin%20edit%20modal%20for%20fileblock.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1899120 Title: Incorrect button classes on submitcancel buttons 20.04 Status in Mahara: New Bug description: Related to: https://bugs.launchpad.net/mahara/+bug/1898955 While testing the above fix I looked for "submitcancel" in .tpl files to see whether there were other cases with "btn-primary" and without "btn" class. I found the following: /htdocs/theme/raw/plugintype/artefact/file/templates/form/editfile.tpl /htdocs/theme/raw/plugintype/module/framework/templates/jsoneditor.tpl /htdocs/theme/raw/plugintype/module/multirecipientnotification/templates/indexsearch.tpl /htdocs/theme/raw/templates/privacy_modal.tpl I confirmed the first three do display incorrect styling for the submitcancel button group. Screenshots below. Limitations Note: This affects 20.04, but not 20.10+ Only buttons using the "submitcancel" class have been searched for. It is possible there are other similar issues with other button classes. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1899120/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1899120] Re: Incorrect button classes on submitcancel buttons 20.04
** Attachment added: "SEeditor-no btn class.png" https://bugs.launchpad.net/mahara/+bug/1899120/+attachment/5419843/+files/SEeditor-no%20btn%20class.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1899120 Title: Incorrect button classes on submitcancel buttons 20.04 Status in Mahara: New Bug description: Related to: https://bugs.launchpad.net/mahara/+bug/1898955 While testing the above fix I looked for "submitcancel" in .tpl files to see whether there were other cases with "btn-primary" and without "btn" class. I found the following: /htdocs/theme/raw/plugintype/artefact/file/templates/form/editfile.tpl /htdocs/theme/raw/plugintype/module/framework/templates/jsoneditor.tpl /htdocs/theme/raw/plugintype/module/multirecipientnotification/templates/indexsearch.tpl /htdocs/theme/raw/templates/privacy_modal.tpl I confirmed the first three do display incorrect styling for the submitcancel button group. Screenshots below. Limitations Note: This affects 20.04, but not 20.10+ Only buttons using the "submitcancel" class have been searched for. It is possible there are other similar issues with other button classes. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1899120/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1899120] Re: Incorrect button classes on submitcancel buttons 20.04
** Attachment added: "inbox_notifications.png" https://bugs.launchpad.net/mahara/+bug/1899120/+attachment/5419842/+files/inbox_notifications.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1899120 Title: Incorrect button classes on submitcancel buttons 20.04 Status in Mahara: New Bug description: Related to: https://bugs.launchpad.net/mahara/+bug/1898955 While testing the above fix I looked for "submitcancel" in .tpl files to see whether there were other cases with "btn-primary" and without "btn" class. I found the following: /htdocs/theme/raw/plugintype/artefact/file/templates/form/editfile.tpl /htdocs/theme/raw/plugintype/module/framework/templates/jsoneditor.tpl /htdocs/theme/raw/plugintype/module/multirecipientnotification/templates/indexsearch.tpl /htdocs/theme/raw/templates/privacy_modal.tpl I confirmed the first three do display incorrect styling for the submitcancel button group. Screenshots below. Limitations Note: This affects 20.04, but not 20.10+ Only buttons using the "submitcancel" class have been searched for. It is possible there are other similar issues with other button classes. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1899120/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1898955] Re: Add collection process missing button styles
The above patch fixes this instance of the bug, however there are others. Tested on Ubuntu 18.04 Firefox Postgres 10.14 PHP 7.4 Raw and Primary School themes Mahara 20.04_STABLE Test steps: 1. Create a collection 2. On the 'Edit collection pages' page (collection/views.php) the 'Next: Edit access/ Cancel' button group has incorrect styling. (It has "btn-primary submitcancel" classes, but is missing "btn" class.) 3. Load a second instance of Mahara with the fix. Results: ✔ On the collection/views.php page the styling is correct. ✔ Checking the inspect window shows "btn" class is now present. PASSED. 4. Load 'Primary school' theme. 5. Click on 'Manage' for collection from P page. Results: ✔ Styling is correct. 6. Look for other instances of "btn-primary submitcancel" without "btn" class 7. Check those for incorrect styling. Results: More incorrect styling found. See bug #tbc -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1898955 Title: Add collection process missing button styles Status in Mahara: Fix Committed Bug description: This not a problem in 20.10+ But is a problem in 20.04 See attached image To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1898955/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1897981] Re: Leap2A import shows Countable error
After further investigation I've found there are a number of issues at
play here. My initial assumption that the import wasn't importing a
particular file is wrong, but I'll lay out the issues as I understand
them because I think there are improvements to be made:
Testing on the QA site:
I tried to import a zip file containing a leap2a export.
I saw an nginx error 413, file too large.
I extracted the zip and tried to import the leap2a.xml thinking it would look
in the files folder for the files.
It looked like it worked because all the info from the xml was loaded. There is
no error saying you must import a zip. On the page it doesn't say you should
import a zip.
When I pressed import, the error message showed up.
There should be an exception displayed at this point, probably for all of the
files that didn't import. What happens is you see an error message which is
thrown by the exception that the artefact can't be found. See the following:
if (is_null($artefacts) || count($artefacts) != 1) {
// This can happen if a Leap2A xml file is uploaded that refers to
// files that (naturally) weren't uploaded with it.
log_debug("Warning: fixref was expecting one artefact to have been
imported by entry {$hrefsrc} but seems to have gotten " . count($artefacts));
return $hrefsrc;
}
The file doesn't exist and $artefacts is null. The check for is_null
triggers the log_debug to run, but the log_debug has a call to count(),
which will generate a php error as you can't call count on null. We
should adapt this message to avoid calling count() on null.
Testing on my local environment:
There are two potential traps here:
1. For some reason, I didn't have php7.x-zip installed, which meant I thought I
was supposed to extract the zip before trying to upload. Having rectified that,
I was able to upload the file without errors.
2. If you failed to change your php.ini settings to allow file upload above a
certain size, you won't be able to upload the zip.
These two things would be out of the hands of a regular user. It would
be nice to see an error message about php-zip not being installed
though.
Summary:
Things to fix:
The exception above which is thrown when an artefact is not found should not
generate an error message.
Feature requests related to this (need review):
1. Message on the import page that says you should be uploading a zip archive
2. If php-zip is looked for and not found, an error message would be nice.
3. QA Mahara seems to have a very low file upload limit set in Nginx. It would
be good to bump this to at least 32MB in line with what we use typically in dev
set-up for apache2.
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1897981
Title:
Leap2A import shows Countable error
Status in Mahara:
Confirmed
Status in Mahara 20.10 series:
Confirmed
Status in Mahara 21.04 series:
In Progress
Bug description:
Using QA Mahara with the following settings on Windows:
PHP 7.4
Postgres 10.9
Skins enabled
Individual themes enabled
Pre-populated data
Maroon theme
Chrome
Steps taken:
1. Log in as a regular person
2. Import a leap2a file
Expected:
You see:
Your portfolio was imported successfully
Actual
The portfolio imports, but there is the following error, which was a PHP 7.2
change to count()(see screenshot):
[WAR] f7 (import/leap/lib.php:1774) count(): Parameter must be an array or an
object that implements Countable
Call stack (most recent first):
log_message("count(): Parameter must be an array or an object t...", 8, true,
true, "/var/www/mahara/htdocs/import/leap/lib.php", 1774) at
/var/www/mahara/htdocs/lib/errors.php:521
error(2, "count(): Parameter must be an array or an object t...",
"/var/www/mahara/htdocs/import/leap/lib.php", 1774, array(size 3)) at
/var/www/mahara/htdocs/import/leap/lib.php:1774
PluginImportLeap->_fixref("portfolio:artefact110") at
/var/www/mahara/htdocs/import/leap/lib.php:1721
PluginImportLeap->fix_artefact_reference(" fix_artefact_references(object(stdClass)) at
/var/www/mahara/htdocs/import/leap/lib.php:344
PluginImportLeap->do_import_from_requests() at
/var/www/mahara/htdocs/import/index.php:314
do_import() at /var/www/mahara/htdocs/import/index.php:71
[DBG] f7 (import/leap/lib.php:1774) Warning: fixref was expecting one
artefact to have been imported by entry portfolio:artefact110 but seems to have
gotten 0
This needs some investigation to see what the $artefact variable contains at
the time count is called on it:
$artefacts = $this->get_artefactids_imported_by_entryid($hrefsrc);
if (is_null($artefacts) || count($artefacts) != 1) {
// This can
[Mahara-contributors] [Bug 1897981] Re: Leap2A import shows Countable error
Importing that particular Leap2A shows the error in both 20.04 and 19.10 with
these conditions:
Ubuntu 18.04
PHP 7.2
Firefox
Postgres 10.14
The error is happening importing a particular png image which is in a journal.
The entry imports, but without the image.
I then tested the following:
1. Make a new journal entry including the image
2. Create a page
3. Add a journal block with the new entry in it.
4. Confirm it displays correctly
5. Export that page only.
Expected:
Page exports including image
Actual:
Page hangs on export
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1897981
Title:
Leap2A import shows Countable error
Status in Mahara:
Confirmed
Status in Mahara 20.10 series:
Confirmed
Status in Mahara 21.04 series:
Confirmed
Bug description:
Using QA Mahara with the following settings on Windows:
PHP 7.4
Postgres 10.9
Skins enabled
Individual themes enabled
Pre-populated data
Maroon theme
Chrome
Steps taken:
1. Log in as a regular person
2. Import a leap2a file
Expected:
You see:
Your portfolio was imported successfully
Actual
The portfolio imports, but there is the following error, which was a PHP 7.2
change to count()(see screenshot):
[WAR] f7 (import/leap/lib.php:1774) count(): Parameter must be an array or an
object that implements Countable
Call stack (most recent first):
log_message("count(): Parameter must be an array or an object t...", 8, true,
true, "/var/www/mahara/htdocs/import/leap/lib.php", 1774) at
/var/www/mahara/htdocs/lib/errors.php:521
error(2, "count(): Parameter must be an array or an object t...",
"/var/www/mahara/htdocs/import/leap/lib.php", 1774, array(size 3)) at
/var/www/mahara/htdocs/import/leap/lib.php:1774
PluginImportLeap->_fixref("portfolio:artefact110") at
/var/www/mahara/htdocs/import/leap/lib.php:1721
PluginImportLeap->fix_artefact_reference(" fix_artefact_references(object(stdClass)) at
/var/www/mahara/htdocs/import/leap/lib.php:344
PluginImportLeap->do_import_from_requests() at
/var/www/mahara/htdocs/import/index.php:314
do_import() at /var/www/mahara/htdocs/import/index.php:71
[DBG] f7 (import/leap/lib.php:1774) Warning: fixref was expecting one
artefact to have been imported by entry portfolio:artefact110 but seems to have
gotten 0
This needs some investigation to see what the $artefact variable contains at
the time count is called on it:
$artefacts = $this->get_artefactids_imported_by_entryid($hrefsrc);
if (is_null($artefacts) || count($artefacts) != 1) {
// This can happen if a Leap2A xml file is uploaded that refers to
// files that (naturally) weren't uploaded with it.
log_debug("Warning: fixref was expecting one artefact to have
been imported by entry {$hrefsrc} but seems to have gotten " .
count($artefacts));
return $hrefsrc;
It looks like it probably contains a number, which won't work with PHP
7.2 and later, it needs to be an array or object from memory. For more
info see: https://www.php.net/manual/en/function.count.php
Note: have not tested on 20.04 to see if this is a regression.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1897981/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1898002] Re: Tinymce on Android does not save input
And on a second try it worked as expected ** Changed in: mahara Status: New => Incomplete ** Changed in: mahara Milestone: 20.10rc2 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1898002 Title: Tinymce on Android does not save input Status in Mahara: Incomplete Bug description: Using master.dev Samsung Galaxy TabA Chrome Primary School theme Steps taken: 1. Logged in as admin 2. Masquerade as Alice User1 on Rangi's Rātā inst 3. Go to a page 4. Use the Tinymce mobile editor to add a comment Expected: Once finished commenting I can click the back arrow to go back to the main page and my comment will be shown. Actual: Pressing the back arrow brings up a warning that my content may not be saved. I cancel but cannot see a way to save it. I choose Leave and when I return to the main page, my comment is not saved. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1898002/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1898002] [NEW] Tinymce on Android does not save input
Public bug reported: Using master.dev Samsung Galaxy TabA Chrome Primary School theme Steps taken: 1. Logged in as admin 2. Masquerade as Alice User1 on Rangi's Rātā inst 3. Go to a page 4. Use the Tinymce mobile editor to add a comment Expected: Once finished commenting I can click the back arrow to go back to the main page and my comment will be shown. Actual: Pressing the back arrow brings up a warning that my content may not be saved. I cancel but cannot see a way to save it. I choose Leave and when I return to the main page, my comment is not saved. ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1898002 Title: Tinymce on Android does not save input Status in Mahara: New Bug description: Using master.dev Samsung Galaxy TabA Chrome Primary School theme Steps taken: 1. Logged in as admin 2. Masquerade as Alice User1 on Rangi's Rātā inst 3. Go to a page 4. Use the Tinymce mobile editor to add a comment Expected: Once finished commenting I can click the back arrow to go back to the main page and my comment will be shown. Actual: Pressing the back arrow brings up a warning that my content may not be saved. I cancel but cannot see a way to save it. I choose Leave and when I return to the main page, my comment is not saved. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1898002/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1897998] [NEW] Add account failed on Android
Public bug reported: Using master.dev Samsung Galaxy TabA Chrome Steps taken: 1. Add a person 2. Go through the form to add an admin account for myself. 3. Selected 'General account options' to check settings 4. Switch on 'Multiple journals' 5. Go back to main page Expected: Settings are saved and I can add the account Actual: See a warning that if I leave the page my settings will be lost, however, as what I see is just the General settings which would appear in a modal if on a desktop and there is no save option, I choose Leave. All my input is lost and the account is not created. Screenshots available - currently on the device. NB: Currently assigned to 20.10RC2, however not confirmed regression. ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1897998 Title: Add account failed on Android Status in Mahara: New Bug description: Using master.dev Samsung Galaxy TabA Chrome Steps taken: 1. Add a person 2. Go through the form to add an admin account for myself. 3. Selected 'General account options' to check settings 4. Switch on 'Multiple journals' 5. Go back to main page Expected: Settings are saved and I can add the account Actual: See a warning that if I leave the page my settings will be lost, however, as what I see is just the General settings which would appear in a modal if on a desktop and there is no save option, I choose Leave. All my input is lost and the account is not created. Screenshots available - currently on the device. NB: Currently assigned to 20.10RC2, however not confirmed regression. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1897998/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1897985] [NEW] Google book block not displaying content
Public bug reported: Possibly related to: https://bugs.launchpad.net/mahara/+bug/1287350 Using QA Mahara with the following settings on Windows: PHP 7.4 Postgres 10.9 Skins enabled Individual themes enabled Pre-populated data Maroon theme Chrome Steps taken: 1. Log in as a regular person 2. Add a Google Apps block with the following embed link: https://books.google.co.nz/books?id=lqYGCwAAQBAJ=PP1=PA4=embed; width=500 height=500> Expected: The block displays the book page as at https://books.google.co.nz/books?id=lqYGCwAAQBAJ=PP1=PA4 Actual: The block is blank ** Affects: mahara Importance: Undecided Status: New ** Tags: regression ** Tags added: regression ** Tags removed: reg -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1897985 Title: Google book block not displaying content Status in Mahara: New Bug description: Possibly related to: https://bugs.launchpad.net/mahara/+bug/1287350 Using QA Mahara with the following settings on Windows: PHP 7.4 Postgres 10.9 Skins enabled Individual themes enabled Pre-populated data Maroon theme Chrome Steps taken: 1. Log in as a regular person 2. Add a Google Apps block with the following embed link: https://books.google.co.nz/books?id=lqYGCwAAQBAJ=PP1=PA4=embed; width=500 height=500> Expected: The block displays the book page as at https://books.google.co.nz/books?id=lqYGCwAAQBAJ=PP1=PA4 Actual: The block is blank To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1897985/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1897985] Re: Google book block not displaying content
** Attachment added: "FireShot Capture 127 - Image only page - Mahara - 2010rc1release-66465.qa.mahara.org.png" https://bugs.launchpad.net/mahara/+bug/1897985/+attachment/5415863/+files/FireShot%20Capture%20127%20-%20Image%20only%20page%20-%20Mahara%20-%202010rc1release-66465.qa.mahara.org.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1897985 Title: Google book block not displaying content Status in Mahara: New Bug description: Possibly related to: https://bugs.launchpad.net/mahara/+bug/1287350 Using QA Mahara with the following settings on Windows: PHP 7.4 Postgres 10.9 Skins enabled Individual themes enabled Pre-populated data Maroon theme Chrome Steps taken: 1. Log in as a regular person 2. Add a Google Apps block with the following embed link: https://books.google.co.nz/books?id=lqYGCwAAQBAJ=PP1=PA4=embed; width=500 height=500> Expected: The block displays the book page as at https://books.google.co.nz/books?id=lqYGCwAAQBAJ=PP1=PA4 Actual: The block is blank To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1897985/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1897981] [NEW] Leap2A import shows Countable error
Public bug reported:
Using QA Mahara with the following settings on Windows:
PHP 7.4
Postgres 10.9
Skins enabled
Individual themes enabled
Pre-populated data
Maroon theme
Chrome
Steps taken:
1. Log in as a regular person
2. Import a leap2a file
Expected:
You see:
Your portfolio was imported successfully
Actual
The portfolio imports, but there is the following error, which was a PHP 7.2
change to count()(see screenshot):
[WAR] f7 (import/leap/lib.php:1774) count(): Parameter must be an array or an
object that implements Countable
Call stack (most recent first):
log_message("count(): Parameter must be an array or an object t...", 8, true,
true, "/var/www/mahara/htdocs/import/leap/lib.php", 1774) at
/var/www/mahara/htdocs/lib/errors.php:521
error(2, "count(): Parameter must be an array or an object t...",
"/var/www/mahara/htdocs/import/leap/lib.php", 1774, array(size 3)) at
/var/www/mahara/htdocs/import/leap/lib.php:1774
PluginImportLeap->_fixref("portfolio:artefact110") at
/var/www/mahara/htdocs/import/leap/lib.php:1721
PluginImportLeap->fix_artefact_reference(" fix_artefact_references(object(stdClass)) at
/var/www/mahara/htdocs/import/leap/lib.php:344
PluginImportLeap->do_import_from_requests() at
/var/www/mahara/htdocs/import/index.php:314
do_import() at /var/www/mahara/htdocs/import/index.php:71
[DBG] f7 (import/leap/lib.php:1774) Warning: fixref was expecting one artefact
to have been imported by entry portfolio:artefact110 but seems to have gotten 0
This needs some investigation to see what the $artefact variable contains at
the time count is called on it:
$artefacts = $this->get_artefactids_imported_by_entryid($hrefsrc);
if (is_null($artefacts) || count($artefacts) != 1) {
// This can happen if a Leap2A xml file is uploaded that refers to
// files that (naturally) weren't uploaded with it.
log_debug("Warning: fixref was expecting one artefact to have been
imported by entry {$hrefsrc} but seems to have gotten " . count($artefacts));
return $hrefsrc;
It looks like it probably contains a number, which won't work with PHP
7.2 and later, it needs to be an array or object from memory. For more
info see: https://www.php.net/manual/en/function.count.php
Note: have not tested on 20.04 to see if this is a regression.
** Affects: mahara
Importance: Undecided
Status: New
** Attachment added: "FireShot Capture 124 - Import your portfolio - Mahara -
2010rc1release-66465.qa.mahara.org.png"
https://bugs.launchpad.net/bugs/1897981/+attachment/5415862/+files/FireShot%20Capture%20124%20-%20Import%20your%20portfolio%20-%20Mahara%20-%202010rc1release-66465.qa.mahara.org.png
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1897981
Title:
Leap2A import shows Countable error
Status in Mahara:
New
Bug description:
Using QA Mahara with the following settings on Windows:
PHP 7.4
Postgres 10.9
Skins enabled
Individual themes enabled
Pre-populated data
Maroon theme
Chrome
Steps taken:
1. Log in as a regular person
2. Import a leap2a file
Expected:
You see:
Your portfolio was imported successfully
Actual
The portfolio imports, but there is the following error, which was a PHP 7.2
change to count()(see screenshot):
[WAR] f7 (import/leap/lib.php:1774) count(): Parameter must be an array or an
object that implements Countable
Call stack (most recent first):
log_message("count(): Parameter must be an array or an object t...", 8, true,
true, "/var/www/mahara/htdocs/import/leap/lib.php", 1774) at
/var/www/mahara/htdocs/lib/errors.php:521
error(2, "count(): Parameter must be an array or an object t...",
"/var/www/mahara/htdocs/import/leap/lib.php", 1774, array(size 3)) at
/var/www/mahara/htdocs/import/leap/lib.php:1774
PluginImportLeap->_fixref("portfolio:artefact110") at
/var/www/mahara/htdocs/import/leap/lib.php:1721
PluginImportLeap->fix_artefact_reference(" fix_artefact_references(object(stdClass)) at
/var/www/mahara/htdocs/import/leap/lib.php:344
PluginImportLeap->do_import_from_requests() at
/var/www/mahara/htdocs/import/index.php:314
do_import() at /var/www/mahara/htdocs/import/index.php:71
[DBG] f7 (import/leap/lib.php:1774) Warning: fixref was expecting one
artefact to have been imported by entry portfolio:artefact110 but seems to have
gotten 0
This needs some investigation to see what the $artefact variable contains at
the time count is called on it:
$artefacts = $this->get_artefactids_imported_by_entryid($hrefsrc);
if (is_null($artefacts) || count($artefacts) != 1) {
// This can happen if a Leap2A xml file is uploaded that refers to
// files that (naturally)
[Mahara-contributors] [Bug 1897831] Re: Pixel bump in diagonal maroon theme line at certain screen heights
I had a look again, and at least in Windows on Chrome, refreshing the page does not resolve this. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1897831 Title: Pixel bump in diagonal maroon theme line at certain screen heights Status in Mahara: Confirmed Bug description: Using QA Mahara with the following settings on Windows: PHP 7.4 Postgres 10.9 Skins enabled Individual themes enabled Pre-populated data Maroon theme Steps Log in. Change the height of the window up and down Expected Page renders smoothly Actual Header bottom diagonal shows some fuzziness and a bump in the middle (see screenshot) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1897831/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1897829] Re: 20.10RC1: Choosing details in image gallery opens a blank modal
I have done some more investigation and confirmed this as a regression:
In 20.04_STABLE the modal opens with the images and download links (see
screenshot).
Inspecting the html shows no difference, but the request repsonse from
opening the modal shows the following console error in 20.10:
1 request
277 B / 789 B transferred
Finish: 38 ms
error true
error_number400
error_name "ParameterException"
error_class "ParameterException"
error_message "The 'artefactid' parameter is not an integer"
error_rendered "A required parameter is missing or malformed\n\nThe
'artefactid' parameter is not an integer"
compared with a working response below:
1 request
8.74 KB / 9.30 KB transferred
Finish: 77 ms
error false
message Object { title: "Placeholder", html: "\n\n\n\n\n \n \n Folder contents:\n
\n\n \n \n \n \n
\n Download image [www.imagesplitter.net](1).jpeg
[19.2K]\n \n \n \n \n \n \n \n
\n\n\n\n jQuery('#configureblock .modal_link').off('click');\n
jQuery('#configureblock .modal_link').on('click', function(e) {\n
open_modal(e);\n toggleDetailsBtn();\n });\n\n", message: "" }
message ""
title "Placeholder"
html"\n\n\n\n\n \n \n Folder contents:\n \n\n \n \n \n \n \n Download image [www.imagesplitter.net](1).jpeg
[19.2K]\n \n \n \n \n \n \n \n
\n\n\n\n jQuery('#configureblock .modal_link').off('click');\n
jQuery('#configureblock .modal_link').on('click', function(e) {\n
open_modal(e);\n toggleDetailsBtn();\n });\n\n"
returnCode 0
** Attachment added: "correct gallery modal.png"
https://bugs.launchpad.net/mahara/+bug/1897829/+attachment/5415849/+files/correct%20gallery%20modal.png
** Changed in: mahara
Milestone: None => 20.10rc2
** Tags added: regression
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1897829
Title:
20.10RC1: Choosing details in image gallery opens a blank modal
Status in Mahara:
New
Bug description:
Using QA Mahara with the following settings on Windows:
PHP 7.4
Postgres 10.9
Skins enabled
Individual themes enabled
Pre-populated data
Maroon theme
Also exists in master on Ubuntu 18.10 and postgres with Ocean theme
Steps:
As a person with a page, add an image gallery with 5 images.
Save the page and display it.
Click the magnifying glass icon and the resulting details icon
Expected:
A modal appears with details of the image gallery block
Actual:
A blank modal appears
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1897829/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1897831] [NEW] 20.10RC1: pixel bump in diagonal maroon theme line at certain screen heights
Public bug reported: Using QA Mahara with the following settings on Windows: PHP 7.4 Postgres 10.9 Skins enabled Individual themes enabled Pre-populated data Maroon theme Steps Log in. Change the height of the window up and down Expected Page renders smoothly Actual Header bottom diagonal shows some fuzziness and a bump in the middle (see screenshot) ** Affects: mahara Importance: Undecided Status: New ** Attachment added: "Header bump.png" https://bugs.launchpad.net/bugs/1897831/+attachment/5415471/+files/Header%20bump.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1897831 Title: 20.10RC1: pixel bump in diagonal maroon theme line at certain screen heights Status in Mahara: New Bug description: Using QA Mahara with the following settings on Windows: PHP 7.4 Postgres 10.9 Skins enabled Individual themes enabled Pre-populated data Maroon theme Steps Log in. Change the height of the window up and down Expected Page renders smoothly Actual Header bottom diagonal shows some fuzziness and a bump in the middle (see screenshot) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1897831/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1897829] [NEW] 20.10RC1: Choosing details in image gallery opens a blank modal
Public bug reported: Using QA Mahara with the following settings on Windows: PHP 7.4 Postgres 10.9 Skins enabled Individual themes enabled Pre-populated data Maroon theme Also exists in master on Ubuntu 18.10 and postgres with Ocean theme Steps: As a person with a page, add an image gallery with 5 images. Save the page and display it. Click the magnifying glass icon and the resulting details icon Expected: A modal appears with details of the image gallery block Actual: A blank modal appears ** Affects: mahara Importance: Undecided Status: New ** Attachment added: "FireShot Capture 056 - kfjel;kaj;fj;lsjUntitled - Mahara - master-20224.qa.mahara.org.png" https://bugs.launchpad.net/bugs/1897829/+attachment/5415470/+files/FireShot%20Capture%20056%20-%20kfjel%3Bkaj%3Bfj%3BlsjUntitled%20-%20Mahara%20-%20master-20224.qa.mahara.org.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1897829 Title: 20.10RC1: Choosing details in image gallery opens a blank modal Status in Mahara: New Bug description: Using QA Mahara with the following settings on Windows: PHP 7.4 Postgres 10.9 Skins enabled Individual themes enabled Pre-populated data Maroon theme Also exists in master on Ubuntu 18.10 and postgres with Ocean theme Steps: As a person with a page, add an image gallery with 5 images. Save the page and display it. Click the magnifying glass icon and the resulting details icon Expected: A modal appears with details of the image gallery block Actual: A blank modal appears To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1897829/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1897811] [NEW] 2010RC1: Comment ratings don't appear filled in
Public bug reported: Using QA Mahara with the following settings on Windows: PHP 7.4 Postgres 10.9 Skins enabled Individual themes enabled Pre-populated data Maroon theme Steps taken: Log in as admin Enable comment ratings in Extensions - comment (12 thumbs up) Log in as a member of an institution (member1) Add a comment to page and a rating of 6 thumbs up Save the comment. Expected: 6 thumbs up displayed on page Actual: No thumbs up are filled in. Additional steps: Share the page with their institution Log in as another institution member (member2) View member1's page Expected: 6 thumbs up displayed on comment Actual: No thumbs up displayed Additional steps: Add a comment and rate it 10 thumbs up. The rating was not displayed. I also re-logged in as admin and changed the rating system to 6 purple stars. Again, the purple stars always appeared empty on the page, despite the number of stars being saved correctly in the edit comment screen. ** Affects: mahara Importance: Undecided Status: New ** Attachment added: "FireShot Capture 094 - Page85 - Mahara - 2010rc1release-10896.qa.mahara.org.png" https://bugs.launchpad.net/bugs/1897811/+attachment/5415423/+files/FireShot%20Capture%20094%20-%20Page85%20-%20Mahara%20-%202010rc1release-10896.qa.mahara.org.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1897811 Title: 2010RC1: Comment ratings don't appear filled in Status in Mahara: New Bug description: Using QA Mahara with the following settings on Windows: PHP 7.4 Postgres 10.9 Skins enabled Individual themes enabled Pre-populated data Maroon theme Steps taken: Log in as admin Enable comment ratings in Extensions - comment (12 thumbs up) Log in as a member of an institution (member1) Add a comment to page and a rating of 6 thumbs up Save the comment. Expected: 6 thumbs up displayed on page Actual: No thumbs up are filled in. Additional steps: Share the page with their institution Log in as another institution member (member2) View member1's page Expected: 6 thumbs up displayed on comment Actual: No thumbs up displayed Additional steps: Add a comment and rate it 10 thumbs up. The rating was not displayed. I also re-logged in as admin and changed the rating system to 6 purple stars. Again, the purple stars always appeared empty on the page, despite the number of stars being saved correctly in the edit comment screen. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1897811/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1897670] Re: 2010RC1: Skins in maroon theme
** Description changed: Using QA Mahara with the following settings on Windows: PHP 7.4 Postgres 10.9 Skins enabled Individual themes enabled Pre-populated data + Maroon theme + Steps taken: Create a skin with the following: - Header background image - Page background image - Background image repeat: Repeat both directions - Background image attachment: Scroll - Background image position: Top left + Background image repeat: Repeat both directions + Background image attachment: Scroll + Background image position: Top left Save and apply to a page. The page background image stops in a horizontal line before it reaches either the header or the footer. (See screenshot) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1897670 Title: 2010RC1: Skins in maroon theme Status in Mahara: New Bug description: Using QA Mahara with the following settings on Windows: PHP 7.4 Postgres 10.9 Skins enabled Individual themes enabled Pre-populated data Maroon theme Steps taken: Create a skin with the following: - Header background image - Page background image Background image repeat: Repeat both directions Background image attachment: Scroll Background image position: Top left Save and apply to a page. The page background image stops in a horizontal line before it reaches either the header or the footer. (See screenshot) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1897670/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1897678] [NEW] 20.10RC1: In page with skin applied, 'More options' menu doesn't show
Public bug reported: Using QA Mahara with the following settings on Windows: PHP 7.4 Postgres 10.9 Skins enabled Individual themes enabled Pre-populated data Maroon theme following the set-up here: https://bugs.launchpad.net/mahara/+bug/1897670 Click the 3 dots button to create a timeline. Expected: More options opens a menu Actual: Nothing happens - no menu is displayed NB: To be confirmed as my testing environment shut down around this time too, although I did confirm that on a page without a skin, the menu was visible. ** Affects: mahara Importance: Undecided Status: New ** Description changed: Using QA Mahara with the following settings on Windows: PHP 7.4 Postgres 10.9 Skins enabled Individual themes enabled Pre-populated data + Maroon theme following the set-up here: https://bugs.launchpad.net/mahara/+bug/1897670 Click the 3 dots button to create a timeline. Expected: More options opens a menu Actual: Nothing happens - no menu is displayed NB: To be confirmed as my testing environment shut down around this time too, although I did confirm that on a page without a skin, the menu was visible. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1897678 Title: 20.10RC1: In page with skin applied, 'More options' menu doesn't show Status in Mahara: New Bug description: Using QA Mahara with the following settings on Windows: PHP 7.4 Postgres 10.9 Skins enabled Individual themes enabled Pre-populated data Maroon theme following the set-up here: https://bugs.launchpad.net/mahara/+bug/1897670 Click the 3 dots button to create a timeline. Expected: More options opens a menu Actual: Nothing happens - no menu is displayed NB: To be confirmed as my testing environment shut down around this time too, although I did confirm that on a page without a skin, the menu was visible. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1897678/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1897670] [NEW] 2010RC1: Skins in maroon theme
Public bug reported: Using QA Mahara with the following settings on Windows: PHP 7.4 Postgres 10.9 Skins enabled Individual themes enabled Pre-populated data Steps taken: Create a skin with the following: - Header background image - Page background image Background image repeat: Repeat both directions Background image attachment: Scroll Background image position: Top left Save and apply to a page. The page background image stops in a horizontal line before it reaches either the header or the footer. (See screenshot) ** Affects: mahara Importance: Undecided Status: New ** Attachment added: "FireShot Capture 079 - New page - Mahara - 2010rc1release-3689.qa.mahara.org.png" https://bugs.launchpad.net/bugs/1897670/+attachment/5415123/+files/FireShot%20Capture%20079%20-%20New%20page%20-%20Mahara%20-%202010rc1release-3689.qa.mahara.org.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1897670 Title: 2010RC1: Skins in maroon theme Status in Mahara: New Bug description: Using QA Mahara with the following settings on Windows: PHP 7.4 Postgres 10.9 Skins enabled Individual themes enabled Pre-populated data Steps taken: Create a skin with the following: - Header background image - Page background image Background image repeat: Repeat both directions Background image attachment: Scroll Background image position: Top left Save and apply to a page. The page background image stops in a horizontal line before it reaches either the header or the footer. (See screenshot) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1897670/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1897641] [NEW] 2010RC1: maroon theme for profile sideblock poor contrast
Public bug reported: Using QA Mahara with the following settings on Windows: PHP 7.4 Postgres 10.9 Skins enabled Individual themes enabled Pre-populated data Steps taken: Log in Change to Maroon theme Masquerade as another user Become admin again Expected: Account settings page displays with profile sideblock information easily readable. Actual: 'Log in as this person' and 'Suspend or delete this account' links are a similar colour to the background. (See screenshot) ** Affects: mahara Importance: Undecided Status: New ** Attachment added: "contrast-sideblock.png" https://bugs.launchpad.net/bugs/1897641/+attachment/5415056/+files/contrast-sideblock.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1897641 Title: 2010RC1: maroon theme for profile sideblock poor contrast Status in Mahara: New Bug description: Using QA Mahara with the following settings on Windows: PHP 7.4 Postgres 10.9 Skins enabled Individual themes enabled Pre-populated data Steps taken: Log in Change to Maroon theme Masquerade as another user Become admin again Expected: Account settings page displays with profile sideblock information easily readable. Actual: 'Log in as this person' and 'Suspend or delete this account' links are a similar colour to the background. (See screenshot) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1897641/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1897640] [NEW] 2010RC1: Error message on inst settings page
Public bug reported:
Using QA Mahara with the following settings on Windows:
PHP 7.4
Postgres 10.9
Skins enabled
Individual themes enabled
Pre-populated data
Steps taken:
Log in
Change to Maroon theme
Masquerade as another user
Become admin again
Go to Admin -> Institutions -> Settings
Click the settings cog on an institution
Expected:
Settings are displayed without error
Actual:
[WAR] 82 (lib/pieforms/pieform.php:1424) Invalid value for select
"showonlineusers"
Call stack (most recent first):
log_message("Invalid value for select "showonlineusers"", 8, true, true,
"/var/www/mahara/htdocs/lib/pieforms/pieform.php", 1424) at
/var/www/mahara/htdocs/lib/errors.php:521
error(1024, "Invalid value for select "showonlineusers"",
"/var/www/mahara/htdocs/lib/pieforms/pieform.php", 1424, array(size 1)) at
Unknown:0
trigger_error("Invalid value for select "showonlineusers"", 1024) at
/var/www/mahara/htdocs/lib/pieforms/pieform.php:1424
Pieform::info("Invalid value for select "showonlineusers"") at
/var/www/mahara/htdocs/lib/pieforms/pieform/elements/select.php:152
pieform_element_select(object(Pieform), array(size 12)) at
/var/www/mahara/htdocs/lib/pieforms/pieform.php:1601
Pieform->build_element_html(array(size 12)) at
/var/www/mahara/htdocs/lib/pieforms/pieform.php:762
Pieform->build() at /var/www/mahara/htdocs/lib/pieforms/pieform.php:173
Pieform::process(array(size 5)) at /var/www/mahara/htdocs/lib/mahara.php:5506
pieform(array(size 5)) at
/var/www/mahara/htdocs/admin/users/institutions.php:698
** Affects: mahara
Importance: Undecided
Status: New
** Attachment added: "FireShot Capture 068 - Institutions - Mahara -
2010rc1release-3689.qa.mahara.org.png"
https://bugs.launchpad.net/bugs/1897640/+attachment/5415055/+files/FireShot%20Capture%20068%20-%20Institutions%20-%20Mahara%20-%202010rc1release-3689.qa.mahara.org.png
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1897640
Title:
2010RC1: Error message on inst settings page
Status in Mahara:
New
Bug description:
Using QA Mahara with the following settings on Windows:
PHP 7.4
Postgres 10.9
Skins enabled
Individual themes enabled
Pre-populated data
Steps taken:
Log in
Change to Maroon theme
Masquerade as another user
Become admin again
Go to Admin -> Institutions -> Settings
Click the settings cog on an institution
Expected:
Settings are displayed without error
Actual:
[WAR] 82 (lib/pieforms/pieform.php:1424) Invalid value for select
"showonlineusers"
Call stack (most recent first):
log_message("Invalid value for select "showonlineusers"", 8, true, true,
"/var/www/mahara/htdocs/lib/pieforms/pieform.php", 1424) at
/var/www/mahara/htdocs/lib/errors.php:521
error(1024, "Invalid value for select "showonlineusers"",
"/var/www/mahara/htdocs/lib/pieforms/pieform.php", 1424, array(size 1)) at
Unknown:0
trigger_error("Invalid value for select "showonlineusers"", 1024) at
/var/www/mahara/htdocs/lib/pieforms/pieform.php:1424
Pieform::info("Invalid value for select "showonlineusers"") at
/var/www/mahara/htdocs/lib/pieforms/pieform/elements/select.php:152
pieform_element_select(object(Pieform), array(size 12)) at
/var/www/mahara/htdocs/lib/pieforms/pieform.php:1601
Pieform->build_element_html(array(size 12)) at
/var/www/mahara/htdocs/lib/pieforms/pieform.php:762
Pieform->build() at /var/www/mahara/htdocs/lib/pieforms/pieform.php:173
Pieform::process(array(size 5)) at /var/www/mahara/htdocs/lib/mahara.php:5506
pieform(array(size 5)) at
/var/www/mahara/htdocs/admin/users/institutions.php:698
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1897640/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1892820] Re: Behat: Add "take a screenshot" step
** Changed in: mahara
Assignee: (unassigned) => Rebecca Blundell (rjb-dev)
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892820
Title:
Behat: Add "take a screenshot" step
Status in Mahara:
Confirmed
Bug description:
It might help our regression testing if we could add screenshot steps
in tests, so that a tester could run the test suite and afterwards
check a folder of screenshots to make sure that the pages look like
they are supposed to.
We can add a step to call the Mink saveScreenshot() function. This
works:
/**
* Save a screenshot for regression testing purposes
*
* @Then I take a screenshot as :filename
*/
public function take_screenshot($filename) {
if (!$this->running_javascript()) {
return false;
}
$path = get_config('dataroot') . 'behat';
$this->saveScreenshot($filename, $path);
}
A limitation of the above is that only the part of the page that is visible
is captured. In Chrome dev-tools there is the following option:
https://www.howtogeek.com/423558/how-to-take-full-page-screenshots-in-google-chrome-without-using-an-extension/
So now I wonder whether we could write a step to utilise that functionality
rather than calling saveScreenshot as above.
Things to consider:
Will these steps be slow?
Do we need to tag tests that use them in a different way, and only run when
regression testing is required? Or some other idea?
A couple of other things to consider:
This extension: https://github.com/elvetemedve/behat-screenshot. The
discussion suggests it does provide full page capture, but it seems people are
having trouble with it:
https://github.com/elvetemedve/behat-screenshot/issues/26
There is also this one, which says it bypasses selenium and uses
chrome directly with a reduction of overhead: https://gitlab.com/DMore
/behat-chrome-extension (this is probably heading out of scope for the
screenshot problem, but is an interesting idea, particularly as it
apparently reduces test time by at least 2/3rds.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892820/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1897190] [NEW] Behat: Tidy up and improve behat properties file
Public bug reported:
Background:
A while ago we set up a behat 'properties' file to hold css/xpath
locators so they wouldn't need to be included directly in steps. When
that was implemented, all the steps that included css/xpath references
were taken out and replaced with the steps that call the properties
file.
The original idea was that as new things needed to be found by the test
suite, they would be added to the properties file and it would gradually
grow to cover more of the site.
Now:
Steps that call the css/xpaths directly have been appearing back in the
tests, rather than being added to the properties file as they are
needed. This is probably just because it is faster to not add the
locator to the properties file and just call it directly in the test.
Issues:
1. Adding the locators directly to tests means they are harder to read.
2. Currently the properties file is hard to read. It has different locators
from anywhere in the site put into one array, so you can't easily see whether a
locator for the item you want already exists.
3. The properties file could use a refactor. We were supporting an old PHP
without constant arrays and constant multi-dimensional arrays when it was
written.
4. It is faster to write a test with the locators directly than adding the
locator to the properties file, so test writers may still not use it.
Suggested solutions to issues:
1. Refactor existing tests with css/xpath locators to use the properties file.
2,3. Update the properties file so that it has different arrays or a single
multi-dimensional array with sections related to components of the site,
something like:
define ("HEADER", array (
'Search' =>'#usf_query',
//more things
));
define ("DASHBOARD", array (
'Static pages' => "//a[contains(@href, 'site/pages')]/b",
//more things
));
define ("FOOTER", array(
//more things
));
define ("SIDEBLOCKS", array(
//more things
));
define ("BLOCKS", array (
//more things
));
4. Spend some time adding some more locators so they are covered and don't need
to be added by the tester, as finding how to interact with an element is the
slowest part of test writing.
Consider the way the properties file is called.
- Is there an easier way than calling the properties steps?
- Could there be an underlying function that replaced passed in variables with
locators called from all existing relevant steps? (Maybe that would create
unnecessary overhead).
- If there is a way that would make it easier to use the properties file from a
dev/tester perspective, it will be used.
** Affects: mahara
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1897190
Title:
Behat: Tidy up and improve behat properties file
Status in Mahara:
New
Bug description:
Background:
A while ago we set up a behat 'properties' file to hold css/xpath
locators so they wouldn't need to be included directly in steps. When
that was implemented, all the steps that included css/xpath references
were taken out and replaced with the steps that call the properties
file.
The original idea was that as new things needed to be found by the
test suite, they would be added to the properties file and it would
gradually grow to cover more of the site.
Now:
Steps that call the css/xpaths directly have been appearing back in
the tests, rather than being added to the properties file as they are
needed. This is probably just because it is faster to not add the
locator to the properties file and just call it directly in the test.
Issues:
1. Adding the locators directly to tests means they are harder to read.
2. Currently the properties file is hard to read. It has different locators
from anywhere in the site put into one array, so you can't easily see whether a
locator for the item you want already exists.
3. The properties file could use a refactor. We were supporting an old PHP
without constant arrays and constant multi-dimensional arrays when it was
written.
4. It is faster to write a test with the locators directly than adding the
locator to the properties file, so test writers may still not use it.
Suggested solutions to issues:
1. Refactor existing tests with css/xpath locators to use the properties file.
2,3. Update the properties file so that it has different arrays or a single
multi-dimensional array with sections related to components of the site,
something like:
define ("HEADER", array (
'Search' =>'#usf_query',
//more things
));
define ("DASHBOARD", array (
'Static pages' => "//a[contains(@href, 'site/pages')]/b",
//more things
));
define ("FOOTER", array(
//more things
));
[Mahara-contributors] [Bug 1892277] Re: Behat: Smart Evidence - review automated and manual tests
** Description changed: - In the regression spreadsheet, there are the following items: + The SmartEvidence tests are not clearly defined. - 1. Change SE framework via matrix - Collection page>Annotation>click on different SE framework + In the behat tests there is overlap of functionality. + In the regression spreadsheet there are specific items that are not covered. - 2. Change SE framework via Page - Portfolio>Page>Edit page> Annotation>Standard drop down menu>click on different SE framework + Please review the following: + 1. Go through the Behat tests and see what is being tested. + - Consolidate tests where there is overlap. + - Make sure the titles of the tests and Feature sections make sense in terms of their functionality. + 2. Review what is in the regression spreadsheet for SE and either + a. Make changes to the tests to incorporate the functionality in the behat tests under this bug number, or + b. Make bug reports for changes that need to be made. - - I wasn't sure exactly what needs to be tested here, but we should be - able to add more SmartEvidence tests to Behat as needed. - - I suggest reviewing the current SE tests of which there are several: - /site_features/install_framework.feature - /site_features/annotation_and_smartevidence.feature - /site_features/institution_smartevidence.feature - /site_features/smart_evidence_editor.feature - /site_features/smart_evidence_workflow.feature - - 1. After confirming what is tested and what still needs to be covered, create bug reports for adding new functionality to behat. - 2. Update the spreadsheet to reference any changes made so that we do not revisit this again later. + 3. Update the regression spreadsheet with progress and any new bug + numbers. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1892277 Title: Behat: Smart Evidence - review automated and manual tests Status in Mahara: Confirmed Bug description: The SmartEvidence tests are not clearly defined. In the behat tests there is overlap of functionality. In the regression spreadsheet there are specific items that are not covered. Please review the following: 1. Go through the Behat tests and see what is being tested. - Consolidate tests where there is overlap. - Make sure the titles of the tests and Feature sections make sense in terms of their functionality. 2. Review what is in the regression spreadsheet for SE and either a. Make changes to the tests to incorporate the functionality in the behat tests under this bug number, or b. Make bug reports for changes that need to be made. 3. Update the regression spreadsheet with progress and any new bug numbers. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1892277/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1894933] [NEW] Behat: Logged out external links
Public bug reported: https://bugs.launchpad.net/mahara/+bug/1892950 said: "There is no automated test for public links and resources. This could be added." As this is on the manual regression testing at the moment, let's follow through and add it. Notes from spreadsheet: - public – Logged out page: external link/s &/or file/s,add/remove If I missed that this was fixed or unnecessary, please remove the bug. ** Affects: mahara Importance: Medium Assignee: Rangi Daymond (rangid) Status: Confirmed ** Tags: behat-test ** Changed in: mahara Status: New => Confirmed ** Changed in: mahara Importance: Undecided => Medium -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1894933 Title: Behat: Logged out external links Status in Mahara: Confirmed Bug description: https://bugs.launchpad.net/mahara/+bug/1892950 said: "There is no automated test for public links and resources. This could be added." As this is on the manual regression testing at the moment, let's follow through and add it. Notes from spreadsheet: - public – Logged out page: external link/s &/or file/s,add/remove If I missed that this was fixed or unnecessary, please remove the bug. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1894933/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1892993] [NEW] Behat: Open sans default font in tinymce
Public bug reported: Automating manual test. Notes from spreadsheet (20.04 WIP): Verify “opensans” is default font 1) Account menu>Profile>Introduction 2) Main menu>Create>Pages and collections>Add>Page>Page description 3) Main menu>Create>Pages and collections>Add>Page>Add Text block>Content This check can be added anywhere there is a tinymce editor on the page. One example would be the edit_journal feature. Just make a note where you put with this bug number so we know why it's there. The steps are: And I click the "Toggle toolbars on. Show full list of buttons" button in the editor And I should see "Open sans" ** Affects: mahara Importance: Undecided Assignee: Rangi Daymond (rangid) Status: New ** Tags: behat-test -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1892993 Title: Behat: Open sans default font in tinymce Status in Mahara: New Bug description: Automating manual test. Notes from spreadsheet (20.04 WIP): Verify “opensans” is default font 1) Account menu>Profile>Introduction 2) Main menu>Create>Pages and collections>Add>Page>Page description 3) Main menu>Create>Pages and collections>Add>Page>Add Text block>Content This check can be added anywhere there is a tinymce editor on the page. One example would be the edit_journal feature. Just make a note where you put with this bug number so we know why it's there. The steps are: And I click the "Toggle toolbars on. Show full list of buttons" button in the editor And I should see "Open sans" To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1892993/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1892982] [NEW] Behat: Using email in tests
Public bug reported: We don't use email in behat, but apparently we could. Here are some links to the documentation: https://docs.behat.org/en/v2.5/cookbook/intercepting_the_redirections.html#implementing-interception-steps-logic https://docs.behat.org/en/v2.5/cookbook/using_the_profiler_with_minkbundle.html We could investigate whether its possible to implement the system they suggest in Mahara's behat. It would mean that we could automate more of the test suite. ** Affects: mahara Importance: Undecided Status: New ** Tags: behat-dev -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1892982 Title: Behat: Using email in tests Status in Mahara: New Bug description: We don't use email in behat, but apparently we could. Here are some links to the documentation: https://docs.behat.org/en/v2.5/cookbook/intercepting_the_redirections.html#implementing-interception-steps-logic https://docs.behat.org/en/v2.5/cookbook/using_the_profiler_with_minkbundle.html We could investigate whether its possible to implement the system they suggest in Mahara's behat. It would mean that we could automate more of the test suite. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1892982/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891266] Re: Behat: Confirm correct dashboard elements are present
** Description changed: Automating a manual test. Copied from spreadsheet: Verify default dashboard includes the following blocks: Latest pages, My pages, Inbox, Topics I’m following (Note these titles are out of date. We need to check the current titles) Verify user can add or remove blocks via edit dashboard For this we can add to the homepage_buttons.feature. I suggest renaming it to dashboard.feature and it can be the core test for items on that page. 1. Add a scenario called "Checking default blocks are displayed". 2. As the section commented "# check for bug 1493199 name changed from “Latest pages” to “Latest changes I can view”" includes a check for that, transfer it to the new scenario. 3. Add checks for the other defaults: Inbox Topics I am following My portfolios Watched pages 4. Follow "Edit dashboard" and confirm that the blocks all contain a "Remove block" option and that all except My portfolios contain a "Configure block" option. 5. Test that the configure modal opens for one of the blocks and that you can save a change. (Note that we are not interested in this test whether the options work.) 6. Test that you can delete one of the blocks 7. Return to the dashboard and confirm the block you deleted is not displayed. + + + ADDITIONAL CHECKS: + There is another manual test that checks a different block can be added to the dashboard. We can incorporate this test too. While editing the dashboard in 4. above, add a block. + In 7. confirm that the new block is displayed. (Let's use a block for this that isn't added elsewhere.) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891266 Title: Behat: Confirm correct dashboard elements are present Status in Mahara: In Progress Bug description: Automating a manual test. Copied from spreadsheet: Verify default dashboard includes the following blocks: Latest pages, My pages, Inbox, Topics I’m following (Note these titles are out of date. We need to check the current titles) Verify user can add or remove blocks via edit dashboard For this we can add to the homepage_buttons.feature. I suggest renaming it to dashboard.feature and it can be the core test for items on that page. 1. Add a scenario called "Checking default blocks are displayed". 2. As the section commented "# check for bug 1493199 name changed from “Latest pages” to “Latest changes I can view”" includes a check for that, transfer it to the new scenario. 3. Add checks for the other defaults: Inbox Topics I am following My portfolios Watched pages 4. Follow "Edit dashboard" and confirm that the blocks all contain a "Remove block" option and that all except My portfolios contain a "Configure block" option. 5. Test that the configure modal opens for one of the blocks and that you can save a change. (Note that we are not interested in this test whether the options work.) 6. Test that you can delete one of the blocks 7. Return to the dashboard and confirm the block you deleted is not displayed. ADDITIONAL CHECKS: There is another manual test that checks a different block can be added to the dashboard. We can incorporate this test too. While editing the dashboard in 4. above, add a block. In 7. confirm that the new block is displayed. (Let's use a block for this that isn't added elsewhere.) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891266/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1892950] [NEW] Behat: Rename create_and_delete_menu_item.feature
Public bug reported: The test for 'Links and resources' is called create_and_delete_menu_item.feature which doesn't make sense. Rename it to links_and_resources.feature and at the same time review functionality. There is no automated test for public links and resources. This could be added. ** Affects: mahara Importance: Undecided Assignee: Rangi Daymond (rangid) Status: New ** Tags: behat-test -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1892950 Title: Behat: Rename create_and_delete_menu_item.feature Status in Mahara: New Bug description: The test for 'Links and resources' is called create_and_delete_menu_item.feature which doesn't make sense. Rename it to links_and_resources.feature and at the same time review functionality. There is no automated test for public links and resources. This could be added. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1892950/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1892820] Re: Behat: Add "take a screenshot" step
** Description changed:
It might help our regression testing if we could add screenshot steps in
tests, so that a tester could run the test suite and afterwards check a
folder of screenshots to make sure that the pages look like they are
supposed to.
We can add a step to call the Mink saveScreenshot() function. This
works:
- /**
- * Save a screenshot for regression testing purposes
- *
- * @Then I take a screenshot as :filename
- */
- public function take_screenshot($filename) {
- if (!$this->running_javascript()) {
- return false;
- }
- $path = get_config('dataroot') . 'behat';
- $this->saveScreenshot($filename, $path);
- }
+ /**
+ * Save a screenshot for regression testing purposes
+ *
+ * @Then I take a screenshot as :filename
+ */
+ public function take_screenshot($filename) {
+ if (!$this->running_javascript()) {
+ return false;
+ }
+ $path = get_config('dataroot') . 'behat';
+ $this->saveScreenshot($filename, $path);
+ }
A limitation of the above is that only the part of the page that is visible
is captured. In Chrome dev-tools there is the following option:
https://www.howtogeek.com/423558/how-to-take-full-page-screenshots-in-google-chrome-without-using-an-extension/
- So now I wonder whether we could write a step to utilise that functionality
rather than calling saveScreenshot as above.
+ So now I wonder whether we could write a step to utilise that functionality
rather than calling saveScreenshot as above.
Things to consider:
Will these steps be slow?
Do we need to tag tests that use them in a different way, and only run when
regression testing is required? Or some other idea?
+
+
+ A couple of other things to consider:
+
+ This extension: https://github.com/elvetemedve/behat-screenshot. The
discussion suggests it does provide full page capture, but it seems people are
having trouble with it:
https://github.com/elvetemedve/behat-screenshot/issues/26
+
+ There is also this one, which says it bypasses selenium and uses chrome
+ directly with a reduction of overhead: https://gitlab.com/DMore/behat-
+ chrome-extension (this is probably heading out of scope for the
+ screenshot problem, but is an interesting idea, particularly as it
+ apparently reduces test time by at least 2/3rds.
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892820
Title:
Behat: Add "take a screenshot" step
Status in Mahara:
Confirmed
Bug description:
It might help our regression testing if we could add screenshot steps
in tests, so that a tester could run the test suite and afterwards
check a folder of screenshots to make sure that the pages look like
they are supposed to.
We can add a step to call the Mink saveScreenshot() function. This
works:
/**
* Save a screenshot for regression testing purposes
*
* @Then I take a screenshot as :filename
*/
public function take_screenshot($filename) {
if (!$this->running_javascript()) {
return false;
}
$path = get_config('dataroot') . 'behat';
$this->saveScreenshot($filename, $path);
}
A limitation of the above is that only the part of the page that is visible
is captured. In Chrome dev-tools there is the following option:
https://www.howtogeek.com/423558/how-to-take-full-page-screenshots-in-google-chrome-without-using-an-extension/
So now I wonder whether we could write a step to utilise that functionality
rather than calling saveScreenshot as above.
Things to consider:
Will these steps be slow?
Do we need to tag tests that use them in a different way, and only run when
regression testing is required? Or some other idea?
A couple of other things to consider:
This extension: https://github.com/elvetemedve/behat-screenshot. The
discussion suggests it does provide full page capture, but it seems people are
having trouble with it:
https://github.com/elvetemedve/behat-screenshot/issues/26
There is also this one, which says it bypasses selenium and uses
chrome directly with a reduction of overhead: https://gitlab.com/DMore
/behat-chrome-extension (this is probably heading out of scope for the
screenshot problem, but is an interesting idea, particularly as it
apparently reduces test time by at least 2/3rds.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892820/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe :
[Mahara-contributors] [Bug 1892820] [NEW] Behat: Add "take a screenshot" step
Public bug reported:
It might help our regression testing if we could add screenshot steps in
tests, so that a tester could run the test suite and afterwards check a
folder of screenshots to make sure that the pages look like they are
supposed to.
We can add a step to call the Mink saveScreenshot() function. This
works:
/**
* Save a screenshot for regression testing purposes
*
* @Then I take a screenshot as :filename
*/
public function take_screenshot($filename) {
if (!$this->running_javascript()) {
return false;
}
$path = get_config('dataroot') . 'behat';
$this->saveScreenshot($filename, $path);
}
A limitation of the above is that only the part of the page that is visible is
captured. In Chrome dev-tools there is the following option:
https://www.howtogeek.com/423558/how-to-take-full-page-screenshots-in-google-chrome-without-using-an-extension/
So now I wonder whether we could write a step to utilise that functionality
rather than calling saveScreenshot as above.
Things to consider:
Will these steps be slow?
Do we need to tag tests that use them in a different way, and only run when
regression testing is required? Or some other idea?
** Affects: mahara
Importance: Undecided
Status: New
** Tags: behat-dev
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892820
Title:
Behat: Add "take a screenshot" step
Status in Mahara:
New
Bug description:
It might help our regression testing if we could add screenshot steps
in tests, so that a tester could run the test suite and afterwards
check a folder of screenshots to make sure that the pages look like
they are supposed to.
We can add a step to call the Mink saveScreenshot() function. This
works:
/**
* Save a screenshot for regression testing purposes
*
* @Then I take a screenshot as :filename
*/
public function take_screenshot($filename) {
if (!$this->running_javascript()) {
return false;
}
$path = get_config('dataroot') . 'behat';
$this->saveScreenshot($filename, $path);
}
A limitation of the above is that only the part of the page that is visible
is captured. In Chrome dev-tools there is the following option:
https://www.howtogeek.com/423558/how-to-take-full-page-screenshots-in-google-chrome-without-using-an-extension/
So now I wonder whether we could write a step to utilise that functionality
rather than calling saveScreenshot as above.
Things to consider:
Will these steps be slow?
Do we need to tag tests that use them in a different way, and only run when
regression testing is required? Or some other idea?
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892820/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1892286] [NEW] Behat: Review peer_assessment.feature and confirm coverage
Public bug reported: The regression spreadsheet has the following test: Peers can perform a blind review of a portfolio authors skills and competencies when the “Peer assessment” block is on a page. They are not able to see any content of the person they are assessing. Peer assessments can be saved as drafts before making them available to the portfolio author and others More info about new functionality found here https://bugs.launchpad.net/mahara/+bug/1784778 https://bugs.launchpad.net/mahara/+bug/1784781 Please review /user_content/peer_assessment.feature and see whether the above functionality is covered. 1. Update this bug with any changes that need to be made. 2. Update the spreadsheet with AT coverage. ** Affects: mahara Importance: Undecided Assignee: Rangi Daymond (rangid) Status: New ** Tags: behat-test -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1892286 Title: Behat: Review peer_assessment.feature and confirm coverage Status in Mahara: New Bug description: The regression spreadsheet has the following test: Peers can perform a blind review of a portfolio authors skills and competencies when the “Peer assessment” block is on a page. They are not able to see any content of the person they are assessing. Peer assessments can be saved as drafts before making them available to the portfolio author and others More info about new functionality found here https://bugs.launchpad.net/mahara/+bug/1784778 https://bugs.launchpad.net/mahara/+bug/1784781 Please review /user_content/peer_assessment.feature and see whether the above functionality is covered. 1. Update this bug with any changes that need to be made. 2. Update the spreadsheet with AT coverage. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1892286/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1892283] [NEW] Behat: Write test for datepicker
Public bug reported: Automating a manual test. This is from Bug 1744191: The date picker is updated with the bootstrap-datepicker. However that original bug is for code to update the file browser consistently across the site, so is not specifically related to the datepicker. What we need here is a test for the basic functionality of the datepicker. 1. User logged in 2. User browse to Main menu > Content > Resume 3. Confirm that the date is in the same format as when created using the old date picker ✔ 4. Confirm the date picker is displayed when the user clicks inside the date field ✔ 5. Confirm the user can enter a date by typing in a date using the keyboard ✔ 6. Confirm the user can change a day inside the date picker by clicking the adjacent number in the calendar ✔ 7. Confirm the user can change the month by a. Clicking the forward > icon ✔ b. Clicking the month and year located in centre of modal window at the top ✔ c. Confirm months are now displayed instead of days and year is displayed in centre of modal window at the top ✔ 8. Confirm the user can change the year inside the date picker by clicking the month and year located in centre of modal window at the top ✔ 9. Confirm years are now displayed instead of days and a year range is displayed in centre of modal window at the top ✔ 10. Confirm the user can delete the date by clicking the trash can icon ✔ ** Affects: mahara Importance: Undecided Assignee: Rangi Daymond (rangid) Status: New ** Tags: behat-test -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1892283 Title: Behat: Write test for datepicker Status in Mahara: New Bug description: Automating a manual test. This is from Bug 1744191: The date picker is updated with the bootstrap-datepicker. However that original bug is for code to update the file browser consistently across the site, so is not specifically related to the datepicker. What we need here is a test for the basic functionality of the datepicker. 1. User logged in 2. User browse to Main menu > Content > Resume 3. Confirm that the date is in the same format as when created using the old date picker ✔ 4. Confirm the date picker is displayed when the user clicks inside the date field ✔ 5. Confirm the user can enter a date by typing in a date using the keyboard ✔ 6. Confirm the user can change a day inside the date picker by clicking the adjacent number in the calendar ✔ 7. Confirm the user can change the month by a. Clicking the forward > icon ✔ b. Clicking the month and year located in centre of modal window at the top ✔ c. Confirm months are now displayed instead of days and year is displayed in centre of modal window at the top ✔ 8. Confirm the user can change the year inside the date picker by clicking the month and year located in centre of modal window at the top ✔ 9. Confirm years are now displayed instead of days and a year range is displayed in centre of modal window at the top ✔ 10. Confirm the user can delete the date by clicking the trash can icon ✔ To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1892283/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1892277] [NEW] Behat: Smart Evidence - review automated and manual tests
Public bug reported: In the regression spreadsheet, there are the following items: 1. Change SE framework via matrix Collection page>Annotation>click on different SE framework 2. Change SE framework via Page Portfolio>Page>Edit page> Annotation>Standard drop down menu>click on different SE framework I wasn't sure exactly what needs to be tested here, but we should be able to add more SmartEvidence tests to Behat as needed. I suggest reviewing the current SE tests of which there are several: /site_features/install_framework.feature /site_features/annotation_and_smartevidence.feature /site_features/institution_smartevidence.feature /site_features/smart_evidence_editor.feature /site_features/smart_evidence_workflow.feature 1. After confirming what is tested and what still needs to be covered, create bug reports for adding new functionality to behat. 2. Update the spreadsheet to reference any changes made so that we do not revisit this again later. ** Affects: mahara Importance: Undecided Assignee: Rangi Daymond (rangid) Status: New ** Tags: behat-test -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1892277 Title: Behat: Smart Evidence - review automated and manual tests Status in Mahara: New Bug description: In the regression spreadsheet, there are the following items: 1. Change SE framework via matrix Collection page>Annotation>click on different SE framework 2. Change SE framework via Page Portfolio>Page>Edit page> Annotation>Standard drop down menu>click on different SE framework I wasn't sure exactly what needs to be tested here, but we should be able to add more SmartEvidence tests to Behat as needed. I suggest reviewing the current SE tests of which there are several: /site_features/install_framework.feature /site_features/annotation_and_smartevidence.feature /site_features/institution_smartevidence.feature /site_features/smart_evidence_editor.feature /site_features/smart_evidence_workflow.feature 1. After confirming what is tested and what still needs to be covered, create bug reports for adding new functionality to behat. 2. Update the spreadsheet to reference any changes made so that we do not revisit this again later. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1892277/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1892128] [NEW] Behat: Test third level nav (arrow-bar) for groups
Public bug reported: We don't currently test the third level nav for groups. This could be added to social/group-main.feature. (Note, this bug should be completed first: https://bugs.launchpad.net/mahara/+bug/1892119) What to test: 1. Follow one of the groups 2. Check we are on the 'About' tab (note that 'bt-groupinfo' elements are checked in create_and_delete_groups.feature, so pick something else!) 3. Click each of the other 'Arrow-bar nav' buttons and check for one element that is unique to each of those pages. There is no need to add an example of each of the elements. E.g. for 'Journals', checking "There are no journals in this group" is displayed is a valid check for this test. We are checking that the nav bar elements are present and work, nothing further. ** Affects: mahara Importance: Undecided Assignee: Rangi Daymond (rangid) Status: New ** Tags: behat-test -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1892128 Title: Behat: Test third level nav (arrow-bar) for groups Status in Mahara: New Bug description: We don't currently test the third level nav for groups. This could be added to social/group-main.feature. (Note, this bug should be completed first: https://bugs.launchpad.net/mahara/+bug/1892119) What to test: 1. Follow one of the groups 2. Check we are on the 'About' tab (note that 'bt-groupinfo' elements are checked in create_and_delete_groups.feature, so pick something else!) 3. Click each of the other 'Arrow-bar nav' buttons and check for one element that is unique to each of those pages. There is no need to add an example of each of the elements. E.g. for 'Journals', checking "There are no journals in this group" is displayed is a valid check for this test. We are checking that the nav bar elements are present and work, nothing further. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1892128/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1892118] [NEW] Behat: Improve background set-up for groups
Public bug reported: Certain options such as - Group category - Group invitation (group_member_invite) are not accessible as background steps. To improve: 1. Check which other functionality could be added to background steps for groups to make the tests easier to manage. 2. Add functionality and refactor tests to use it. Note that this is a wishlist item reported as a reminder that improvements can be made. It will be edited if other options are found. ** Affects: mahara Importance: Wishlist Status: New ** Tags: behat-dev ** Tags removed: beh ** Tags added: behat-dev ** Changed in: mahara Importance: Undecided => Wishlist -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1892118 Title: Behat: Improve background set-up for groups Status in Mahara: New Bug description: Certain options such as - Group category - Group invitation (group_member_invite) are not accessible as background steps. To improve: 1. Check which other functionality could be added to background steps for groups to make the tests easier to manage. 2. Add functionality and refactor tests to use it. Note that this is a wishlist item reported as a reminder that improvements can be made. It will be edited if other options are found. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1892118/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1892119] [NEW] Behat: Test for basic group elements
Public bug reported: Automating manual test. Test from spreadsheet is below: Pre req: Site Admin allowed to create groups Displays Create group button, Group categories, Filter, Settings and Delete (to remove group permanently). Click Accept button to join a group or Decline 1. Set up a new test called social/group_main.feature, with a @mainflow tag 2. Add 2 users and 2 groups as background steps. a. The first user should own GroupA and the second user should not be a member. b. The second user should own GroupB. 3. Admin logs in, turns on group categories. 3. UserA logs in, edits the group to add a category and invites UserB to join the group. 4. UserB logs in, goes the the Group page and should see the following: - create group button - group category - Filter by label In the GroupA row - Accept - Decline In the GroupB row: - Label - Settings - Delete Note that if group category and invitations could be added in the background, this test would be shorter: https://bugs.launchpad.net/mahara/+bug/1892118 ** Affects: mahara Importance: Undecided Assignee: Rangi Daymond (rangid) Status: New ** Tags: behat-test -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1892119 Title: Behat: Test for basic group elements Status in Mahara: New Bug description: Automating manual test. Test from spreadsheet is below: Pre req: Site Admin allowed to create groups Displays Create group button, Group categories, Filter, Settings and Delete (to remove group permanently). Click Accept button to join a group or Decline 1. Set up a new test called social/group_main.feature, with a @mainflow tag 2. Add 2 users and 2 groups as background steps. a. The first user should own GroupA and the second user should not be a member. b. The second user should own GroupB. 3. Admin logs in, turns on group categories. 3. UserA logs in, edits the group to add a category and invites UserB to join the group. 4. UserB logs in, goes the the Group page and should see the following: - create group button - group category - Filter by label In the GroupA row - Accept - Decline In the GroupB row: - Label - Settings - Delete Note that if group category and invitations could be added in the background, this test would be shorter: https://bugs.launchpad.net/mahara/+bug/1892118 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1892119/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891951] Re: Behat: comments are moderated if made anonymously
** Description changed: Automating manual test. Test from spreadsheet is below: When “Make public” is set to “Yes”, comment moderation should kick in automatically as per https://reviews.mahara.org/8575 We test anonymous comments in social/add_delete_comments.feature. We can add a check to this to make sure moderation is forced for anonymous comments. 1. Because the feature name is mis-leading, let's rename it to anonymous_comments.feature 2. After Joe Anonymous makes his comment, add a check that he sees "Comment submitted, awaiting moderation" - 3. When the page owner logs back in, confirm that the anonymous comment says "This comment is private - " and they can click the button for "Make comment public" + 3. When the page owner logs back in, confirm that they have a message in their inbox saying "Joe Anonymous has requested that you make their comment public." If they go to the comment, it says "This comment is private - " and they can click the button for "Make comment public" 4. Review test content. Decide whether page mtime scenario makes sense here or if it should be in a separate file. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891951 Title: Behat: comments are moderated if made anonymously Status in Mahara: New Bug description: Automating manual test. Test from spreadsheet is below: When “Make public” is set to “Yes”, comment moderation should kick in automatically as per https://reviews.mahara.org/8575 We test anonymous comments in social/add_delete_comments.feature. We can add a check to this to make sure moderation is forced for anonymous comments. 1. Because the feature name is mis-leading, let's rename it to anonymous_comments.feature 2. After Joe Anonymous makes his comment, add a check that he sees "Comment submitted, awaiting moderation" 3. When the page owner logs back in, confirm that they have a message in their inbox saying "Joe Anonymous has requested that you make their comment public." If they go to the comment, it says "This comment is private - " and they can click the button for "Make comment public" 4. Review test content. Decide whether page mtime scenario makes sense here or if it should be in a separate file. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891951/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891426] Re: Behat: Move quota checks to notification_quota.feature
** Changed in: mahara Status: New => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891426 Title: Behat: Move quota checks to notification_quota.feature Status in Mahara: In Progress Bug description: We have a test called /user_content/file_edit.feature which includes checks for the upload quota allowed. These would be better placed in /settings/notification_quota.feature. Remove steps related to quota from file_edit.feature and add them to notification_quota.feature in the section where UserA logs in (approx ln 33) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891426/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891955] [NEW] Behat: rename versioning.feature->timeline.feature
Public bug reported: Let's change the name of this test to make it more obvious what it does: versioning.feature->timeline.feature ** Affects: mahara Importance: Undecided Assignee: Rangi Daymond (rangid) Status: Fix Committed ** Tags: behat-test ** Changed in: mahara Status: New => In Progress ** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891955 Title: Behat: rename versioning.feature->timeline.feature Status in Mahara: Fix Committed Bug description: Let's change the name of this test to make it more obvious what it does: versioning.feature->timeline.feature To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891955/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891568] Re: Behat: Add test for "Pages and collections" page elements
** Description changed: Automating manual test. These are the details from the spreadsheet: Overview page contains the following * Page title - “Pages and Collections - * listing of existing pages + * listing of existing pages * default pages – Dashboard & Profile page * side bar – user info. Online users, Tags * section header – search, sort, add & copy button Displays create and Copy button, Search and Sort by with drop down arrow, Edit and Delete button Create a new test called pages_collections.feature + tag it @mainflow Add tests that the default elements are present on the page. This does not include the header and footer elements or any functionality. These things are tested elsewhere. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891568 Title: Behat: Add test for "Pages and collections" page elements Status in Mahara: New Bug description: Automating manual test. These are the details from the spreadsheet: Overview page contains the following * Page title - “Pages and Collections * listing of existing pages * default pages – Dashboard & Profile page * side bar – user info. Online users, Tags * section header – search, sort, add & copy button Displays create and Copy button, Search and Sort by with drop down arrow, Edit and Delete button Create a new test called pages_collections.feature tag it @mainflow Add tests that the default elements are present on the page. This does not include the header and footer elements or any functionality. These things are tested elsewhere. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891568/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891951] [NEW] Behat: comments are moderated if made anonymously
Public bug reported: Automating manual test. Test from spreadsheet is below: When “Make public” is set to “Yes”, comment moderation should kick in automatically as per https://reviews.mahara.org/8575 We test anonymous comments in social/add_delete_comments.feature. We can add a check to this to make sure moderation is forced for anonymous comments. 1. Because the feature name is mis-leading, let's rename it to anonymous_comments.feature 2. After Joe Anonymous makes his comment, add a check that he sees "Comment submitted, awaiting moderation" 3. When the page owner logs back in, confirm that the anonymous comment says "This comment is private - " and they can click the button for "Make comment public" 4. Review test content. Decide whether page mtime scenario makes sense here or if it should be in a separate file. ** Affects: mahara Importance: Undecided Assignee: Rangi Daymond (rangid) Status: New ** Tags: behat-test -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891951 Title: Behat: comments are moderated if made anonymously Status in Mahara: New Bug description: Automating manual test. Test from spreadsheet is below: When “Make public” is set to “Yes”, comment moderation should kick in automatically as per https://reviews.mahara.org/8575 We test anonymous comments in social/add_delete_comments.feature. We can add a check to this to make sure moderation is forced for anonymous comments. 1. Because the feature name is mis-leading, let's rename it to anonymous_comments.feature 2. After Joe Anonymous makes his comment, add a check that he sees "Comment submitted, awaiting moderation" 3. When the page owner logs back in, confirm that the anonymous comment says "This comment is private - " and they can click the button for "Make comment public" 4. Review test content. Decide whether page mtime scenario makes sense here or if it should be in a separate file. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891951/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891946] Re: Behat: Comment rating, license and attachment
** Description changed: Automating manual test. Test from spreadsheet is below: Pre req: Site Admin has turned on comment ratings and license metadata. Set make public to Yes and verify License field, Licensor and Original URL fields are displayed. - Add comment and click window sizer icon then add rating. - Attach feedback file into the files area and click Add attachment to add another file then click comment button or click cancel. Author receives Notification + Add comment and click window sizer icon then add rating. + Attach feedback file into the files area and click Add attachment to add another file then click comment button or click cancel. Author receives Notification NB: Comment ratings is turned on in Extensions->Plugin adminstration->Comment License is turned on in Site options->Site settings->License metadata (But perhaps these can be turned on in the background). I have no idea what is meant by the 'window sizer' icon. Perhaps this is no longer relevant. If you know what it means, test it, otherwise ignore. We need at least 2 users for this: UserA has a page which is visible to UserB. UserB comments on the page, using the rating, attaching a file and filling in the license field and url. - UserA gets notified of the comment, can see the attachment and the rating. If they go to Files they should have a commentfiles folder including the attached file. Following the edit option for the file should show all the file information. Note that the license information isn't currently seen in these places. This will be reported as a separate bug (if it is one, tbc). + UserA gets notified of the comment, can see the attachment and the rating. If they go to Files they should have a commentfiles folder including the attached file. Following the edit option for the file should show all the file information. Note that the license information isn't currently displayed, so we are not checking for it. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891946 Title: Behat: Comment rating, license and attachment Status in Mahara: New Bug description: Automating manual test. Test from spreadsheet is below: Pre req: Site Admin has turned on comment ratings and license metadata. Set make public to Yes and verify License field, Licensor and Original URL fields are displayed. Add comment and click window sizer icon then add rating. Attach feedback file into the files area and click Add attachment to add another file then click comment button or click cancel. Author receives Notification NB: Comment ratings is turned on in Extensions->Plugin adminstration->Comment License is turned on in Site options->Site settings->License metadata (But perhaps these can be turned on in the background). I have no idea what is meant by the 'window sizer' icon. Perhaps this is no longer relevant. If you know what it means, test it, otherwise ignore. We need at least 2 users for this: UserA has a page which is visible to UserB. UserB comments on the page, using the rating, attaching a file and filling in the license field and url. UserA gets notified of the comment, can see the attachment and the rating. If they go to Files they should have a commentfiles folder including the attached file. Following the edit option for the file should show all the file information. Note that the license information isn't currently displayed, so we are not checking for it. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891946/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891946] [NEW] Behat: Comment rating, license and attachment
Public bug reported: Automating manual test. Test from spreadsheet is below: Pre req: Site Admin has turned on comment ratings and license metadata. Set make public to Yes and verify License field, Licensor and Original URL fields are displayed. Add comment and click window sizer icon then add rating. Attach feedback file into the files area and click Add attachment to add another file then click comment button or click cancel. Author receives Notification NB: Comment ratings is turned on in Extensions->Plugin adminstration->Comment License is turned on in Site options->Site settings->License metadata (But perhaps these can be turned on in the background). I have no idea what is meant by the 'window sizer' icon. Perhaps this is no longer relevant. If you know what it means, test it, otherwise ignore. We need at least 2 users for this: UserA has a page which is visible to UserB. UserB comments on the page, using the rating, attaching a file and filling in the license field and url. UserA gets notified of the comment, can see the attachment and the rating. If they go to Files they should have a commentfiles folder including the attached file. Following the edit option for the file should show all the file information. Note that the license information isn't currently seen in these places. This will be reported as a separate bug (if it is one, tbc). ** Affects: mahara Importance: Undecided Assignee: Rangi Daymond (rangid) Status: New ** Tags: behat-test -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891946 Title: Behat: Comment rating, license and attachment Status in Mahara: New Bug description: Automating manual test. Test from spreadsheet is below: Pre req: Site Admin has turned on comment ratings and license metadata. Set make public to Yes and verify License field, Licensor and Original URL fields are displayed. Add comment and click window sizer icon then add rating. Attach feedback file into the files area and click Add attachment to add another file then click comment button or click cancel. Author receives Notification NB: Comment ratings is turned on in Extensions->Plugin adminstration->Comment License is turned on in Site options->Site settings->License metadata (But perhaps these can be turned on in the background). I have no idea what is meant by the 'window sizer' icon. Perhaps this is no longer relevant. If you know what it means, test it, otherwise ignore. We need at least 2 users for this: UserA has a page which is visible to UserB. UserB comments on the page, using the rating, attaching a file and filling in the license field and url. UserA gets notified of the comment, can see the attachment and the rating. If they go to Files they should have a commentfiles folder including the attached file. Following the edit option for the file should show all the file information. Note that the license information isn't currently seen in these places. This will be reported as a separate bug (if it is one, tbc). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891946/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891266] Re: Behat: Confirm correct dashboard elements are present
After editing this test, we found that we could not find a way to get Behat to "see" the "Configure block" and "Remove block" elements without using the steps that click them. We have left that part of the test as "TODO" in the meantime. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891266 Title: Behat: Confirm correct dashboard elements are present Status in Mahara: New Bug description: Automating a manual test. Copied from spreadsheet: Verify default dashboard includes the following blocks: Latest pages, My pages, Inbox, Topics I’m following (Note these titles are out of date. We need to check the current titles) Verify user can add or remove blocks via edit dashboard For this we can add to the homepage_buttons.feature. I suggest renaming it to dashboard.feature and it can be the core test for items on that page. 1. Add a scenario called "Checking default blocks are displayed". 2. As the section commented "# check for bug 1493199 name changed from “Latest pages” to “Latest changes I can view”" includes a check for that, transfer it to the new scenario. 3. Add checks for the other defaults: Inbox Topics I am following My portfolios Watched pages 4. Follow "Edit dashboard" and confirm that the blocks all contain a "Remove block" option and that all except My portfolios contain a "Configure block" option. 5. Test that the configure modal opens for one of the blocks and that you can save a change. (Note that we are not interested in this test whether the options work.) 6. Test that you can delete one of the blocks 7. Return to the dashboard and confirm the block you deleted is not displayed. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891266/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891266] Re: Behat: Confirm correct dashboard elements are present
** Description changed: Automating a manual test. Copied from spreadsheet: Verify default dashboard includes the following blocks: Latest pages, My pages, Inbox, Topics I’m following (Note these titles are out of date. We need to check the current titles) Verify user can add or remove blocks via edit dashboard For this we can add to the homepage_buttons.feature. I suggest renaming it to dashboard.feature and it can be the core test for items on that page. 1. Add a scenario called "Checking default blocks are displayed". 2. As the section commented "# check for bug 1493199 name changed from “Latest pages” to “Latest changes I can view”" includes a check for that, transfer it to the new scenario. 3. Add checks for the other defaults: Inbox Topics I am following My portfolios Watched pages 4. Follow "Edit dashboard" and confirm that the blocks all contain a "Remove block" option and that all except My portfolios contain a "Configure block" option. - 5. Test that you can delete one of the blocks - - 6. Test that the configure modal opens for one of the blocks and that + 5. Test that the configure modal opens for one of the blocks and that you can save a change. (Note that we are not interested in this test whether the options work.) + 6. Test that you can delete one of the blocks + 7. Return to the dashboard and confirm the block you deleted is not displayed. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891266 Title: Behat: Confirm correct dashboard elements are present Status in Mahara: New Bug description: Automating a manual test. Copied from spreadsheet: Verify default dashboard includes the following blocks: Latest pages, My pages, Inbox, Topics I’m following (Note these titles are out of date. We need to check the current titles) Verify user can add or remove blocks via edit dashboard For this we can add to the homepage_buttons.feature. I suggest renaming it to dashboard.feature and it can be the core test for items on that page. 1. Add a scenario called "Checking default blocks are displayed". 2. As the section commented "# check for bug 1493199 name changed from “Latest pages” to “Latest changes I can view”" includes a check for that, transfer it to the new scenario. 3. Add checks for the other defaults: Inbox Topics I am following My portfolios Watched pages 4. Follow "Edit dashboard" and confirm that the blocks all contain a "Remove block" option and that all except My portfolios contain a "Configure block" option. 5. Test that the configure modal opens for one of the blocks and that you can save a change. (Note that we are not interested in this test whether the options work.) 6. Test that you can delete one of the blocks 7. Return to the dashboard and confirm the block you deleted is not displayed. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891266/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891266] Re: Behat: Confirm correct dashboard elements are present
** Summary changed: - Behat: Confirm correct homepage elements are present + Behat: Confirm correct dashboard elements are present -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891266 Title: Behat: Confirm correct dashboard elements are present Status in Mahara: New Bug description: Automating a manual test. Copied from spreadsheet: Verify default dashboard includes the following blocks: Latest pages, My pages, Inbox, Topics I’m following (Note these titles are out of date. We need to check the current titles) Verify user can add or remove blocks via edit dashboard For this we can add to the homepage_buttons.feature. I suggest renaming it to dashboard.feature and it can be the core test for items on that page. 1. Add a scenario called "Checking default blocks are displayed". 2. As the section commented "# check for bug 1493199 name changed from “Latest pages” to “Latest changes I can view”" includes a check for that, transfer it to the new scenario. 3. Add checks for the other defaults: Inbox Topics I am following My portfolios Watched pages 4. Follow "Edit dashboard" and confirm that the blocks all contain a "Remove block" option and that all except My portfolios contain a "Configure block" option. 5. Test that you can delete one of the blocks 6. Test that the configure modal opens for one of the blocks and that you can save a change. (Note that we are not interested in this test whether the options work.) 7. Return to the dashboard and confirm the block you deleted is not displayed. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891266/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891266] Re: Behat: Confirm correct homepage elements are present
** Description changed: Automating a manual test. Copied from spreadsheet: Verify default dashboard includes the following blocks: Latest pages, My pages, Inbox, Topics I’m following (Note these titles are out of date. We need to check the current titles) Verify user can add or remove blocks via edit dashboard - - For this we can add to the homepage_buttons.feature. I suggest renaming it to homepage.feature and it can be the core test for items on that page. + For this we can add to the homepage_buttons.feature. I suggest renaming + it to dashboard.feature and it can be the core test for items on that + page. 1. Add a scenario called "Checking default blocks are displayed". 2. As the section commented "# check for bug 1493199 name changed from “Latest pages” to “Latest changes I can view”" includes a check for that, transfer it to the new scenario. - 3. Add checks for the other defaults: + 3. Add checks for the other defaults: Inbox Topics I am following My portfolios - Watched pages + Watched pages 4. Follow "Edit dashboard" and confirm that the blocks all contain a "Remove block" option and that all except My portfolios contain a "Configure block" option. 5. Test that you can delete one of the blocks 6. Test that the configure modal opens for one of the blocks and that you can save a change. (Note that we are not interested in this test whether the options work.) - 7. Return to the homepage and confirm the block you deleted is not + 7. Return to the dashboard and confirm the block you deleted is not displayed. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891266 Title: Behat: Confirm correct homepage elements are present Status in Mahara: New Bug description: Automating a manual test. Copied from spreadsheet: Verify default dashboard includes the following blocks: Latest pages, My pages, Inbox, Topics I’m following (Note these titles are out of date. We need to check the current titles) Verify user can add or remove blocks via edit dashboard For this we can add to the homepage_buttons.feature. I suggest renaming it to dashboard.feature and it can be the core test for items on that page. 1. Add a scenario called "Checking default blocks are displayed". 2. As the section commented "# check for bug 1493199 name changed from “Latest pages” to “Latest changes I can view”" includes a check for that, transfer it to the new scenario. 3. Add checks for the other defaults: Inbox Topics I am following My portfolios Watched pages 4. Follow "Edit dashboard" and confirm that the blocks all contain a "Remove block" option and that all except My portfolios contain a "Configure block" option. 5. Test that you can delete one of the blocks 6. Test that the configure modal opens for one of the blocks and that you can save a change. (Note that we are not interested in this test whether the options work.) 7. Return to the dashboard and confirm the block you deleted is not displayed. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891266/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891828] [NEW] Behat: Compare functionality between settings tests
Public bug reported: There looks to be some similarity between what test/behat/features/settings/change_account_settings.feature and test/behat/features/settings/notification_settings.feature are testing. This bug covers: 1. comparing the tests 2. checking that the functionality we are testing makes sense within the test suite 3. making improvements if required 4. document the changes and reasoning in the feature file itself, either as part of the 'Feature' text (high level) or as comments (more granular) ** Affects: mahara Importance: Undecided Assignee: Rangi Daymond (rangid) Status: New ** Tags: behat-test -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891828 Title: Behat: Compare functionality between settings tests Status in Mahara: New Bug description: There looks to be some similarity between what test/behat/features/settings/change_account_settings.feature and test/behat/features/settings/notification_settings.feature are testing. This bug covers: 1. comparing the tests 2. checking that the functionality we are testing makes sense within the test suite 3. making improvements if required 4. document the changes and reasoning in the feature file itself, either as part of the 'Feature' text (high level) or as comments (more granular) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891828/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891827] [NEW] Behat: Test leap2A import works
Public bug reported: Automating manual test. Test from spreadsheet is below: 1. Click Browse button to upload Leap2A file then edit 3. Click the headings of a section to expand, Leap2A file is displayed on the left while on the right can either se Ignore, Replace, Append or Add new. This looks like it should be able to be automated fairly easily. If it turns out to be difficult, ask for dev help, as it's possible we are missing some functionality. ** Affects: mahara Importance: Undecided Assignee: Rangi Daymond (rangid) Status: New ** Tags: behat-test -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891827 Title: Behat: Test leap2A import works Status in Mahara: New Bug description: Automating manual test. Test from spreadsheet is below: 1. Click Browse button to upload Leap2A file then edit 3. Click the headings of a section to expand, Leap2A file is displayed on the left while on the right can either se Ignore, Replace, Append or Add new. This looks like it should be able to be automated fairly easily. If it turns out to be difficult, ask for dev help, as it's possible we are missing some functionality. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891827/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891590] [NEW] Behat: Html purifier doesn't strip button tags (Bug 1560780)
Public bug reported: Automating manual test. This relates to this original bug report. https://bugs.launchpad.net/mahara/+bug/1560780 Full test steps exist in the above bug report. Accessing tinymce may be problematic, but hopefully not! :) ** Affects: mahara Importance: Undecided Assignee: Rangi Daymond (rangid) Status: New ** Tags: behat-test ** Changed in: mahara Assignee: ranh (ran) => (unassigned) ** Changed in: mahara Assignee: (unassigned) => Rangi Daymond (rangid) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891590 Title: Behat: Html purifier doesn't strip button tags (Bug 1560780) Status in Mahara: New Bug description: Automating manual test. This relates to this original bug report. https://bugs.launchpad.net/mahara/+bug/1560780 Full test steps exist in the above bug report. Accessing tinymce may be problematic, but hopefully not! :) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891590/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891576] [NEW] Behat: Review create_delete_page.feature
Public bug reported: Automating manual test. These are the details from the spreadsheet: Verify Copy page elements displayed Go to the Pages overview page and click on the title of a page. Verify the following are displayed: 1. Edit this page button 2. copy button (Note this is out of date) 4. 3 dots 5. artefacts 6. Add comment 7. Details icon (from Add comment) 8. comments from user 9. total number of comments 10. How many times the page is accessed 1. Review coverage included in user_content/create_delete_page.feature a. Remove irrelevant comments, e.g. ln 75, 76 (old steps commented out) b. Remove irrelevant steps, e.g. And I should see "More options" before And I press "More options" If it can't be seen, the press step will fail, so there's no need for the first one. c. Take note of the roles used and whether the test needs to run as admin. If not, it should be run as a normal user. d. If there is functionality that would make more sense elsewhere, move it, or create a bug report. If unsure, look to see if there is coverage elsewhere for similar things. 2. Most of the functionality from the automated test above is covered. If it isn't, add it unless it would be better covered in another test. For instance adding comments should be covered elsewhere. Confirm this. ** Affects: mahara Importance: Undecided Assignee: Rangi Daymond (rangid) Status: New ** Tags: behat-test -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891576 Title: Behat: Review create_delete_page.feature Status in Mahara: New Bug description: Automating manual test. These are the details from the spreadsheet: Verify Copy page elements displayed Go to the Pages overview page and click on the title of a page. Verify the following are displayed: 1. Edit this page button 2. copy button (Note this is out of date) 4. 3 dots 5. artefacts 6. Add comment 7. Details icon (from Add comment) 8. comments from user 9. total number of comments 10. How many times the page is accessed 1. Review coverage included in user_content/create_delete_page.feature a. Remove irrelevant comments, e.g. ln 75, 76 (old steps commented out) b. Remove irrelevant steps, e.g. And I should see "More options" before And I press "More options" If it can't be seen, the press step will fail, so there's no need for the first one. c. Take note of the roles used and whether the test needs to run as admin. If not, it should be run as a normal user. d. If there is functionality that would make more sense elsewhere, move it, or create a bug report. If unsure, look to see if there is coverage elsewhere for similar things. 2. Most of the functionality from the automated test above is covered. If it isn't, add it unless it would be better covered in another test. For instance adding comments should be covered elsewhere. Confirm this. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891576/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891569] Re: Behat: Class and id locaters back in tests
** Description changed: We made a decision some time ago that we would take class and id locators out of test steps and use a 'properties' file to abstract those instead: https://bugs.launchpad.net/mahara/+bug/1705622 I notice that locators are creeping back into the test steps. I'm not sure why this is: - Do people not know about the properties file? - Is it clunky and hard to use? + Do people not know about the properties file? + Is it clunky and hard to use? Are test steps with locators preferred by devs/testers over the abstracted steps? - The properties was really the first iteration of the idea of abstracting - out page elements and having a page each for each mahara page which - would allow a tester to use the more user-friendly titles and not have - to delve into the inspect window. If this is still seen as desirable, we - need to continue to update and develop the 'properties' idea and to - commit to adding to this instead of adding locators to the tests. This - means that tests with locators should fail code review. + The 'properties' file was really the first iteration of the idea of + creating a dictionary of human-readable-name mapping to a page locater + (which could be a css element, xpath or other more background way of + accessing the element). + + The long-term goal was seen as a collection of locators for each page in + Mahara that would allow a test to be written quickly, without the writer + having to delve into the inspect window to find elements. If this is + still seen as desirable, we need to continue to update and develop the + 'properties' idea and to commit to adding to this instead of adding + locators to the tests. This means that tests with locators should fail + code review. Do we need to abandon the properties idea, implement it in another way, or be more conscious of using the existing functionality? Needs discussion. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891569 Title: Behat: Class and id locaters back in tests Status in Mahara: New Bug description: We made a decision some time ago that we would take class and id locators out of test steps and use a 'properties' file to abstract those instead: https://bugs.launchpad.net/mahara/+bug/1705622 I notice that locators are creeping back into the test steps. I'm not sure why this is: Do people not know about the properties file? Is it clunky and hard to use? Are test steps with locators preferred by devs/testers over the abstracted steps? The 'properties' file was really the first iteration of the idea of creating a dictionary of human-readable-name mapping to a page locater (which could be a css element, xpath or other more background way of accessing the element). The long-term goal was seen as a collection of locators for each page in Mahara that would allow a test to be written quickly, without the writer having to delve into the inspect window to find elements. If this is still seen as desirable, we need to continue to update and develop the 'properties' idea and to commit to adding to this instead of adding locators to the tests. This means that tests with locators should fail code review. Do we need to abandon the properties idea, implement it in another way, or be more conscious of using the existing functionality? Needs discussion. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891569/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891569] [NEW] Behat: Class and id locaters back in tests
Public bug reported: We made a decision some time ago that we would take class and id locators out of test steps and use a 'properties' file to abstract those instead: https://bugs.launchpad.net/mahara/+bug/1705622 I notice that locators are creeping back into the test steps. I'm not sure why this is: Do people not know about the properties file? Is it clunky and hard to use? Are test steps with locators preferred by devs/testers over the abstracted steps? The properties was really the first iteration of the idea of abstracting out page elements and having a page each for each mahara page which would allow a tester to use the more user-friendly titles and not have to delve into the inspect window. If this is still seen as desirable, we need to continue to update and develop the 'properties' idea and to commit to adding to this instead of adding locators to the tests. This means that tests with locators should fail code review. Do we need to abandon the properties idea, implement it in another way, or be more conscious of using the existing functionality? Needs discussion. ** Affects: mahara Importance: Undecided Status: New ** Tags: behat-dev -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891569 Title: Behat: Class and id locaters back in tests Status in Mahara: New Bug description: We made a decision some time ago that we would take class and id locators out of test steps and use a 'properties' file to abstract those instead: https://bugs.launchpad.net/mahara/+bug/1705622 I notice that locators are creeping back into the test steps. I'm not sure why this is: Do people not know about the properties file? Is it clunky and hard to use? Are test steps with locators preferred by devs/testers over the abstracted steps? The properties was really the first iteration of the idea of abstracting out page elements and having a page each for each mahara page which would allow a tester to use the more user-friendly titles and not have to delve into the inspect window. If this is still seen as desirable, we need to continue to update and develop the 'properties' idea and to commit to adding to this instead of adding locators to the tests. This means that tests with locators should fail code review. Do we need to abandon the properties idea, implement it in another way, or be more conscious of using the existing functionality? Needs discussion. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891569/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891568] [NEW] Behat: Add test for "Pages and collections" page elements
Public bug reported: Automating manual test. These are the details from the spreadsheet: Overview page contains the following * Page title - “Pages and Collections * listing of existing pages * default pages – Dashboard & Profile page * side bar – user info. Online users, Tags * section header – search, sort, add & copy button Displays create and Copy button, Search and Sort by with drop down arrow, Edit and Delete button Create a new test called pages_collections.feature Add tests that the default elements are present on the page. This does not include the header and footer elements or any functionality. These things are tested elsewhere. ** Affects: mahara Importance: Undecided Assignee: Rangi Daymond (rangid) Status: New ** Tags: behat-test -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891568 Title: Behat: Add test for "Pages and collections" page elements Status in Mahara: New Bug description: Automating manual test. These are the details from the spreadsheet: Overview page contains the following * Page title - “Pages and Collections * listing of existing pages * default pages – Dashboard & Profile page * side bar – user info. Online users, Tags * section header – search, sort, add & copy button Displays create and Copy button, Search and Sort by with drop down arrow, Edit and Delete button Create a new test called pages_collections.feature Add tests that the default elements are present on the page. This does not include the header and footer elements or any functionality. These things are tested elsewhere. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891568/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891430] Re: Behat: Rationalise tests for file and folder upload/edit/delete
** Description changed: - This bug report incorporates automating a manual test and merging two + This bug report incorporates automating manual tests and merging two tests with duplicated functionality. These changes should be made after this Bug is complete: https://bugs.launchpad.net/mahara/+bug/1891426. It can be either a child patch or made after that patch is merged. 1. Merge the functionality of: /user_content/file_edit.feature /download_files_block.feature Make sure that the current functionality from both tests is still represented. Rename the merged test files_folders.feature. It can be the core test for this functionality. - 2. Automating manual test. These are the details from the spreadsheet - items: + 2. Automating manual test. These are the details from the spreadsheet: - User can do the following + Upload a file - Page elements present + + Following blocks as follows + - User info block ✔ + - On line users block ✔ + - Quota Block ✔ + - Profile completion (if turned on) ✔ + Upload file area ✔ + File browser table – displaying all uploaded files ✔ + + Add tests to make sure the correct blocks are on the page. We don't care + if they contain the right info or if they work. The functionality is + tested elsewhere. + + + 3. Automating manual test. These are the details from the spreadsheet: + + User can do the following - Drag and drop files ✘ - Create folders ✔ - Download files ✔ - Edit a file or folder ✔ - Delete a file or folder ✔ We can't test drag and drop, or that download works, but we can test the other things via behat. - Edit the new files_folders.feature to include a check for + Edit the new files_folders.feature to include a check for a. editing the folder name: I press "Edit folder \"\"" b. deleting the folder -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891430 Title: Behat: Rationalise tests for file and folder upload/edit/delete Status in Mahara: New Bug description: This bug report incorporates automating manual tests and merging two tests with duplicated functionality. These changes should be made after this Bug is complete: https://bugs.launchpad.net/mahara/+bug/1891426. It can be either a child patch or made after that patch is merged. 1. Merge the functionality of: /user_content/file_edit.feature /download_files_block.feature Make sure that the current functionality from both tests is still represented. Rename the merged test files_folders.feature. It can be the core test for this functionality. 2. Automating manual test. These are the details from the spreadsheet: Upload a file - Page elements present Following blocks as follows - User info block ✔ - On line users block ✔ - Quota Block ✔ - Profile completion (if turned on) ✔ Upload file area ✔ File browser table – displaying all uploaded files ✔ Add tests to make sure the correct blocks are on the page. We don't care if they contain the right info or if they work. The functionality is tested elsewhere. 3. Automating manual test. These are the details from the spreadsheet: User can do the following - Drag and drop files ✘ - Create folders ✔ - Download files ✔ - Edit a file or folder ✔ - Delete a file or folder ✔ We can't test drag and drop, or that download works, but we can test the other things via behat. Edit the new files_folders.feature to include a check for a. editing the folder name: I press "Edit folder \"\"" b. deleting the folder To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891430/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891426] Re: Behat: Move quota checks to notification_quota.feature
** Description changed: We have a test called /user_content/file_edit.feature which includes checks for the upload quota allowed. These would be better placed in /settings/notification_quota.feature. Remove steps related to quota from file_edit.feature and add them to notification_quota.feature in the section where UserA logs in (approx ln 33) - - Note there is also a bug report for reconciling the content of file_edit.feature. - This bug should be completed before working on that one to avoid conflicting changes. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891426 Title: Behat: Move quota checks to notification_quota.feature Status in Mahara: New Bug description: We have a test called /user_content/file_edit.feature which includes checks for the upload quota allowed. These would be better placed in /settings/notification_quota.feature. Remove steps related to quota from file_edit.feature and add them to notification_quota.feature in the section where UserA logs in (approx ln 33) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891426/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891430] [NEW] Behat: Rationalise tests for file and folder upload/edit/delete
Public bug reported: This bug report incorporates automating a manual test and merging two tests with duplicated functionality. These changes should be made after this Bug is complete: https://bugs.launchpad.net/mahara/+bug/1891426. It can be either a child patch or made after that patch is merged. 1. Merge the functionality of: /user_content/file_edit.feature /download_files_block.feature Make sure that the current functionality from both tests is still represented. Rename the merged test files_folders.feature. It can be the core test for this functionality. 2. Automating manual test. These are the details from the spreadsheet items: User can do the following - Drag and drop files ✘ - Create folders ✔ - Download files ✔ - Edit a file or folder ✔ - Delete a file or folder ✔ We can't test drag and drop, or that download works, but we can test the other things via behat. Edit the new files_folders.feature to include a check for a. editing the folder name: I press "Edit folder \"\"" b. deleting the folder ** Affects: mahara Importance: Undecided Assignee: Rangi Daymond (rangid) Status: New ** Tags: behat-test -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891430 Title: Behat: Rationalise tests for file and folder upload/edit/delete Status in Mahara: New Bug description: This bug report incorporates automating a manual test and merging two tests with duplicated functionality. These changes should be made after this Bug is complete: https://bugs.launchpad.net/mahara/+bug/1891426. It can be either a child patch or made after that patch is merged. 1. Merge the functionality of: /user_content/file_edit.feature /download_files_block.feature Make sure that the current functionality from both tests is still represented. Rename the merged test files_folders.feature. It can be the core test for this functionality. 2. Automating manual test. These are the details from the spreadsheet items: User can do the following - Drag and drop files ✘ - Create folders ✔ - Download files ✔ - Edit a file or folder ✔ - Delete a file or folder ✔ We can't test drag and drop, or that download works, but we can test the other things via behat. Edit the new files_folders.feature to include a check for a. editing the folder name: I press "Edit folder \"\"" b. deleting the folder To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891430/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891426] [NEW] Behat: Move quota checks to notification_quota.feature
Public bug reported: We have a test called /user_content/file_edit.feature which includes checks for the upload quota allowed. These would be better placed in /settings/notification_quota.feature. Remove steps related to quota from file_edit.feature and add them to notification_quota.feature in the section where UserA logs in (approx ln 33) Note there is also a bug report for reconciling the content of file_edit.feature. This bug should be completed before working on that one to avoid conflicting changes. ** Affects: mahara Importance: Undecided Assignee: Rangi Daymond (rangid) Status: New ** Tags: behat-test -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891426 Title: Behat: Move quota checks to notification_quota.feature Status in Mahara: New Bug description: We have a test called /user_content/file_edit.feature which includes checks for the upload quota allowed. These would be better placed in /settings/notification_quota.feature. Remove steps related to quota from file_edit.feature and add them to notification_quota.feature in the section where UserA logs in (approx ln 33) Note there is also a bug report for reconciling the content of file_edit.feature. This bug should be completed before working on that one to avoid conflicting changes. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891426/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891266] [NEW] Behat: Confirm correct homepage elements are present
Public bug reported: Automating a manual test. Copied from spreadsheet: Verify default dashboard includes the following blocks: Latest pages, My pages, Inbox, Topics I’m following (Note these titles are out of date. We need to check the current titles) Verify user can add or remove blocks via edit dashboard For this we can add to the homepage_buttons.feature. I suggest renaming it to homepage.feature and it can be the core test for items on that page. 1. Add a scenario called "Checking default blocks are displayed". 2. As the section commented "# check for bug 1493199 name changed from “Latest pages” to “Latest changes I can view”" includes a check for that, transfer it to the new scenario. 3. Add checks for the other defaults: Inbox Topics I am following My portfolios Watched pages 4. Follow "Edit dashboard" and confirm that the blocks all contain a "Remove block" option and that all except My portfolios contain a "Configure block" option. 5. Test that you can delete one of the blocks 6. Test that the configure modal opens for one of the blocks and that you can save a change. (Note that we are not interested in this test whether the options work.) 7. Return to the homepage and confirm the block you deleted is not displayed. ** Affects: mahara Importance: Undecided Assignee: Rangi Daymond (rangid) Status: New ** Tags: behat-test -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891266 Title: Behat: Confirm correct homepage elements are present Status in Mahara: New Bug description: Automating a manual test. Copied from spreadsheet: Verify default dashboard includes the following blocks: Latest pages, My pages, Inbox, Topics I’m following (Note these titles are out of date. We need to check the current titles) Verify user can add or remove blocks via edit dashboard For this we can add to the homepage_buttons.feature. I suggest renaming it to homepage.feature and it can be the core test for items on that page. 1. Add a scenario called "Checking default blocks are displayed". 2. As the section commented "# check for bug 1493199 name changed from “Latest pages” to “Latest changes I can view”" includes a check for that, transfer it to the new scenario. 3. Add checks for the other defaults: Inbox Topics I am following My portfolios Watched pages 4. Follow "Edit dashboard" and confirm that the blocks all contain a "Remove block" option and that all except My portfolios contain a "Configure block" option. 5. Test that you can delete one of the blocks 6. Test that the configure modal opens for one of the blocks and that you can save a change. (Note that we are not interested in this test whether the options work.) 7. Return to the homepage and confirm the block you deleted is not displayed. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891266/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891265] [NEW] Behat: Check Page->Advanced has an instrution field
Public bug reported: Automating a manual test. Copied from spreadsheet: Page instructions: Pages can be set up with instructions that sit at the top of the page rather than needing to use a block for that. Create a new portfolio page Confirm that there is a new field under the advanced accordion tab Label = “Instructions” Lock blocks: You can lock blocks to a page preventing their deletion from the page. While a portfolio author can remove the lock, at first look it is not possible to delete the blocks. Create a new portfolio page Confirm that there is a new toggle under the advanced accordion tab Label = “Lock blocks” we can add a few lines to create_delete_page.feature to check these things. In the section commented: "# This is the test for manually creating a page", at around line 25, before And I press "Save", open the "Advanced" accordion and look for instructions and lock blocks. ** Affects: mahara Importance: Undecided Assignee: Rangi Daymond (rangid) Status: New ** Tags: behat-test -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891265 Title: Behat: Check Page->Advanced has an instrution field Status in Mahara: New Bug description: Automating a manual test. Copied from spreadsheet: Page instructions: Pages can be set up with instructions that sit at the top of the page rather than needing to use a block for that. Create a new portfolio page Confirm that there is a new field under the advanced accordion tab Label = “Instructions” Lock blocks: You can lock blocks to a page preventing their deletion from the page. While a portfolio author can remove the lock, at first look it is not possible to delete the blocks. Create a new portfolio page Confirm that there is a new toggle under the advanced accordion tab Label = “Lock blocks” we can add a few lines to create_delete_page.feature to check these things. In the section commented: "# This is the test for manually creating a page", at around line 25, before And I press "Save", open the "Advanced" accordion and look for instructions and lock blocks. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891265/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891258] [NEW] Behat: Expand test for new background steps
Public bug reported: There is a test currently called /user_content/test.feature, which could be expanded to better test the background steps functionality. Currently it creates content using the background steps, and visits the created pages, but doesn't confirm the created content exists on the pages. 1. We should re-name the test to be more descriptive of its functionality - test_background_steps.feature would work. 2. Confirm that all the background steps are tested in this test. 3. Check that the content added in the background is displayed correctly on the page. ** Affects: mahara Importance: Undecided Assignee: Rangi Daymond (rangid) Status: New ** Tags: behat-test -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891258 Title: Behat: Expand test for new background steps Status in Mahara: New Bug description: There is a test currently called /user_content/test.feature, which could be expanded to better test the background steps functionality. Currently it creates content using the background steps, and visits the created pages, but doesn't confirm the created content exists on the pages. 1. We should re-name the test to be more descriptive of its functionality - test_background_steps.feature would work. 2. Confirm that all the background steps are tested in this test. 3. Check that the content added in the background is displayed correctly on the page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891258/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891255] [NEW] Behat: Check institution tag cancel works as expected
Public bug reported: Automating manual test. The following is copied from the spreadsheet: Make a selection from the Institution drop down menu Click on Create tag button Go to Institution tag field and enter a tag name Click on the cancel button User is returned to the Institution tag homepage In settings/institution_tags.feature we do a test for 'Creating Institution tags' - approx ln. 32. This section creates 2 tags and tests the delete feature removes one of them. We can add a test for creating a tag, clicking cancel and confirming the tag is not entered. ** Affects: mahara Importance: Undecided Assignee: Rangi Daymond (rangid) Status: New ** Tags: behat-test ** Changed in: mahara Assignee: (unassigned) => Rangi Daymond (rangid) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891255 Title: Behat: Check institution tag cancel works as expected Status in Mahara: New Bug description: Automating manual test. The following is copied from the spreadsheet: Make a selection from the Institution drop down menu Click on Create tag button Go to Institution tag field and enter a tag name Click on the cancel button User is returned to the Institution tag homepage In settings/institution_tags.feature we do a test for 'Creating Institution tags' - approx ln. 32. This section creates 2 tags and tests the delete feature removes one of them. We can add a test for creating a tag, clicking cancel and confirming the tag is not entered. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891255/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1890971] Re: Behat: Check 'Shared by me' defaults to correct page
** Changed in: mahara Status: New => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1890971 Title: Behat: Check 'Shared by me' defaults to correct page Status in Mahara: In Progress Bug description: Automating a manual test: From the main menu click on Share select Shared by me defaults to collection tab displays Collection name/Access list click on Pages tab displays Page title/Access list Add this functionality to the existing behat test adding_pages_collection.feature in the last block after the line "And I choose "Shared by me" in "Share" from main menu" (approx ln 50), since as the test is already on that page, it is easy at that point. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1890971/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1890973] Re: Behat: 'Shared with me' pages displayed in order of most recent comments
** Changed in: mahara Status: New => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1890973 Title: Behat: 'Shared with me' pages displayed in order of most recent comments Status in Mahara: In Progress Bug description: Automating manual test: From the main menu click on Share select Shared with me Displays Title/Comments/Last comments page lists the most recently modified or commented on pages that have been shared with you They may have been shared with you directly, shared with friends of the owner, or shared with one of your groups can add to /make_comment_public.feature to make sure this is covered: Add a test for the column headings and a test for the order of comments displayed. The existing test has pages sharing and comments, so should be straight-forward. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1890973/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891253] [NEW] Behat: Check institution tags cannot be edited by members
Public bug reported: Automating manual test. The following is copied from the spreadsheet: Institution tags cannot be edited by institution members. A test for this can be added to: settings/institution_tags.feature. We already have the following scenario: Scenario: Mahara member can use Institution tags in their content (ln 45 ish) After the tag has been saved, we need to go to Pages and Collections -> Tags and confirm the inst tag is not displayed after clicking Edit Tags. ** Affects: mahara Importance: Undecided Assignee: Rangi Daymond (rangid) Status: New ** Tags: behat-test ** Tags removed: behat ** Tags added: behat-test ** Changed in: mahara Assignee: (unassigned) => Rangi Daymond (rangid) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891253 Title: Behat: Check institution tags cannot be edited by members Status in Mahara: New Bug description: Automating manual test. The following is copied from the spreadsheet: Institution tags cannot be edited by institution members. A test for this can be added to: settings/institution_tags.feature. We already have the following scenario: Scenario: Mahara member can use Institution tags in their content (ln 45 ish) After the tag has been saved, we need to go to Pages and Collections -> Tags and confirm the inst tag is not displayed after clicking Edit Tags. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891253/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1890971] Re: Behat: Check 'Shared by me' defaults to correct page
** Changed in: mahara Assignee: (unassigned) => Rangi Daymond (rangid) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1890971 Title: Behat: Check 'Shared by me' defaults to correct page Status in Mahara: New Bug description: Automating a manual test: From the main menu click on Share select Shared by me defaults to collection tab displays Collection name/Access list click on Pages tab displays Page title/Access list Add this functionality to the existing behat test adding_pages_collection.feature in the last block after the line "And I choose "Shared by me" in "Share" from main menu" (approx ln 50), since as the test is already on that page, it is easy at that point. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1890971/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1890973] Re: Behat: 'Shared with me' pages displayed in order of most recent comments
** Changed in: mahara Assignee: (unassigned) => Rangi Daymond (rangid) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1890973 Title: Behat: 'Shared with me' pages displayed in order of most recent comments Status in Mahara: New Bug description: Automating manual test: From the main menu click on Share select Shared with me Displays Title/Comments/Last comments page lists the most recently modified or commented on pages that have been shared with you They may have been shared with you directly, shared with friends of the owner, or shared with one of your groups can add to /make_comment_public.feature to make sure this is covered: Add a test for the column headings and a test for the order of comments displayed. The existing test has pages sharing and comments, so should be straight-forward. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1890973/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891252] [NEW] Behat: Check tag is displayed in journal entry
Public bug reported: Automating manual test. Test from spreadsheet is below: Go to Journals click on Create journal button Enter title Enter page description Go to Tags and type in search term the drop down will pre populate Select a Tag Click on Create journal button Message ‘Journal entry saved’ is displayed User is returned to the Journals tab Click on New entry button Enter Title Enter Entry text Go to Tags and type in search term the drop down will pre populate Select a Tag Click on Save entry Message ‘Journal entry saved’ Tag displayed below the title This is mostly covered by /user_content/add_tags.feature, except check for tag displayed on page. We just need to add in the# Creating a Journal with tag section of the test a line to check that 'Tags: blue' is displayed after the entry is saved. ** Affects: mahara Importance: Undecided Assignee: Rangi Daymond (rangid) Status: New ** Tags: behat-test ** Changed in: mahara Assignee: (unassigned) => Rangi Daymond (rangid) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891252 Title: Behat: Check tag is displayed in journal entry Status in Mahara: New Bug description: Automating manual test. Test from spreadsheet is below: Go to Journals click on Create journal button Enter title Enter page description Go to Tags and type in search term the drop down will pre populate Select a Tag Click on Create journal button Message ‘Journal entry saved’ is displayed User is returned to the Journals tab Click on New entry button Enter Title Enter Entry text Go to Tags and type in search term the drop down will pre populate Select a Tag Click on Save entry Message ‘Journal entry saved’ Tag displayed below the title This is mostly covered by /user_content/add_tags.feature, except check for tag displayed on page. We just need to add in the# Creating a Journal with tag section of the test a line to check that 'Tags: blue' is displayed after the entry is saved. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891252/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891249] Re: Behat: Check tags are visible in page header
** Changed in: mahara Assignee: (unassigned) => Rangi Daymond (rangid) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891249 Title: Behat: Check tags are visible in page header Status in Mahara: New Bug description: Automating manual test. These are the details from the two spreadsheet items covered by this bug report: Go to Main menu create Pages and Collections click on Add button Create a page or collection popup box displayed Click on Collection Enter Collection name Enter Collection description Go to Tags and type in search term the drop down will pre populate Select a Tag Click on Next: Edit collection pages button Add pages to collection then click on add pages Pages will display in ‘Pages already in collection’ block Click on Done button User is returned to the Pages and collections page Verify page is auto populated with tagged content Go to Pages and Collections click on Add button Create a page or collection popup box displayed Click on Page Enter title Enter page description Go to Tags and type in search term the drop down will pre populate Select a Tag Click on Save Message ‘Page saved successfully’ is displayed Click on Display page button Page is displayed with Tag beneath the file name Both of these requirements look to be mostly covered by: /user_content/add_tags.feature What is not tested is that the tag is displayed in the header. We can add a display page and check for tag in the header, at approx ln 125 in this test. The reason for not adding anything specific to collections is that a collection of pages displays the pages, which in turn display the tags. The portfolio autopopulation by tag is tested. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891249/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891249] [NEW] Behat: Check tags are visible in page header
Public bug reported: Automating manual test. These are the details from the two spreadsheet items covered by this bug report: Go to Main menu create Pages and Collections click on Add button Create a page or collection popup box displayed Click on Collection Enter Collection name Enter Collection description Go to Tags and type in search term the drop down will pre populate Select a Tag Click on Next: Edit collection pages button Add pages to collection then click on add pages Pages will display in ‘Pages already in collection’ block Click on Done button User is returned to the Pages and collections page Verify page is auto populated with tagged content Go to Pages and Collections click on Add button Create a page or collection popup box displayed Click on Page Enter title Enter page description Go to Tags and type in search term the drop down will pre populate Select a Tag Click on Save Message ‘Page saved successfully’ is displayed Click on Display page button Page is displayed with Tag beneath the file name Both of these requirements look to be mostly covered by: /user_content/add_tags.feature What is not tested is that the tag is displayed in the header. We can add a display page and check for tag in the header, at approx ln 125 in this test. The reason for not adding anything specific to collections is that a collection of pages displays the pages, which in turn display the tags. The portfolio autopopulation by tag is tested. ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891249 Title: Behat: Check tags are visible in page header Status in Mahara: New Bug description: Automating manual test. These are the details from the two spreadsheet items covered by this bug report: Go to Main menu create Pages and Collections click on Add button Create a page or collection popup box displayed Click on Collection Enter Collection name Enter Collection description Go to Tags and type in search term the drop down will pre populate Select a Tag Click on Next: Edit collection pages button Add pages to collection then click on add pages Pages will display in ‘Pages already in collection’ block Click on Done button User is returned to the Pages and collections page Verify page is auto populated with tagged content Go to Pages and Collections click on Add button Create a page or collection popup box displayed Click on Page Enter title Enter page description Go to Tags and type in search term the drop down will pre populate Select a Tag Click on Save Message ‘Page saved successfully’ is displayed Click on Display page button Page is displayed with Tag beneath the file name Both of these requirements look to be mostly covered by: /user_content/add_tags.feature What is not tested is that the tag is displayed in the header. We can add a display page and check for tag in the header, at approx ln 125 in this test. The reason for not adding anything specific to collections is that a collection of pages displays the pages, which in turn display the tags. The portfolio autopopulation by tag is tested. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891249/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1890973] Re: Behat: 'Shared with me' pages displayed in order of most recent comments
** Summary changed: - Behat: 'Shared by me' pages displayed in order of most recent comments + Behat: 'Shared with me' pages displayed in order of most recent comments -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1890973 Title: Behat: 'Shared with me' pages displayed in order of most recent comments Status in Mahara: New Bug description: Automating manual test: From the main menu click on Share select Shared with me Displays Title/Comments/Last comments page lists the most recently modified or commented on pages that have been shared with you They may have been shared with you directly, shared with friends of the owner, or shared with one of your groups can add to /make_comment_public.feature to make sure this is covered: Add a test for the column headings and a test for the order of comments displayed. The existing test has pages sharing and comments, so should be straight-forward. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1890973/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1890973] [NEW] Behat: 'Shared by me' pages displayed in order of most recent comments
Public bug reported: Automating manual test: >From the main menu click on Share > select Shared with me Displays Title/Comments/Last comments page lists the most recently modified or commented on pages that have been shared with you They may have been shared with you directly, shared with friends of the owner, or shared with one of your groups can add to /make_comment_public.feature to make sure this is covered: Add a test for the column headings and a test for the order of comments displayed. The existing test has pages sharing and comments, so should be straight-forward. ** Affects: mahara Importance: Undecided Status: New ** Tags: behat-test -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1890973 Title: Behat: 'Shared by me' pages displayed in order of most recent comments Status in Mahara: New Bug description: Automating manual test: From the main menu click on Share select Shared with me Displays Title/Comments/Last comments page lists the most recently modified or commented on pages that have been shared with you They may have been shared with you directly, shared with friends of the owner, or shared with one of your groups can add to /make_comment_public.feature to make sure this is covered: Add a test for the column headings and a test for the order of comments displayed. The existing test has pages sharing and comments, so should be straight-forward. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1890973/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1890971] [NEW] Behat: Check 'Shared by me' defaults to correct page
Public bug reported: Automating a manual test: >From the main menu click on Share select Shared by me defaults to collection tab displays Collection name/Access listclick on Pages tab displays Page title/Access list Add this functionality to the existing behat test adding_pages_collection.feature in the last block after the line "And I choose "Shared by me" in "Share" from main menu" (approx ln 50), since as the test is already on that page, it is easy at that point. ** Affects: mahara Importance: Undecided Status: New ** Tags: behat-test -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1890971 Title: Behat: Check 'Shared by me' defaults to correct page Status in Mahara: New Bug description: Automating a manual test: From the main menu click on Share select Shared by me defaults to collection tab displays Collection name/Access list click on Pages tab displays Page title/Access list Add this functionality to the existing behat test adding_pages_collection.feature in the last block after the line "And I choose "Shared by me" in "Share" from main menu" (approx ln 50), since as the test is already on that page, it is easy at that point. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1890971/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1890225] [NEW] Replace oauth-php library with PHPs OAuth or similar
Public bug reported: In Webservices we currently have this library (from the README.Mahara): Website: https://code.google.com/archive/p/oauth-php/ Version: 175 Notes: This package is not maintained and was last updated in 2010 This library is used to provide the OAuth 1.x server side processing. We should replace with an oauth2 php library https://oauth.net/code/php/ or checkout what Moodle do. This needs some investigation to see how it's currently being used and what an equivalent and up-to-date replacement would be. ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1890225 Title: Replace oauth-php library with PHPs OAuth or similar Status in Mahara: New Bug description: In Webservices we currently have this library (from the README.Mahara): Website: https://code.google.com/archive/p/oauth-php/ Version: 175 Notes: This package is not maintained and was last updated in 2010 This library is used to provide the OAuth 1.x server side processing. We should replace with an oauth2 php library https://oauth.net/code/php/ or checkout what Moodle do. This needs some investigation to see how it's currently being used and what an equivalent and up-to-date replacement would be. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1890225/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1890218] [NEW] Plugin jQuery UI touchpunch no longer maintained
Public bug reported: >From the github page: jQuery UI Touch Punch is a small hack that enables the use of touch events on sites using the jQuery UI user interface library. https://github.com/furf/jquery-ui-touch-punch Touch Punch works by using simulated events to map touch events to their mouse event analogs. This library was last updated in 2014. Given the proliferation of touch devices since then it seems maybe it might have been superseded? Or maybe we don't need it anymore? We should investigate whether we need this old library still. ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1890218 Title: Plugin jQuery UI touchpunch no longer maintained Status in Mahara: New Bug description: From the github page: jQuery UI Touch Punch is a small hack that enables the use of touch events on sites using the jQuery UI user interface library. https://github.com/furf/jquery-ui-touch-punch Touch Punch works by using simulated events to map touch events to their mouse event analogs. This library was last updated in 2014. Given the proliferation of touch devices since then it seems maybe it might have been superseded? Or maybe we don't need it anymore? We should investigate whether we need this old library still. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1890218/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1890217] [NEW] Replace unmaintained Dwoo templating engine
Public bug reported: The Dwoo templating engine, which we use to process all our Smarty templates is no longer maintained. The website has been taken down and the Github project is archived: https://github.com/dwoo-project/dwoo This may start to cause problems for us as PHP moves on and Dwoo does not keep up with the new code. Currently it has been unmaintained since 2018. It looks like Dwoo was developed to make Smarty faster, but perhaps it is no longer faster. Smarty is at least patched for the latest PHP versions. We need to investigate what to do next in order to not be relying on an unmaintained library for all our templating. We can probably patch it ourselves for a limited time, but will need to move on from Dwoo. ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1890217 Title: Replace unmaintained Dwoo templating engine Status in Mahara: New Bug description: The Dwoo templating engine, which we use to process all our Smarty templates is no longer maintained. The website has been taken down and the Github project is archived: https://github.com/dwoo-project/dwoo This may start to cause problems for us as PHP moves on and Dwoo does not keep up with the new code. Currently it has been unmaintained since 2018. It looks like Dwoo was developed to make Smarty faster, but perhaps it is no longer faster. Smarty is at least patched for the latest PHP versions. We need to investigate what to do next in order to not be relying on an unmaintained library for all our templating. We can probably patch it ourselves for a limited time, but will need to move on from Dwoo. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1890217/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1865115] [NEW] Library upgrades: Check status of third party libraries
Public bug reported: We need to run through the list of third party libraries and make notes about what changes have been made so a decision can be made on what to update before the next release. https://wiki.mahara.org/wiki/Developer_Area/Plugins/Third_party ** Affects: mahara Importance: Undecided Assignee: Rebecca Blundell (rjb-dev) Status: In Progress ** Changed in: mahara Assignee: (unassigned) => Rebecca Blundell (rjb-dev) ** Changed in: mahara Status: New => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1865115 Title: Library upgrades: Check status of third party libraries Status in Mahara: In Progress Bug description: We need to run through the list of third party libraries and make notes about what changes have been made so a decision can be made on what to update before the next release. https://wiki.mahara.org/wiki/Developer_Area/Plugins/Third_party To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1865115/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1863533] [NEW] Stop popper warning that map file doesn't exist
Public bug reported: Currently the popper library is logging a warning that popper.min.js.map does not exist: error.log.1:1172:[Fri Feb 14 13:50:53.397235 2020] [core:info] [pid 5090] [client 192.xxx.xxx.xx:50078] AH00128: File does not exist: /htdocs/js/popper/popper.min.js.map access.log.1:7223:192.xxx.xxx.xx - - [17/Feb/2020:13:58:41 +1300] "GET //js/popper/popper.min.js?v=8673 HTTP/1.1" 200 7820 "http:///admin/extensions/pluginconfig.php?plugintype=search=elasticsearch" "Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:73.0) Gecko/20100101 Firefox/73.0 I found this when configuring elasticsearch, but it is possible it is triggered on other occasions popper is used. This seems to happen because the last line of htdocs/js/popper.min.js is: //# sourceMappingURL=popper.min.js.map Even though the line is commented out, it seems to trigger this warning that the map file doesn't exist. The map file is not required. A quick fix is to remove the line entirely. We need to check it that is the best solution, however. ** Affects: mahara Importance: Undecided Status: New ** Tags: bite-sized ** Description changed: Currently the popper library is logging a warning that popper.min.js.map does not exist: error.log.1:1172:[Fri Feb 14 13:50:53.397235 2020] [core:info] [pid - 5090] [client 192.168.194.44:50078] AH00128: File does not exist: + 5090] [client 192.xxx.xxx.xx:50078] AH00128: File does not exist: /htdocs/js/popper/popper.min.js.map - access.log.1:7223:192.168.194.44 - - [17/Feb/2020:13:58:41 +1300] "GET + access.log.1:7223:192.xxx.xxx.xx - - [17/Feb/2020:13:58:41 +1300] "GET //js/popper/popper.min.js?v=8673 HTTP/1.1" 200 7820 "http:///admin/extensions/pluginconfig.php?plugintype=search=elasticsearch" "Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:73.0) Gecko/20100101 Firefox/73.0 I found this when configuring elasticsearch, but it is possible it is triggered on other occasions popper is used. This seems to happen because the last line of htdocs/js/popper.min.js is: //# sourceMappingURL=popper.min.js.map Even though the line is commented out, it seems to trigger this warning that the map file doesn't exist. The map file is not required. A quick fix is to remove the line entirely. We need to check it that is the best solution, however. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1863533 Title: Stop popper warning that map file doesn't exist Status in Mahara: New Bug description: Currently the popper library is logging a warning that popper.min.js.map does not exist: error.log.1:1172:[Fri Feb 14 13:50:53.397235 2020] [core:info] [pid 5090] [client 192.xxx.xxx.xx:50078] AH00128: File does not exist: /htdocs/js/popper/popper.min.js.map access.log.1:7223:192.xxx.xxx.xx - - [17/Feb/2020:13:58:41 +1300] "GET //js/popper/popper.min.js?v=8673 HTTP/1.1" 200 7820 "http:///admin/extensions/pluginconfig.php?plugintype=search=elasticsearch" "Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:73.0) Gecko/20100101 Firefox/73.0 I found this when configuring elasticsearch, but it is possible it is triggered on other occasions popper is used. This seems to happen because the last line of htdocs/js/popper.min.js is: //# sourceMappingURL=popper.min.js.map Even though the line is commented out, it seems to trigger this warning that the map file doesn't exist. The map file is not required. A quick fix is to remove the line entirely. We need to check it that is the best solution, however. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1863533/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1840101] Re: Library upgrade: Elasticsearch to 7.1.1
The update that this bug number now refers to is: elasticsearch-php: 7.4 to work with elasticsearch server: 7.6 There is an existing (interim) under the same bug number for elasticsearch-php 7.2 which works with elastisearch server 6.8 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1840101 Title: Library upgrade: Elasticsearch to 7.1.1 Status in Mahara: In Progress Bug description: Related to: https://bugs.launchpad.net/mahara/+bug/1827291 Elasticsearch is now at version 7.1.1. (We are on 6.1). Note that installing version 7.0.0 and above requires PHP 7.1 to work. https://github.com/elastic/elasticsearch-php/blob/master/CHANGELOG.md To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1840101/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1749308] Re: Collection navigation triggering swiperight event on mouse click
** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1749308 Title: Collection navigation triggering swiperight event on mouse click Status in Mahara: In Progress Bug description: Mahara: 17.10.3 OS: Linux 16.04 DB: Postgres (not relevant) Browser: Firefox and Chrome In a collection on a view with the 'Previous page' displayed, the swiperight event is getting triggered on a mouse click. When a user tries to select some text (i.e. click mouse, hold it down, and select text), this action is interpreted as a swipe action. And, the swiperight event is triggered. I've come across this stackoverflow discussion: https://stackoverflow.com/questions/36317660/jquery-mobile-swipe- gesture-for-touch-screen-only-and-not-for-mouse Bascially, the swiperight and swipeleft events should be disabled on the mousedown event and enabled on the touchstart event. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1749308/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1749308] Re: Collection navigation triggering swiperight event on mouse click
** Changed in: mahara Assignee: (unassigned) => Rebecca Blundell (rjb-dev) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1749308 Title: Collection navigation triggering swiperight event on mouse click Status in Mahara: Confirmed Bug description: Mahara: 17.10.3 OS: Linux 16.04 DB: Postgres (not relevant) Browser: Firefox and Chrome In a collection on a view with the 'Previous page' displayed, the swiperight event is getting triggered on a mouse click. When a user tries to select some text (i.e. click mouse, hold it down, and select text), this action is interpreted as a swipe action. And, the swiperight event is triggered. I've come across this stackoverflow discussion: https://stackoverflow.com/questions/36317660/jquery-mobile-swipe- gesture-for-touch-screen-only-and-not-for-mouse Bascially, the swiperight and swipeleft events should be disabled on the mousedown event and enabled on the touchstart event. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1749308/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1788538] Re: Behat: should see in row step passes/fails for same text
I've re-tested this and it no longer seems to be an issue. ** Changed in: mahara Status: Confirmed => Incomplete -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1788538 Title: Behat: should see in row step passes/fails for same text Status in Mahara: Incomplete Bug description: In making a step for 'I should not see "blah" in the "blah" row', I found a problem with 'I should see "blah" in the "blah" row'. 'And I should see "Edit General discussion" in the "General discussion" row' in the test below seems to pass regardless of whether it's true or not. There's some hidden screen-reader text in the row that contains "Edit", but the full text is not in the page. I suspect it's an issue with how the xpath is being generated, or what is done with it. There's a line in the i_find_in_row function (BehatGeneral.php ln 495) that assigns a $rownode variable that is never used. @javascript @core Feature: Mahara users can participate in groups As a mahara user I need to participate in groups Background: Given the following "users" exist: | username | password | email | firstname | lastname | institution | authname | role | | UserA | Kupuh1pa! | us...@example.org | Angela | User | mahara | internal | member | | UserB | Kupuh1pa! | us...@example.org | Bob | User | mahara | internal | member | | UserC | Kupuh1pa! | us...@example.org | Cecilia | User | mahara | internal | member | | UserD | Kupuh1pa! | us...@example.org | Dmitri | User | mahara | internal | member | | UserE | Kupuh1pa! | us...@example.org | Evonne | User | mahara | internal | member | And the following "groups" exist: | name | owner | description | grouptype | open | invitefriends | editroles | submittableto | allowarchives | members | staff | | GroupA | UserA | GroupA owned by UserA | standard | ON | ON | all | ON | ON | UserB, UserC | UserD | Scenario: Verify group member can not see Edit forum or Delete forum only New topic and Unsubscribe from forum Given I log in as "UserB" with password "Kupuh1pa!" And I follow "GroupA" And I follow "Forums (tab)" Then I should see "Unsubscribe" in the "General discussion" row And I should see "Edit General discussion" in the "General discussion" row And I should not see "Delete General discussion" in the "General discussion" row To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1788538/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1853230] Re: Library upgrade: jTLine needs updating to fix jquery deprecations
** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1853230 Title: Library upgrade: jTLine needs updating to fix jquery deprecations Status in Mahara: In Progress Bug description: While working on: https://bugs.launchpad.net/mahara/+bug/1843357 I found jTLine has a deprecated jQuery selector. We could fix this manually or update the library. The latest version of the file we use (https://github.com/naadydev/jTLine/blob/master/js/jtline.js) doesn't contain the deprecation, so it would make sense to grab that as long as it still works with the rest of Mahara. The only reason I would hesitate is that it doesn't look like an actively maintained library, so if it requires re-work on the Mahara side, it might not be worth our while. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1853230/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1853230] Re: Library upgrade: jTLine needs updating to fix jquery deprecations
** Changed in: mahara Assignee: (unassigned) => Rebecca Blundell (rjb-dev) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1853230 Title: Library upgrade: jTLine needs updating to fix jquery deprecations Status in Mahara: Confirmed Bug description: While working on: https://bugs.launchpad.net/mahara/+bug/1843357 I found jTLine has a deprecated jQuery selector. We could fix this manually or update the library. The latest version of the file we use (https://github.com/naadydev/jTLine/blob/master/js/jtline.js) doesn't contain the deprecation, so it would make sense to grab that as long as it still works with the rest of Mahara. The only reason I would hesitate is that it doesn't look like an actively maintained library, so if it requires re-work on the Mahara side, it might not be worth our while. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1853230/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1859528] Re: Update adodb to version 5.21.0 (due 31/1/2020)
** Changed in: mahara Assignee: (unassigned) => Rebecca Blundell (rjb-dev) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1859528 Title: Update adodb to version 5.21.0 (due 31/1/2020) Status in Mahara: Confirmed Bug description: Adodb requires some changes to work with PHP 7.4. The January 31 2020 release includes fixes for all of the current issues: https://github.com/ADOdb/ADOdb/milestone/2 We should update our version when it is released. We are currently on 5.20.14. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1859528/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1845507] Re: PHP 7.3
Should be fixed by patch for https://bugs.launchpad.net/mahara/+bug/1839411 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1845507 Title: PHP 7.3 Status in Mahara: Confirmed Bug description: When using Mahara against PHP 7.3, the log file is cluttered with warnings like [WAR] 2c (lib/view.php:1555) "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? and several lines of stack trace. I have no knowledge of PHP, but the second item on this page seems to be the problem: https://www.php.net/manual/en/migration73.incompatible.php It would be great if this could be fixed in order to reduce the noise in the log :) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1845507/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1745250] Re: composer.json settings allow dev versions for php: Specify max version
This was fixed in another patch: https://bugs.launchpad.net/mahara/+bug/1772792 ** Changed in: mahara/20.04 Status: In Progress => Fix Released ** Changed in: mahara/19.10 Status: Confirmed => Fix Released ** No longer affects: mahara/20.04 ** No longer affects: mahara/19.10 ** Changed in: mahara Milestone: 20.04.0 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1745250 Title: composer.json settings allow dev versions for php: Specify max version Status in Mahara: Fix Released Bug description: Looking at composer.json to see if we should update dependencies to make tests run better, I see that our syntax for php >=5.3.3 allows any version above that specified with default stability as dev. It explains how I ended up with php 7.2 after running make initcomposer... I think our default stability should be stable and that we should think about specifying a maximum version. Should we also change our settings to allow some other upgrades if there is a new stable non-breaking release, or just leave things pinned? If we change to "^version", it allows upgrades up to but not including the next major version, which seems reasonable?? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1745250/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1745250] Re: composer.json settings allow dev versions for php: Specify max version
** Changed in: mahara/20.04 Assignee: (unassigned) => Rebecca Blundell (rjb-dev) ** Changed in: mahara/20.04 Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1745250 Title: composer.json settings allow dev versions for php: Specify max version Status in Mahara: In Progress Status in Mahara 19.10 series: Confirmed Status in Mahara 20.04 series: In Progress Bug description: Looking at composer.json to see if we should update dependencies to make tests run better, I see that our syntax for php >=5.3.3 allows any version above that specified with default stability as dev. It explains how I ended up with php 7.2 after running make initcomposer... I think our default stability should be stable and that we should think about specifying a maximum version. Should we also change our settings to allow some other upgrades if there is a new stable non-breaking release, or just leave things pinned? If we change to "^version", it allows upgrades up to but not including the next major version, which seems reasonable?? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1745250/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1840099] Re: Library upgrade: CSS Tidy to 1.7.0
Actually, now the update is to 1.7.1, which includes PHP7.4 updates -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1840099 Title: Library upgrade: CSS Tidy to 1.7.0 Status in Mahara: In Progress Status in Mahara 19.10 series: Confirmed Status in Mahara 20.04 series: In Progress Bug description: Related to: https://bugs.launchpad.net/mahara/+bug/1827291 Update CSS Tidy to 1.7.0 for support of nested @media and @supports rules https://github.com/Cerdic/CSSTidy To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1840099/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1860941] Re: Behat: can't target property
At the time we are looking for the text "Note page1 block1 original title" in the modal title, the value of the title field, #instconf_title is "Placeholder", so Behat is unable to 'see' the title. In the page source there are 6 instances of the title we are looking for, but none of those 6 are the one we want to target. Once the modal has been saved and the data written back, it exists in the field and can be found be Behat if the configure modal is opened up again. The question this raises is, if we can see it on the page, shouldn't the value of the field reflect what is displayed at the time? As functionality is not affected, maybe we just label this "won't fix" and do the tests after the "Save" has happened. ** Attachment added: "Screenshot from 2020-01-28 17-28-38.png" https://bugs.launchpad.net/mahara/+bug/1860941/+attachment/5323434/+files/Screenshot%20from%202020-01-28%2017-28-38.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1860941 Title: Behat: can't target property Status in Mahara: New Bug description: Need to look into why Behat can't see text in the block title field of the copy_note modal (refer patch for bug 1044878) --- Failed steps: 001 Scenario: Page1 - create note with content then use it to create another note (via copy) # /home/rdaymond/code/behat/mahara/test/behat/features/user_content/copy_note_content.feature:17 And I should see "Note page1 block 1 original" in the "Block title" property # /home/rdaymond/code/behat/mahara/test/behat/features/user_content/copy_note_content.feature:43 "Note page1 block 1 original" text was not found in the "#instconf_title" element (Behat\Mink\Exception\ExpectationException) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1860941/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1860941] Re: Behat: can't target property
** Changed in: mahara Assignee: (unassigned) => Rebecca Blundell (rjb-dev) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1860941 Title: Behat: can't target property Status in Mahara: New Bug description: Need to look into why Behat can't see text in the block title field of the copy_note modal (refer patch for bug 1044878) --- Failed steps: 001 Scenario: Page1 - create note with content then use it to create another note (via copy) # /home/rdaymond/code/behat/mahara/test/behat/features/user_content/copy_note_content.feature:17 And I should see "Note page1 block 1 original" in the "Block title" property # /home/rdaymond/code/behat/mahara/test/behat/features/user_content/copy_note_content.feature:43 "Note page1 block 1 original" text was not found in the "#instconf_title" element (Behat\Mink\Exception\ExpectationException) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1860941/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1767933] Re: Behat copies html styling regardless of whether the option for an html report is passed in
** Changed in: mahara Assignee: (unassigned) => Rebecca Blundell (rjb-dev) ** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1767933 Title: Behat copies html styling regardless of whether the option for an html report is passed in Status in Mahara: In Progress Bug description: When running behat tests with the html flag as in: ./test/behat/mahara_behat.sh run test.feature html the styling needs to be copied over to the plugin folder to make the report display correctly. If the test is being run without 'html', there is no need for the styling to be copied over. Currently this happens regardless. Currently the function set_report_styling is called during behat setup from /htdocs/testing/frameworks/behat/cli/util.php. In order to fix this there should be an if statement around that call. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1767933/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1859528] [NEW] Update adodb to version 5.21.0 (due 31/1/2020)
Public bug reported: Adodb requires some changes to work with PHP 7.4. The January 31 2020 release includes fixes for all of the current issues: https://github.com/ADOdb/ADOdb/milestone/2 We should update our version when it is released. We are currently on 5.20.14. ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1859528 Title: Update adodb to version 5.21.0 (due 31/1/2020) Status in Mahara: New Bug description: Adodb requires some changes to work with PHP 7.4. The January 31 2020 release includes fixes for all of the current issues: https://github.com/ADOdb/ADOdb/milestone/2 We should update our version when it is released. We are currently on 5.20.14. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1859528/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1855798] Re: Database anomalies and orphan tables
Orphan tables are stand-alone tables without any foreign key relations,
so they don't have any relationships with other tables. In theory, they
shouldn't exist in a relational database, so I suppose that there are
some foreign key constraints not set up that should be between these
tables and others.
I had a look at blocktype_taggedposts_tags. The block_instance instance
field in there looks to be the id from the block_instance table, however
that relationship is not referenced in the database:
mahara-master=> select * from blocktype_taggedposts_tags;
-[ RECORD 1 ]--+-
id | 1
block_instance | 38
tag| cats
tagtype| 1
mahara-master=> select * from block_instance
where id=38;
-[ RECORD 1
]
id | 38
blocktype | taggedposts
title | Tagged journal entries
configdata |
a:5:{s:5:"count";s:2:"10";s:8:"copytype";s:6:"nocopy";s:4:"full";b:0;s:11:"retractable";b:0;s:15:"retractedonload";b:0;}
view | 11
row|
column |
order |
mahara-master=> \d block_instance
Table "public.block_instance"
Column | Type | Collation | Nullable |
Default
++---+--+
id | bigint | | not null |
nextval('block_instance_id_seq'::regclass)
blocktype | character varying(255) | | not null |
title | character varying(255) | | not null |
configdata | text | | |
view | bigint | | not null |
row| smallint | | | 1
column | smallint | | |
order | smallint | | |
Indexes:
"blocinst_id_pk" PRIMARY KEY, btree (id)
"blocinst_blo_ix" btree (blocktype)
"blocinst_vie_ix" btree (view)
Foreign-key constraints:
"blocinst_blo_fk" FOREIGN KEY (blocktype) REFERENCES
blocktype_installed(name)
"blocinst_vie_fk" FOREIGN KEY (view) REFERENCES view(id)
Referenced by:
TABLE "artefact_peer_assessment" CONSTRAINT "artepeerasse_blo_fk" FOREIGN
KEY (block) REFERENCES block_instance(id)
TABLE "block_instance_dimension" CONSTRAINT "blocinstdime_blo_fk" FOREIGN
KEY (block) REFERENCES block_instance(id)
TABLE "blocktype_wall_post" CONSTRAINT "blocwallpost_ins_fk" FOREIGN KEY
(instance) REFERENCES block_instance(id)
TABLE "framework_evidence" CONSTRAINT "framevid_ann_fk" FOREIGN KEY
(annotation) REFERENCES block_instance(id)
TABLE "view_artefact" CONSTRAINT "viewarte_blo_fk" FOREIGN KEY (block)
REFERENCES block_instance(id)
TABLE "watchlist_queue" CONSTRAINT "watcqueu_blo_fk" FOREIGN KEY (block)
REFERENCES block_instance(id)
mahara-master=> \d blocktype_taggedposts_tags
Table
"public.blocktype_taggedposts_tags"
Column | Type | Collation | Nullable |
Default
++---+--+
id | bigint | | not null |
nextval('blocktype_taggedposts_tags_id_seq'::regclass)
block_instance | bigint | | not null |
tag| character varying(128) | | not null |
tagtype| bigint | | not null |
Indexes:
"bloctaggtags_id_pk" PRIMARY KEY, btree (id)
"bloctaggtags_tagtag_ix" btree (tag, tagtype)
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1855798
Title:
Database anomalies and orphan tables
Status in Mahara:
New
Bug description:
While investigating how to map out Mahara and see what connects to
what a discovered a db schema-mapping tool. (Details in the bug
report: https://bugs.launchpad.net/mahara/+bug/1855630)
That highlighted some issues with our db schema:
'Anomalies'
We have 3 tables that contain a single column:
artefact_comment_deletedby
event_type
view_type
We have 1 table with incrementing column names, potentially indicating
denormalization
usr_friend
We have a number of orphan tables listed in the comment below.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1855798/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe :
[Mahara-contributors] [Bug 1839411] Re: Update codebase for php 7.3 and php 7.4
Notes after reading documentation on what might affect Mahara. I have included a note about anything here that has changed that we use in the code, regardless of whether a change is needed. Many of these are in the category of 'check this to make sure' rather than 'we have to make changes'. Some things are hard to check for issues with, so it may be necessary to upgrade and see what breaks. PHP 7.3 continue in switch statements behaves as break. This is not new, but the correct usage is break or continue2 depending on what you want. some differences with how doc strings work, implicit conversion of array object "123" to 123 won't happen; static props can't be separated from the parent class; Assigning by reference happens on access; getimagesize() now report the mime type of BMP images as image/bmp instead of image/x-ms-bmp (do we rely on this behaviour anywhere?) simplexml uses float as well as int now, implicitally. (Any probs with this?) libcurl ≥ 7.15.5 is now required. https://www.php.net/manual/en/migration73.incompatible.php 7.4 Strong typing is supported. checkout str_split - possibly better to use mb_str_split in 7.4??(but not backwards, so no.) PDO stuff important to know. strip_tags() easier check fread() for tests of ''. Now a non-read will be false (7.4) in cli.php/ file.php ... Check for comparisons on DateTime objects Check usage of get_object_vars(array) for use to get values. Check for non-bracketed nested ternary operators adodb has calls to deprecated functions get_magic_quotes_gpc() and get_magic_quotes_runtime(). Look for update Also calls fgetcsv which has changed function. Passing parameters to implode() in reverse order is deprecated, use implode($glue, $parts) instead of implode($parts, $glue). Fix this. Check behaviour of parse_data in csvfile.php (change to funct fgetcsv()) Check behaviour of imagescale() in skin.php (Change to funct) check libxml version (needs to be at least 2.7.6) Do we need PEAR for stuff (I think so.) Check what happens on install. We may need to enable it. (It's no longer enabled by default). Changes to constants in ReflectionClass may affect $refClass in errors.php Changes to constants in ReflectionFunction may affect $refFunc in errors.php Elasticsearch and Dwoo also rely on ReflectionFunction - check for update. Changes to constants in ReflectionMethod may affect Dwoo, Elasticsearch and htmlpurifier - check for update SImpleXMLElement implements Countable now - check if that means any new errors/usage changes Does removal of libzip have any flow-on effects (e.g. need to include another syslib in instructions?) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1839411 Title: Update codebase for php 7.3 and php 7.4 Status in Mahara: Confirmed Bug description: I tried running behat tests in php 7.3 and among other issues got the following error due to a PHP 7.3 deprecation: /code/mahara/test/behat/features/site_features/smart_evidence_editor.feature:8 8192: strpos(): Non-string needles will be interpreted as strings in the future. Use an explicit chr() call to preserve the current behavior in ~/code/mahara/htdocs/lib/mahara.php line 1620 This made me think we should check the code for this and other 7.3 issues. Notes on migrating to 7.3: https://www.php.net/manual/en/migration73.php And on migrating to 7.4: https://www.php.net/manual/en/migration74.php To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1839411/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1839411] Re: Update codebase for php 7.3 and php 7.4
** Description changed: I tried running behat tests in php 7.3 and among other issues got the following error due to a PHP 7.3 deprecation: /code/mahara/test/behat/features/site_features/smart_evidence_editor.feature:8 - 8192: strpos(): Non-string needles will be interpreted as strings in the future. Use an explicit chr() call to preserve the current behavior in ~/code/mahara/htdocs/lib/mahara.php line 1620 + 8192: strpos(): Non-string needles will be interpreted as strings in the future. Use an explicit chr() call to preserve the current behavior in ~/code/mahara/htdocs/lib/mahara.php line 1620 - This made me think we should check the code for this and other 7.3 issues. Notes on migrating to 7.3: + This made me think we should check the code for this and other 7.3 issues. Notes on migrating to 7.3: https://www.php.net/manual/en/migration73.php + + And on migrating to 7.4: + https://www.php.net/manual/en/migration74.php -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1839411 Title: Update codebase for php 7.3 and php 7.4 Status in Mahara: Confirmed Bug description: I tried running behat tests in php 7.3 and among other issues got the following error due to a PHP 7.3 deprecation: /code/mahara/test/behat/features/site_features/smart_evidence_editor.feature:8 8192: strpos(): Non-string needles will be interpreted as strings in the future. Use an explicit chr() call to preserve the current behavior in ~/code/mahara/htdocs/lib/mahara.php line 1620 This made me think we should check the code for this and other 7.3 issues. Notes on migrating to 7.3: https://www.php.net/manual/en/migration73.php And on migrating to 7.4: https://www.php.net/manual/en/migration74.php To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1839411/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1839411] Re: Update codebase for php 7.3 and php 7.4
** Summary changed: - Update codebase for php 7.3 + Update codebase for php 7.3 and php 7.4 ** Changed in: mahara Assignee: (unassigned) => Rebecca Blundell (rjb-dev) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1839411 Title: Update codebase for php 7.3 and php 7.4 Status in Mahara: Confirmed Bug description: I tried running behat tests in php 7.3 and among other issues got the following error due to a PHP 7.3 deprecation: /code/mahara/test/behat/features/site_features/smart_evidence_editor.feature:8 8192: strpos(): Non-string needles will be interpreted as strings in the future. Use an explicit chr() call to preserve the current behavior in ~/code/mahara/htdocs/lib/mahara.php line 1620 This made me think we should check the code for this and other 7.3 issues. Notes on migrating to 7.3: https://www.php.net/manual/en/migration73.php To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1839411/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
