[Mahara-contributors] [Bug 1046750] Re: Show more of the file name
** Changed in: mahara Milestone: 1.8rc1 = 1.8.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1046750 Title: Show more of the file name Status in Mahara ePortfolio: Fix Committed Bug description: https://mahara.org/interaction/forum/topic.php?id=4841 The file names are shortened too quickly when they are long and are not easily readable. A potential solution for showing more is proposed in the forum discussion, but maybe it can be made more flexible and depend on the width of the block? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1046750/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1046750] Re: Show more of the file name
** Changed in: mahara Status: In Progress = Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib members https://bugs.launchpad.net/bugs/1046750 Title: Show more of the file name Status in Mahara ePortfolio: Fix Committed Bug description: https://mahara.org/interaction/forum/topic.php?id=4841 The file names are shortened too quickly when they are long and are not easily readable. A potential solution for showing more is proposed in the forum discussion, but maybe it can be made more flexible and depend on the width of the block? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1046750/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1046750] Re: Show more of the file name
It's worth noting, to anyone following this bug, that there is some discussion about the merits of eliminating filename display lengths, in the review comments for https://reviews.mahara.org/2376 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib members https://bugs.launchpad.net/bugs/1046750 Title: Show more of the file name Status in Mahara ePortfolio: In Progress Bug description: https://mahara.org/interaction/forum/topic.php?id=4841 The file names are shortened too quickly when they are long and are not easily readable. A potential solution for showing more is proposed in the forum discussion, but maybe it can be made more flexible and depend on the width of the block? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1046750/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1046750] Re: Show more of the file name
I added a separate bug report for the collectionnav.tpl issue here https://bugs.launchpad.net/mahara/+bug/1203965 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib members https://bugs.launchpad.net/bugs/1046750 Title: Show more of the file name Status in Mahara ePortfolio: Triaged Bug description: https://mahara.org/interaction/forum/topic.php?id=4841 The file names are shortened too quickly when they are long and are not easily readable. A potential solution for showing more is proposed in the forum discussion, but maybe it can be made more flexible and depend on the width of the block? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1046750/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1046750] Re: Show more of the file name
Dirk submitted a patch for this: https://reviews.mahara.org/#/c/2368/ -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib members https://bugs.launchpad.net/bugs/1046750 Title: Show more of the file name Status in Mahara ePortfolio: Triaged Bug description: https://mahara.org/interaction/forum/topic.php?id=4841 The file names are shortened too quickly when they are long and are not easily readable. A potential solution for showing more is proposed in the forum discussion, but maybe it can be made more flexible and depend on the width of the block? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1046750/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1046750] Re: Show more of the file name
With Evonne's new theme changes, lengthy filenames wrap around quite nicely, so I no longer see any need to truncate them at all. I'll submit a patch to eliminate the limit on the display of filenames. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib members https://bugs.launchpad.net/bugs/1046750 Title: Show more of the file name Status in Mahara ePortfolio: In Progress Bug description: https://mahara.org/interaction/forum/topic.php?id=4841 The file names are shortened too quickly when they are long and are not easily readable. A potential solution for showing more is proposed in the forum discussion, but maybe it can be made more flexible and depend on the width of the block? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1046750/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1046750] Re: Show more of the file name
Patch to eliminate file name length display restrictions: https://reviews.mahara.org/2376 ** Changed in: mahara Status: Triaged = In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib members https://bugs.launchpad.net/bugs/1046750 Title: Show more of the file name Status in Mahara ePortfolio: In Progress Bug description: https://mahara.org/interaction/forum/topic.php?id=4841 The file names are shortened too quickly when they are long and are not easily readable. A potential solution for showing more is proposed in the forum discussion, but maybe it can be made more flexible and depend on the width of the block? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1046750/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1046750] Re: Show more of the file name
Hi Aaron, please also add -theme/raw/templates/collectionnav.tpl When I change '30' to '60' I get the preferred results as per two screenshots. Your solution sound much better but this could be a temporary workaround. If you are short on time, I could submit a bug fix. ** Attachment added: collectnav_before.PNG https://bugs.launchpad.net/mahara/+bug/1046750/+attachment/3743745/+files/collectnav_before.PNG -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib members https://bugs.launchpad.net/bugs/1046750 Title: Show more of the file name Status in Mahara ePortfolio: Triaged Bug description: https://mahara.org/interaction/forum/topic.php?id=4841 The file names are shortened too quickly when they are long and are not easily readable. A potential solution for showing more is proposed in the forum discussion, but maybe it can be made more flexible and depend on the width of the block? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1046750/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1046750] Re: Show more of the file name
after ** Attachment added: collectnav_after.PNG https://bugs.launchpad.net/mahara/+bug/1046750/+attachment/3743746/+files/collectnav_after.PNG -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib members https://bugs.launchpad.net/bugs/1046750 Title: Show more of the file name Status in Mahara ePortfolio: Triaged Bug description: https://mahara.org/interaction/forum/topic.php?id=4841 The file names are shortened too quickly when they are long and are not easily readable. A potential solution for showing more is proposed in the forum discussion, but maybe it can be made more flexible and depend on the width of the block? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1046750/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1046750] Re: Show more of the file name
So, to be clear, we're talking about extending the file length displayed in: - artefact/file/lib.php - theme/raw/form/filelist.tpl - artefact/file/blocktype/filedownload/theme/raw/filedownload.tpl Is that right? The truth is, Mahara puts no limit on the length of filenames uploaded. (They're stored in artefact.title, which is a binary text column, which in theory is more or less unlimited; in practice it's something like a couple billion characters.) So any length limit we pick is going to an arbitrary cutoff. I'm all for raising that arbitrary cutoff if people think it would make the site look better, though. :-D There are a couple of other things we could do to help out with this as well: - put a title attribute (i.e. mouseover text) on the shortened name, which has the full name - use the CSS3 text-overflow attribute (supported in all modern browsers): http://caniuse.com/text-overflow - but the problem with text-overflow is that it puts ellipses at the END of the filename, which obscures the file suffix - find some JS library that will auto-expand/hide the text with ellipses in the middle (I didn't find one in a quick Google search) Anyway, just let me know if I've identified all the places where the filename length should change, and I'll see about upstreaming it. Cheers, Aaron -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib members https://bugs.launchpad.net/bugs/1046750 Title: Show more of the file name Status in Mahara ePortfolio: Triaged Bug description: https://mahara.org/interaction/forum/topic.php?id=4841 The file names are shortened too quickly when they are long and are not easily readable. A potential solution for showing more is proposed in the forum discussion, but maybe it can be made more flexible and depend on the width of the block? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1046750/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1046750] Re: Show more of the file name
Actually, here's a JQuery plugin that promises to do it: https://github.com/tbasse/jquery-truncate -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib members https://bugs.launchpad.net/bugs/1046750 Title: Show more of the file name Status in Mahara ePortfolio: Triaged Bug description: https://mahara.org/interaction/forum/topic.php?id=4841 The file names are shortened too quickly when they are long and are not easily readable. A potential solution for showing more is proposed in the forum discussion, but maybe it can be made more flexible and depend on the width of the block? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1046750/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1046750] Re: Show more of the file name
Hi, Just wondering if there's any progress in this filename display issue reaching core code? In my new institution making custom tweaks to code is restricted so changes like this to enhance usability will only be implemented if they are changed in core. Thanks, Gordon. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib members https://bugs.launchpad.net/bugs/1046750 Title: Show more of the file name Status in Mahara ePortfolio: Triaged Bug description: https://mahara.org/interaction/forum/topic.php?id=4841 The file names are shortened too quickly when they are long and are not easily readable. A potential solution for showing more is proposed in the forum discussion, but maybe it can be made more flexible and depend on the width of the block? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1046750/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1046750] Re: Show more of the file name
** Changed in: mahara Status: New = Triaged -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/1046750 Title: Show more of the file name Status in Mahara ePortfolio: Triaged Bug description: https://mahara.org/interaction/forum/topic.php?id=4841 The file names are shortened too quickly when they are long and are not easily readable. A potential solution for showing more is proposed in the forum discussion, but maybe it can be made more flexible and depend on the width of the block? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1046750/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1046750] Re: Show more of the file name
Hi Kristina, Just wondering if this might also be an approach to address the issue with filenames being displayed with video and other objects - https://bugs.launchpad.net/mahara/+bug/1034382 If the code suggested by Dirk could be tweaked with an 'if' statement that modified $child-title = str_shorten_text($child-title, 20); to $child-title = str_shorten_text($child-title, 0); if the object type was an embedded block rather than a linked file Of course I could be wildly wrong as these are two different object types (file links and blocks) - but the principle might be similar? Thanks, Gordon. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/1046750 Title: Show more of the file name Status in Mahara ePortfolio: New Bug description: https://mahara.org/interaction/forum/topic.php?id=4841 The file names are shortened too quickly when they are long and are not easily readable. A potential solution for showing more is proposed in the forum discussion, but maybe it can be made more flexible and depend on the width of the block? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1046750/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1046750] Re: Show more of the file name
Hi Gordon, We' d have to see what a developer says. My code reading ability doesn't extend to anything further. ;-) But I would say they might be separate things. They are definitely separate blocks, but if the name of the video file is also shortened too quickly, that should be fixed there as well. However, making it optional to display it is a different thing. Cheers Kristina -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/1046750 Title: Show more of the file name Status in Mahara ePortfolio: New Bug description: https://mahara.org/interaction/forum/topic.php?id=4841 The file names are shortened too quickly when they are long and are not easily readable. A potential solution for showing more is proposed in the forum discussion, but maybe it can be made more flexible and depend on the width of the block? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1046750/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp