[Mahara-contributors] [Bug 1072972] A change has been merged
Reviewed: https://reviews.mahara.org/2394 Committed: http://gitorious.org/mahara/mahara/commit/c4686009a88bea29a44e96539173ade432559a53 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit c4686009a88bea29a44e96539173ade432559a53 Author: Aaron Wells Date: Wed Aug 7 11:53:36 2013 +1200 Update PREG_CLASS_SEARCH_EXCLUDE to latest from Drupal 6 Bug #1072972: This includes the KATAKANA-HIRAGANA PROLONGED SOUND MARK, which should solve some issues for Japanese language users. It also removes the 16-bit surrogate characters D800-DFFF from the exclusion class. Change-Id: Iaaa70b891219d97758b3d7982d69a4522a477009 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib members https://bugs.launchpad.net/bugs/1072972 Title: Internal search ignores 'KATAKANA-HIRAGANA PROLONGED SOUND MARK' Status in Mahara ePortfolio: In Progress Status in Mahara 1.7 series: New Bug description: Mahara's (1.5.6) internal search cannot handle Japanese character 'KATAKANA-HIRAGANA PROLONGED SOUND MARK'. This character 'ー' is frequently used. For example 'データ (data)', 'サーバー (server)' or 'ポートフォリオ (portfolio)'. The cause of problem is line 1102 in search/internal/lib.php. 1102:$text = preg_replace('/['. PREG_CLASS_SEARCH_EXCLUDE . ']+/u', ' ', $text); In this line, mahara replaces special characters specified by PREG_CLASS_SEARCH_EXCLUDE with ' '. And 'KATAKANA-HIRAGANA PROLONGED SOUND MARK' is included in PREG_CLASS_SEARCH_EXCLUDE. The solution of this problem is very simple. Just remove 'KATAKANA- HIRAGANA PROLONGED SOUND MARK' (code 0x30fc) from PREG_CLASS_SEARCH_EXCLUDE. We can find the definition on line 1198-1225. 1221: '\x{3099}-\x{309e}\x{30a0}\x{30fb}-\x{30fe}\x{3190}-\x{319f}\x{31c0}-\x{31cf}'. should be replaced with 1221: '\x{3099}-\x{309e}\x{30a0}\x{30fb}\x{30fd}\x{30fe}\x{3190}-\x{319f}\x{31c0}-\x{31cf}'. P.S. The definition of PREG_CLASS_SEARCH_EXCLUDE is originally from Drupal, and this fix was already applied. http://api.drupal.org/api/drupal/modules!search!search.module/constant/PREG_CLASS_SEARCH_EXCLUDE/6 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1072972/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1072972] A change has been merged
Reviewed: https://reviews.mahara.org/2396 Committed: http://gitorious.org/mahara/mahara/commit/9e64ecb63e658938953a700d746ddbf6788861fc Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:1.7_STABLE commit 9e64ecb63e658938953a700d746ddbf6788861fc Author: Aaron Wells Date: Wed Aug 7 11:53:36 2013 +1200 Update PREG_CLASS_SEARCH_EXCLUDE to latest from Drupal 6 Bug #1072972: This includes the KATAKANA-HIRAGANA PROLONGED SOUND MARK, which should solve some issues for Japanese language users. It also removes the 16-bit surrogate characters D800-DFFF from the exclusion class. Change-Id: Iaaa70b891219d97758b3d7982d69a4522a477009 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib members https://bugs.launchpad.net/bugs/1072972 Title: Internal search ignores 'KATAKANA-HIRAGANA PROLONGED SOUND MARK' Status in Mahara ePortfolio: Fix Committed Status in Mahara 1.7 series: New Bug description: Mahara's (1.5.6) internal search cannot handle Japanese character 'KATAKANA-HIRAGANA PROLONGED SOUND MARK'. This character 'ー' is frequently used. For example 'データ (data)', 'サーバー (server)' or 'ポートフォリオ (portfolio)'. The cause of problem is line 1102 in search/internal/lib.php. 1102:$text = preg_replace('/['. PREG_CLASS_SEARCH_EXCLUDE . ']+/u', ' ', $text); In this line, mahara replaces special characters specified by PREG_CLASS_SEARCH_EXCLUDE with ' '. And 'KATAKANA-HIRAGANA PROLONGED SOUND MARK' is included in PREG_CLASS_SEARCH_EXCLUDE. The solution of this problem is very simple. Just remove 'KATAKANA- HIRAGANA PROLONGED SOUND MARK' (code 0x30fc) from PREG_CLASS_SEARCH_EXCLUDE. We can find the definition on line 1198-1225. 1221: '\x{3099}-\x{309e}\x{30a0}\x{30fb}-\x{30fe}\x{3190}-\x{319f}\x{31c0}-\x{31cf}'. should be replaced with 1221: '\x{3099}-\x{309e}\x{30a0}\x{30fb}\x{30fd}\x{30fe}\x{3190}-\x{319f}\x{31c0}-\x{31cf}'. P.S. The definition of PREG_CLASS_SEARCH_EXCLUDE is originally from Drupal, and this fix was already applied. http://api.drupal.org/api/drupal/modules!search!search.module/constant/PREG_CLASS_SEARCH_EXCLUDE/6 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1072972/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp