[Mahara-contributors] [Bug 1272122] Re: Rotate images
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1272122 Title: Rotate images Status in Mahara: Fix Released Bug description: A teacher on MyPortfolio.school.nz said it would be great to be able to rotate images once uploaded to Mahara because when kids upload photos from mobile devices, they may not have the correct orientation. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1272122/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1272122] Re: Rotate images
** Tags removed: fileupload images snack-sized ** Tags added: nominatedfeature -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1272122 Title: Rotate images Status in Mahara: Fix Committed Bug description: A teacher on MyPortfolio.school.nz said it would be great to be able to rotate images once uploaded to Mahara because when kids upload photos from mobile devices, they may not have the correct orientation. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1272122/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1272122] Re: Rotate images
** Changed in: mahara Status: In Progress => Fix Committed ** Changed in: mahara Milestone: None => 18.10.0 ** Changed in: mahara Milestone: 18.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1272122 Title: Rotate images Status in Mahara: Fix Committed Bug description: A teacher on MyPortfolio.school.nz said it would be great to be able to rotate images once uploaded to Mahara because when kids upload photos from mobile devices, they may not have the correct orientation. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1272122/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1272122] Re: Rotate images
With current patch 7587 I did notice this: 1) Add first image block to page, select an image in config, edit image in config, save block config - I'd get block with image as expected 2) Add second image block to page, edit image that was used for block one, rotate image 90deg, save image edit part, but not select image as one to use for image block and then save block config - the image in block one does not show rotation applied and block two shows no image selected. 3) If I then edit block two and select the image and then save block two again both blocks now show image correctly rotated This is because other blocks on page only get updated if block being saved has a choice (so we know which other blocks to update) Not sure if that will be a problem or not as it is quit the edge-case -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1272122 Title: Rotate images Status in Mahara: In Progress Bug description: A teacher on MyPortfolio.school.nz said it would be great to be able to rotate images once uploaded to Mahara because when kids upload photos from mobile devices, they may not have the correct orientation. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1272122/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1272122] Re: Rotate images
https://reviews.mahara.org/#/c/7587/ ** Changed in: mahara Status: Triaged => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1272122 Title: Rotate images Status in Mahara: In Progress Bug description: A teacher on MyPortfolio.school.nz said it would be great to be able to rotate images once uploaded to Mahara because when kids upload photos from mobile devices, they may not have the correct orientation. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1272122/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1272122] Re: Rotate images
Thinking about this some more we could do the following: 1) Alter the artefact_file_image table and add a column 'orientation' where we record one of the 4 possible values, 0 (the default), 90, 180, 270 2) On saving/choosing image rotation state, eg 90 deg clockwise we could record in the artefact_file_image table 'orientation' column as the preferred orientation of the image So next time the image is rendered on a page (or wherever) it is shown in that rotation from original either by: 3a) applying the rotation via css or 3b) running image through a php function to generate a new resized image with that orientation before displaying it. The advantage of this are: - Will only deal with images in relating to rotation - Never touch the original so easier to change orientation choice multiple times - No need to have 'cancelling' as it will be easy to choose any of the 4 possible rotation choices -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1272122 Title: Rotate images Status in Mahara: Triaged Bug description: A teacher on MyPortfolio.school.nz said it would be great to be able to rotate images once uploaded to Mahara because when kids upload photos from mobile devices, they may not have the correct orientation. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1272122/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1272122] Re: Rotate images
There is some discussion about achieving this in the forums - https://mahara.org/interaction/forum/topic.php?id=7541=0=10#post31336 Which mentions what is needed to achieve this basic concept http://stackoverflow.com/questions/11259881/how-to-rotate-image-and-save-the-image Things we would have to deal with in Mahara: 1) Should the rotated image overwrite the original or be a copy of original? 2) Should we allow rotation of image after it's been added to a page / as attachment to something? 3) What file formats should be allowed to rotate? PHP has inbuilt handling for jpeg / gif / png formats only 4) Clearing any cache / resizing of original image if we rotate it 5) Dealing with a temporary saving of rotated image before saving in case user wants to cancel the rotation. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1272122 Title: Rotate images Status in Mahara: Triaged Bug description: A teacher on MyPortfolio.school.nz said it would be great to be able to rotate images once uploaded to Mahara because when kids upload photos from mobile devices, they may not have the correct orientation. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1272122/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1272122] Re: Rotate images
** Changed in: mahara Assignee: Walter Lowe (brokenchiw4w4) => (unassigned) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1272122 Title: Rotate images Status in Mahara: Triaged Bug description: A teacher on MyPortfolio.school.nz said it would be great to be able to rotate images once uploaded to Mahara because when kids upload photos from mobile devices, they may not have the correct orientation. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1272122/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1272122] Re: Rotate images
** Changed in: mahara Assignee: (unassigned) => Walter Lowe (brokenchiw4w4) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1272122 Title: Rotate images Status in Mahara: Triaged Bug description: A teacher on MyPortfolio.school.nz said it would be great to be able to rotate images once uploaded to Mahara because when kids upload photos from mobile devices, they may not have the correct orientation. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1272122/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1272122] Re: Rotate images
Setting this as a duplicate of bug 1498936, because that one encompasses the idea that if we do add an image manipulation system, it can do additional things beyond just rotating images. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1272122 Title: Rotate images Status in Mahara: Triaged Bug description: A teacher on MyPortfolio.school.nz said it would be great to be able to rotate images once uploaded to Mahara because when kids upload photos from mobile devices, they may not have the correct orientation. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1272122/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1272122] Re: Rotate images
Actually, let's keep this one separate from Bug 1498936. This bug is "snack-sized", only if you add a server-side system for rotating an image 90 degrees. The Bug 1498936, incorporating a client-side photo manipulation system, is a larger project. Although still fairly self-contained and not enormous in scope. ** Tags added: fileupload -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1272122 Title: Rotate images Status in Mahara: Triaged Bug description: A teacher on MyPortfolio.school.nz said it would be great to be able to rotate images once uploaded to Mahara because when kids upload photos from mobile devices, they may not have the correct orientation. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1272122/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1272122] Re: Rotate images
Fair enough. This could go under the individual file editing section. (The same place where you can set tags and comment permissions for an individual file.) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1272122 Title: Rotate images Status in Mahara ePortfolio: Triaged Bug description: A teacher on MyPortfolio.school.nz said it would be great to be able to rotate images once uploaded to Mahara because when kids upload photos from mobile devices, they may not have the correct orientation. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1272122/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1272122] Re: Rotate images
I would go for #1 only. Also, if at some point we decide to add some more options (if needed), we wouldn't overload the file upload. Also, since you can upload files in bulk, it might not be convenient to do the rotating during the upload. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1272122 Title: Rotate images Status in Mahara ePortfolio: Triaged Bug description: A teacher on MyPortfolio.school.nz said it would be great to be able to rotate images once uploaded to Mahara because when kids upload photos from mobile devices, they may not have the correct orientation. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1272122/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1272122] Re: Rotate images
Setting this one to Snack-sized. I think it'd be a pretty standalone bit of work, and probably quite achievable since we already require some image processing libraries. There are two workflows we'd need to support: 1. Rotating an image that's already been uploaded, via the Content - Files page. 2. Rotating an image as it is being uploaded, i.e. via the Pieforms filepicker element on the Image Block or elsewhere. It'll be tricky to think of a good interface for #2. We don't want to further complicate the filepicker by adding a pair of great big rotate? buttons that will always take up space but only be used 5% of the time. Maybe it would be better to just implement workflow #1... ** Tags added: images snack-sized -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1272122 Title: Rotate images Status in Mahara ePortfolio: Triaged Bug description: A teacher on MyPortfolio.school.nz said it would be great to be able to rotate images once uploaded to Mahara because when kids upload photos from mobile devices, they may not have the correct orientation. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1272122/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1272122] Re: Rotate images
** Changed in: mahara Status: New = Triaged -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1272122 Title: Rotate images Status in Mahara ePortfolio: Triaged Bug description: A teacher on MyPortfolio.school.nz said it would be great to be able to rotate images once uploaded to Mahara because when kids upload photos from mobile devices, they may not have the correct orientation. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1272122/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
