[Mahara-contributors] [Bug 1318432] A change has been merged
Reviewed: https://reviews.mahara.org/4375 Committed: http://gitorious.org/mahara/mahara/commit/01467168a15d501f9767b9de66853b02e50db32d Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 01467168a15d501f9767b9de66853b02e50db32d Author: Aaron Wells Date: Tue Mar 10 18:00:14 2015 +1300 Make the JSON request handler better able to handle malformed responses Bug 1318432 Change-Id: I161df25067515a4c85b7058df7b2e7dbebe32a33 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1318432 Title: Improve error reporting in Ajax installer/upgrader Status in Mahara ePortfolio: Fix Committed Status in Mahara 1.10 series: New Status in Mahara 15.04 series: Fix Committed Bug description: We use an Ajax-based page to install & upgrade Mahara. For each upgrade task it: - fires off a separate Ajax request to run the task - shows a "progress" spinner while it waits for a response - and then once it gets a response it updates the page and fires off the next task The problem is that this system doesn't handle errors well. If the Ajax script errors out, it continues showing the "progress" spinner forever. Consequently we get a LOT of error reports where people complain that "installation takes forever", when in fact it errored out after 30 seconds or whatever and it just never told them. We need to update this process so that it actually lets you know when it failed, and why. The simplest solution, suggested by Robert, is that we put a timeout on waiting for the Ajax response. Mahara sets max_execution_time itself, so we could: 1. Make the ajax time out after max_execution_time 2. Show an error icon 3. Fire off a second ajax response to a script that gets any error messages from the session and displays those on the page. That should be pretty robust against any type of error. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1318432/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1318432] A change has been merged
Reviewed: https://reviews.mahara.org/3510 Committed: http://gitorious.org/mahara/mahara/commit/2e873d2a5251b905ddd2543ba53f40d19749b28c Submitter: Aaron Wells (aar...@catalyst.net.nz) Branch:master commit 2e873d2a5251b905ddd2543ba53f40d19749b28c Author: Nigel Cunningham Date: Mon Jul 14 16:04:00 2014 +1000 (Bug 1318432) Ensure errorhandler called In sendjsonrequest, if the request completes but returns an error, we should invoke the caller's error handling function. Change-Id: I52ef8ae900796c5db4532fa11c2a152d8a75b838 Signed-off-by: Nigel Cunningham -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1318432 Title: Improve error reporting in Ajax installer/upgrader Status in Mahara ePortfolio: In Progress Status in Mahara 1.10 series: New Status in Mahara 15.04 series: In Progress Bug description: We use an Ajax-based page to install & upgrade Mahara. For each upgrade task it: - fires off a separate Ajax request to run the task - shows a "progress" spinner while it waits for a response - and then once it gets a response it updates the page and fires off the next task The problem is that this system doesn't handle errors well. If the Ajax script errors out, it continues showing the "progress" spinner forever. Consequently we get a LOT of error reports where people complain that "installation takes forever", when in fact it errored out after 30 seconds or whatever and it just never told them. We need to update this process so that it actually lets you know when it failed, and why. The simplest solution, suggested by Robert, is that we put a timeout on waiting for the Ajax response. Mahara sets max_execution_time itself, so we could: 1. Make the ajax time out after max_execution_time 2. Show an error icon 3. Fire off a second ajax response to a script that gets any error messages from the session and displays those on the page. That should be pretty robust against any type of error. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1318432/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
