[Mahara-contributors] [Bug 1409545] Re: RSS block: Invalid array key 'url' messages when using an atom feed
** Changed in: mahara/1.10 Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1409545 Title: RSS block: Invalid array key 'url' messages when using an atom feed Status in Mahara ePortfolio: Fix Released Status in Mahara 1.10 series: Fix Released Status in Mahara 1.8 series: Won't Fix Status in Mahara 1.9 series: Won't Fix Status in Mahara 15.04 series: Fix Released Bug description: A client reported that when using the external feed block to display the Atom feeds of Mahara's own blogs, you'd see this warning message: [WAR] f9 (blocktype/externalfeed/lib.php:464) Illegal string offset 'url' Call stack (most recent first): log_message(Illegal string offset 'url', 8, true, true, /home/aaronw/www/mahara/htdocs/blocktype/externalf..., 464) at /home/aaronw/www/mahara/htdocs/lib/errors.php:439 error(2, Illegal string offset 'url', /home/aaronw/www/mahara/htdocs/blocktype/externalf..., 464, array(size 2)) at /home/aaronw/www/mahara/htdocs/blocktype/externalfeed/lib.php:464 PluginBlocktypeExternalfeed::make_feed_image_tag(http://trinity-mahara.testing.elearning.catalyst.n...;) at /home/aaronw/www/mahara/htdocs/blocktype/externalfeed/lib.php:98 PluginBlocktypeExternalfeed::render_instance(object(BlockInstance)) at Unknown:0 call_user_func_array(array(size 2), array(size 1)) at /home/aaronw/www/mahara/htdocs/lib/mahara.php:1578 call_static_method(PluginBlocktypeExternalfeed, render_instance, object(BlockInstance)) at /home/aaronw/www/mahara/htdocs/blocktype/lib.php:782 BlockInstance-render_viewing() at /home/aaronw/www/mahara/htdocs/lib/view.php:2049 View-build_column(1, 1, false) at /home/aaronw/www/mahara/htdocs/lib/view.php:2006 View-build_columns(1, false) at /home/aaronw/www/mahara/htdocs/lib/view.php:1991 View-build_rows() at /home/aaronw/www/mahara/htdocs/view/view.php:257 On looking at the code, it looks like the problem is that the PluginBlocktypeExternalfeed::make_feed_image_tag() function is in dire need of a cleanup. It is built to handle an array if the feed is an RSS feed, and a URL string if the feed is an Atom feed. But it just checks for array keys directly, rather than checking whether it's an array or if the array key exists, and although that works, it throws a warning message. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1409545/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1409545] Re: RSS block: Invalid array key 'url' messages when using an atom feed
** Changed in: mahara Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1409545 Title: RSS block: Invalid array key 'url' messages when using an atom feed Status in Mahara ePortfolio: Fix Released Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.8 series: Won't Fix Status in Mahara 1.9 series: Won't Fix Status in Mahara 15.04 series: Fix Released Bug description: A client reported that when using the external feed block to display the Atom feeds of Mahara's own blogs, you'd see this warning message: [WAR] f9 (blocktype/externalfeed/lib.php:464) Illegal string offset 'url' Call stack (most recent first): log_message(Illegal string offset 'url', 8, true, true, /home/aaronw/www/mahara/htdocs/blocktype/externalf..., 464) at /home/aaronw/www/mahara/htdocs/lib/errors.php:439 error(2, Illegal string offset 'url', /home/aaronw/www/mahara/htdocs/blocktype/externalf..., 464, array(size 2)) at /home/aaronw/www/mahara/htdocs/blocktype/externalfeed/lib.php:464 PluginBlocktypeExternalfeed::make_feed_image_tag(http://trinity-mahara.testing.elearning.catalyst.n...;) at /home/aaronw/www/mahara/htdocs/blocktype/externalfeed/lib.php:98 PluginBlocktypeExternalfeed::render_instance(object(BlockInstance)) at Unknown:0 call_user_func_array(array(size 2), array(size 1)) at /home/aaronw/www/mahara/htdocs/lib/mahara.php:1578 call_static_method(PluginBlocktypeExternalfeed, render_instance, object(BlockInstance)) at /home/aaronw/www/mahara/htdocs/blocktype/lib.php:782 BlockInstance-render_viewing() at /home/aaronw/www/mahara/htdocs/lib/view.php:2049 View-build_column(1, 1, false) at /home/aaronw/www/mahara/htdocs/lib/view.php:2006 View-build_columns(1, false) at /home/aaronw/www/mahara/htdocs/lib/view.php:1991 View-build_rows() at /home/aaronw/www/mahara/htdocs/view/view.php:257 On looking at the code, it looks like the problem is that the PluginBlocktypeExternalfeed::make_feed_image_tag() function is in dire need of a cleanup. It is built to handle an array if the feed is an RSS feed, and a URL string if the feed is an Atom feed. But it just checks for array keys directly, rather than checking whether it's an array or if the array key exists, and although that works, it throws a warning message. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1409545/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1409545] Re: RSS block: Invalid array key 'url' messages when using an atom feed
** Changed in: mahara/15.04 Status: In Progress = Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1409545 Title: RSS block: Invalid array key 'url' messages when using an atom feed Status in Mahara ePortfolio: Fix Committed Status in Mahara 1.10 series: Confirmed Status in Mahara 1.8 series: Won't Fix Status in Mahara 1.9 series: Won't Fix Status in Mahara 15.04 series: Fix Committed Bug description: A client reported that when using the external feed block to display the Atom feeds of Mahara's own blogs, you'd see this warning message: [WAR] f9 (blocktype/externalfeed/lib.php:464) Illegal string offset 'url' Call stack (most recent first): log_message(Illegal string offset 'url', 8, true, true, /home/aaronw/www/mahara/htdocs/blocktype/externalf..., 464) at /home/aaronw/www/mahara/htdocs/lib/errors.php:439 error(2, Illegal string offset 'url', /home/aaronw/www/mahara/htdocs/blocktype/externalf..., 464, array(size 2)) at /home/aaronw/www/mahara/htdocs/blocktype/externalfeed/lib.php:464 PluginBlocktypeExternalfeed::make_feed_image_tag(http://trinity-mahara.testing.elearning.catalyst.n...;) at /home/aaronw/www/mahara/htdocs/blocktype/externalfeed/lib.php:98 PluginBlocktypeExternalfeed::render_instance(object(BlockInstance)) at Unknown:0 call_user_func_array(array(size 2), array(size 1)) at /home/aaronw/www/mahara/htdocs/lib/mahara.php:1578 call_static_method(PluginBlocktypeExternalfeed, render_instance, object(BlockInstance)) at /home/aaronw/www/mahara/htdocs/blocktype/lib.php:782 BlockInstance-render_viewing() at /home/aaronw/www/mahara/htdocs/lib/view.php:2049 View-build_column(1, 1, false) at /home/aaronw/www/mahara/htdocs/lib/view.php:2006 View-build_columns(1, false) at /home/aaronw/www/mahara/htdocs/lib/view.php:1991 View-build_rows() at /home/aaronw/www/mahara/htdocs/view/view.php:257 On looking at the code, it looks like the problem is that the PluginBlocktypeExternalfeed::make_feed_image_tag() function is in dire need of a cleanup. It is built to handle an array if the feed is an RSS feed, and a URL string if the feed is an Atom feed. But it just checks for array keys directly, rather than checking whether it's an array or if the array key exists, and although that works, it throws a warning message. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1409545/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1409545] Re: RSS block: Invalid array key 'url' messages when using an atom feed
I uploaded into gerrit the quick fix patch I wrote for our client, but I gave it a -2 to indicate the further issues we should also tackle. https://reviews.mahara.org/#/c/4137/ The code that causes this problem is quite old (probably from Mahara 1.6), so it probably affects 1.8 and 1.9 as well, but since it only throws a warning message and doesn't cause any other problems, it's probably not worth backporting further than 1.10. ** Changed in: mahara Status: Confirmed = In Progress ** Also affects: mahara/15.04 Importance: Medium Status: In Progress ** Also affects: mahara/1.8 Importance: Undecided Status: New ** Also affects: mahara/1.10 Importance: Undecided Status: New ** Also affects: mahara/1.9 Importance: Undecided Status: New ** Changed in: mahara/15.04 Importance: Medium = Low ** Changed in: mahara/1.10 Status: New = Confirmed ** Changed in: mahara/1.10 Importance: Undecided = Low ** Changed in: mahara/1.8 Status: New = Won't Fix ** Changed in: mahara/1.9 Status: New = Won't Fix ** Changed in: mahara/1.8 Importance: Undecided = Low ** Changed in: mahara/1.9 Importance: Undecided = Low ** Changed in: mahara/15.04 Milestone: 1.10.3 = 15.04.0 ** Changed in: mahara/1.10 Milestone: None = 1.10.2 ** Tags added: bite-sized -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1409545 Title: RSS block: Invalid array key 'url' messages when using an atom feed Status in Mahara ePortfolio: In Progress Status in Mahara 1.10 series: Confirmed Status in Mahara 1.8 series: Won't Fix Status in Mahara 1.9 series: Won't Fix Status in Mahara 15.04 series: In Progress Bug description: A client reported that when using the external feed block to display the Atom feeds of Mahara's own blogs, you'd see this warning message: [WAR] f9 (blocktype/externalfeed/lib.php:464) Illegal string offset 'url' Call stack (most recent first): log_message(Illegal string offset 'url', 8, true, true, /home/aaronw/www/mahara/htdocs/blocktype/externalf..., 464) at /home/aaronw/www/mahara/htdocs/lib/errors.php:439 error(2, Illegal string offset 'url', /home/aaronw/www/mahara/htdocs/blocktype/externalf..., 464, array(size 2)) at /home/aaronw/www/mahara/htdocs/blocktype/externalfeed/lib.php:464 PluginBlocktypeExternalfeed::make_feed_image_tag(http://trinity-mahara.testing.elearning.catalyst.n...;) at /home/aaronw/www/mahara/htdocs/blocktype/externalfeed/lib.php:98 PluginBlocktypeExternalfeed::render_instance(object(BlockInstance)) at Unknown:0 call_user_func_array(array(size 2), array(size 1)) at /home/aaronw/www/mahara/htdocs/lib/mahara.php:1578 call_static_method(PluginBlocktypeExternalfeed, render_instance, object(BlockInstance)) at /home/aaronw/www/mahara/htdocs/blocktype/lib.php:782 BlockInstance-render_viewing() at /home/aaronw/www/mahara/htdocs/lib/view.php:2049 View-build_column(1, 1, false) at /home/aaronw/www/mahara/htdocs/lib/view.php:2006 View-build_columns(1, false) at /home/aaronw/www/mahara/htdocs/lib/view.php:1991 View-build_rows() at /home/aaronw/www/mahara/htdocs/view/view.php:257 On looking at the code, it looks like the problem is that the PluginBlocktypeExternalfeed::make_feed_image_tag() function is in dire need of a cleanup. It is built to handle an array if the feed is an RSS feed, and a URL string if the feed is an Atom feed. But it just checks for array keys directly, rather than checking whether it's an array or if the array key exists, and although that works, it throws a warning message. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1409545/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1409545] Re: RSS block: Invalid array key 'url' messages when using an atom feed
** Changed in: mahara/1.10 Milestone: 1.10.2 = 1.10.3 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1409545 Title: RSS block: Invalid array key 'url' messages when using an atom feed Status in Mahara ePortfolio: In Progress Status in Mahara 1.10 series: Confirmed Status in Mahara 1.8 series: Won't Fix Status in Mahara 1.9 series: Won't Fix Status in Mahara 15.04 series: In Progress Bug description: A client reported that when using the external feed block to display the Atom feeds of Mahara's own blogs, you'd see this warning message: [WAR] f9 (blocktype/externalfeed/lib.php:464) Illegal string offset 'url' Call stack (most recent first): log_message(Illegal string offset 'url', 8, true, true, /home/aaronw/www/mahara/htdocs/blocktype/externalf..., 464) at /home/aaronw/www/mahara/htdocs/lib/errors.php:439 error(2, Illegal string offset 'url', /home/aaronw/www/mahara/htdocs/blocktype/externalf..., 464, array(size 2)) at /home/aaronw/www/mahara/htdocs/blocktype/externalfeed/lib.php:464 PluginBlocktypeExternalfeed::make_feed_image_tag(http://trinity-mahara.testing.elearning.catalyst.n...;) at /home/aaronw/www/mahara/htdocs/blocktype/externalfeed/lib.php:98 PluginBlocktypeExternalfeed::render_instance(object(BlockInstance)) at Unknown:0 call_user_func_array(array(size 2), array(size 1)) at /home/aaronw/www/mahara/htdocs/lib/mahara.php:1578 call_static_method(PluginBlocktypeExternalfeed, render_instance, object(BlockInstance)) at /home/aaronw/www/mahara/htdocs/blocktype/lib.php:782 BlockInstance-render_viewing() at /home/aaronw/www/mahara/htdocs/lib/view.php:2049 View-build_column(1, 1, false) at /home/aaronw/www/mahara/htdocs/lib/view.php:2006 View-build_columns(1, false) at /home/aaronw/www/mahara/htdocs/lib/view.php:1991 View-build_rows() at /home/aaronw/www/mahara/htdocs/view/view.php:257 On looking at the code, it looks like the problem is that the PluginBlocktypeExternalfeed::make_feed_image_tag() function is in dire need of a cleanup. It is built to handle an array if the feed is an RSS feed, and a URL string if the feed is an Atom feed. But it just checks for array keys directly, rather than checking whether it's an array or if the array key exists, and although that works, it throws a warning message. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1409545/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1409545] Re: RSS block: Invalid array key 'url' messages when using an atom feed
The function also is written in a confusing order, and sometimes it cleans up URLs and sometimes it doesn't. The whole thing could use some cleanup and maybe refactoring. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1409545 Title: RSS block: Invalid array key 'url' messages when using an atom feed Status in Mahara ePortfolio: Confirmed Bug description: A client reported that when using the external feed block to display the Atom feeds of Mahara's own blogs, you'd see this warning message: [WAR] f9 (blocktype/externalfeed/lib.php:464) Illegal string offset 'url' Call stack (most recent first): log_message(Illegal string offset 'url', 8, true, true, /home/aaronw/www/mahara/htdocs/blocktype/externalf..., 464) at /home/aaronw/www/mahara/htdocs/lib/errors.php:439 error(2, Illegal string offset 'url', /home/aaronw/www/mahara/htdocs/blocktype/externalf..., 464, array(size 2)) at /home/aaronw/www/mahara/htdocs/blocktype/externalfeed/lib.php:464 PluginBlocktypeExternalfeed::make_feed_image_tag(http://trinity-mahara.testing.elearning.catalyst.n...;) at /home/aaronw/www/mahara/htdocs/blocktype/externalfeed/lib.php:98 PluginBlocktypeExternalfeed::render_instance(object(BlockInstance)) at Unknown:0 call_user_func_array(array(size 2), array(size 1)) at /home/aaronw/www/mahara/htdocs/lib/mahara.php:1578 call_static_method(PluginBlocktypeExternalfeed, render_instance, object(BlockInstance)) at /home/aaronw/www/mahara/htdocs/blocktype/lib.php:782 BlockInstance-render_viewing() at /home/aaronw/www/mahara/htdocs/lib/view.php:2049 View-build_column(1, 1, false) at /home/aaronw/www/mahara/htdocs/lib/view.php:2006 View-build_columns(1, false) at /home/aaronw/www/mahara/htdocs/lib/view.php:1991 View-build_rows() at /home/aaronw/www/mahara/htdocs/view/view.php:257 On looking at the code, it looks like the problem is that the PluginBlocktypeExternalfeed::make_feed_image_tag() function is in dire need of a cleanup. It is built to handle an array if the feed is an RSS feed, and a URL string if the feed is an Atom feed. But it just checks for array keys directly, rather than checking whether it's an array or if the array key exists, and although that works, it throws a warning message. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1409545/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
