[Mahara-contributors] [Bug 1429871] Re: Link underlining in skins doesn't work
** Changed in: mahara/15.10 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1429871 Title: Link underlining in skins doesn't work Status in Mahara: Fix Released Status in Mahara 1.10 series: Fix Released Status in Mahara 1.8 series: Fix Released Status in Mahara 1.9 series: Fix Released Status in Mahara 15.04 series: Fix Released Status in Mahara 15.10 series: Fix Released Bug description: If the user edits a skin (Edit skin > Fonts and colours) and checks the Underline link -option, the link doesn't get underlined on a page with the skin applied. There seems to be a bug in skin/style.php#38 with the comparison if ($option == 'transparent') because when a checkbox is selected, the $option value is a boolean TRUE and when using PHP's loose comparison operator, (true == 'transparent') = true. Therefore for example $skin->viewskin['view_link_normal_underline'] (and a few others) value changes to an empty string and the value assigned to template is 'none' instead of 'underline'. A simple fix is to use strict comparison: if ($option === 'transparent') --- Mahara version: 1.9.1 Browser: Chrome (Linux) 40.0.2214.115 (64-bit) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1429871/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1429871] Re: Link underlining in skins doesn't work
** Tags added: no-behat-needed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1429871 Title: Link underlining in skins doesn't work Status in Mahara ePortfolio: Fix Released Status in Mahara 1.10 series: Fix Released Status in Mahara 1.8 series: Fix Released Status in Mahara 1.9 series: Fix Released Status in Mahara 15.04 series: Fix Released Status in Mahara 15.10 series: Fix Committed Bug description: If the user edits a skin (Edit skin Fonts and colours) and checks the Underline link -option, the link doesn't get underlined on a page with the skin applied. There seems to be a bug in skin/style.php#38 with the comparison if ($option == 'transparent') because when a checkbox is selected, the $option value is a boolean TRUE and when using PHP's loose comparison operator, (true == 'transparent') = true. Therefore for example $skin-viewskin['view_link_normal_underline'] (and a few others) value changes to an empty string and the value assigned to template is 'none' instead of 'underline'. A simple fix is to use strict comparison: if ($option === 'transparent') --- Mahara version: 1.9.1 Browser: Chrome (Linux) 40.0.2214.115 (64-bit) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1429871/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1429871] Re: Link underlining in skins doesn't work
** Changed in: mahara/1.9 Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1429871 Title: Link underlining in skins doesn't work Status in Mahara ePortfolio: Fix Released Status in Mahara 1.10 series: Fix Released Status in Mahara 1.8 series: Fix Released Status in Mahara 1.9 series: Fix Released Status in Mahara 15.04 series: Fix Released Status in Mahara 15.10 series: Fix Committed Bug description: If the user edits a skin (Edit skin Fonts and colours) and checks the Underline link -option, the link doesn't get underlined on a page with the skin applied. There seems to be a bug in skin/style.php#38 with the comparison if ($option == 'transparent') because when a checkbox is selected, the $option value is a boolean TRUE and when using PHP's loose comparison operator, (true == 'transparent') = true. Therefore for example $skin-viewskin['view_link_normal_underline'] (and a few others) value changes to an empty string and the value assigned to template is 'none' instead of 'underline'. A simple fix is to use strict comparison: if ($option === 'transparent') --- Mahara version: 1.9.1 Browser: Chrome (Linux) 40.0.2214.115 (64-bit) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1429871/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1429871] Re: Link underlining in skins doesn't work
** Changed in: mahara/1.10 Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1429871 Title: Link underlining in skins doesn't work Status in Mahara ePortfolio: Fix Released Status in Mahara 1.10 series: Fix Released Status in Mahara 1.8 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: Fix Released Status in Mahara 15.10 series: Fix Committed Bug description: If the user edits a skin (Edit skin Fonts and colours) and checks the Underline link -option, the link doesn't get underlined on a page with the skin applied. There seems to be a bug in skin/style.php#38 with the comparison if ($option == 'transparent') because when a checkbox is selected, the $option value is a boolean TRUE and when using PHP's loose comparison operator, (true == 'transparent') = true. Therefore for example $skin-viewskin['view_link_normal_underline'] (and a few others) value changes to an empty string and the value assigned to template is 'none' instead of 'underline'. A simple fix is to use strict comparison: if ($option === 'transparent') --- Mahara version: 1.9.1 Browser: Chrome (Linux) 40.0.2214.115 (64-bit) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1429871/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1429871] Re: Link underlining in skins doesn't work
** Changed in: mahara/1.8 Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1429871 Title: Link underlining in skins doesn't work Status in Mahara ePortfolio: Fix Released Status in Mahara 1.10 series: Fix Released Status in Mahara 1.8 series: Fix Released Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: Fix Released Status in Mahara 15.10 series: Fix Committed Bug description: If the user edits a skin (Edit skin Fonts and colours) and checks the Underline link -option, the link doesn't get underlined on a page with the skin applied. There seems to be a bug in skin/style.php#38 with the comparison if ($option == 'transparent') because when a checkbox is selected, the $option value is a boolean TRUE and when using PHP's loose comparison operator, (true == 'transparent') = true. Therefore for example $skin-viewskin['view_link_normal_underline'] (and a few others) value changes to an empty string and the value assigned to template is 'none' instead of 'underline'. A simple fix is to use strict comparison: if ($option === 'transparent') --- Mahara version: 1.9.1 Browser: Chrome (Linux) 40.0.2214.115 (64-bit) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1429871/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1429871] Re: Link underlining in skins doesn't work
** Changed in: mahara Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1429871 Title: Link underlining in skins doesn't work Status in Mahara ePortfolio: Fix Released Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.8 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: Fix Released Status in Mahara 15.10 series: Fix Committed Bug description: If the user edits a skin (Edit skin Fonts and colours) and checks the Underline link -option, the link doesn't get underlined on a page with the skin applied. There seems to be a bug in skin/style.php#38 with the comparison if ($option == 'transparent') because when a checkbox is selected, the $option value is a boolean TRUE and when using PHP's loose comparison operator, (true == 'transparent') = true. Therefore for example $skin-viewskin['view_link_normal_underline'] (and a few others) value changes to an empty string and the value assigned to template is 'none' instead of 'underline'. A simple fix is to use strict comparison: if ($option === 'transparent') --- Mahara version: 1.9.1 Browser: Chrome (Linux) 40.0.2214.115 (64-bit) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1429871/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1429871] Re: Link underlining in skins doesn't work
** Changed in: mahara/15.10 Status: Triaged = In Progress ** Changed in: mahara/15.04 Status: Triaged = In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1429871 Title: Link underlining in skins doesn't work Status in Mahara ePortfolio: In Progress Status in Mahara 1.10 series: Triaged Status in Mahara 1.9 series: Triaged Status in Mahara 15.04 series: In Progress Status in Mahara 15.10 series: In Progress Bug description: If the user edits a skin (Edit skin Fonts and colours) and checks the Underline link -option, the link doesn't get underlined on a page with the skin applied. There seems to be a bug in skin/style.php#38 with the comparison if ($option == 'transparent') because when a checkbox is selected, the $option value is a boolean TRUE and when using PHP's loose comparison operator, (true == 'transparent') = true. Therefore for example $skin-viewskin['view_link_normal_underline'] (and a few others) value changes to an empty string and the value assigned to template is 'none' instead of 'underline'. A simple fix is to use strict comparison: if ($option === 'transparent') --- Mahara version: 1.9.1 Browser: Chrome (Linux) 40.0.2214.115 (64-bit) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1429871/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1429871] Re: Link underlining in skins doesn't work
** Changed in: mahara/15.10 Status: In Progress = Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1429871 Title: Link underlining in skins doesn't work Status in Mahara ePortfolio: In Progress Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.8 series: New Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: In Progress Status in Mahara 15.10 series: Fix Committed Bug description: If the user edits a skin (Edit skin Fonts and colours) and checks the Underline link -option, the link doesn't get underlined on a page with the skin applied. There seems to be a bug in skin/style.php#38 with the comparison if ($option == 'transparent') because when a checkbox is selected, the $option value is a boolean TRUE and when using PHP's loose comparison operator, (true == 'transparent') = true. Therefore for example $skin-viewskin['view_link_normal_underline'] (and a few others) value changes to an empty string and the value assigned to template is 'none' instead of 'underline'. A simple fix is to use strict comparison: if ($option === 'transparent') --- Mahara version: 1.9.1 Browser: Chrome (Linux) 40.0.2214.115 (64-bit) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1429871/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1429871] Re: Link underlining in skins doesn't work
** Changed in: mahara/1.9 Status: Triaged = Fix Committed ** Changed in: mahara/1.10 Status: Triaged = Fix Committed ** Also affects: mahara/1.8 Importance: Undecided Status: New ** Changed in: mahara/1.8 Status: New = Fix Committed ** Changed in: mahara/1.8 Importance: Undecided = Medium ** Changed in: mahara/1.8 Milestone: None = 1.8.7 ** Changed in: mahara/15.04 Status: In Progress = Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1429871 Title: Link underlining in skins doesn't work Status in Mahara ePortfolio: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.8 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Bug description: If the user edits a skin (Edit skin Fonts and colours) and checks the Underline link -option, the link doesn't get underlined on a page with the skin applied. There seems to be a bug in skin/style.php#38 with the comparison if ($option == 'transparent') because when a checkbox is selected, the $option value is a boolean TRUE and when using PHP's loose comparison operator, (true == 'transparent') = true. Therefore for example $skin-viewskin['view_link_normal_underline'] (and a few others) value changes to an empty string and the value assigned to template is 'none' instead of 'underline'. A simple fix is to use strict comparison: if ($option === 'transparent') --- Mahara version: 1.9.1 Browser: Chrome (Linux) 40.0.2214.115 (64-bit) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1429871/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1429871] Re: Link underlining in skins doesn't work
Hi Olli, Thanks for the bug report! Cheers, Aaron ** Also affects: mahara/1.10 Importance: Undecided Status: New ** Also affects: mahara/15.10 Importance: Undecided Status: New ** Also affects: mahara/1.9 Importance: Undecided Status: New ** Also affects: mahara/15.04 Importance: Undecided Status: New ** Changed in: mahara/1.9 Status: New = Triaged ** Changed in: mahara/1.9 Importance: Undecided = Medium ** Changed in: mahara/1.10 Status: New = Triaged ** Changed in: mahara/1.10 Importance: Undecided = Medium ** Changed in: mahara/15.04 Status: New = Triaged ** Changed in: mahara/15.04 Importance: Undecided = Medium ** Changed in: mahara/15.10 Status: New = Triaged ** Changed in: mahara/15.10 Importance: Undecided = Medium ** Changed in: mahara/1.10 Milestone: None = 1.10.3 ** Changed in: mahara/1.9 Milestone: None = 1.9.5 ** Changed in: mahara/15.04 Milestone: None = 15.04.0 ** Changed in: mahara/15.10 Milestone: None = 15.10.0 ** Tags added: skins -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1429871 Title: Link underlining in skins doesn't work Status in Mahara ePortfolio: Triaged Status in Mahara 1.10 series: Triaged Status in Mahara 1.9 series: Triaged Status in Mahara 15.04 series: Triaged Status in Mahara 15.10 series: Triaged Bug description: If the user edits a skin (Edit skin Fonts and colours) and checks the Underline link -option, the link doesn't get underlined on a page with the skin applied. There seems to be a bug in skin/style.php#38 with the comparison if ($option == 'transparent') because when a checkbox is selected, the $option value is a boolean TRUE and when using PHP's loose comparison operator, (true == 'transparent') = true. Therefore for example $skin-viewskin['view_link_normal_underline'] (and a few others) value changes to an empty string and the value assigned to template is 'none' instead of 'underline'. A simple fix is to use strict comparison: if ($option === 'transparent') --- Mahara version: 1.9.1 Browser: Chrome (Linux) 40.0.2214.115 (64-bit) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1429871/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
