Public bug reported: Currently, "make minaccept" checks the code style of all changed lines in the latest git commit. This is usually a good thing, but falls down when a third-party library is added which doesn't follow Mahara's code style.
The current convention for including third-party code is to put it in a new directory along with a README.Mahara file, so it would be nice if any code in such a directory was ignored by the code style checker. This would also remind people to add a README.Mahara along with their third party library ... Affects latest master ** Affects: mahara Importance: Low Status: Confirmed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1486826 Title: "make minaccept" should skip code in third-party libraries Status in Mahara: Confirmed Bug description: Currently, "make minaccept" checks the code style of all changed lines in the latest git commit. This is usually a good thing, but falls down when a third-party library is added which doesn't follow Mahara's code style. The current convention for including third-party code is to put it in a new directory along with a README.Mahara file, so it would be nice if any code in such a directory was ignored by the code style checker. This would also remind people to add a README.Mahara along with their third party library ... Affects latest master To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1486826/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp