[Mahara-contributors] [Bug 1703751] Re: behat change_account_settings.feature doesn't test functionality
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1703751 Title: behat change_account_settings.feature doesn't test functionality Status in Mahara: Fix Released Bug description: This test is currently not testing actual functionality. It should be changed to check notification options are available and to check one or two actually work. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1703751/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1703751] Re: behat change_account_settings.feature doesn't test functionality
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1703751 Title: behat change_account_settings.feature doesn't test functionality Status in Mahara: Fix Committed Bug description: This test is currently not testing actual functionality. It should be changed to check notification options are available and to check one or two actually work. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1703751/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1703751] Re: behat change_account_settings.feature doesn't test functionality
To clarify any potential ambiguities from the previous note: - Take out all the "I should see" steps in test/behat/features/settings/notification_setting_order.feature - Add more "should appear" steps to check that every notification type in the list is tested in their respective alphabetical order. Currently, not all notification types are checked if they are in the correct order. Only a few are checked but that wouldn't mean that the rest is in the correct order. - Once these steps are added, take the content from that file and add it as scenario to the notification_choices.feature and make changes to the feature description as needed. - In notification_choices.feature, after the I press "Save" step, add the step: And I should see "Preferences saved" The step to not see "Delete account" is not necessary as you are on a different page. - Rename notification_choices.feature as notification_settings.feature -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1703751 Title: behat change_account_settings.feature doesn't test functionality Status in Mahara: In Progress Bug description: This test is currently not testing actual functionality. It should be changed to check notification options are available and to check one or two actually work. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1703751/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1703751] Re: behat change_account_settings.feature doesn't test functionality
Actually, we already have some tests to check what options are available - We can combine those with this: test/behat/features/settings/notification_choices.feature This systematically tests all options are available for user and admin. - Change feature text to accurately describe what the test does. test/behat/features/settings/notification_setting_order.feature - take out all the "I should see" steps as if they aren't on the page, the "should appear" steps won't work anyway. - Add the remaining steps as a Scenario called "Check options are in alphabetical order" to notification_choices.feature. - Delete notification_setting_order.feature - At the end of the main scenario of notification_choices.feature, after the I press "Save" step, add the steps: And I should see "Preferences saved" And I should not see "Delete account" - Delete the change_account_settings.feature - Rename notification_choices.feature as notification_settings.feature -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1703751 Title: behat change_account_settings.feature doesn't test functionality Status in Mahara: In Progress Bug description: This test is currently not testing actual functionality. It should be changed to check notification options are available and to check one or two actually work. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1703751/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1703751] Re: behat change_account_settings.feature doesn't test functionality
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1703751 Title: behat change_account_settings.feature doesn't test functionality Status in Mahara: In Progress Bug description: This test is currently not testing actual functionality. It should be changed to check notification options are available and to check one or two actually work. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1703751/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1703751] Re: behat change_account_settings.feature doesn't test functionality
** Changed in: mahara Importance: Undecided => Medium ** Changed in: mahara Milestone: None => 17.10.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1703751 Title: behat change_account_settings.feature doesn't test functionality Status in Mahara: In Progress Bug description: This test is currently not testing actual functionality. It should be changed to check notification options are available and to check one or two actually work. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1703751/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
