[Mahara-contributors] [Bug 1772792] Re: Behat: upgrade for php 7.2
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1772792 Title: Behat: upgrade for php 7.2 Status in Mahara: Fix Released Bug description: 1. Upgrade behat to run in php 7.2 2. Figure out what best to do for this problem: Currently there is an issue with the Behat2Renderer.php file in the html report. It uses count() as a test whether object properties return null. As in 7.2 passing null to count results in a warning, running tests currently produces a long list of warnings, so we should probably change that. It looks like implementing Countable on the object may solve this. Related to https://bugs.launchpad.net/mahara/+bug/1767945 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1772792/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1772792] Re: Behat: upgrade for php 7.2
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1772792 Title: Behat: upgrade for php 7.2 Status in Mahara: Fix Committed Bug description: 1. Upgrade behat to run in php 7.2 2. Figure out what best to do for this problem: Currently there is an issue with the Behat2Renderer.php file in the html report. It uses count() as a test whether object properties return null. As in 7.2 passing null to count results in a warning, running tests currently produces a long list of warnings, so we should probably change that. It looks like implementing Countable on the object may solve this. Related to https://bugs.launchpad.net/mahara/+bug/1767945 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1772792/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1772792] Re: Behat: upgrade for php 7.2
** Changed in: mahara Status: New => In Progress ** Changed in: mahara Importance: Undecided => High ** Changed in: mahara Milestone: None => 18.10.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1772792 Title: Behat: upgrade for php 7.2 Status in Mahara: In Progress Bug description: 1. Upgrade behat to run in php 7.2 2. Figure out what best to do for this problem: Currently there is an issue with the Behat2Renderer.php file in the html report. It uses count() as a test whether object properties return null. As in 7.2 passing null to count results in a warning, running tests currently produces a long list of warnings, so we should probably change that. It looks like implementing Countable on the object may solve this. Related to https://bugs.launchpad.net/mahara/+bug/1767945 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1772792/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1772792] Re: Behat: upgrade for php 7.2
** Description changed: 1. Upgrade behat to run in php 7.2 2. Figure out what best to do for this problem: Currently there is an issue with the Behat2Renderer.php file in the html report. It uses count() as a test whether object properties return null. As in 7.2 passing null to count results in a warning, running tests currently produces a long list of warnings, so we should probably change that. + It looks like implementing Countable on the object may solve this. + Related to https://bugs.launchpad.net/mahara/+bug/1767945 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1772792 Title: Behat: upgrade for php 7.2 Status in Mahara: New Bug description: 1. Upgrade behat to run in php 7.2 2. Figure out what best to do for this problem: Currently there is an issue with the Behat2Renderer.php file in the html report. It uses count() as a test whether object properties return null. As in 7.2 passing null to count results in a warning, running tests currently produces a long list of warnings, so we should probably change that. It looks like implementing Countable on the object may solve this. Related to https://bugs.launchpad.net/mahara/+bug/1767945 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1772792/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
