[Mahara-contributors] [Bug 1847177] Re: Deleting comment from page produces a Loading spinner that doesn't clear
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1847177 Title: Deleting comment from page produces a Loading spinner that doesn't clear Status in Mahara: Fix Released Bug description: The "Loading..." spinner that briefly appears when a comment is deleted is not clearing. 1. Create a page and make a comment on the page 2. Delete the comment Expected Results: The comment is deleted and the "Loading..." spinner clears Actual Results: The comment is deleted but the "Loading..." spinner hangs This affects comments deleted from the page and comments deleted from the "Comment" block. It does not seem to affect comments deleted via the comments/details modal. version: 19.10.dev Browsers: Firefox 69.0.1, Chrome: 76.0.3809.10 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1847177/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1847177] Re: Deleting comment from page produces a Loading spinner that doesn't clear
** Changed in: mahara Milestone: 19.10rc1 => 19.10.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1847177 Title: Deleting comment from page produces a Loading spinner that doesn't clear Status in Mahara: Fix Committed Bug description: The "Loading..." spinner that briefly appears when a comment is deleted is not clearing. 1. Create a page and make a comment on the page 2. Delete the comment Expected Results: The comment is deleted and the "Loading..." spinner clears Actual Results: The comment is deleted but the "Loading..." spinner hangs This affects comments deleted from the page and comments deleted from the "Comment" block. It does not seem to affect comments deleted via the comments/details modal. version: 19.10.dev Browsers: Firefox 69.0.1, Chrome: 76.0.3809.10 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1847177/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1847177] Re: Deleting comment from page produces a Loading spinner that doesn't clear
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1847177 Title: Deleting comment from page produces a Loading spinner that doesn't clear Status in Mahara: Fix Committed Bug description: The "Loading..." spinner that briefly appears when a comment is deleted is not clearing. 1. Create a page and make a comment on the page 2. Delete the comment Expected Results: The comment is deleted and the "Loading..." spinner clears Actual Results: The comment is deleted but the "Loading..." spinner hangs This affects comments deleted from the page and comments deleted from the "Comment" block. It does not seem to affect comments deleted via the comments/details modal. version: 19.10.dev Browsers: Firefox 69.0.1, Chrome: 76.0.3809.10 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1847177/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1847177] Re: Deleting comment from page produces a Loading spinner that doesn't clear
** Changed in: mahara Status: New => Confirmed ** Changed in: mahara Importance: Undecided => High ** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1847177 Title: Deleting comment from page produces a Loading spinner that doesn't clear Status in Mahara: In Progress Bug description: The "Loading..." spinner that briefly appears when a comment is deleted is not clearing. 1. Create a page and make a comment on the page 2. Delete the comment Expected Results: The comment is deleted and the "Loading..." spinner clears Actual Results: The comment is deleted but the "Loading..." spinner hangs This affects comments deleted from the page and comments deleted from the "Comment" block. It does not seem to affect comments deleted via the comments/details modal. version: 19.10.dev Browsers: Firefox 69.0.1, Chrome: 76.0.3809.10 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1847177/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1847177] Re: Deleting comment from page produces a Loading spinner that doesn't clear
eg:
if (!data.data.artefact) {
paginator.updateResults(data);
paginator.alertProxy('pagechanged', data);
return;
}
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1847177
Title:
Deleting comment from page produces a Loading spinner that doesn't
clear
Status in Mahara:
New
Bug description:
The "Loading..." spinner that briefly appears when a comment is
deleted is not clearing.
1. Create a page and make a comment on the page
2. Delete the comment
Expected Results:
The comment is deleted and the "Loading..." spinner clears
Actual Results:
The comment is deleted but the "Loading..." spinner hangs
This affects comments deleted from the page and comments deleted from the
"Comment" block.
It does not seem to affect comments deleted via the comments/details modal.
version: 19.10.dev
Browsers: Firefox 69.0.1, Chrome: 76.0.3809.10
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1847177/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1847177] Re: Deleting comment from page produces a Loading spinner that doesn't clear
I believe the problem is in htdocs/js/viewmenu.js
In the function delete_comment_from_modal_submit(form, data) {
I believe the first bit:
if (!data.data.artefact) {
paginator.updateResults(data);
paginator.alertProxy('pagechanged', data);
}
is meant for the comment box at base of page
If that is the case I believe we don't need to do the rest of the code
so we could add a: return; in that bit
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1847177
Title:
Deleting comment from page produces a Loading spinner that doesn't
clear
Status in Mahara:
New
Bug description:
The "Loading..." spinner that briefly appears when a comment is
deleted is not clearing.
1. Create a page and make a comment on the page
2. Delete the comment
Expected Results:
The comment is deleted and the "Loading..." spinner clears
Actual Results:
The comment is deleted but the "Loading..." spinner hangs
This affects comments deleted from the page and comments deleted from the
"Comment" block.
It does not seem to affect comments deleted via the comments/details modal.
version: 19.10.dev
Browsers: Firefox 69.0.1, Chrome: 76.0.3809.10
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1847177/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
