Public bug reported: We made a decision some time ago that we would take class and id locators out of test steps and use a 'properties' file to abstract those instead: https://bugs.launchpad.net/mahara/+bug/1705622
I notice that locators are creeping back into the test steps. I'm not sure why this is: Do people not know about the properties file? Is it clunky and hard to use? Are test steps with locators preferred by devs/testers over the abstracted steps? The properties was really the first iteration of the idea of abstracting out page elements and having a page each for each mahara page which would allow a tester to use the more user-friendly titles and not have to delve into the inspect window. If this is still seen as desirable, we need to continue to update and develop the 'properties' idea and to commit to adding to this instead of adding locators to the tests. This means that tests with locators should fail code review. Do we need to abandon the properties idea, implement it in another way, or be more conscious of using the existing functionality? Needs discussion. ** Affects: mahara Importance: Undecided Status: New ** Tags: behat-dev -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891569 Title: Behat: Class and id locaters back in tests Status in Mahara: New Bug description: We made a decision some time ago that we would take class and id locators out of test steps and use a 'properties' file to abstract those instead: https://bugs.launchpad.net/mahara/+bug/1705622 I notice that locators are creeping back into the test steps. I'm not sure why this is: Do people not know about the properties file? Is it clunky and hard to use? Are test steps with locators preferred by devs/testers over the abstracted steps? The properties was really the first iteration of the idea of abstracting out page elements and having a page each for each mahara page which would allow a tester to use the more user-friendly titles and not have to delve into the inspect window. If this is still seen as desirable, we need to continue to update and develop the 'properties' idea and to commit to adding to this instead of adding locators to the tests. This means that tests with locators should fail code review. Do we need to abandon the properties idea, implement it in another way, or be more conscious of using the existing functionality? Needs discussion. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891569/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp