[Mahara-contributors] [Bug 1958499] Re: Upload CSV Users Bug with Failed Emails

2022-04-26 Thread Gold
** Changed in: mahara/22.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1958499

Title:
  Upload CSV Users Bug with Failed Emails

Status in Mahara:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released
Status in Mahara 21.04 series:
  Fix Released
Status in Mahara 21.10 series:
  Fix Released
Status in Mahara 22.04 series:
  Fix Released

Bug description:
  Mahara: 21.10.0
  OS: Linux 20.04
  DB: Postgres
  Browser: n/a

  While implementing a customisation for a client, we identified a very
  old bug in htdocs/admin/users/uploadcsv.php.

  The setting of the `$failedusers` array on line 639 occurs within the
  foreach loop. Which means, the data in the $failedusers array gets
  reset after each iteration.

  The initialisation of $failedusers should occur outside of the foreach
  loop.

  
  
https://github.com/MaharaProject/mahara/blob/main/htdocs/admin/users/uploadcsv.php#L644-L667

  
  This is the current code at line 637:

  if ($values['emailusers'] && $addedusers) {
  foreach ($addedusers as $user) {
  $failedusers = array();
  try {
  ...

  It should be:

  if ($values['emailusers'] && $addedusers) {
  $failedusers = array(); <- MOVE outside the foreach loop
  foreach ($addedusers as $user) {
  try {
  ...

  
  Hope that makes sense.

  Thank you.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1958499/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1958499] Re: Upload CSV Users Bug with Failed Emails

2022-02-08 Thread Doris Tam
** Changed in: mahara/21.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1958499

Title:
  Upload CSV Users Bug with Failed Emails

Status in Mahara:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Released
Status in Mahara 21.04 series:
  Fix Released
Status in Mahara 21.10 series:
  Fix Released
Status in Mahara 22.04 series:
  Fix Committed

Bug description:
  Mahara: 21.10.0
  OS: Linux 20.04
  DB: Postgres
  Browser: n/a

  While implementing a customisation for a client, we identified a very
  old bug in htdocs/admin/users/uploadcsv.php.

  The setting of the `$failedusers` array on line 639 occurs within the
  foreach loop. Which means, the data in the $failedusers array gets
  reset after each iteration.

  The initialisation of $failedusers should occur outside of the foreach
  loop.

  
  
https://github.com/MaharaProject/mahara/blob/main/htdocs/admin/users/uploadcsv.php#L644-L667

  
  This is the current code at line 637:

  if ($values['emailusers'] && $addedusers) {
  foreach ($addedusers as $user) {
  $failedusers = array();
  try {
  ...

  It should be:

  if ($values['emailusers'] && $addedusers) {
  $failedusers = array(); <- MOVE outside the foreach loop
  foreach ($addedusers as $user) {
  try {
  ...

  
  Hope that makes sense.

  Thank you.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1958499/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1958499] Re: Upload CSV Users Bug with Failed Emails

2022-02-08 Thread Dianne Tennent
** Changed in: mahara/21.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1958499

Title:
  Upload CSV Users Bug with Failed Emails

Status in Mahara:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Released
Status in Mahara 21.04 series:
  Fix Committed
Status in Mahara 21.10 series:
  Fix Released
Status in Mahara 22.04 series:
  Fix Committed

Bug description:
  Mahara: 21.10.0
  OS: Linux 20.04
  DB: Postgres
  Browser: n/a

  While implementing a customisation for a client, we identified a very
  old bug in htdocs/admin/users/uploadcsv.php.

  The setting of the `$failedusers` array on line 639 occurs within the
  foreach loop. Which means, the data in the $failedusers array gets
  reset after each iteration.

  The initialisation of $failedusers should occur outside of the foreach
  loop.

  
  
https://github.com/MaharaProject/mahara/blob/main/htdocs/admin/users/uploadcsv.php#L644-L667

  
  This is the current code at line 637:

  if ($values['emailusers'] && $addedusers) {
  foreach ($addedusers as $user) {
  $failedusers = array();
  try {
  ...

  It should be:

  if ($values['emailusers'] && $addedusers) {
  $failedusers = array(); <- MOVE outside the foreach loop
  foreach ($addedusers as $user) {
  try {
  ...

  
  Hope that makes sense.

  Thank you.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1958499/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1958499] Re: Upload CSV Users Bug with Failed Emails

2022-02-08 Thread Gold
** Changed in: mahara/20.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1958499

Title:
  Upload CSV Users Bug with Failed Emails

Status in Mahara:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Released
Status in Mahara 21.04 series:
  Fix Committed
Status in Mahara 21.10 series:
  Fix Released
Status in Mahara 22.04 series:
  Fix Committed

Bug description:
  Mahara: 21.10.0
  OS: Linux 20.04
  DB: Postgres
  Browser: n/a

  While implementing a customisation for a client, we identified a very
  old bug in htdocs/admin/users/uploadcsv.php.

  The setting of the `$failedusers` array on line 639 occurs within the
  foreach loop. Which means, the data in the $failedusers array gets
  reset after each iteration.

  The initialisation of $failedusers should occur outside of the foreach
  loop.

  
  
https://github.com/MaharaProject/mahara/blob/main/htdocs/admin/users/uploadcsv.php#L644-L667

  
  This is the current code at line 637:

  if ($values['emailusers'] && $addedusers) {
  foreach ($addedusers as $user) {
  $failedusers = array();
  try {
  ...

  It should be:

  if ($values['emailusers'] && $addedusers) {
  $failedusers = array(); <- MOVE outside the foreach loop
  foreach ($addedusers as $user) {
  try {
  ...

  
  Hope that makes sense.

  Thank you.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1958499/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1958499] Re: Upload CSV Users Bug with Failed Emails

2022-01-24 Thread Robert Lyon
** Changed in: mahara/20.10
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1958499

Title:
  Upload CSV Users Bug with Failed Emails

Status in Mahara:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed
Status in Mahara 21.04 series:
  Fix Committed
Status in Mahara 21.10 series:
  Fix Committed
Status in Mahara 22.04 series:
  Fix Committed

Bug description:
  Mahara: 21.10.0
  OS: Linux 20.04
  DB: Postgres
  Browser: n/a

  While implementing a customisation for a client, we identified a very
  old bug in htdocs/admin/users/uploadcsv.php.

  The setting of the `$failedusers` array on line 639 occurs within the
  foreach loop. Which means, the data in the $failedusers array gets
  reset after each iteration.

  The initialisation of $failedusers should occur outside of the foreach
  loop.

  
  
https://github.com/MaharaProject/mahara/blob/main/htdocs/admin/users/uploadcsv.php#L644-L667

  
  This is the current code at line 637:

  if ($values['emailusers'] && $addedusers) {
  foreach ($addedusers as $user) {
  $failedusers = array();
  try {
  ...

  It should be:

  if ($values['emailusers'] && $addedusers) {
  $failedusers = array(); <- MOVE outside the foreach loop
  foreach ($addedusers as $user) {
  try {
  ...

  
  Hope that makes sense.

  Thank you.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1958499/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1958499] Re: Upload CSV Users Bug with Failed Emails

2022-01-20 Thread Robert Lyon
** Changed in: mahara/21.10
   Status: New => Fix Committed

** Changed in: mahara/20.10
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1958499

Title:
  Upload CSV Users Bug with Failed Emails

Status in Mahara:
  Fix Committed
Status in Mahara 20.10 series:
  In Progress
Status in Mahara 21.04 series:
  Fix Committed
Status in Mahara 21.10 series:
  Fix Committed
Status in Mahara 22.04 series:
  Fix Committed

Bug description:
  Mahara: 21.10.0
  OS: Linux 20.04
  DB: Postgres
  Browser: n/a

  While implementing a customisation for a client, we identified a very
  old bug in htdocs/admin/users/uploadcsv.php.

  The setting of the `$failedusers` array on line 639 occurs within the
  foreach loop. Which means, the data in the $failedusers array gets
  reset after each iteration.

  The initialisation of $failedusers should occur outside of the foreach
  loop.

  
  
https://github.com/MaharaProject/mahara/blob/main/htdocs/admin/users/uploadcsv.php#L644-L667

  
  This is the current code at line 637:

  if ($values['emailusers'] && $addedusers) {
  foreach ($addedusers as $user) {
  $failedusers = array();
  try {
  ...

  It should be:

  if ($values['emailusers'] && $addedusers) {
  $failedusers = array(); <- MOVE outside the foreach loop
  foreach ($addedusers as $user) {
  try {
  ...

  
  Hope that makes sense.

  Thank you.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1958499/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1958499] Re: Upload CSV Users Bug with Failed Emails

2022-01-20 Thread Robert Lyon
** Changed in: mahara/21.04
   Status: New => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1958499

Title:
  Upload CSV Users Bug with Failed Emails

Status in Mahara:
  Fix Committed
Status in Mahara 20.10 series:
  New
Status in Mahara 21.04 series:
  Fix Committed
Status in Mahara 21.10 series:
  New
Status in Mahara 22.04 series:
  Fix Committed

Bug description:
  Mahara: 21.10.0
  OS: Linux 20.04
  DB: Postgres
  Browser: n/a

  While implementing a customisation for a client, we identified a very
  old bug in htdocs/admin/users/uploadcsv.php.

  The setting of the `$failedusers` array on line 639 occurs within the
  foreach loop. Which means, the data in the $failedusers array gets
  reset after each iteration.

  The initialisation of $failedusers should occur outside of the foreach
  loop.

  
  
https://github.com/MaharaProject/mahara/blob/main/htdocs/admin/users/uploadcsv.php#L644-L667

  
  This is the current code at line 637:

  if ($values['emailusers'] && $addedusers) {
  foreach ($addedusers as $user) {
  $failedusers = array();
  try {
  ...

  It should be:

  if ($values['emailusers'] && $addedusers) {
  $failedusers = array(); <- MOVE outside the foreach loop
  foreach ($addedusers as $user) {
  try {
  ...

  
  Hope that makes sense.

  Thank you.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1958499/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1958499] Re: Upload CSV Users Bug with Failed Emails

2022-01-20 Thread Robert Lyon
** Also affects: mahara/20.10
   Importance: Undecided
   Status: New

** Also affects: mahara/21.04
   Importance: Undecided
   Status: New

** Also affects: mahara/21.10
   Importance: Undecided
   Status: New

** Also affects: mahara/22.04
   Importance: High
   Status: Fix Committed

** Changed in: mahara/21.10
   Importance: Undecided => High

** Changed in: mahara/21.04
   Importance: Undecided => High

** Changed in: mahara/20.10
   Importance: Undecided => High

** Changed in: mahara/21.10
Milestone: None => 21.10.1

** Changed in: mahara/21.04
Milestone: None => 21.04.3

** Changed in: mahara/20.10
Milestone: None => 20.10.4

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1958499

Title:
  Upload CSV Users Bug with Failed Emails

Status in Mahara:
  Fix Committed
Status in Mahara 20.10 series:
  New
Status in Mahara 21.04 series:
  New
Status in Mahara 21.10 series:
  New
Status in Mahara 22.04 series:
  Fix Committed

Bug description:
  Mahara: 21.10.0
  OS: Linux 20.04
  DB: Postgres
  Browser: n/a

  While implementing a customisation for a client, we identified a very
  old bug in htdocs/admin/users/uploadcsv.php.

  The setting of the `$failedusers` array on line 639 occurs within the
  foreach loop. Which means, the data in the $failedusers array gets
  reset after each iteration.

  The initialisation of $failedusers should occur outside of the foreach
  loop.

  
  
https://github.com/MaharaProject/mahara/blob/main/htdocs/admin/users/uploadcsv.php#L644-L667

  
  This is the current code at line 637:

  if ($values['emailusers'] && $addedusers) {
  foreach ($addedusers as $user) {
  $failedusers = array();
  try {
  ...

  It should be:

  if ($values['emailusers'] && $addedusers) {
  $failedusers = array(); <- MOVE outside the foreach loop
  foreach ($addedusers as $user) {
  try {
  ...

  
  Hope that makes sense.

  Thank you.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1958499/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1958499] Re: Upload CSV Users Bug with Failed Emails

2022-01-20 Thread Robert Lyon
** Changed in: mahara
   Status: New => Fix Committed

** Changed in: mahara
Milestone: None => 22.04.0

** Changed in: mahara
   Importance: Undecided => High

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1958499

Title:
  Upload CSV Users Bug with Failed Emails

Status in Mahara:
  Fix Committed
Status in Mahara 20.10 series:
  New
Status in Mahara 21.04 series:
  New
Status in Mahara 21.10 series:
  New
Status in Mahara 22.04 series:
  Fix Committed

Bug description:
  Mahara: 21.10.0
  OS: Linux 20.04
  DB: Postgres
  Browser: n/a

  While implementing a customisation for a client, we identified a very
  old bug in htdocs/admin/users/uploadcsv.php.

  The setting of the `$failedusers` array on line 639 occurs within the
  foreach loop. Which means, the data in the $failedusers array gets
  reset after each iteration.

  The initialisation of $failedusers should occur outside of the foreach
  loop.

  
  
https://github.com/MaharaProject/mahara/blob/main/htdocs/admin/users/uploadcsv.php#L644-L667

  
  This is the current code at line 637:

  if ($values['emailusers'] && $addedusers) {
  foreach ($addedusers as $user) {
  $failedusers = array();
  try {
  ...

  It should be:

  if ($values['emailusers'] && $addedusers) {
  $failedusers = array(); <- MOVE outside the foreach loop
  foreach ($addedusers as $user) {
  try {
  ...

  
  Hope that makes sense.

  Thank you.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1958499/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1958499] Re: Upload CSV Users Bug with Failed Emails

2022-01-20 Thread Robert Lyon
https://reviews.mahara.org/#/c/12367/1

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1958499

Title:
  Upload CSV Users Bug with Failed Emails

Status in Mahara:
  New

Bug description:
  Mahara: 21.10.0
  OS: Linux 20.04
  DB: Postgres
  Browser: n/a

  While implementing a customisation for a client, we identified a very
  old bug in htdocs/admin/users/uploadcsv.php.

  The setting of the `$failedusers` array on line 639 occurs within the
  foreach loop. Which means, the data in the $failedusers array gets
  reset after each iteration.

  The initialisation of $failedusers should occur outside of the foreach
  loop.

  
  
https://github.com/MaharaProject/mahara/blob/main/htdocs/admin/users/uploadcsv.php#L644-L667

  
  This is the current code at line 637:

  if ($values['emailusers'] && $addedusers) {
  foreach ($addedusers as $user) {
  $failedusers = array();
  try {
  ...

  It should be:

  if ($values['emailusers'] && $addedusers) {
  $failedusers = array(); <- MOVE outside the foreach loop
  foreach ($addedusers as $user) {
  try {
  ...

  
  Hope that makes sense.

  Thank you.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1958499/+subscriptions


___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp