[Mahara-contributors] [Bug 2006514] Re: Inconsistent Sign-off blocks after upgrade
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2006514 Title: Inconsistent Sign-off blocks after upgrade Status in Mahara: Fix Released Bug description: When rebasing a patchset on main I noticed a Page had lost the Sign- off block. This Page **was not** in a signed off state. The other Page in the Collection also had the block, **was** in a Signed off state, and did still have the new form of the block. I think the upgrade step here needs to be updated. It's working for block instances that are signed off, but not for those that aren't. https://git.mahara.org/mahara/mahara/-/blob/main/htdocs/lib/db/upgrade.php#L975 Testing: Checkout 22.10_RELEASE and install the site Create an account As that account, create 2 Pages and add them to a Collection Add Progress Completion to the Collection Sign-off blocks to both pages Mark the first Page as Signed off. Back up the DB for handy restoring during development. Checkout main Run the upgrade Look at the Collection and pages. Expected result: * A Collection with a Progress Completion page * The Progress Completion page to shows the first Page with the Sign-off state with a signed off indicator * The Progress Completion page to shows the second Page with the Sign-off state with a not signed off indicator * The first Page to have the new form of the Sign-off block in a signed off state * The second Page to have the new form of the Sign-off block in a not signed off state The current result: * A Collection with a Progress Completion page * The Progress Completion page to shows the first Page with the Sign-off state with a signed off indicator * The Progress Completion page to shows the second Page **with no** Sign-off state indicator * The first Page has the new form of the Sign-off block in a signed off state * The second Page **does not have have** the new form of the Sign-off block in a not signed off state To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2006514/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2006514] Re: Inconsistent Sign-off blocks after upgrade
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2006514 Title: Inconsistent Sign-off blocks after upgrade Status in Mahara: Fix Committed Bug description: When rebasing a patchset on main I noticed a Page had lost the Sign- off block. This Page **was not** in a signed off state. The other Page in the Collection also had the block, **was** in a Signed off state, and did still have the new form of the block. I think the upgrade step here needs to be updated. It's working for block instances that are signed off, but not for those that aren't. https://git.mahara.org/mahara/mahara/-/blob/main/htdocs/lib/db/upgrade.php#L975 Testing: Checkout 22.10_RELEASE and install the site Create an account As that account, create 2 Pages and add them to a Collection Add Progress Completion to the Collection Sign-off blocks to both pages Mark the first Page as Signed off. Back up the DB for handy restoring during development. Checkout main Run the upgrade Look at the Collection and pages. Expected result: * A Collection with a Progress Completion page * The Progress Completion page to shows the first Page with the Sign-off state with a signed off indicator * The Progress Completion page to shows the second Page with the Sign-off state with a not signed off indicator * The first Page to have the new form of the Sign-off block in a signed off state * The second Page to have the new form of the Sign-off block in a not signed off state The current result: * A Collection with a Progress Completion page * The Progress Completion page to shows the first Page with the Sign-off state with a signed off indicator * The Progress Completion page to shows the second Page **with no** Sign-off state indicator * The first Page has the new form of the Sign-off block in a signed off state * The second Page **does not have have** the new form of the Sign-off block in a not signed off state To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2006514/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2006514] Re: Inconsistent Sign-off blocks after upgrade
** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2006514 Title: Inconsistent Sign-off blocks after upgrade Status in Mahara: In Progress Bug description: When rebasing a patchset on main I noticed a Page had lost the Sign- off block. This Page **was not** in a signed off state. The other Page in the Collection also had the block, **was** in a Signed off state, and did still have the new form of the block. I think the upgrade step here needs to be updated. It's working for block instances that are signed off, but not for those that aren't. https://git.mahara.org/mahara/mahara/-/blob/main/htdocs/lib/db/upgrade.php#L975 Testing: Checkout 22.10_RELEASE and install the site Create an account As that account, create 2 Pages and add them to a Collection Add Progress Completion to the Collection Sign-off blocks to both pages Mark the first Page as Signed off. Back up the DB for handy restoring during development. Checkout main Run the upgrade Look at the Collection and pages. Expected result: * A Collection with a Progress Completion page * The Progress Completion page to shows the first Page with the Sign-off state with a signed off indicator * The Progress Completion page to shows the second Page with the Sign-off state with a not signed off indicator * The first Page to have the new form of the Sign-off block in a signed off state * The second Page to have the new form of the Sign-off block in a not signed off state The current result: * A Collection with a Progress Completion page * The Progress Completion page to shows the first Page with the Sign-off state with a signed off indicator * The Progress Completion page to shows the second Page **with no** Sign-off state indicator * The first Page has the new form of the Sign-off block in a signed off state * The second Page **does not have have** the new form of the Sign-off block in a not signed off state To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2006514/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2006514] Re: Inconsistent Sign-off blocks after upgrade
The patch 13881 might not fix all of the issues but should at least fix one issue relating to the watchlist queue -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2006514 Title: Inconsistent Sign-off blocks after upgrade Status in Mahara: Confirmed Bug description: When rebasing a patchset on main I noticed a Page had lost the Sign- off block. This Page **was not** in a signed off state. The other Page in the Collection also had the block, **was** in a Signed off state, and did still have the new form of the block. I think the upgrade step here needs to be updated. It's working for block instances that are signed off, but not for those that aren't. https://git.mahara.org/mahara/mahara/-/blob/main/htdocs/lib/db/upgrade.php#L975 Testing: Checkout 22.10_RELEASE and install the site Create an account As that account, create 2 Pages and add them to a Collection Add Progress Completion to the Collection Sign-off blocks to both pages Mark the first Page as Signed off. Back up the DB for handy restoring during development. Checkout main Run the upgrade Look at the Collection and pages. Expected result: * A Collection with a Progress Completion page * The Progress Completion page to shows the first Page with the Sign-off state with a signed off indicator * The Progress Completion page to shows the second Page with the Sign-off state with a not signed off indicator * The first Page to have the new form of the Sign-off block in a signed off state * The second Page to have the new form of the Sign-off block in a not signed off state The current result: * A Collection with a Progress Completion page * The Progress Completion page to shows the first Page with the Sign-off state with a signed off indicator * The Progress Completion page to shows the second Page **with no** Sign-off state indicator * The first Page has the new form of the Sign-off block in a signed off state * The second Page **does not have have** the new form of the Sign-off block in a not signed off state To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2006514/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2006514] Re: Inconsistent Sign-off blocks after upgrade
When I try to upgrade from 22.04 to main, I do get error messages:
[DBG] 2f (lib/dml.php:180) postgres9 error: [-1: ERROR: update or delete on
table "blocktype_installed" violates foreign key constraint "blocinst_blo_fk"
on table "block_instance"
DETAIL: Key (name)=(signoff) is still referenced from table "block_instance".]
in EXECUTE("DELETE FROM "blocktype_installed" WHERE name='signoff'")Command
was: DELETE FROM "blocktype_installed" WHERE name='signoff'
[WAR] 2f (lib/errors.php:853) Could not execute command: DELETE FROM
"blocktype_installed" WHERE name='signoff'
Call stack (most recent first):
log_message("Could not execute command: DELETE FROM "blocktype_...", 8,
true, true) at /home/kristina/code/mahara/htdocs/lib/errors.php:89
log_warn("Could not execute command: DELETE FROM "blocktype_...") at
/home/kristina/code/mahara/htdocs/lib/errors.php:853
SQLException->__construct("Could not execute command: DELETE FROM
"blocktype_...") at /home/kristina/code/mahara/htdocs/lib/dml.php:181
execute_sql("DELETE FROM "blocktype_installed" WHERE name='sign...") at
/home/kristina/code/mahara/htdocs/lib/db/upgrade.php:1019
xmldb_core_upgrade("2022032212") at
/home/kristina/code/mahara/htdocs/lib/upgrade.php:378
upgrade_core(object(stdClass)) at
/home/kristina/code/mahara/htdocs/admin/upgrade.json.php:84
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/2006514
Title:
Inconsistent Sign-off blocks after upgrade
Status in Mahara:
Confirmed
Bug description:
When rebasing a patchset on main I noticed a Page had lost the Sign-
off block. This Page **was not** in a signed off state. The other Page
in the Collection also had the block, **was** in a Signed off state,
and did still have the new form of the block.
I think the upgrade step here needs to be updated. It's working for
block instances that are signed off, but not for those that aren't.
https://git.mahara.org/mahara/mahara/-/blob/main/htdocs/lib/db/upgrade.php#L975
Testing:
Checkout 22.10_RELEASE and install the site
Create an account
As that account, create 2 Pages and add them to a Collection
Add Progress Completion to the Collection
Sign-off blocks to both pages
Mark the first Page as Signed off.
Back up the DB for handy restoring during development.
Checkout main
Run the upgrade
Look at the Collection and pages.
Expected result:
* A Collection with a Progress Completion page
* The Progress Completion page to shows the first Page with the Sign-off
state with a signed off indicator
* The Progress Completion page to shows the second Page with the Sign-off
state with a not signed off indicator
* The first Page to have the new form of the Sign-off block in a signed off
state
* The second Page to have the new form of the Sign-off block in a not signed
off state
The current result:
* A Collection with a Progress Completion page
* The Progress Completion page to shows the first Page with the Sign-off
state with a signed off indicator
* The Progress Completion page to shows the second Page **with no** Sign-off
state indicator
* The first Page has the new form of the Sign-off block in a signed off state
* The second Page **does not have have** the new form of the Sign-off block
in a not signed off state
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/2006514/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2006514] Re: Inconsistent Sign-off blocks after upgrade
Unable to replicate the issue. Upon upgrading a site from 22.10 to main, the sign-off forms remained with the expected states on both pages. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2006514 Title: Inconsistent Sign-off blocks after upgrade Status in Mahara: Confirmed Bug description: When rebasing a patchset on main I noticed a Page had lost the Sign- off block. This Page **was not** in a signed off state. The other Page in the Collection also had the block, **was** in a Signed off state, and did still have the new form of the block. I think the upgrade step here needs to be updated. It's working for block instances that are signed off, but not for those that aren't. https://git.mahara.org/mahara/mahara/-/blob/main/htdocs/lib/db/upgrade.php#L975 Testing: Checkout 22.10_RELEASE and install the site Create an account As that account, create 2 Pages and add them to a Collection Add Progress Completion to the Collection Sign-off blocks to both pages Mark the first Page as Signed off. Back up the DB for handy restoring during development. Checkout main Run the upgrade Look at the Collection and pages. Expected result: * A Collection with a Progress Completion page * The Progress Completion page to shows the first Page with the Sign-off state with a signed off indicator * The Progress Completion page to shows the second Page with the Sign-off state with a not signed off indicator * The first Page to have the new form of the Sign-off block in a signed off state * The second Page to have the new form of the Sign-off block in a not signed off state The current result: * A Collection with a Progress Completion page * The Progress Completion page to shows the first Page with the Sign-off state with a signed off indicator * The Progress Completion page to shows the second Page **with no** Sign-off state indicator * The first Page has the new form of the Sign-off block in a signed off state * The second Page **does not have have** the new form of the Sign-off block in a not signed off state To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2006514/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2006514] Re: Inconsistent Sign-off blocks after upgrade
** Changed in: mahara Assignee: (unassigned) => Doris Tam (doristam) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2006514 Title: Inconsistent Sign-off blocks after upgrade Status in Mahara: Confirmed Bug description: When rebasing a patchset on main I noticed a Page had lost the Sign- off block. This Page **was not** in a signed off state. The other Page in the Collection also had the block, **was** in a Signed off state, and did still have the new form of the block. I think the upgrade step here needs to be updated. It's working for block instances that are signed off, but not for those that aren't. https://git.mahara.org/mahara/mahara/-/blob/main/htdocs/lib/db/upgrade.php#L975 Testing: Checkout 22.10_RELEASE and install the site Create an account As that account, create 2 Pages and add them to a Collection Add Progress Completion to the Collection Sign-off blocks to both pages Mark the first Page as Signed off. Back up the DB for handy restoring during development. Checkout main Run the upgrade Look at the Collection and pages. Expected result: * A Collection with a Progress Completion page * The Progress Completion page to shows the first Page with the Sign-off state with a signed off indicator * The Progress Completion page to shows the second Page with the Sign-off state with a not signed off indicator * The first Page to have the new form of the Sign-off block in a signed off state * The second Page to have the new form of the Sign-off block in a not signed off state The current result: * A Collection with a Progress Completion page * The Progress Completion page to shows the first Page with the Sign-off state with a signed off indicator * The Progress Completion page to shows the second Page **with no** Sign-off state indicator * The first Page has the new form of the Sign-off block in a signed off state * The second Page **does not have have** the new form of the Sign-off block in a not signed off state To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2006514/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2006514] Re: Inconsistent Sign-off blocks after upgrade
** Changed in: mahara Status: New => Confirmed ** Changed in: mahara Importance: Undecided => High -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2006514 Title: Inconsistent Sign-off blocks after upgrade Status in Mahara: Confirmed Bug description: When rebasing a patchset on main I noticed a Page had lost the Sign- off block. This Page **was not** in a signed off state. The other Page in the Collection also had the block, **was** in a Signed off state, and did still have the new form of the block. I think the upgrade step here needs to be updated. It's working for block instances that are signed off, but not for those that aren't. https://git.mahara.org/mahara/mahara/-/blob/main/htdocs/lib/db/upgrade.php#L975 Testing: Checkout 22.10_RELEASE and install the site Create an account As that account, create 2 Pages and add them to a Collection Add Progress Completion to the Collection Sign-off blocks to both pages Mark the first Page as Signed off. Back up the DB for handy restoring during development. Checkout main Run the upgrade Look at the Collection and pages. Expected result: * A Collection with a Progress Completion page * The Progress Completion page to shows the first Page with the Sign-off state with a signed off indicator * The Progress Completion page to shows the second Page with the Sign-off state with a not signed off indicator * The first Page to have the new form of the Sign-off block in a signed off state * The second Page to have the new form of the Sign-off block in a not signed off state The current result: * A Collection with a Progress Completion page * The Progress Completion page to shows the first Page with the Sign-off state with a signed off indicator * The Progress Completion page to shows the second Page **with no** Sign-off state indicator * The first Page has the new form of the Sign-off block in a signed off state * The second Page **does not have have** the new form of the Sign-off block in a not signed off state To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2006514/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
