Re: svn commit: r823611 - in /lucene/mahout/trunk: core/src/main/java/org/apache/mahout/cf/taste/impl/common/ core/src/main/java/org/apache/mahout/cf/taste/impl/recommender/ core/src/main/java/org/
I mean, my mistake and I'll fix it, but doesn't this sound like a
javac bug? these are static methods -- they can't override each other.
So to fail because of clashing signature of an overridden method...
anybody knows what's going on there?
On Sat, Oct 10, 2009 at 5:24 AM, deneche abdelhakim wrote:
> the following change :
>
> {code}
> ==
> ---
> lucene/mahout/trunk/examples/src/main/java/org/apache/mahout/clustering/dirichlet/DisplayDirichlet.java
> (original)
> +++
> lucene/mahout/trunk/examples/src/main/java/org/apache/mahout/clustering/dirichlet/DisplayDirichlet.java
> Fri Oct 9 16:48:09 2009
> @@ -96,7 +96,7 @@
> });
> }
>
> - public static void main(String[] args) throws IOException {
> + public static void main(String[] args) {
> {code}
>
> causes compiling failures:
>
> {noformat}
> [INFO] Compilation failure
>
[jira] Updated: (MAHOUT-148) Convert Classification Algs to use richer Writable syntax
[ https://issues.apache.org/jira/browse/MAHOUT-148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robin Anil updated MAHOUT-148: -- Attachment: MAHOUT-148-Oct10.patch Cleaned up main functions, used the latest trunk > Convert Classification Algs to use richer Writable syntax > - > > Key: MAHOUT-148 > URL: https://issues.apache.org/jira/browse/MAHOUT-148 > Project: Mahout > Issue Type: Improvement > Components: Classification >Affects Versions: 0.1, 0.2 >Reporter: Grant Ingersoll >Assignee: Robin Anil > Fix For: 0.2 > > Attachments: MAHOUT-148-Oct10.patch, > MAHOUT-148-Work-In-Progress.patch, MAHOUT-148.patch > > > Much of the classification capabilities relies on parsing values out from the > Text object just to determine what type of "thing" is being used. We should > try to avoid having to do string manipulation for this kind of thing and > instead encapsulate it in Writable instances. This should make things > perform faster and bring stronger typing to the problem, which should make it > easier to understand and debug the code. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (MAHOUT-181) DistanceMeasure is broken: iteration is done over nonZeroElements of v1.plus(v2), not v1.minus(v2)
[ https://issues.apache.org/jira/browse/MAHOUT-181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Ingersoll reassigned MAHOUT-181: -- Assignee: Grant Ingersoll > DistanceMeasure is broken: iteration is done over nonZeroElements of > v1.plus(v2), not v1.minus(v2) > -- > > Key: MAHOUT-181 > URL: https://issues.apache.org/jira/browse/MAHOUT-181 > Project: Mahout > Issue Type: Bug > Components: Matrix >Affects Versions: 0.2 > Environment: all >Reporter: Jake Mannix >Assignee: Grant Ingersoll > Fix For: 0.2 > > Attachments: MAHOUT-181.patch > > > SquaredEuclideanDistanceMeasure iterates over v1.plus(v2), which has the > right number of nonzero elements if v1.get(i) != -v2.get(i) for all i > indexing nonzero elements, but for example, the simple case of looking at > SquaredEuclideanDisanceMeasure.distance(v, v.assign(new NegateFunction())) > yeilds zero on current trunk, instead of 4*v.lengthSquared(). > Attached is a patch with a unit test which checks that > DistanceMeasure.distance always returns nonnegative results and in particular > also does not return , as well as a fix for ManhattanDistanceMeasure, > SquaredEuclideanDistanceMeasure, and EuclideanDistanceMeasure. > Unfortunately, the attached unit test reveals that the > TanimotoDistanceMeasure is more broken than I can fix at present. It doesn't > appear to be properly using the referenced formula in wikipedia, and in fact > sometimes returns negative results. This means that with this patch applied, > TestTanimotoDistanceMeasure is failing (and rightfully so). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-181) DistanceMeasure is broken: iteration is done over nonZeroElements of v1.plus(v2), not v1.minus(v2)
[ https://issues.apache.org/jira/browse/MAHOUT-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12764369#action_12764369 ] Grant Ingersoll commented on MAHOUT-181: Jake, can you bring this patch up to date? I'm getting errors on the applying it to the test. Thanks, Grant > DistanceMeasure is broken: iteration is done over nonZeroElements of > v1.plus(v2), not v1.minus(v2) > -- > > Key: MAHOUT-181 > URL: https://issues.apache.org/jira/browse/MAHOUT-181 > Project: Mahout > Issue Type: Bug > Components: Matrix >Affects Versions: 0.2 > Environment: all >Reporter: Jake Mannix >Assignee: Grant Ingersoll > Fix For: 0.2 > > Attachments: MAHOUT-181.patch > > > SquaredEuclideanDistanceMeasure iterates over v1.plus(v2), which has the > right number of nonzero elements if v1.get(i) != -v2.get(i) for all i > indexing nonzero elements, but for example, the simple case of looking at > SquaredEuclideanDisanceMeasure.distance(v, v.assign(new NegateFunction())) > yeilds zero on current trunk, instead of 4*v.lengthSquared(). > Attached is a patch with a unit test which checks that > DistanceMeasure.distance always returns nonnegative results and in particular > also does not return , as well as a fix for ManhattanDistanceMeasure, > SquaredEuclideanDistanceMeasure, and EuclideanDistanceMeasure. > Unfortunately, the attached unit test reveals that the > TanimotoDistanceMeasure is more broken than I can fix at present. It doesn't > appear to be properly using the referenced formula in wikipedia, and in fact > sometimes returns negative results. This means that with this patch applied, > TestTanimotoDistanceMeasure is failing (and rightfully so). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-181) DistanceMeasure is broken: iteration is done over nonZeroElements of v1.plus(v2), not v1.minus(v2)
[ https://issues.apache.org/jira/browse/MAHOUT-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12764373#action_12764373 ] Jake Mannix commented on MAHOUT-181: Grant, are we going to be using Ted's patch for MAHOUT-165, which he says fixes this as well (I haven't looked in any great detail at that part to see how much of that is covered)? Also, is this probably going to get clobbered by any major shift toward using commons-math linear algebra primitives? Either way, sure, I'll bring this patch up-to-date so that we have choices. > DistanceMeasure is broken: iteration is done over nonZeroElements of > v1.plus(v2), not v1.minus(v2) > -- > > Key: MAHOUT-181 > URL: https://issues.apache.org/jira/browse/MAHOUT-181 > Project: Mahout > Issue Type: Bug > Components: Matrix >Affects Versions: 0.2 > Environment: all >Reporter: Jake Mannix >Assignee: Grant Ingersoll > Fix For: 0.2 > > Attachments: MAHOUT-181.patch > > > SquaredEuclideanDistanceMeasure iterates over v1.plus(v2), which has the > right number of nonzero elements if v1.get(i) != -v2.get(i) for all i > indexing nonzero elements, but for example, the simple case of looking at > SquaredEuclideanDisanceMeasure.distance(v, v.assign(new NegateFunction())) > yeilds zero on current trunk, instead of 4*v.lengthSquared(). > Attached is a patch with a unit test which checks that > DistanceMeasure.distance always returns nonnegative results and in particular > also does not return , as well as a fix for ManhattanDistanceMeasure, > SquaredEuclideanDistanceMeasure, and EuclideanDistanceMeasure. > Unfortunately, the attached unit test reveals that the > TanimotoDistanceMeasure is more broken than I can fix at present. It doesn't > appear to be properly using the referenced formula in wikipedia, and in fact > sometimes returns negative results. This means that with this patch applied, > TestTanimotoDistanceMeasure is failing (and rightfully so). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAHOUT-157) Frequent Pattern Mining using Parallel FP-Growth
[ https://issues.apache.org/jira/browse/MAHOUT-157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robin Anil updated MAHOUT-157: -- Attachment: MAHOUT-157-Oct-10.pfpgrowth.patch Completed streaming fpgrowth where transactions are read in a stream using an Iterator. The patch looks good (except for the comments above which has to be integrated) Units Tests average 90% coverage > Frequent Pattern Mining using Parallel FP-Growth > > > Key: MAHOUT-157 > URL: https://issues.apache.org/jira/browse/MAHOUT-157 > Project: Mahout > Issue Type: New Feature > Components: Frequent Itemset/Association Rule Mining >Affects Versions: 0.2 >Reporter: Robin Anil >Assignee: Robin Anil > Fix For: 0.2 > > Attachments: MAHOUT-157-August-17.patch, MAHOUT-157-August-24.patch, > MAHOUT-157-August-31.patch, MAHOUT-157-August-6.patch, > MAHOUT-157-Combinations-BSD-License.patch, > MAHOUT-157-Combinations-BSD-License.patch, > MAHOUT-157-inProgress-August-5.patch, MAHOUT-157-Oct-1.patch, > MAHOUT-157-Oct-10.pfpgrowth.patch, MAHOUT-157-Oct-8.pfpgrowth.patch, > MAHOUT-157-Oct-8.TestedMapReducePipeline.patch, > MAHOUT-157-Oct-9.StreamingDBRead-Inprogress.patch, > MAHOUT-157-September-10.patch, MAHOUT-157-September-18.patch, > MAHOUT-157-September-5.patch > > > Implement: http://infolab.stanford.edu/~echang/recsys08-69.pdf -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAHOUT-113) CDInfosToolTest.testGatherInfos failure in Mahout examples
[
https://issues.apache.org/jira/browse/MAHOUT-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deneche A. Hakim updated MAHOUT-113:
Attachment: mahout113-patch-update.diff
updated the patch to the current trunk
> CDInfosToolTest.testGatherInfos failure in Mahout examples
> --
>
> Key: MAHOUT-113
> URL: https://issues.apache.org/jira/browse/MAHOUT-113
> Project: Mahout
> Issue Type: Bug
> Environment: Maven version: 2.0.9
> Java version: 1.6.0_07
> OS name: "linux" version: "2.6.26.6-79.fc9.i686" arch: "i386" Family: "unix"
>Reporter: Jukka Zitting
>Priority: Minor
> Attachments: mahout113-patch-update.diff, mahout113-patch.diff,
> org.apache.mahout.ga.watchmaker.cd.tool.CDInfosToolTest-output.txt
>
>
> I'm getting the following test failure when running "mvn clean install" on a
> fresh checkout of Mahout trunk:
> {noformat}
> ---
> Test set: org.apache.mahout.ga.watchmaker.cd.tool.CDInfosToolTest
> ---
> Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.828 sec <<<
> FAILURE!
> testGatherInfos(org.apache.mahout.ga.watchmaker.cd.tool.CDInfosToolTest)
> Time elapsed: 1.798 sec <<< FAILURE!
> junit.framework.AssertionFailedError: expected:<48> but was:<46>
> at junit.framework.Assert.fail(Assert.java:47)
> at junit.framework.Assert.failNotEquals(Assert.java:280)
> at junit.framework.Assert.assertEquals(Assert.java:64)
> at junit.framework.Assert.assertEquals(Assert.java:198)
> at junit.framework.Assert.assertEquals(Assert.java:204)
> at
> org.apache.mahout.ga.watchmaker.cd.tool.CDInfosToolTest.testGatherInfos(CDInfosToolTest.java:207)
> {noformat}
> I'll attach the test output file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (MAHOUT-113) CDInfosToolTest.testGatherInfos failure in Mahout examples
[
https://issues.apache.org/jira/browse/MAHOUT-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deneche A. Hakim reassigned MAHOUT-113:
---
Assignee: Deneche A. Hakim
> CDInfosToolTest.testGatherInfos failure in Mahout examples
> --
>
> Key: MAHOUT-113
> URL: https://issues.apache.org/jira/browse/MAHOUT-113
> Project: Mahout
> Issue Type: Bug
> Environment: Maven version: 2.0.9
> Java version: 1.6.0_07
> OS name: "linux" version: "2.6.26.6-79.fc9.i686" arch: "i386" Family: "unix"
>Reporter: Jukka Zitting
>Assignee: Deneche A. Hakim
>Priority: Minor
> Attachments: mahout113-patch-update.diff, mahout113-patch.diff,
> org.apache.mahout.ga.watchmaker.cd.tool.CDInfosToolTest-output.txt
>
>
> I'm getting the following test failure when running "mvn clean install" on a
> fresh checkout of Mahout trunk:
> {noformat}
> ---
> Test set: org.apache.mahout.ga.watchmaker.cd.tool.CDInfosToolTest
> ---
> Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.828 sec <<<
> FAILURE!
> testGatherInfos(org.apache.mahout.ga.watchmaker.cd.tool.CDInfosToolTest)
> Time elapsed: 1.798 sec <<< FAILURE!
> junit.framework.AssertionFailedError: expected:<48> but was:<46>
> at junit.framework.Assert.fail(Assert.java:47)
> at junit.framework.Assert.failNotEquals(Assert.java:280)
> at junit.framework.Assert.assertEquals(Assert.java:64)
> at junit.framework.Assert.assertEquals(Assert.java:198)
> at junit.framework.Assert.assertEquals(Assert.java:204)
> at
> org.apache.mahout.ga.watchmaker.cd.tool.CDInfosToolTest.testGatherInfos(CDInfosToolTest.java:207)
> {noformat}
> I'll attach the test output file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
