Re: [Mailman-Users] Attachment URL in the archive is mangled.

2008-11-22 Thread Mark Dale


Hi Mark
(Apologies for late reply, have been away)

Yes, I sure did. And also rebooted the server (and checked that the
qrunner was starting up on boot)
I also noticed that with the new Scrubber.py, emails with attachments
were neither delivered nor archived. Emails without attachments were okay.

Once I returned the original Scrubber.py and restarted, emails with
attachments got delivered and also sent to archive. (Broken link to
attachment still in archived message though).

Mark Dale



Mark Sapiro wrote:
 Did you remember to restart Mailman after replacing Scrubber.py?
 





--
Mailman-Users mailing list
Mailman-Users@python.org
http://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://wiki.list.org/x/AgA3
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Security Policy: http://wiki.list.org/x/QIA9


Re: [Mailman-Users] Attachment URL in the archive is mangled.

2008-11-22 Thread Mark Sapiro
Mark Dale wrote:

I also noticed that with the new Scrubber.py, emails with attachments
were neither delivered nor archived. Emails without attachments were okay.


There is probably some incompatibility between the 2.1.9 Scrubber.py
and the rest of your installation that threw an exception on mail with
attachments. Check Mailman's error log and shunt queue.


Once I returned the original Scrubber.py and restarted, emails with
attachments got delivered and also sent to archive. (Broken link to
attachment still in archived message though).


I have been able to duplicate the problem with the 2.1.5 version of
Scrubber.py. I'll try to come up with a simple patch that you can
apply to fix it. It is fixed in recent Scrubber.py versions.

The issue is as I thought. The scrubbed message is quoted-printable
encoded, but the Content-Transfer-Encoding: header says 8bit and not
quoted-printable so the message is not properly decoded for the
archive.

In my case, I could see other symptoms of this besides just the URL of
the scrubbed attachment. For example, the --  separator before my
signature was rendered as -- = followed by a blank line.

-- 
Mark Sapiro [EMAIL PROTECTED]The highway is for gamblers,
San Francisco Bay Area, Californiabetter use your sense - B. Dylan

--
Mailman-Users mailing list
Mailman-Users@python.org
http://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://wiki.list.org/x/AgA3
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Security Policy: http://wiki.list.org/x/QIA9


Re: [Mailman-Users] Attachment URL in the archive is mangled.

2008-11-22 Thread Mark Sapiro
Mark Sapiro wrote:

I have been able to duplicate the problem with the 2.1.5 version of
Scrubber.py. I'll try to come up with a simple patch that you can
apply to fix it. It is fixed in recent Scrubber.py versions.


I think you'd be better off upgrading your Mailman, but if you want to
try a patch to the 2.1.5 Scrubber.py, I think this should do it. It is
only lightly tested, but I think it's OK.

--- Scrubber.py 2008-11-22 20:21:38.37500 -0800
+++ Scrubberx.py2008-11-22 20:54:47.25000 -0800
@@ -326,9 +326,8 @@
 # Now join the text and set the payload
 sep = _('-- next part --\n')
 del msg['content-type']
-msg.set_payload(sep.join(text), charset)
 del msg['content-transfer-encoding']
-msg.add_header('Content-Transfer-Encoding', '8bit')
+msg.set_payload(sep.join(text), charset)
 return msg



-- 
Mark Sapiro [EMAIL PROTECTED]The highway is for gamblers,
San Francisco Bay Area, Californiabetter use your sense - B. Dylan

--
Mailman-Users mailing list
Mailman-Users@python.org
http://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://wiki.list.org/x/AgA3
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Security Policy: http://wiki.list.org/x/QIA9