Re: [Mailman-Users] Mailman 2.1.10 has been released

2008-05-23 Thread Barry Finkel
On April 23 Mark Sapiro wrote:

| I am happy to announce the release of Mailman 2.1.10.


I have discovered a few problems with the release. None is a major show
stopper, but the most significant so far is that I broke cmd_subscribe
so that email subscribe to the -subscribe or -join address or the
- -request address with a bare 'subscribe' command results in the message
being shunted. A patch for this is attached, but I plan to make a patch
release probably next week.

Has there been a patch release, other than the one -subscribe patch
included in that posting?  Thanks.
--
Barry S. Finkel
Computing and Information Systems Division
Argonne National Laboratory  Phone:+1 (630) 252-7277
9700 South Cass Avenue   Facsimile:+1 (630) 252-4601
Building 222, Room D209  Internet: [EMAIL PROTECTED]
Argonne, IL   60439-4828 IBMMAIL:  I1004994

--
Mailman-Users mailing list
Mailman-Users@python.org
http://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://www.python.org/cgi-bin/faqw-mm.py
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Security Policy: 
http://www.python.org/cgi-bin/faqw-mm.py?req=showamp;file=faq01.027.htp


Re: [Mailman-Users] Mailman 2.1.10 has been released

2008-04-23 Thread Mark Sapiro

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Mark Sapiro wrote:
| I am happy to announce the release of Mailman 2.1.10.


I have discovered a few problems with the release. None is a major show
stopper, but the most significant so far is that I broke cmd_subscribe
so that email subscribe to the -subscribe or -join address or the
- -request address with a bare 'subscribe' command results in the message
being shunted. A patch for this is attached, but I plan to make a patch
release probably next week.

- --
Mark Sapiro [EMAIL PROTECTED]The highway is for gamblers,
San Francisco Bay Area, Californiabetter use your sense - B. Dylan

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.7 (MingW32)

iD8DBQFID1HvVVuXXpU7hpMRAm+3AKD2otRNTXWYSRjguJEYVc0HRVflhACZAVXf
Kao5NWvpiRQ9U9keKT2Jbj8=
=1NSl
-END PGP SIGNATURE-
=== modified file 'Mailman/Commands/cmd_subscribe.py'
--- Mailman/Commands/cmd_subscribe.py   2008-03-20 03:07:51 +
+++ Mailman/Commands/cmd_subscribe.py   2008-04-23 14:32:48 +
@@ -71,7 +71,8 @@
 return STOP
 argnum += 1
 # Fix the password/digest issue
-if digest is None and password.lower() in ('digest', 'nodigest'):
+if (digest is None
+and password and password.lower() in ('digest', 'nodigest')):
 if password.lower() == 'digest':
 digest = 1
 else:

--
Mailman-Users mailing list
Mailman-Users@python.org
http://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://www.python.org/cgi-bin/faqw-mm.py
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Security Policy: 
http://www.python.org/cgi-bin/faqw-mm.py?req=showamp;file=faq01.027.htp

Re: [Mailman-Users] Mailman 2.1.10 has been released

2008-04-22 Thread Mark Sapiro
Brad Knowles wrote:

On 4/21/08, Brad Knowles wrote:

   I have applied the patch to my installation and I'm sure it's good, but
   I haven't seen any unparseable messages.

  I haven't seen any more unparseable messages in the last few minutes,
  but let's see how things go.

We've now had a couple of unparseable messages since applying the 
patch, and it seems to be working as expected.


Going back to Jun 12 23:48:51 2007, it looks like we've had a total 
of about 378,989 unparseable messages, although we only have just 
over 8000 messages in the mailman/qfiles/shunt and 
mailman/qfiles/shunt.old directories (7759 .psv files, and 312 .pck 
files).

That works out to about 37,900 unparseable messages per month, or 
something like about 125 unparseable messages per day.


The light dawns! (thanks to the post at
http://mail.python.org/pipermail/mailman-users/2008-April/061365.html).

There was an error in 2.1.9 that didn't delete (or move aside) the .bak
file in qfiles/in from an unparseable message. Thus, there were 7500+
unparseable message qfiles/in/*.bak files when you restarted mailman.
These were all 'recovered' and reprocessed, reproducing the
unparseable message error, and this time moved to qfiles/shunt/*.psv
(so it wouldn't happen again).

This explains why there were over 7500 of these at once, when the
normal rate is /only/ 125 per day.

-- 
Mark Sapiro [EMAIL PROTECTED]The highway is for gamblers,
San Francisco Bay Area, Californiabetter use your sense - B. Dylan

--
Mailman-Users mailing list
Mailman-Users@python.org
http://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://www.python.org/cgi-bin/faqw-mm.py
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Security Policy: 
http://www.python.org/cgi-bin/faqw-mm.py?req=showamp;file=faq01.027.htp


Re: [Mailman-Users] Mailman 2.1.10 has been released

2008-04-22 Thread Mark Sapiro
Brad Knowles wrote:

Going back to Jun 12 23:48:51 2007, it looks like we've had a total 
of about 378,989 unparseable messages, although we only have just 
over 8000 messages in the mailman/qfiles/shunt and 
mailman/qfiles/shunt.old directories (7759 .psv files, and 312 .pck 
files).


There are two reasons why you've had 378,989 unparseable messages, but
only have 7759 .psv files.

First, some of the unparseable .bak files that 2.1.9 left behind in
qfiles/in may have been removed or moved aside.

Second, whenever Mailman was restarted, any qfiles/in/*.bak files would
have been reprocessed resulting in a flood of unparseable message
errors and leaving just one new .bak file per message. Thus a single
message and .bak file could have been responsible for several logged
unparseable message errors if Mailman had been restarted several times.

-- 
Mark Sapiro [EMAIL PROTECTED]The highway is for gamblers,
San Francisco Bay Area, Californiabetter use your sense - B. Dylan

--
Mailman-Users mailing list
Mailman-Users@python.org
http://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://www.python.org/cgi-bin/faqw-mm.py
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Security Policy: 
http://www.python.org/cgi-bin/faqw-mm.py?req=showamp;file=faq01.027.htp


[Mailman-Users] Mailman 2.1.10 has been released

2008-04-21 Thread Mark Sapiro
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

I am happy to announce the release of Mailman 2.1.10.

This is a security and bug fix release and it is highly recommended
that all sites upgrade to this version. Mailman 2.1.10 also adds support
for three new language translations, Galician, Hebrew and Slovak and a
few new features.

Mailman is free software for managing email mailing lists and e-
newsletters. Mailman is used for all the python.org and
SourceForge.net mailing lists, as well as at hundreds of other sites.

For more information, including download links, please see:

http://www.list.org
http://mailman.sf.net
http://www.gnu.org/software/mailman

Special thanks are due to Barry Warsaw and Tokio Kikuchi for much coding
and support, Moritz Naumann for help with security issues and Jim Tittsler
for a significant patch.

Here's a list of the major changes.

Security

- - The 2.1.9 fixes for CVE-2006-3636 were not complete.  In particular,
some potential cross-site scripting attacks were not detected in
editing templates and updating the list's info attribute via the web
admin interface.  This has been assigned CVE-2008-0564 and has been
fixed.  Thanks again to Moritz Naumann for assistance with this.

- - There is a new mm_cfg.py/Defaults.py variable
OWNERS_CAN_CHANGE_MEMBER_PASSWORDS which controls whether the list
owner can change a member's password from the member's options page.
This defaults to No and should be changed to Yes only if list owners
are trusted to not change a member's password, log in as the member
and make global membership changes.

Note: If you are not ready to upgrade, patches for these two issues
are available at
http://sourceforge.net/project/showfiles.php?group_id=103
in the 2.1.9 file list.

New Features

- - Changed cmd_who.py to list all members if authorization is with the
list's admin or moderator password and to accept the password if the
roster is public. Also changed the web roster to show hidden members
when authorization is by site or list's admin or moderator password
(1587651).

- - Added the ability to put a list name in accept_these_nonmembers
to accept posts from members of that list (1220144).

- - Added a new 'sibling list' feature to exclude members of another list
from receiving a post from this list if the other list is in the To: or
Cc: of the post or to include members of the other list if that list is
not in the To: or Cc: of the post (Patch ID 1347962).

- - Added the admin_member_chunksize attribute to the admin General Options
interface (Bug 1072002, Partial RFE 782436).

Internationalization

- - Added the Hebrew translation from Dov Zamir. This includes addition of
a direction ('ltr', 'rtl') to the LC_DESCRIPTIONS table. The
add_language() function defaults direction to 'ltr' to not break
existing mm_cfg.py files.

- - Added the Slovak translation from Martin Matuska.

- - Added the Galician translation from Frco. Javier Rial Rodríguez.


- --
Mark Sapiro [EMAIL PROTECTED]The highway is for gamblers,
San Francisco Bay Area, Californiabetter use your sense - B. Dylan

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.7 (MingW32)

iD8DBQFIDO/oVVuXXpU7hpMRAngiAKCwIOhSJJrCaY3afhGJQN339/dKuACeMckR
SI7DwCHcYONnIj3LoNYueC0=
=DO/d
-END PGP SIGNATURE-
--
Mailman-Users mailing list
Mailman-Users@python.org
http://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://www.python.org/cgi-bin/faqw-mm.py
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Security Policy: 
http://www.python.org/cgi-bin/faqw-mm.py?req=showamp;file=faq01.027.htp


Re: [Mailman-Users] Mailman 2.1.10 has been released

2008-04-21 Thread Jim Popovitch
On Mon, Apr 21, 2008 at 3:50 PM, Mark Sapiro [EMAIL PROTECTED] wrote:
  Note: If you are not ready to upgrade, patches for these two issues
  are available at
  http://sourceforge.net/project/showfiles.php?group_id=103
  in the 2.1.9 file list.

THANK YOU!

-Jim P.
--
Mailman-Users mailing list
Mailman-Users@python.org
http://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://www.python.org/cgi-bin/faqw-mm.py
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Security Policy: 
http://www.python.org/cgi-bin/faqw-mm.py?req=showamp;file=faq01.027.htp


Re: [Mailman-Users] Mailman 2.1.10 has been released

2008-04-21 Thread Brad Knowles
Mark Sapiro wrote:

 I am happy to announce the release of Mailman 2.1.10.

Now running on mail.python.org.  Please let us know if there are any problems.

-- 
Brad Knowles [EMAIL PROTECTED]
LinkedIn Profile: http://tinyurl.com/y8kpxu
--
Mailman-Users mailing list
Mailman-Users@python.org
http://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://www.python.org/cgi-bin/faqw-mm.py
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Security Policy: 
http://www.python.org/cgi-bin/faqw-mm.py?req=showamp;file=faq01.027.htp


Re: [Mailman-Users] Mailman 2.1.10 has been released

2008-04-21 Thread David Newman

Mark Sapiro wrote:

I am happy to announce the release of Mailman 2.1.10.


Congratulations!

I presume the usual upgrade instructions apply?

http://www.python.org/cgi-bin/faqw-mm.py?req=showfile=faq04.014.htp

dn

--
Mailman-Users mailing list
Mailman-Users@python.org
http://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://www.python.org/cgi-bin/faqw-mm.py
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Security Policy: 
http://www.python.org/cgi-bin/faqw-mm.py?req=showamp;file=faq01.027.htp


Re: [Mailman-Users] Mailman 2.1.10 has been released

2008-04-21 Thread Brad Knowles

Mark Sapiro wrote:


I am happy to announce the release of Mailman 2.1.10.

This is a security and bug fix release and it is highly recommended
that all sites upgrade to this version. Mailman 2.1.10 also adds support
for three new language translations, Galician, Hebrew and Slovak and a
few new features.


Remind me next time that we *MUST* upgrade to the betas and RCs on 
python.org once you've made them available.  The changes made to the code 
which supports skipping unparseable messages means that mmdsr has to be 
changed to suit, otherwise you could wind up with a daily report that is 
800MB in size, depending on how many unparseable messages you might have.


We'll need to coordinate the updates to mmdsr and get the official version 
with all code contributions from all parties out there on the SourceForge page.


--
Brad Knowles [EMAIL PROTECTED]
LinkedIn Profile: http://tinyurl.com/y8kpxu
--
Mailman-Users mailing list
Mailman-Users@python.org
http://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://www.python.org/cgi-bin/faqw-mm.py
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Security Policy: 
http://www.python.org/cgi-bin/faqw-mm.py?req=showamp;file=faq01.027.htp


Re: [Mailman-Users] Mailman 2.1.10 has been released

2008-04-21 Thread Brad Knowles

David Newman wrote:


I presume the usual upgrade instructions apply?

http://www.python.org/cgi-bin/faqw-mm.py?req=showfile=faq04.014.htp


For upgrading python.org, I made the mistake of leaving Mailman running even 
though I had shut down postfix and apache, and it still worked okay.  I'd 
recommend shutting down the web interface first, then Mailman, and then 
finally the MTA.


Then do the upgrade, and restart them in reverse order.

Then watch your log files like a hawk, and test out all your standard 
stupid user tricks to see if anything obvious has been broken.


--
Brad Knowles [EMAIL PROTECTED]
LinkedIn Profile: http://tinyurl.com/y8kpxu
--
Mailman-Users mailing list
Mailman-Users@python.org
http://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://www.python.org/cgi-bin/faqw-mm.py
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Security Policy: 
http://www.python.org/cgi-bin/faqw-mm.py?req=showamp;file=faq01.027.htp


Re: [Mailman-Users] Mailman 2.1.10 has been released

2008-04-21 Thread Barry Warsaw

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On Apr 21, 2008, at 5:28 PM, Brad Knowles wrote:


Mark Sapiro wrote:


I am happy to announce the release of Mailman 2.1.10.


Now running on mail.python.org.  Please let us know if there are any  
problems.


Wow, awesome Brad.  Thanks!

- -Barry

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.8 (Darwin)

iEYEARECAAYFAkgNFi4ACgkQ2YZpQepbvXG4+wCgp+P2SypS4dBTbAdP4LBpShDu
VCoAoKn0Xvqlt0x72zOWgsvlQA1cJLMv
=4M3O
-END PGP SIGNATURE-
--
Mailman-Users mailing list
Mailman-Users@python.org
http://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://www.python.org/cgi-bin/faqw-mm.py
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Security Policy: 
http://www.python.org/cgi-bin/faqw-mm.py?req=showamp;file=faq01.027.htp


Re: [Mailman-Users] Mailman 2.1.10 has been released

2008-04-21 Thread Mark Sapiro
Brad Knowles wrote:

Remind me next time that we *MUST* upgrade to the betas and RCs on 
python.org once you've made them available.  The changes made to the code 
which supports skipping unparseable messages means that mmdsr has to be 
changed to suit, otherwise you could wind up with a daily report that is 
800MB in size, depending on how many unparseable messages you might have.

We'll need to coordinate the updates to mmdsr and get the official version 
with all code contributions from all parties out there on the SourceForge page.


OK, I'll try to remember.

FYI, I've been running all the 2.1.10 beta and rc releases and mmdsr
and haven't seen an issue, but I think in my case Postgrey/MailScanner
must be getting rid of all the unparseable messages before they reach
Mailman.

Note that in addition to the logging change for unparseable messages,
they will now be saved in the shunt queue, so if you have a lot,
you'll have to deal with that too.

-- 
Mark Sapiro [EMAIL PROTECTED]The highway is for gamblers,
San Francisco Bay Area, Californiabetter use your sense - B. Dylan

--
Mailman-Users mailing list
Mailman-Users@python.org
http://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://www.python.org/cgi-bin/faqw-mm.py
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Security Policy: 
http://www.python.org/cgi-bin/faqw-mm.py?req=showamp;file=faq01.027.htp


Re: [Mailman-Users] Mailman 2.1.10 has been released

2008-04-21 Thread Mark Sapiro
David Newman wrote:

I presume the usual upgrade instructions apply?

http://www.python.org/cgi-bin/faqw-mm.py?req=showfile=faq04.014.htp


Those are really somewhat outdated. I probably should have just
replaced them, but I created a new FAQ
http://www.python.org/cgi-bin/faqw-mm.py?req=showfile=faq04.080.htp.

-- 
Mark Sapiro [EMAIL PROTECTED]The highway is for gamblers,
San Francisco Bay Area, Californiabetter use your sense - B. Dylan

--
Mailman-Users mailing list
Mailman-Users@python.org
http://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://www.python.org/cgi-bin/faqw-mm.py
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Security Policy: 
http://www.python.org/cgi-bin/faqw-mm.py?req=showamp;file=faq01.027.htp


Re: [Mailman-Users] Mailman 2.1.10 has been released

2008-04-21 Thread Brad Knowles

Mark Sapiro wrote:


Note that in addition to the logging change for unparseable messages,
they will now be saved in the shunt queue, so if you have a lot,
you'll have to deal with that too.


These are the *.psv files?  Yeah, we've got almost 8000 of them on 
python.org.  Do you have any documentation on what should be done with them?


--
Brad Knowles [EMAIL PROTECTED]
LinkedIn Profile: http://tinyurl.com/y8kpxu
--
Mailman-Users mailing list
Mailman-Users@python.org
http://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://www.python.org/cgi-bin/faqw-mm.py
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Security Policy: 
http://www.python.org/cgi-bin/faqw-mm.py?req=showamp;file=faq01.027.htp


Re: [Mailman-Users] Mailman 2.1.10 has been released

2008-04-21 Thread Mark Sapiro
Brad Knowles wrote:

Mark Sapiro wrote:

 Note that in addition to the logging change for unparseable messages,
 they will now be saved in the shunt queue, so if you have a lot,
 you'll have to deal with that too.

These are the *.psv files?  Yeah, we've got almost 8000 of them on 
python.org.  Do you have any documentation on what should be done with them?


Wow! I never thought there would be anything like this.

Here's the situation. Pre 2.1.9, when Mailman dequeued an incoming
message and then the Python email library couldn't parse the MIME
structure  the message was just lost. There wasn't anything that could
be done other than log the fact. This is not a big deal as the
message's MIME structure was defective and the message was almost
certainly spam.

Beginning in 2.1.9, we implemented the .bak files to back up an in
process message so the message could be recovered if something died
horribly (e.g. power failure) while it was in process. Nothing was
done at that time about the unparseable messages.

I then realized that the unparseable message had an intact .bak file in
the queue, so for 2.1.10, I decided to preserve this file (thus the
.psv in the shunt queue) in case some human wanted to look at it with
bin/dumpdb or whatever. Obviously, if you get 8000+ in a few hours, no
one is going to look at them all or even much of a sample.

You could set up a cron to run every hour or some other interval to
efectively do

  rm $var_prefix/qfiles/shunt/*.psv

The problem with that is there can occasionally be queue entries
preserved for other conditions which are hopefully much rarer, but you
might actually want to look at those.

I think the best solution is to turn off the preservation of
unparseable messages, and add an mm_cfg.py setting to turn it on. I
can work up a patch.

-- 
Mark Sapiro [EMAIL PROTECTED]The highway is for gamblers,
San Francisco Bay Area, Californiabetter use your sense - B. Dylan

--
Mailman-Users mailing list
Mailman-Users@python.org
http://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://www.python.org/cgi-bin/faqw-mm.py
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Security Policy: 
http://www.python.org/cgi-bin/faqw-mm.py?req=showamp;file=faq01.027.htp


Re: [Mailman-Users] Mailman 2.1.10 has been released

2008-04-21 Thread Mark Sapiro

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Mark Sapiro wrote:
|
| I think the best solution is to turn off the preservation of
| unparseable messages, and add an mm_cfg.py setting to turn it on. I
| can work up a patch.
|


A patch is attached. It doesn't turn off preservation by default because
it piggybacks on an existing Defaults.py/mm_cfg.py setting which was
lately used only by bin/update. The Defaults.py setting is

QRUNNER_SAVE_BAD_MESSAGES = Yes

Setting

QRUNNER_SAVE_BAD_MESSAGES = No

in mm_cfg.py will stop preserving the unparseable messages, but certain
other problem qfiles will still be preserved. Additionally, preserved
files will be stored in qfiles/bad and not qfiles/shunt. Finally, if
QRUNNER_SAVE_BAD_MESSAGES = No, the log message will revert to the old
Ignoring unparseable message:.

Brad,

If you could apply this patch (you can apply it directly to the
installation directory, by e.g.

cd /usr/local/mailman
patch -p0  path/to/2.1.10.patch.txt

and set

QRUNNER_SAVE_BAD_MESSAGES = No

in mm_cfg.py and restart Mailman, things should be back more or less the
way they were in 2.1.9.

I have applied the patch to my installation and I'm sure it's good, but
I haven't seen any unparseable messages.

- --
Mark Sapiro [EMAIL PROTECTED]The highway is for gamblers,
San Francisco Bay Area, Californiabetter use your sense - B. Dylan

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.7 (MingW32)

iD8DBQFIDVAhVVuXXpU7hpMRAqHBAKCFODqF84UhBYnRvblS00eX4roxdQCeNOXl
amZX+XRwrdd9RpIE80eOFKM=
=vi+P
-END PGP SIGNATURE-
=== modified file 'Mailman/Queue/Runner.py'
--- Mailman/Queue/Runner.py 2007-05-08 03:16:04 +
+++ Mailman/Queue/Runner.py 2008-04-22 02:02:38 +
@@ -1,4 +1,4 @@
-# Copyright (C) 1998-2007 by the Free Software Foundation, Inc.
+# Copyright (C) 1998-2008 by the Free Software Foundation, Inc.
 #
 # This program is free software; you can redistribute it and/or
 # modify it under the terms of the GNU General Public License
@@ -103,12 +103,18 @@
 # but other problems can occur in message parsing, e.g.
 # ValueError, and exceptions can occur in unpickling too.
 # We don't want the runner to die, so we just log and skip
-# this entry, but preserve it for analysis.
+# this entry, but maybe preserve it for analysis.
 self._log(e)
-syslog('error',
-   'Skipping and preserving unparseable message: %s',
-   filebase)
-self._switchboard.finish(filebase, preserve=True)
+if mm_cfg.QRUNNER_SAVE_BAD_MESSAGES:
+syslog('error',
+   'Skipping and preserving unparseable message: %s',
+   filebase)
+preserve=True
+else:
+syslog('error',
+   'Ignoring unparseable message: %s', filebase)
+preserve=False
+self._switchboard.finish(filebase, preserve=preserve)
 continue
 try:
 self._onefile(msg, msgdata)

=== modified file 'Mailman/Queue/Switchboard.py'
--- Mailman/Queue/Switchboard.py2008-02-14 16:53:52 +
+++ Mailman/Queue/Switchboard.py2008-04-22 02:11:19 +
@@ -169,13 +169,13 @@
 bakfile = os.path.join(self.__whichq, filebase + '.bak')
 try:
 if preserve:
-psvfile = os.path.join(mm_cfg.SHUNTQUEUE_DIR, filebase + 
'.psv')
+psvfile = os.path.join(mm_cfg.BADQUEUE_DIR, filebase + '.psv')
 # Create the directory if it doesn't yet exist.
 # Copied from __init__.
 omask = os.umask(0)   # rwxrws---
 try:
 try:
-os.mkdir(mm_cfg.SHUNTQUEUE_DIR, 0770)
+os.mkdir(mm_cfg.BADQUEUE_DIR, 0770)
 except OSError, e:
 if e.errno  errno.EEXIST: raise
 finally:

--
Mailman-Users mailing list
Mailman-Users@python.org
http://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://www.python.org/cgi-bin/faqw-mm.py
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Security Policy: 
http://www.python.org/cgi-bin/faqw-mm.py?req=showamp;file=faq01.027.htp

Re: [Mailman-Users] Mailman 2.1.10 has been released

2008-04-21 Thread Brad Knowles

On 4/21/08, Mark Sapiro wrote:


 If you could apply this patch (you can apply it directly to the
 installation directory, by e.g.

 cd /usr/local/mailman
 patch -p0  path/to/2.1.10.patch.txt


Patch applied fine, no complaints.


 and set

 QRUNNER_SAVE_BAD_MESSAGES = No


Done.


 in mm_cfg.py and restart Mailman, things should be back more or less the
 way they were in 2.1.9.

 I have applied the patch to my installation and I'm sure it's good, but
 I haven't seen any unparseable messages.


I haven't seen any more unparseable messages in the last few minutes, 
but let's see how things go.


--
Brad Knowles [EMAIL PROTECTED]
LinkedIn Profile: http://tinyurl.com/y8kpxu
--
Mailman-Users mailing list
Mailman-Users@python.org
http://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://www.python.org/cgi-bin/faqw-mm.py
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Security Policy: 
http://www.python.org/cgi-bin/faqw-mm.py?req=showamp;file=faq01.027.htp


Re: [Mailman-Users] Mailman 2.1.10 has been released

2008-04-21 Thread Brad Knowles

On 4/21/08, Brad Knowles wrote:


  I have applied the patch to my installation and I'm sure it's good, but
  I haven't seen any unparseable messages.


 I haven't seen any more unparseable messages in the last few minutes,
 but let's see how things go.


We've now had a couple of unparseable messages since applying the 
patch, and it seems to be working as expected.



Going back to Jun 12 23:48:51 2007, it looks like we've had a total 
of about 378,989 unparseable messages, although we only have just 
over 8000 messages in the mailman/qfiles/shunt and 
mailman/qfiles/shunt.old directories (7759 .psv files, and 312 .pck 
files).


That works out to about 37,900 unparseable messages per month, or 
something like about 125 unparseable messages per day.


--
Brad Knowles [EMAIL PROTECTED]
LinkedIn Profile: http://tinyurl.com/y8kpxu
--
Mailman-Users mailing list
Mailman-Users@python.org
http://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://www.python.org/cgi-bin/faqw-mm.py
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Security Policy: 
http://www.python.org/cgi-bin/faqw-mm.py?req=showamp;file=faq01.027.htp