Re: issue with bogus override

[Maciej Bliziński via maintainers]

On Tue, Jan 22, 2019 at 02:58:43PM +0100, Riccardo Mottola via maintainers 
wrote:
> You are right! sorry didn't notice. Also, the other override ispresent for
> both /usr/local and /usr/share
> 
> I wonder why this did not happen in the old release package! But fixed now.

Maybe if you check the difference between the previosly existing overrides and
the new ones, you'll see what changed. Maybe the files with bad content
changed location?

> I also don't think that the file gets installed twice, but it must be some
> peculiarity of the packaging?

What do you mean by the file getting installed twice? That it occurs twice in
a package manifest? Or that two packages contain/own the same path?

As far as I remember this particular check is about the contents of the file.
It was a common mistake that we would create packages that install in /opt/csw
but mistakenly refer to paths in /usr/local, and then fail. For example, it
could be a program that is supposed to look for the default configuration in
${prefix}/foo/foo.conf but instead looks into hardcoded
/usr/local/foo/foo.conf while the file gets installed as
/opt/csw/foo/foo.conf.

Here's the function (13 lines):
https://sourceforge.net/p/gar/code/HEAD/tree/csw/mgar/gar/v2/lib/python/package_checks.py#l679

Hope this helps understand the issue,
Maciej

Re: issue with bogus override

[Riccardo Mottola via maintainers]

Hi Dago!

Dagobert Michelsen wrote:






If any of the reported errors were false positives, you can override them
pasting the lines below to the GAR recipe.
CHECKPKG_OVERRIDES_CSWgnustep-base += 
file-with-bad-content|/usr/share|root/opt/csw/GNUstep/System/Library/Libraries/gnustep-base/Versions/1.26/Resources/NSTimeZones/README


However, the receipe already contains exactly that line! It was present also in 
the previous versions (just with a different soname)


Nope. The upper overrides /usr/local while the latter warns about /usr/share.
You need to override both.


You are right! sorry didn't notice. Also, the other override ispresent 
for both /usr/local and /usr/share


I wonder why this did not happen in the old release package! But fixed now.

I also don't think that the file gets installed twice, but it must be 
some peculiarity of the packaging?


Riccardo

Re: issue with bogus override

[Dagobert Michelsen via maintainers]

> Am 20.01.2019 um 18:07 schrieb Riccardo Mottola via maintainers 
> :
> 
> Hi!
> 
> 
> I am updating the gnustep base package.
> 
> Little changed, except the new version.
> 
> 
> When I build it, I get this:
> 
> 
>  * File root/opt/csw/GNUstep/System/Library/Libraries/gnustep-
>base/Versions/1.26/Resources/NSTimeZones/README contains bad content:
>'/usr/local'. If it's a legacy file you can't modify, or if you
>investigated the issue and the string does not pose a real issue, you can
>override this error.
> 
> And of course, later,
> 
> If any of the reported errors were false positives, you can override them
> pasting the lines below to the GAR recipe.
> CHECKPKG_OVERRIDES_CSWgnustep-base += 
> file-with-bad-content|/usr/share|root/opt/csw/GNUstep/System/Library/Libraries/gnustep-base/Versions/1.26/Resources/NSTimeZones/README
> 
> 
> However, the receipe already contains exactly that line! It was present also 
> in the previous versions (just with a different soname)

Nope. The upper overrides /usr/local while the latter warns about /usr/share.
You need to override both.


Best regards

  — Dago

> 
> 
> Ideas?
> 
> 
> Thank you, Riccardo
> 

-- 
"You don't become great by trying to be great, you become great by wanting to 
do something,
and then doing it so hard that you become great in the process." - xkcd #896