Re: Problems with latest Cygwin make patch; builds OK but binary segfaults
From: William Sheehan [EMAIL PROTECTED] Date: Tue, 5 Sep 2006 11:03:22 -0700 Thanks for catching this; your patch works perfectly and does not demonstrate any of the problems I was encountering before. Thanks for testing. Paul, I recommend this patch (reproduced below) for inclusion in the development sources. There's one more problem with HAVE_DOS_PATHS: $abspath doesn't support it. I already submitted a patch for that, but it will not DTRT for Cygwin, now that Cygwin supports HAVE_DOS_PATHS. I will rework that patch and resubmit it soon. 2006-08-18 Eli Zaretskii [EMAIL PROTECTED] * config/dospaths.m4 ac_cv_dos_paths: Define to yes on Cygwin as well. * make.h (PATH_SEPARATOR_CHAR): Define only if still undefined. Normally, it is defined in config.h. * configure.in (PATH_SEPARATOR_CHAR): Define to the value of $PATH_SEPARATOR. * job.c (construct_command_argv_internal) [HAVE_DOS_PATHS]: Define sh_chars_sh for Windows platforms that emulate Unix. --- configure.in~0 2006-04-01 12:36:40.0 +0300 +++ configure.in2006-08-18 21:12:32.828125000 +0300 @@ -384,6 +384,8 @@ ;; esac +AC_DEFINE_UNQUOTED(PATH_SEPARATOR_CHAR,'$PATH_SEPARATOR',[Define to the character that separates directories in PATH.]) + # Include the Maintainer's Makefile section, if it's here. MAINT_MAKEFILE=/dev/null --- make.h~02006-02-16 03:54:43.0 +0200 +++ make.h 2006-08-18 21:12:32.859375000 +0300 @@ -347,12 +347,14 @@ #define S_(msg1,msg2,num) ngettext (msg1,msg2,num) /* Handle other OSs. */ -#if defined(HAVE_DOS_PATHS) -# define PATH_SEPARATOR_CHAR ';' -#elif defined(VMS) -# define PATH_SEPARATOR_CHAR ',' -#else -# define PATH_SEPARATOR_CHAR ':' +#ifndef PATH_SEPARATOR_CHAR +# if defined(HAVE_DOS_PATHS) +# define PATH_SEPARATOR_CHAR ';' +# elif defined(VMS) +# define PATH_SEPARATOR_CHAR ',' +# else +# define PATH_SEPARATOR_CHAR ':' +# endif #endif /* This is needed for getcwd() and chdir(). */ --- config/dospaths.m4~02006-03-10 06:20:45.0 +0200 +++ config/dospaths.m4 2006-08-18 21:12:32.859375000 +0300 @@ -22,7 +22,7 @@ AC_CACHE_CHECK([whether system uses MSDOS-style paths], [ac_cv_dos_paths], [ AC_COMPILE_IFELSE([ -#if !defined _WIN32 !defined __WIN32__ !defined __MSDOS__ !defined __EMX__ !defined __MSYS__ +#if !defined _WIN32 !defined __WIN32__ !defined __MSDOS__ !defined __EMX__ !defined __MSYS__ !defined __CYGWIN__ neither MSDOS nor Windows nor OS2 #endif ], --- job.c~0 2006-03-20 07:03:04.0 +0200 +++ job.c 2006-08-19 09:25:07.68750 +0300 @@ -2307,6 +2307,12 @@ construct_command_argv_internal (char *l login, logout, read, readonly, set, shift, switch, test, times, trap, umask, wait, while, 0 }; +# ifdef HAVE_DOS_PATHS + /* This is required if the MSYS/Cygwin ports (which do not define + WINDOWS32) are compiled with HAVE_DOS_PATHS defined, which uses + sh_chars_sh[] directly (see below). */ + static char *sh_chars_sh = sh_chars; +# endif /* HAVE_DOS_PATHS */ #endif register int i; register char *p; ___ Make-w32 mailing list Make-w32@gnu.org http://lists.gnu.org/mailman/listinfo/make-w32
Re: Problems with latest Cygwin make patch; builds OK but binary segfaults
On Tue, Sep 05, 2006 at 09:23:41PM +0300, Eli Zaretskii wrote: From: William Sheehan [EMAIL PROTECTED] Date: Tue, 5 Sep 2006 11:03:22 -0700 Thanks for catching this; your patch works perfectly and does not demonstrate any of the problems I was encountering before. Thanks for testing. Paul, I recommend this patch (reproduced below) for inclusion in the development sources. There's one more problem with HAVE_DOS_PATHS: $abspath doesn't support it. I already submitted a patch for that, but it will not DTRT for Cygwin, now that Cygwin supports HAVE_DOS_PATHS. I will rework that patch and resubmit it soon. We've only had one success report for this so far, and even that seemed to have generated some confusion. Given all of the hoopla on the Cygwin list about this functionality, I'd feel much more comfortable if a few of the complainers there tested this also. I'm not willing to go through this amount of pain very often so I'd like to make sure we got things right the first time. So, I'd prefer holding off until a couple more people try this out. cgf ___ Make-w32 mailing list Make-w32@gnu.org http://lists.gnu.org/mailman/listinfo/make-w32
Re: Problems with latest Cygwin make patch; builds OK but binary segfaults
Date: Tue, 5 Sep 2006 14:29:02 -0400 From: Christopher Faylor [EMAIL PROTECTED] We've only had one success report for this so far, and even that seemed to have generated some confusion. Actually, we had 2 success reports. Given all of the hoopla on the Cygwin list about this functionality, I'd feel much more comfortable if a few of the complainers there tested this also. Me too, but I cannot force any of you to promote the patch on the Cygwin mailing list. You refused to do that, while William Hoffman didn't say no, but didn't post anything, either. I don't think it's reasonable to ask me do more than I already did. ___ Make-w32 mailing list Make-w32@gnu.org http://lists.gnu.org/mailman/listinfo/make-w32
Need Volunteers to test patch for gnu make
I have tested it and it works for me. William Sheehan has also tested it. Can a few more folks give the patch a try? Here is the link to the most recent patch: http://www.mail-archive.com/make-w32@gnu.org/msg01157.html Just get the source for make-3.81 and apply the above patch. You can get make from here: http://ftp.gnu.org/pub/gnu/make/ You will need to rerun autoconf/automake after the patch, as the patch does not include the configure script. Once you build it, run make check to verify that the build is working. Also, please try with any makefiles that you have and need to work with windows paths. Thanks. -Bill ___ Make-w32 mailing list Make-w32@gnu.org http://lists.gnu.org/mailman/listinfo/make-w32
MSYS (not mingw) make 3.80 or 3.81?
Does anyone here know whether there is already a plan to upgrade the MSYS distribution so that the msys make (not mingw-make) is 3.80 or 3.81? If not, is there any documentation how to build msys make at all? The closest I've found is a message on this list from March: http://www.mail-archive.com/make-w32@gnu.org/msg00841.html I tried following these directions, and got as far as linking the final executable, which then failed on missing symbols _open_osfhandle and _beginthreadex and a few others from the CRT. Mozilla would like to upgrade their makefile system to use the $(eval) function made available in make 3.80, but don't want to stop working on the MSYS build system, which is significantly faster than cygwin because of the cost of forking cygwin processes. --BDS ___ Make-w32 mailing list Make-w32@gnu.org http://lists.gnu.org/mailman/listinfo/make-w32
Re: Problems with latest Cygwin make patch; builds OK but binary segfaults
Date: Tue, 05 Sep 2006 15:37:19 -0400 From: William A. Hoffman [EMAIL PROTECTED] I have sent out a new message, and cross posted to this list so all can see it. Thanks. Let's wait for a couple more weeks. ___ Make-w32 mailing list Make-w32@gnu.org http://lists.gnu.org/mailman/listinfo/make-w32
Re: MSYS (not mingw) make 3.80 or 3.81?
Date: Tue, 05 Sep 2006 19:38:07 -0400 From: Benjamin Smedberg [EMAIL PROTECTED] Does anyone here know whether there is already a plan to upgrade the MSYS distribution so that the msys make (not mingw-make) is 3.80 or 3.81? I don't use MSYS and don't participate in MSYS development, so I don't know the answers to these questions. Please wait for Earnie to respond. The current official source distribution of Make 3.81 does not support MSYS at all, as you will see from past discussions on this list. ___ Make-w32 mailing list Make-w32@gnu.org http://lists.gnu.org/mailman/listinfo/make-w32
