[jira] [Commented] (MAPREDUCE-5616) MR Client-AppMaster RPC max retries on socket timeout is too high.
[
https://issues.apache.org/jira/browse/MAPREDUCE-5616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13818169#comment-13818169
]
Chris Nauroth commented on MAPREDUCE-5616:
--
{quote}
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{quote}
Trying to write a test around this timeout condition would likely be very
specific to the environment and risk breaking on other environments.
{quote}
-1 core tests. The following test timeouts occurred in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient:
org.apache.hadoop.mapreduce.v2.TestUberAM
{quote}
This is the timeout that we've seen elsewhere on {{TestUberAM}}. It's
unrelated to this patch.
> MR Client-AppMaster RPC max retries on socket timeout is too high.
> --
>
> Key: MAPREDUCE-5616
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5616
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: client
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Chris Nauroth
>Assignee: Chris Nauroth
> Attachments: MAPREDUCE-5616.1.patch
>
>
> MAPREDUCE-3811 introduced a separate config key for overriding the max
> retries applied to RPC connections from the MapReduce Client to the MapReduce
> Application Master. This was done to make failover from the AM to the
> MapReduce History Server faster in the event that the AM completes while the
> client thinks it's still running. However, the RPC client uses a separate
> setting for socket timeouts, and this one is not overridden. The default for
> this is 45 retries with a 20-second timeout on each retry. This means that
> in environments subject to connection timeout instead of connection refused,
> the client waits 15 minutes for failover.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (MAPREDUCE-5616) MR Client-AppMaster RPC max retries on socket timeout is too high.
[
https://issues.apache.org/jira/browse/MAPREDUCE-5616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13818074#comment-13818074
]
Hadoop QA commented on MAPREDUCE-5616:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12612975/MAPREDUCE-5616.1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The following test timeouts occurred in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient:
org.apache.hadoop.mapreduce.v2.TestUberAM
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4186//testReport/
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4186//console
This message is automatically generated.
> MR Client-AppMaster RPC max retries on socket timeout is too high.
> --
>
> Key: MAPREDUCE-5616
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5616
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: client
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Chris Nauroth
>Assignee: Chris Nauroth
> Attachments: MAPREDUCE-5616.1.patch
>
>
> MAPREDUCE-3811 introduced a separate config key for overriding the max
> retries applied to RPC connections from the MapReduce Client to the MapReduce
> Application Master. This was done to make failover from the AM to the
> MapReduce History Server faster in the event that the AM completes while the
> client thinks it's still running. However, the RPC client uses a separate
> setting for socket timeouts, and this one is not overridden. The default for
> this is 45 retries with a 20-second timeout on each retry. This means that
> in environments subject to connection timeout instead of connection refused,
> the client waits 15 minutes for failover.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
