[jira] [Commented] (MAPREDUCE-6174) Combine common stream code into parent class for InMemoryMapOutput and OnDiskMapOutput.
[
https://issues.apache.org/jira/browse/MAPREDUCE-6174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14546877#comment-14546877
]
Eric Payne commented on MAPREDUCE-6174:
---
Thanks [~jira.shegalov], for your detailed suggestions. One question:
{quote}
- We can remove unused parameters {{reduceId}} and {{mapOutputFile}} from the
{{OnDiskMapOutput}} constructors.
{quote}
In the first constructor for {{OnDiskMapOutput}},
{{mapOutputFile#getInputFileForWrite}} is actually used to get the
{{outputPath}} path for the second constructor.
{{MergeManagerImpl}} appears to be the only place which calls the first
constructor for {{OnDiskMapOutput}}. This call to the
{{OnDiskMapOutputConstructor}} could either
# calculate the {{outputPath}} from within {{MergeManagerImpl}}
# or, since {{MergeManagerImpl}} is the only one calling this constructor and
{{MergeManagerImpl}} is being modified anyway, {{MergeManagerImpl}} could use
the second constructor and the first one could be eliminated.
> Combine common stream code into parent class for InMemoryMapOutput and
> OnDiskMapOutput.
> ---
>
> Key: MAPREDUCE-6174
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6174
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv2
>Affects Versions: 3.0.0, 2.6.0
>Reporter: Eric Payne
>Assignee: Eric Payne
> Labels: BB2015-05-RFC
> Attachments: MAPREDUCE-6174.002.patch, MAPREDUCE-6174.003.patch,
> MAPREDUCE-6174.004.patch, MAPREDUCE-6174.v1.txt
>
>
> Per MAPREDUCE-6166, both InMemoryMapOutput and OnDiskMapOutput will be doing
> similar things with regards to IFile streams.
> In order to make it explicit that InMemoryMapOutput and OnDiskMapOutput are
> different from 3rd-party implementations, this JIRA will make them subclass a
> common class (see
> https://issues.apache.org/jira/browse/MAPREDUCE-6166?focusedCommentId=14223368&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14223368)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-5748) Potential null pointer dereference in ShuffleHandler#Shuffle#messageReceived()
[
https://issues.apache.org/jira/browse/MAPREDUCE-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14546829#comment-14546829
]
Varun Saxena commented on MAPREDUCE-5748:
-
OK [~devaraj.k]..Will check this.
> Potential null pointer dereference in ShuffleHandler#Shuffle#messageReceived()
> --
>
> Key: MAPREDUCE-5748
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5748
> Project: Hadoop Map/Reduce
> Issue Type: Bug
>Affects Versions: 2.7.0
>Reporter: Ted Yu
>Assignee: Varun Saxena
>Priority: Minor
> Labels: BB2015-05-RFC
> Attachments:
> 0001-MAPREDUCE-5748-Potential-null-pointer-deference-in-S.patch,
> MAPREDUCE-5748.02.patch, MAPREDUCE-5748.03.patch
>
>
> Starting around line 510:
> {code}
> ChannelFuture lastMap = null;
> for (String mapId : mapIds) {
> ...
> }
> lastMap.addListener(metrics);
> lastMap.addListener(ChannelFutureListener.CLOSE);
> {code}
> If mapIds is empty, lastMap would remain null, leading to NPE in
> addListener() call.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MAPREDUCE-5748) Potential null pointer dereference in ShuffleHandler#Shuffle#messageReceived()
[
https://issues.apache.org/jira/browse/MAPREDUCE-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Saxena updated MAPREDUCE-5748:
Summary: Potential null pointer dereference in
ShuffleHandler#Shuffle#messageReceived() (was: Potential null pointer
deference in ShuffleHandler#Shuffle#messageReceived())
> Potential null pointer dereference in ShuffleHandler#Shuffle#messageReceived()
> --
>
> Key: MAPREDUCE-5748
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5748
> Project: Hadoop Map/Reduce
> Issue Type: Bug
>Affects Versions: 2.7.0
>Reporter: Ted Yu
>Assignee: Varun Saxena
>Priority: Minor
> Labels: BB2015-05-RFC
> Attachments:
> 0001-MAPREDUCE-5748-Potential-null-pointer-deference-in-S.patch,
> MAPREDUCE-5748.02.patch, MAPREDUCE-5748.03.patch
>
>
> Starting around line 510:
> {code}
> ChannelFuture lastMap = null;
> for (String mapId : mapIds) {
> ...
> }
> lastMap.addListener(metrics);
> lastMap.addListener(ChannelFutureListener.CLOSE);
> {code}
> If mapIds is empty, lastMap would remain null, leading to NPE in
> addListener() call.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
