[jira] [Updated] (MAPREDUCE-7351) CleanupJob during handle of SIGTERM signal

2021-07-01 Thread Shubham Gupta (Jira)


 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-7351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shubham Gupta updated MAPREDUCE-7351:
-
Attachment: (was: mrappcleanuptempfiles.patch)

> CleanupJob during handle of SIGTERM signal
> --
>
> Key: MAPREDUCE-7351
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7351
> Project: Hadoop Map/Reduce
>  Issue Type: Improvement
>  Components: mrv2
>Affects Versions: 3.3.0
>Reporter: Prabhu Joseph
>Assignee: Shubham Gupta
>Priority: Minor
>
> Currently MR CleanupJob happens when the job is either successful or fail. 
> But during kill, it is not handled. This leaves all the temporary folders 
> under the output path.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org



[jira] [Updated] (MAPREDUCE-7351) CleanupJob during handle of SIGTERM signal

2021-07-01 Thread Shubham Gupta (Jira)


 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-7351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shubham Gupta updated MAPREDUCE-7351:
-
   Attachment: MAPREDUCE-7351-001.patch
Fix Version/s: 3.3.0
   Status: Patch Available  (was: Open)

I have uploaded the patch, please have a look!
We will call the "committer.abortJob(jobContext, State.KILLED);" in 
MRAppMasterShutdownHook.
I have tested it by killing the jobs and the _temporary files got cleared up.

> CleanupJob during handle of SIGTERM signal
> --
>
> Key: MAPREDUCE-7351
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7351
> Project: Hadoop Map/Reduce
>  Issue Type: Improvement
>  Components: mrv2
>Affects Versions: 3.3.0
>Reporter: Prabhu Joseph
>Assignee: Shubham Gupta
>Priority: Minor
> Fix For: 3.3.0
>
> Attachments: MAPREDUCE-7351-001.patch
>
>
> Currently MR CleanupJob happens when the job is either successful or fail. 
> But during kill, it is not handled. This leaves all the temporary folders 
> under the output path.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org



[jira] [Commented] (MAPREDUCE-7351) CleanupJob during handle of SIGTERM signal

2021-07-01 Thread Steve Loughran (Jira)


[ 
https://issues.apache.org/jira/browse/MAPREDUCE-7351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372847#comment-17372847
 ] 

Steve Loughran commented on MAPREDUCE-7351:
---

1. Submit it as a github PR
2. we use SLF4J for logging'
thanks

> CleanupJob during handle of SIGTERM signal
> --
>
> Key: MAPREDUCE-7351
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7351
> Project: Hadoop Map/Reduce
>  Issue Type: Improvement
>  Components: mrv2
>Affects Versions: 3.3.0
>Reporter: Prabhu Joseph
>Assignee: Shubham Gupta
>Priority: Minor
> Fix For: 3.3.0
>
> Attachments: MAPREDUCE-7351-001.patch
>
>
> Currently MR CleanupJob happens when the job is either successful or fail. 
> But during kill, it is not handled. This leaves all the temporary folders 
> under the output path.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org



[jira] [Commented] (MAPREDUCE-7351) CleanupJob during handle of SIGTERM signal

2021-07-01 Thread Shubham Gupta (Jira)


[ 
https://issues.apache.org/jira/browse/MAPREDUCE-7351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372962#comment-17372962
 ] 

Shubham Gupta commented on MAPREDUCE-7351:
--

Hi, I tried putting it as log.error, but the log is not coming in the log file, 
mostly logger is also getting closed before this 

> CleanupJob during handle of SIGTERM signal
> --
>
> Key: MAPREDUCE-7351
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7351
> Project: Hadoop Map/Reduce
>  Issue Type: Improvement
>  Components: mrv2
>Affects Versions: 3.3.0
>Reporter: Prabhu Joseph
>Assignee: Shubham Gupta
>Priority: Minor
> Fix For: 3.3.0
>
> Attachments: MAPREDUCE-7351-001.patch
>
>
> Currently MR CleanupJob happens when the job is either successful or fail. 
> But during kill, it is not handled. This leaves all the temporary folders 
> under the output path.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org