[jira] [Commented] (MAPREDUCE-2068) TaskInProgress contains duplicate idWithinJob() / getIdWithinJob() accessors

2011-09-03 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13096720#comment-13096720
 ] 

Hadoop QA commented on MAPREDUCE-2068:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12492910/MAPREDUCE-2068.r3.diff
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 8 new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed unit tests in hadoop-mapreduce-project.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/599//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/599//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-hs.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/599//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-shuffle.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/599//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/599//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/599//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-jobclient.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/599//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/599//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/599//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/599//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-nodemanager.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/599//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/599//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-api.html
Console output: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/599//console

This message is automatically generated.

 TaskInProgress contains duplicate idWithinJob() / getIdWithinJob() accessors
 

 Key: MAPREDUCE-2068
 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2068
 Project: Hadoop Map/Reduce
  Issue Type: Bug
  Components: task
Affects Versions: 0.22.0
Reporter: Greg Roelofs
Assignee: Harsh J
Priority: Minor
 Fix For: 0.23.0

 Attachments: 0.22-MAPREDUCE-2068.r3.diff, 
 0.23-MAPREDUCE-2068.r3.diff, MAPREDUCE-2068.r1.diff, MAPREDUCE-2068.r2.diff, 
 MAPREDUCE-2068.r3.diff


 Both are public, both return partition;, and neither is currently 
 deprecated.
 Main user seems to be JobInProgress, and it mostly uses the get flavor, but 
 it also uses the other one in two places.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (MAPREDUCE-2068) TaskInProgress contains duplicate idWithinJob() / getIdWithinJob() accessors

2011-06-26 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13055189#comment-13055189
 ] 

Hadoop QA commented on MAPREDUCE-2068:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12483874/MAPREDUCE-2068.r1.diff
  against trunk revision 1139400.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

-1 javac.  The patch appears to cause tar ant target to fail.

-1 findbugs.  The patch appears to cause Findbugs (version 1.3.9) to fail.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed these core unit tests:


-1 contrib tests.  The patch failed contrib unit tests.

-1 system test framework.  The patch failed system test framework compile.

Test results: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/424//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/424//console

This message is automatically generated.

 TaskInProgress contains duplicate idWithinJob() / getIdWithinJob() accessors
 

 Key: MAPREDUCE-2068
 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2068
 Project: Hadoop Map/Reduce
  Issue Type: Bug
  Components: task
Affects Versions: 0.22.0
Reporter: Greg Roelofs
Assignee: Harsh J
Priority: Minor
 Fix For: 0.23.0

 Attachments: MAPREDUCE-2068.r1.diff


 Both are public, both return partition;, and neither is currently 
 deprecated.
 Main user seems to be JobInProgress, and it mostly uses the get flavor, but 
 it also uses the other one in two places.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira