[jira] [Commented] (MAPREDUCE-2558) Add queue-level metrics 0.20-security branch
[ https://issues.apache.org/jira/browse/MAPREDUCE-2558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045724#comment-13045724 ] Hadoop QA commented on MAPREDUCE-2558: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481762/MAPREDUCE-2558-testfixes.patch against trunk revision 1133175. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/361//console This message is automatically generated. > Add queue-level metrics 0.20-security branch > > > Key: MAPREDUCE-2558 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-2558 > Project: Hadoop Map/Reduce > Issue Type: New Feature > Components: jobtracker >Affects Versions: 0.20.204.0 >Reporter: Jeffrey Naisbitt >Assignee: Jeffrey Naisbitt > Fix For: 0.20.205.0 > > Attachments: MAPREDUCE-2558-0.20s.patch, > MAPREDUCE-2558-testfixes.patch, queue-metrics-v2.patch, > queue-metrics-v3.patch, queue-metrics.patch > > > We would like to record and present the jobtracker metrics on a per-queue > basis. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2558) Add queue-level metrics 0.20-security branch
[ https://issues.apache.org/jira/browse/MAPREDUCE-2558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043869#comment-13043869 ] Jeffrey Naisbitt commented on MAPREDUCE-2558: - Again, this patch is for 0.20-security, so the test-patch failures from Hudson are not applicable. Additionally, Luke said it looked good to him (by email). > Add queue-level metrics 0.20-security branch > > > Key: MAPREDUCE-2558 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-2558 > Project: Hadoop Map/Reduce > Issue Type: New Feature > Components: jobtracker >Affects Versions: 0.20.204.0 >Reporter: Jeffrey Naisbitt >Assignee: Jeffrey Naisbitt > Fix For: 0.20.205.0 > > Attachments: MAPREDUCE-2558-0.20s.patch, queue-metrics-v2.patch, > queue-metrics-v3.patch, queue-metrics.patch > > > We would like to record and present the jobtracker metrics on a per-queue > basis. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2558) Add queue-level metrics 0.20-security branch
[ https://issues.apache.org/jira/browse/MAPREDUCE-2558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043194#comment-13043194 ] Hadoop QA commented on MAPREDUCE-2558: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481312/MAPREDUCE-2558-0.20s.patch against trunk revision 1130554. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/340//console This message is automatically generated. > Add queue-level metrics 0.20-security branch > > > Key: MAPREDUCE-2558 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-2558 > Project: Hadoop Map/Reduce > Issue Type: New Feature > Components: jobtracker >Affects Versions: 0.20.204.0 >Reporter: Jeffrey Naisbitt >Assignee: Jeffrey Naisbitt > Fix For: 0.20.205.0 > > Attachments: MAPREDUCE-2558-0.20s.patch, queue-metrics-v2.patch, > queue-metrics-v3.patch, queue-metrics.patch > > > We would like to record and present the jobtracker metrics on a per-queue > basis. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2558) Add queue-level metrics 0.20-security branch
[ https://issues.apache.org/jira/browse/MAPREDUCE-2558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043192#comment-13043192 ] Jeffrey Naisbitt commented on MAPREDUCE-2558: - This patch is for the 20-security branch, so here are the results of the manual test-patch run: [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] -1 javadoc. The javadoc tool appears to have generated 1 warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] -1 Eclipse classpath. The patch causes the Eclipse classpath to differ from the contents of the lib directories. [exec] The javadoc and Eclipse classpath failures are pre-existing and unrelated to these changes. > Add queue-level metrics 0.20-security branch > > > Key: MAPREDUCE-2558 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-2558 > Project: Hadoop Map/Reduce > Issue Type: New Feature > Components: jobtracker >Affects Versions: 0.20.204.0 >Reporter: Jeffrey Naisbitt >Assignee: Jeffrey Naisbitt > Fix For: 0.20.205.0 > > Attachments: MAPREDUCE-2558-0.20s.patch, queue-metrics-v2.patch, > queue-metrics-v3.patch, queue-metrics.patch > > > We would like to record and present the jobtracker metrics on a per-queue > basis. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2558) Add queue-level metrics 0.20-security branch
[
https://issues.apache.org/jira/browse/MAPREDUCE-2558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042977#comment-13042977
]
Luke Lu commented on MAPREDUCE-2558:
You can mock concrete classes the same way as long as the class and methods are
not final:
{code}
QueueMetrics metrics = Mockito.mock(QueueMetrics.class);
{code}
> Add queue-level metrics 0.20-security branch
>
>
> Key: MAPREDUCE-2558
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2558
> Project: Hadoop Map/Reduce
> Issue Type: New Feature
> Components: jobtracker
>Affects Versions: 0.20.204.0
>Reporter: Jeffrey Naisbitt
>Assignee: Jeffrey Naisbitt
> Fix For: 0.20.205.0
>
> Attachments: queue-metrics-v2.patch, queue-metrics.patch
>
>
> We would like to record and present the jobtracker metrics on a per-queue
> basis.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2558) Add queue-level metrics 0.20-security branch
[ https://issues.apache.org/jira/browse/MAPREDUCE-2558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042970#comment-13042970 ] Jeffrey Naisbitt commented on MAPREDUCE-2558: - Thanks. That's what I thought. I had originally created the abstract class thinking we may want to create a stub/mock queue metrics class for testing purposes. I'm fine combining the classes and go ahead and do so - unless you think we may need them for testing. > Add queue-level metrics 0.20-security branch > > > Key: MAPREDUCE-2558 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-2558 > Project: Hadoop Map/Reduce > Issue Type: New Feature > Components: jobtracker >Affects Versions: 0.20.204.0 >Reporter: Jeffrey Naisbitt >Assignee: Jeffrey Naisbitt > Fix For: 0.20.205.0 > > Attachments: queue-metrics-v2.patch, queue-metrics.patch > > > We would like to record and present the jobtracker metrics on a per-queue > basis. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2558) Add queue-level metrics 0.20-security branch
[ https://issues.apache.org/jira/browse/MAPREDUCE-2558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042968#comment-13042968 ] Luke Lu commented on MAPREDUCE-2558: Your first guess is what I meant :) i.e., you can combine QueueInstrumentation and QueueMetricsSource and call the resulting class QueueMetrics. The introduction of the QueueInstrumentation abstract class is only necessary when you have different implementations of queue metrics, which we don't (and probably won't) have. > Add queue-level metrics 0.20-security branch > > > Key: MAPREDUCE-2558 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-2558 > Project: Hadoop Map/Reduce > Issue Type: New Feature > Components: jobtracker >Affects Versions: 0.20.204.0 >Reporter: Jeffrey Naisbitt >Assignee: Jeffrey Naisbitt > Fix For: 0.20.205.0 > > Attachments: queue-metrics-v2.patch, queue-metrics.patch > > > We would like to record and present the jobtracker metrics on a per-queue > basis. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2558) Add queue-level metrics 0.20-security branch
[ https://issues.apache.org/jira/browse/MAPREDUCE-2558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042902#comment-13042902 ] Jeffrey Naisbitt commented on MAPREDUCE-2558: - With your first comment about the "queue level instrumentation class configuration", are you just saying that I should combine the QueueInstrumentation and QueueMetricSource classes, or are you just talking about removing the extra functionality for the createInstrumentation and get/setInstrumentationClass in the Queue class? (I'm not sure I understand what you mean there) > Add queue-level metrics 0.20-security branch > > > Key: MAPREDUCE-2558 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-2558 > Project: Hadoop Map/Reduce > Issue Type: New Feature > Components: jobtracker >Affects Versions: 0.20.204.0 >Reporter: Jeffrey Naisbitt >Assignee: Jeffrey Naisbitt > Fix For: 0.20.205.0 > > Attachments: queue-metrics-v2.patch, queue-metrics.patch > > > We would like to record and present the jobtracker metrics on a per-queue > basis. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2558) Add queue-level metrics 0.20-security branch
[
https://issues.apache.org/jira/browse/MAPREDUCE-2558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042846#comment-13042846
]
Luke Lu commented on MAPREDUCE-2558:
Comments on patch v2:
The queue level instrumentation class configuration is not a requirement. If
you don't want to test the mechanism I'd suggest that you remove the related
code (you can still keep the instrumentation methods, it's the abstract class
and class loading stuff that are unnecessary).
Looking up the queue from queue manager for metrics for every metrics update
seems unnecessary as well. You can add a final Queue field in JIP and
initialize it in the JIP ctor.
You need a unique name (which also maps to a MBean name) for every queue
metrics so you don't have naming conflicts when you have multiple queues. An
MBean/jconsole friendly QueueInstrumentation#create would look like this:
{code}
return ms.register("QueueMetrics,q="+ queueName, "Queue metrics",
new QueueMetricsSource(queueName, conf));
{code}
> Add queue-level metrics 0.20-security branch
>
>
> Key: MAPREDUCE-2558
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2558
> Project: Hadoop Map/Reduce
> Issue Type: New Feature
> Components: jobtracker
>Affects Versions: 0.20.204.0
>Reporter: Jeffrey Naisbitt
>Assignee: Jeffrey Naisbitt
> Fix For: 0.20.205.0
>
> Attachments: queue-metrics-v2.patch, queue-metrics.patch
>
>
> We would like to record and present the jobtracker metrics on a per-queue
> basis.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
