[jira] [Commented] (MAPREDUCE-3336) com.google.inject.internal.Preconditions not public api - shouldn't be using it

2011-11-10 Thread Hudson (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147650#comment-13147650
 ] 

Hudson commented on MAPREDUCE-3336:
---

Integrated in Hadoop-Hdfs-trunk #859 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/859/])
MAPREDUCE-3336. Replaced guice internal.Preconditions api usage with the 
public Preconditions API. Contributed by Thomas Graves.

vinodkv : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1199714
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java


> com.google.inject.internal.Preconditions not public api - shouldn't be using 
> it
> ---
>
> Key: MAPREDUCE-3336
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3336
> Project: Hadoop Map/Reduce
>  Issue Type: Bug
>  Components: mrv2
>Affects Versions: 0.23.0
>Reporter: Thomas Graves
>Assignee: Thomas Graves
>Priority: Critical
> Fix For: 0.23.1
>
> Attachments: MAPREDUCE-3336.patch
>
>
> com.google.inject.internal.Preconditions does not exist in guice 3.0 and from 
> in guice 2.0 it was an internal api and shouldn't have been used.   We should 
> use com.google.common.base.Preconditions instead.
> This is currently being used in 
> hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (MAPREDUCE-3336) com.google.inject.internal.Preconditions not public api - shouldn't be using it

2011-11-10 Thread Hudson (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147645#comment-13147645
 ] 

Hudson commented on MAPREDUCE-3336:
---

Integrated in Hadoop-Hdfs-0.23-Build #72 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/72/])
MAPREDUCE-3336. Replaced guice internal.Preconditions api usage with the 
public Preconditions API. Contributed by Thomas Graves.
svn merge -c r1199714 --ignore-ancestry ../../trunk/

vinodkv : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1199716
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* 
/hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java


> com.google.inject.internal.Preconditions not public api - shouldn't be using 
> it
> ---
>
> Key: MAPREDUCE-3336
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3336
> Project: Hadoop Map/Reduce
>  Issue Type: Bug
>  Components: mrv2
>Affects Versions: 0.23.0
>Reporter: Thomas Graves
>Assignee: Thomas Graves
>Priority: Critical
> Fix For: 0.23.1
>
> Attachments: MAPREDUCE-3336.patch
>
>
> com.google.inject.internal.Preconditions does not exist in guice 3.0 and from 
> in guice 2.0 it was an internal api and shouldn't have been used.   We should 
> use com.google.common.base.Preconditions instead.
> This is currently being used in 
> hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (MAPREDUCE-3336) com.google.inject.internal.Preconditions not public api - shouldn't be using it

2011-11-09 Thread Hudson (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147030#comment-13147030
 ] 

Hudson commented on MAPREDUCE-3336:
---

Integrated in Hadoop-Mapreduce-0.23-Build #86 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/86/])
MAPREDUCE-3336. Replaced guice internal.Preconditions api usage with the 
public Preconditions API. Contributed by Thomas Graves.
svn merge -c r1199714 --ignore-ancestry ../../trunk/

vinodkv : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1199716
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* 
/hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java


> com.google.inject.internal.Preconditions not public api - shouldn't be using 
> it
> ---
>
> Key: MAPREDUCE-3336
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3336
> Project: Hadoop Map/Reduce
>  Issue Type: Bug
>  Components: mrv2
>Affects Versions: 0.23.0
>Reporter: Thomas Graves
>Assignee: Thomas Graves
>Priority: Critical
> Fix For: 0.23.1
>
> Attachments: MAPREDUCE-3336.patch
>
>
> com.google.inject.internal.Preconditions does not exist in guice 3.0 and from 
> in guice 2.0 it was an internal api and shouldn't have been used.   We should 
> use com.google.common.base.Preconditions instead.
> This is currently being used in 
> hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (MAPREDUCE-3336) com.google.inject.internal.Preconditions not public api - shouldn't be using it

2011-11-09 Thread Hudson (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147034#comment-13147034
 ] 

Hudson commented on MAPREDUCE-3336:
---

Integrated in Hadoop-Mapreduce-trunk #892 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/892/])
MAPREDUCE-3336. Replaced guice internal.Preconditions api usage with the 
public Preconditions API. Contributed by Thomas Graves.

vinodkv : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1199714
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java


> com.google.inject.internal.Preconditions not public api - shouldn't be using 
> it
> ---
>
> Key: MAPREDUCE-3336
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3336
> Project: Hadoop Map/Reduce
>  Issue Type: Bug
>  Components: mrv2
>Affects Versions: 0.23.0
>Reporter: Thomas Graves
>Assignee: Thomas Graves
>Priority: Critical
> Fix For: 0.23.1
>
> Attachments: MAPREDUCE-3336.patch
>
>
> com.google.inject.internal.Preconditions does not exist in guice 3.0 and from 
> in guice 2.0 it was an internal api and shouldn't have been used.   We should 
> use com.google.common.base.Preconditions instead.
> This is currently being used in 
> hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (MAPREDUCE-3336) com.google.inject.internal.Preconditions not public api - shouldn't be using it

2011-11-09 Thread Hudson (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147024#comment-13147024
 ] 

Hudson commented on MAPREDUCE-3336:
---

Integrated in Hadoop-Mapreduce-0.23-Commit #171 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/171/])
MAPREDUCE-3336. Replaced guice internal.Preconditions api usage with the 
public Preconditions API. Contributed by Thomas Graves.
svn merge -c r1199714 --ignore-ancestry ../../trunk/

vinodkv : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1199716
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* 
/hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java


> com.google.inject.internal.Preconditions not public api - shouldn't be using 
> it
> ---
>
> Key: MAPREDUCE-3336
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3336
> Project: Hadoop Map/Reduce
>  Issue Type: Bug
>  Components: mrv2
>Affects Versions: 0.23.0
>Reporter: Thomas Graves
>Assignee: Thomas Graves
>Priority: Critical
> Fix For: 0.23.1
>
> Attachments: MAPREDUCE-3336.patch
>
>
> com.google.inject.internal.Preconditions does not exist in guice 3.0 and from 
> in guice 2.0 it was an internal api and shouldn't have been used.   We should 
> use com.google.common.base.Preconditions instead.
> This is currently being used in 
> hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (MAPREDUCE-3336) com.google.inject.internal.Preconditions not public api - shouldn't be using it

2011-11-09 Thread Hudson (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147019#comment-13147019
 ] 

Hudson commented on MAPREDUCE-3336:
---

Integrated in Hadoop-Mapreduce-trunk-Commit #1282 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1282/])
MAPREDUCE-3336. Replaced guice internal.Preconditions api usage with the 
public Preconditions API. Contributed by Thomas Graves.

vinodkv : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1199714
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java


> com.google.inject.internal.Preconditions not public api - shouldn't be using 
> it
> ---
>
> Key: MAPREDUCE-3336
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3336
> Project: Hadoop Map/Reduce
>  Issue Type: Bug
>  Components: mrv2
>Affects Versions: 0.23.0
>Reporter: Thomas Graves
>Assignee: Thomas Graves
>Priority: Critical
> Fix For: 0.23.1
>
> Attachments: MAPREDUCE-3336.patch
>
>
> com.google.inject.internal.Preconditions does not exist in guice 3.0 and from 
> in guice 2.0 it was an internal api and shouldn't have been used.   We should 
> use com.google.common.base.Preconditions instead.
> This is currently being used in 
> hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (MAPREDUCE-3336) com.google.inject.internal.Preconditions not public api - shouldn't be using it

2011-11-09 Thread Hudson (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147011#comment-13147011
 ] 

Hudson commented on MAPREDUCE-3336:
---

Integrated in Hadoop-Common-0.23-Commit #160 (See 
[https://builds.apache.org/job/Hadoop-Common-0.23-Commit/160/])
MAPREDUCE-3336. Replaced guice internal.Preconditions api usage with the 
public Preconditions API. Contributed by Thomas Graves.
svn merge -c r1199714 --ignore-ancestry ../../trunk/

vinodkv : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1199716
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* 
/hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java


> com.google.inject.internal.Preconditions not public api - shouldn't be using 
> it
> ---
>
> Key: MAPREDUCE-3336
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3336
> Project: Hadoop Map/Reduce
>  Issue Type: Bug
>  Components: mrv2
>Affects Versions: 0.23.0
>Reporter: Thomas Graves
>Assignee: Thomas Graves
>Priority: Critical
> Fix For: 0.23.1
>
> Attachments: MAPREDUCE-3336.patch
>
>
> com.google.inject.internal.Preconditions does not exist in guice 3.0 and from 
> in guice 2.0 it was an internal api and shouldn't have been used.   We should 
> use com.google.common.base.Preconditions instead.
> This is currently being used in 
> hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (MAPREDUCE-3336) com.google.inject.internal.Preconditions not public api - shouldn't be using it

2011-11-09 Thread Hudson (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147010#comment-13147010
 ] 

Hudson commented on MAPREDUCE-3336:
---

Integrated in Hadoop-Hdfs-0.23-Commit #159 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/159/])
MAPREDUCE-3336. Replaced guice internal.Preconditions api usage with the 
public Preconditions API. Contributed by Thomas Graves.
svn merge -c r1199714 --ignore-ancestry ../../trunk/

vinodkv : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1199716
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* 
/hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java


> com.google.inject.internal.Preconditions not public api - shouldn't be using 
> it
> ---
>
> Key: MAPREDUCE-3336
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3336
> Project: Hadoop Map/Reduce
>  Issue Type: Bug
>  Components: mrv2
>Affects Versions: 0.23.0
>Reporter: Thomas Graves
>Assignee: Thomas Graves
>Priority: Critical
> Fix For: 0.23.1
>
> Attachments: MAPREDUCE-3336.patch
>
>
> com.google.inject.internal.Preconditions does not exist in guice 3.0 and from 
> in guice 2.0 it was an internal api and shouldn't have been used.   We should 
> use com.google.common.base.Preconditions instead.
> This is currently being used in 
> hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (MAPREDUCE-3336) com.google.inject.internal.Preconditions not public api - shouldn't be using it

2011-11-09 Thread Hudson (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146997#comment-13146997
 ] 

Hudson commented on MAPREDUCE-3336:
---

Integrated in Hadoop-Common-trunk-Commit #1260 (See 
[https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1260/])
MAPREDUCE-3336. Replaced guice internal.Preconditions api usage with the 
public Preconditions API. Contributed by Thomas Graves.

vinodkv : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1199714
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java


> com.google.inject.internal.Preconditions not public api - shouldn't be using 
> it
> ---
>
> Key: MAPREDUCE-3336
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3336
> Project: Hadoop Map/Reduce
>  Issue Type: Bug
>  Components: mrv2
>Affects Versions: 0.23.0
>Reporter: Thomas Graves
>Assignee: Thomas Graves
>Priority: Critical
> Fix For: 0.23.1
>
> Attachments: MAPREDUCE-3336.patch
>
>
> com.google.inject.internal.Preconditions does not exist in guice 3.0 and from 
> in guice 2.0 it was an internal api and shouldn't have been used.   We should 
> use com.google.common.base.Preconditions instead.
> This is currently being used in 
> hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (MAPREDUCE-3336) com.google.inject.internal.Preconditions not public api - shouldn't be using it

2011-11-09 Thread Hudson (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146995#comment-13146995
 ] 

Hudson commented on MAPREDUCE-3336:
---

Integrated in Hadoop-Hdfs-trunk-Commit #1334 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1334/])
MAPREDUCE-3336. Replaced guice internal.Preconditions api usage with the 
public Preconditions API. Contributed by Thomas Graves.

vinodkv : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1199714
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java


> com.google.inject.internal.Preconditions not public api - shouldn't be using 
> it
> ---
>
> Key: MAPREDUCE-3336
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3336
> Project: Hadoop Map/Reduce
>  Issue Type: Bug
>  Components: mrv2
>Affects Versions: 0.23.0
>Reporter: Thomas Graves
>Assignee: Thomas Graves
>Priority: Critical
> Fix For: 0.23.1
>
> Attachments: MAPREDUCE-3336.patch
>
>
> com.google.inject.internal.Preconditions does not exist in guice 3.0 and from 
> in guice 2.0 it was an internal api and shouldn't have been used.   We should 
> use com.google.common.base.Preconditions instead.
> This is currently being used in 
> hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (MAPREDUCE-3336) com.google.inject.internal.Preconditions not public api - shouldn't be using it

2011-11-02 Thread Hadoop QA (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142697#comment-13142697
 ] 

Hadoop QA commented on MAPREDUCE-3336:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12502044/MAPREDUCE-3336.patch
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed unit tests in .

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1244//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1244//console

This message is automatically generated.

> com.google.inject.internal.Preconditions not public api - shouldn't be using 
> it
> ---
>
> Key: MAPREDUCE-3336
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3336
> Project: Hadoop Map/Reduce
>  Issue Type: Bug
>  Components: mrv2
>Affects Versions: 0.23.0
>Reporter: Thomas Graves
>Assignee: Thomas Graves
>Priority: Critical
> Attachments: MAPREDUCE-3336.patch
>
>
> com.google.inject.internal.Preconditions does not exist in guice 3.0 and from 
> in guice 2.0 it was an internal api and shouldn't have been used.   We should 
> use com.google.common.base.Preconditions instead.
> This is currently being used in 
> hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira