[jira] [Commented] (MAPREDUCE-3796) Scheduler.normalizeRequest does not account for allocation requests that exceed maximumAllocation limits
[ https://issues.apache.org/jira/browse/MAPREDUCE-3796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13211656#comment-13211656 ] Vinod Kumar Vavilapalli commented on MAPREDUCE-3796: Looked at the patch briefly. Thinking that moving the normalization of the requests out of the scheduler into the 'leaf-services' like ClientRMService and ApplicationMasterService simplifies things a lot. It seems more natural to me too, as we can recover from or report errors sooner than later. What do you say? Scheduler.normalizeRequest does not account for allocation requests that exceed maximumAllocation limits - Key: MAPREDUCE-3796 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3796 Project: Hadoop Map/Reduce Issue Type: Bug Components: mrv2 Affects Versions: 0.23.0, 0.24.0 Reporter: Hitesh Shah Assignee: Hitesh Shah Priority: Critical Attachments: MR-3796.1.patch, MR-3796.2.patch, MR-3796.wip.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3796) Scheduler.normalizeRequest does not account for allocation requests that exceed maximumAllocation limits
[ https://issues.apache.org/jira/browse/MAPREDUCE-3796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13211693#comment-13211693 ] Hitesh Shah commented on MAPREDUCE-3796: @Vinod, true - had thought of that but for that to be done, I think we need to move the min/max allocation configuration to be a global RM-level setting and not a scheduler-specific configuration option. Scheduler.normalizeRequest does not account for allocation requests that exceed maximumAllocation limits - Key: MAPREDUCE-3796 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3796 Project: Hadoop Map/Reduce Issue Type: Bug Components: mrv2 Affects Versions: 0.23.0, 0.24.0 Reporter: Hitesh Shah Assignee: Hitesh Shah Priority: Critical Attachments: MR-3796.1.patch, MR-3796.2.patch, MR-3796.wip.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3796) Scheduler.normalizeRequest does not account for allocation requests that exceed maximumAllocation limits
[ https://issues.apache.org/jira/browse/MAPREDUCE-3796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13209236#comment-13209236 ] Hadoop QA commented on MAPREDUCE-3796: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12514773/MR-3796.2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1879//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1879//console This message is automatically generated. Scheduler.normalizeRequest does not account for allocation requests that exceed maximumAllocation limits - Key: MAPREDUCE-3796 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3796 Project: Hadoop Map/Reduce Issue Type: Bug Components: mrv2 Affects Versions: 0.23.0, 0.24.0 Reporter: Hitesh Shah Assignee: Hitesh Shah Priority: Critical Attachments: MR-3796.1.patch, MR-3796.2.patch, MR-3796.wip.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3796) Scheduler.normalizeRequest does not account for allocation requests that exceed maximumAllocation limits
[ https://issues.apache.org/jira/browse/MAPREDUCE-3796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13200250#comment-13200250 ] Hadoop QA commented on MAPREDUCE-3796: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12513209/MR-3796.1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. -1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1772//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1772//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1772//console This message is automatically generated. Scheduler.normalizeRequest does not account for allocation requests that exceed maximumAllocation limits - Key: MAPREDUCE-3796 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3796 Project: Hadoop Map/Reduce Issue Type: Bug Components: mrv2 Affects Versions: 0.23.0, 0.24.0 Reporter: Hitesh Shah Assignee: Hitesh Shah Priority: Critical Attachments: MR-3796.1.patch, MR-3796.wip.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3796) Scheduler.normalizeRequest does not account for allocation requests that exceed maximumAllocation limits
[ https://issues.apache.org/jira/browse/MAPREDUCE-3796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13199513#comment-13199513 ] Hitesh Shah commented on MAPREDUCE-3796: Ignore the patch. Still need to work some stuff out with respect to the state machine changes. Scheduler.normalizeRequest does not account for allocation requests that exceed maximumAllocation limits - Key: MAPREDUCE-3796 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3796 Project: Hadoop Map/Reduce Issue Type: Bug Components: mrv2 Affects Versions: 0.23.0, 0.24.0 Reporter: Hitesh Shah Assignee: Hitesh Shah Priority: Critical Attachments: MR-3796.wip.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
