[jira] [Commented] (MAPREDUCE-4173) Clean up hadoop-mapreduce-client-app
[ https://issues.apache.org/jira/browse/MAPREDUCE-4173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13265561#comment-13265561 ] Tom White commented on MAPREDUCE-4173: -- Looks good to me. There's a new findbugs warning that you should address though. Clean up hadoop-mapreduce-client-app Key: MAPREDUCE-4173 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4173 Project: Hadoop Map/Reduce Issue Type: Sub-task Affects Versions: trunk Reporter: Harsh J Assignee: Harsh J Priority: Minor Attachments: 0001-MR-Client-App-Cleanup.patch, 0001-MR-Client-App-Cleanup.patch Clean up a bunch of existing javac warnings in hadoop-mapreduce-client-app module. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4173) Clean up hadoop-mapreduce-client-app
[ https://issues.apache.org/jira/browse/MAPREDUCE-4173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259285#comment-13259285 ] Hadoop QA commented on MAPREDUCE-4173: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12523717/0001-MR-Client-App-Cleanup.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified test files. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.yarn.server.TestContainerManagerSecurity org.apache.hadoop.yarn.server.resourcemanager.security.TestApplicationTokens org.apache.hadoop.yarn.server.resourcemanager.TestClientRMService org.apache.hadoop.yarn.server.resourcemanager.resourcetracker.TestNMExpiry org.apache.hadoop.yarn.server.resourcemanager.TestAMAuthorization org.apache.hadoop.yarn.server.resourcemanager.TestApplicationACLs org.apache.hadoop.mapred.TestClientRedirect org.apache.hadoop.mapreduce.security.TestJHSSecurity +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2287//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2287//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2287//console This message is automatically generated. Clean up hadoop-mapreduce-client-app Key: MAPREDUCE-4173 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4173 Project: Hadoop Map/Reduce Issue Type: Sub-task Affects Versions: trunk Reporter: Harsh J Assignee: Harsh J Priority: Minor Attachments: 0001-MR-Client-App-Cleanup.patch, 0001-MR-Client-App-Cleanup.patch Clean up a bunch of existing javac warnings in hadoop-mapreduce-client-app module. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4173) Clean up hadoop-mapreduce-client-app
[ https://issues.apache.org/jira/browse/MAPREDUCE-4173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259290#comment-13259290 ] Harsh J commented on MAPREDUCE-4173: These failing tests are unrelated to the changes introduced by the patch. Clean up hadoop-mapreduce-client-app Key: MAPREDUCE-4173 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4173 Project: Hadoop Map/Reduce Issue Type: Sub-task Affects Versions: trunk Reporter: Harsh J Assignee: Harsh J Priority: Minor Attachments: 0001-MR-Client-App-Cleanup.patch, 0001-MR-Client-App-Cleanup.patch Clean up a bunch of existing javac warnings in hadoop-mapreduce-client-app module. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
