[jira] [Commented] (MAPREDUCE-4181) Clean up yarn-api

2012-04-30 Thread Tsz Wo (Nicholas), SZE (JIRA) 

[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265591#comment-13265591
 ] 

Tsz Wo (Nicholas), SZE commented on MAPREDUCE-4181:
---

Could you revise the summary and description for reflecting the actual changes? 
 "Clean up yarn-api" sounds like changing the Yarn APIs.  How about "Remove the 
unused maybeInitBuilder() method from various classes in 
hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-api/"?

> Clean up yarn-api
> -
>
> Key: MAPREDUCE-4181
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4181
> Project: Hadoop Map/Reduce
>  Issue Type: Sub-task
>  Components: build
>Affects Versions: trunk
>Reporter: Harsh J
>Assignee: Harsh J
>Priority: Minor
> Attachments: 0009-YARN-API-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-yarn-api module.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-4181) Clean up yarn-api

2012-04-30 Thread Tom White (JIRA) 

[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265570#comment-13265570
 ] 

Tom White commented on MAPREDUCE-4181:
--

+1

> Clean up yarn-api
> -
>
> Key: MAPREDUCE-4181
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4181
> Project: Hadoop Map/Reduce
>  Issue Type: Sub-task
>  Components: build
>Affects Versions: trunk
>Reporter: Harsh J
>Assignee: Harsh J
>Priority: Minor
> Attachments: 0009-YARN-API-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-yarn-api module.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-4181) Clean up yarn-api

2012-04-22 Thread Harsh J (JIRA) 

[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259373#comment-13259373
 ] 

Harsh J commented on MAPREDUCE-4181:


The failure of {{org.apache.hadoop.yarn.server.TestContainerManagerSecurity}} 
is unrelated to this patch. Its been failing for a while across all builds.

> Clean up yarn-api
> -
>
> Key: MAPREDUCE-4181
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4181
> Project: Hadoop Map/Reduce
>  Issue Type: Sub-task
>  Components: build
>Affects Versions: trunk
>Reporter: Harsh J
>Assignee: Harsh J
>Priority: Minor
> Attachments: 0009-YARN-API-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-yarn-api module.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-4181) Clean up yarn-api

2012-04-22 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259214#comment-13259214
 ] 

Hadoop QA commented on MAPREDUCE-4181:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12523702/0009-YARN-API-Cleanup.patch
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 eclipse:eclipse.  The patch built with eclipse:eclipse.

+1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed these unit tests:
  org.apache.hadoop.yarn.server.TestContainerManagerSecurity

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2282//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2282//console

This message is automatically generated.

> Clean up yarn-api
> -
>
> Key: MAPREDUCE-4181
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4181
> Project: Hadoop Map/Reduce
>  Issue Type: Sub-task
>  Components: build
>Affects Versions: trunk
>Reporter: Harsh J
>Assignee: Harsh J
>Priority: Minor
> Attachments: 0009-YARN-API-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-yarn-api module.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira