[jira] [Commented] (MAPREDUCE-4216) Make MultipleOutputs generic to support non-file output formats
[
https://issues.apache.org/jira/browse/MAPREDUCE-4216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525147#comment-14525147
]
Hadoop QA commented on MAPREDUCE-4216:
--
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 38s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 29s | There were no new javac warning
messages. |
| {color:red}-1{color} | javadoc | 9m 36s | The applied patch generated 1
additional warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 0m 46s | The applied patch generated 3
new checkstyle issues (total was 67, now 70). |
| {color:red}-1{color} | whitespace | 0m 0s | The patch has 4 line(s) that
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install | 1m 36s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 14s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | mapreduce tests | 1m 34s | Tests passed in
hadoop-mapreduce-client-core. |
| | | 37m 52s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12525460/MAPREDUCE-4216.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / f1a152c |
| javadoc |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5585/artifact/patchprocess/diffJavadocWarnings.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5585/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-core.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5585/artifact/patchprocess/whitespace.txt
|
| hadoop-mapreduce-client-core test log |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5585/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5585/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5585/console |
This message was automatically generated.
> Make MultipleOutputs generic to support non-file output formats
> ---
>
> Key: MAPREDUCE-4216
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4216
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv2
>Affects Versions: 1.0.2
>Reporter: Robbie Strickland
> Labels: Output
> Attachments: MAPREDUCE-4216.patch
>
>
> The current MultipleOutputs implementation is tied to FileOutputFormat in
> such a way that it is not extensible to other types of output. It should be
> made more generic, such as with an interface that can be implemented for
> different outputs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-4216) Make MultipleOutputs generic to support non-file output formats
[
https://issues.apache.org/jira/browse/MAPREDUCE-4216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525072#comment-14525072
]
Hadoop QA commented on MAPREDUCE-4216:
--
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 35s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 29s | There were no new javac warning
messages. |
| {color:red}-1{color} | javadoc | 9m 33s | The applied patch generated 1
additional warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 0m 46s | The applied patch generated 3
new checkstyle issues (total was 67, now 70). |
| {color:red}-1{color} | whitespace | 0m 0s | The patch has 4 line(s) that
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install | 1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 15s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | mapreduce tests | 1m 35s | Tests passed in
hadoop-mapreduce-client-core. |
| | | 37m 46s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12525460/MAPREDUCE-4216.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / f1a152c |
| javadoc |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5581/artifact/patchprocess/diffJavadocWarnings.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5581/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-core.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5581/artifact/patchprocess/whitespace.txt
|
| hadoop-mapreduce-client-core test log |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5581/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5581/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5581/console |
This message was automatically generated.
> Make MultipleOutputs generic to support non-file output formats
> ---
>
> Key: MAPREDUCE-4216
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4216
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv2
>Affects Versions: 1.0.2
>Reporter: Robbie Strickland
> Labels: Output
> Attachments: MAPREDUCE-4216.patch
>
>
> The current MultipleOutputs implementation is tied to FileOutputFormat in
> such a way that it is not extensible to other types of output. It should be
> made more generic, such as with an interface that can be implemented for
> different outputs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-4216) Make MultipleOutputs generic to support non-file output formats
[ https://issues.apache.org/jira/browse/MAPREDUCE-4216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13288539#comment-13288539 ] Robbie Strickland commented on MAPREDUCE-4216: -- I guess we don't have to, but if it isn't located somewhere generic there's no guarantee (to implementers of other output formats) that the version in FOF won't change. And if the FOF version is the one being called in MultipleOutputs, then it doesn't really matter what other classes implement. My motivation here is that I have submitted a patch against Cassandra to support MultipleOutputs (see the related issue), and in order to do this I have to duplicate the config key string. I think it would be cleaner to have a way to access this property through a method call rather than duplicating the key. > Make MultipleOutputs generic to support non-file output formats > --- > > Key: MAPREDUCE-4216 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4216 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: mrv2 >Affects Versions: 1.0.2 >Reporter: Robbie Strickland > Labels: Output > Attachments: MAPREDUCE-4216.patch > > > The current MultipleOutputs implementation is tied to FileOutputFormat in > such a way that it is not extensible to other types of output. It should be > made more generic, such as with an interface that can be implemented for > different outputs. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4216) Make MultipleOutputs generic to support non-file output formats
[ https://issues.apache.org/jira/browse/MAPREDUCE-4216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285331#comment-13285331 ] Harsh J commented on MAPREDUCE-4216: Hey Robbie, thanks for the patch and the report! Do we _have_ to move static methods into the abstract OutputFormat class? Why can't it remain in the FileOutputFormat class itself? I agree MultipleOutputs should allow non FOF-extending classes (though it was primarily written for file classes), however why doesn't your first change hunk alone suffice for it? > Make MultipleOutputs generic to support non-file output formats > --- > > Key: MAPREDUCE-4216 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4216 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: mrv2 >Affects Versions: 1.0.2 >Reporter: Robbie Strickland > Labels: Output > Attachments: MAPREDUCE-4216.patch > > > The current MultipleOutputs implementation is tied to FileOutputFormat in > such a way that it is not extensible to other types of output. It should be > made more generic, such as with an interface that can be implemented for > different outputs. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4216) Make MultipleOutputs generic to support non-file output formats
[ https://issues.apache.org/jira/browse/MAPREDUCE-4216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267542#comment-13267542 ] Hadoop QA commented on MAPREDUCE-4216: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525460/MAPREDUCE-4216.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated 3 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2353//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2353//console This message is automatically generated. > Make MultipleOutputs generic to support non-file output formats > --- > > Key: MAPREDUCE-4216 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4216 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: mrv2 >Affects Versions: 1.0.2 >Reporter: Robbie Strickland > Labels: Output > Attachments: MAPREDUCE-4216.patch > > > The current MultipleOutputs implementation is tied to FileOutputFormat in > such a way that it is not extensible to other types of output. It should be > made more generic, such as with an interface that can be implemented for > different outputs. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
