[jira] [Commented] (MAPREDUCE-4221) Remove jquery theming support
[ https://issues.apache.org/jira/browse/MAPREDUCE-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13496366#comment-13496366 ] Luke Lu commented on MAPREDUCE-4221: Themeability was mostly there to ensure that we have consistent css usage and keep presentation out of semantic markups. BTW, themes _should_ work even better with web app proxy, as your preferred theme works for any AMs by default. I'm not against removing the extra theme assets but the default theme. We should keep the consistent css selector usage regardless though. Remove jquery theming support - Key: MAPREDUCE-4221 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4221 Project: Hadoop Map/Reduce Issue Type: Improvement Components: webapps Affects Versions: 2.0.0-alpha Reporter: Todd Lipcon Labels: newbie Attachments: MAPREDUCE-4221.patch, MAPREDUCE-4221.patch As of today we have 9.4MB of JQuery themes in our code tree. In addition to being a waste of space, it's a highly questionable feature. I've never heard anyone complain that the Hadoop interface isn't themeable enough, and there's far more value in consistency across installations than there is in themeability. Let's rip it out. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4221) Remove jquery theming support
[ https://issues.apache.org/jira/browse/MAPREDUCE-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13496432#comment-13496432 ] Robert Joseph Evans commented on MAPREDUCE-4221: I agree that we want to keep the pages compatible with the jquery css themes. Remove jquery theming support - Key: MAPREDUCE-4221 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4221 Project: Hadoop Map/Reduce Issue Type: Improvement Components: webapps Affects Versions: 2.0.0-alpha Reporter: Todd Lipcon Labels: newbie Attachments: MAPREDUCE-4221.patch, MAPREDUCE-4221.patch As of today we have 9.4MB of JQuery themes in our code tree. In addition to being a waste of space, it's a highly questionable feature. I've never heard anyone complain that the Hadoop interface isn't themeable enough, and there's far more value in consistency across installations than there is in themeability. Let's rip it out. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4221) Remove jquery theming support
[ https://issues.apache.org/jira/browse/MAPREDUCE-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13496437#comment-13496437 ] Robert Joseph Evans commented on MAPREDUCE-4221: The above patches work for trunk and branch-2. I will try to come up with a version for 0.23. It looks like it should just be a minor merge conflict. The fair share scheduler page is not there in 0.23 Remove jquery theming support - Key: MAPREDUCE-4221 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4221 Project: Hadoop Map/Reduce Issue Type: Improvement Components: webapps Affects Versions: 2.0.0-alpha Reporter: Todd Lipcon Assignee: Robert Joseph Evans Labels: newbie Attachments: MAPREDUCE-4221.patch, MAPREDUCE-4221.patch, MR-4221.sh, MR-4221.txt As of today we have 9.4MB of JQuery themes in our code tree. In addition to being a waste of space, it's a highly questionable feature. I've never heard anyone complain that the Hadoop interface isn't themeable enough, and there's far more value in consistency across installations than there is in themeability. Let's rip it out. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4221) Remove jquery theming support
[
https://issues.apache.org/jira/browse/MAPREDUCE-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13496483#comment-13496483
]
Hadoop QA commented on MAPREDUCE-4221:
--
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12553348/MR-4221.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3026//testReport/
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3026//console
This message is automatically generated.
Remove jquery theming support
-
Key: MAPREDUCE-4221
URL: https://issues.apache.org/jira/browse/MAPREDUCE-4221
Project: Hadoop Map/Reduce
Issue Type: Improvement
Components: webapps
Affects Versions: 2.0.0-alpha
Reporter: Todd Lipcon
Assignee: Robert Joseph Evans
Labels: newbie
Attachments: MAPREDUCE-4221.patch, MAPREDUCE-4221.patch, MR-4221.sh,
MR-4221.txt
As of today we have 9.4MB of JQuery themes in our code tree. In addition to
being a waste of space, it's a highly questionable feature. I've never heard
anyone complain that the Hadoop interface isn't themeable enough, and there's
far more value in consistency across installations than there is in
themeability. Let's rip it out.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4221) Remove jquery theming support
[ https://issues.apache.org/jira/browse/MAPREDUCE-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13496525#comment-13496525 ] Luke Lu commented on MAPREDUCE-4221: There is no need to remove themeroller (vs themeswitcher) support in jstree in *SchedulerPage, as they're there to support standard jquery-ui css classes. Remove jquery theming support - Key: MAPREDUCE-4221 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4221 Project: Hadoop Map/Reduce Issue Type: Improvement Components: webapps Affects Versions: 2.0.0-alpha Reporter: Todd Lipcon Assignee: Robert Joseph Evans Labels: newbie Attachments: MAPREDUCE-4221.patch, MAPREDUCE-4221.patch, MR-4221.sh, MR-4221.txt As of today we have 9.4MB of JQuery themes in our code tree. In addition to being a waste of space, it's a highly questionable feature. I've never heard anyone complain that the Hadoop interface isn't themeable enough, and there's far more value in consistency across installations than there is in themeability. Let's rip it out. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4221) Remove jquery theming support
[ https://issues.apache.org/jira/browse/MAPREDUCE-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13496574#comment-13496574 ] Jason Lowe commented on MAPREDUCE-4221: --- Patch looks pretty good. Besides Luke's comment, I think the following directories can also be deleted as they appear to be specific to the theme switching support being removed: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/jquery/themeswitcher-images hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/theme I manually tested some pages with those also removed, and it seemed to be working fine. Remove jquery theming support - Key: MAPREDUCE-4221 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4221 Project: Hadoop Map/Reduce Issue Type: Improvement Components: webapps Affects Versions: 2.0.0-alpha Reporter: Todd Lipcon Assignee: Robert Joseph Evans Labels: newbie Attachments: MAPREDUCE-4221.patch, MAPREDUCE-4221.patch, MR-4221.sh, MR-4221.txt As of today we have 9.4MB of JQuery themes in our code tree. In addition to being a waste of space, it's a highly questionable feature. I've never heard anyone complain that the Hadoop interface isn't themeable enough, and there's far more value in consistency across installations than there is in themeability. Let's rip it out. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4221) Remove jquery theming support
[ https://issues.apache.org/jira/browse/MAPREDUCE-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13496578#comment-13496578 ] Robert Joseph Evans commented on MAPREDUCE-4221: Thanks for the comments I will update the patch accordingly. Also I noticed that all of the changes are in YARN, so I am going to move this JIRA over to YARN. Remove jquery theming support - Key: MAPREDUCE-4221 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4221 Project: Hadoop Map/Reduce Issue Type: Improvement Affects Versions: 2.0.0-alpha Reporter: Todd Lipcon Assignee: Robert Joseph Evans Labels: newbie Attachments: MAPREDUCE-4221.patch, MAPREDUCE-4221.patch, MR-4221.sh, MR-4221.txt As of today we have 9.4MB of JQuery themes in our code tree. In addition to being a waste of space, it's a highly questionable feature. I've never heard anyone complain that the Hadoop interface isn't themeable enough, and there's far more value in consistency across installations than there is in themeability. Let's rip it out. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4221) Remove jquery theming support
[ https://issues.apache.org/jira/browse/MAPREDUCE-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13293944#comment-13293944 ] Todd Lipcon commented on MAPREDUCE-4221: Hi Dennis. I don't think just removing the files is sufficient -- we probably need to change the UI to no longer offer the theming dropdown, etc, no? Remove jquery theming support - Key: MAPREDUCE-4221 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4221 Project: Hadoop Map/Reduce Issue Type: Improvement Components: webapps Affects Versions: 2.0.0-alpha Reporter: Todd Lipcon Labels: newbie Attachments: MAPREDUCE-4221.patch As of today we have 9.4MB of JQuery themes in our code tree. In addition to being a waste of space, it's a highly questionable feature. I've never heard anyone complain that the Hadoop interface isn't themeable enough, and there's far more value in consistency across installations than there is in themeability. Let's rip it out. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4221) Remove jquery theming support
[ https://issues.apache.org/jira/browse/MAPREDUCE-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13293952#comment-13293952 ] Dennis Mårtensson commented on MAPREDUCE-4221: -- Can you point my to the UI classes and jsp:s? Remove jquery theming support - Key: MAPREDUCE-4221 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4221 Project: Hadoop Map/Reduce Issue Type: Improvement Components: webapps Affects Versions: 2.0.0-alpha Reporter: Todd Lipcon Labels: newbie Attachments: MAPREDUCE-4221.patch As of today we have 9.4MB of JQuery themes in our code tree. In addition to being a waste of space, it's a highly questionable feature. I've never heard anyone complain that the Hadoop interface isn't themeable enough, and there's far more value in consistency across installations than there is in themeability. Let's rip it out. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4221) Remove jquery theming support
[ https://issues.apache.org/jira/browse/MAPREDUCE-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13267245#comment-13267245 ] Eli Collins commented on MAPREDUCE-4221: +1 amen Remove jquery theming support - Key: MAPREDUCE-4221 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4221 Project: Hadoop Map/Reduce Issue Type: Improvement Components: webapps Affects Versions: 2.0.0 Reporter: Todd Lipcon Labels: newbie As of today we have 9.4MB of JQuery themes in our code tree. In addition to being a waste of space, it's a highly questionable feature. I've never heard anyone complain that the Hadoop interface isn't themeable enough, and there's far more value in consistency across installations than there is in themeability. Let's rip it out. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4221) Remove jquery theming support
[ https://issues.apache.org/jira/browse/MAPREDUCE-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13267485#comment-13267485 ] Robert Joseph Evans commented on MAPREDUCE-4221: I am the one that checked in the themes and I was very reluctant to do so because of the size, but that was required to make Hadoop work on a cluster with no Internet access. Additionally because of the web app proxy, themes do not really work on AMs anyways. +1 on removing the themes. Remove jquery theming support - Key: MAPREDUCE-4221 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4221 Project: Hadoop Map/Reduce Issue Type: Improvement Components: webapps Affects Versions: 2.0.0 Reporter: Todd Lipcon Labels: newbie As of today we have 9.4MB of JQuery themes in our code tree. In addition to being a waste of space, it's a highly questionable feature. I've never heard anyone complain that the Hadoop interface isn't themeable enough, and there's far more value in consistency across installations than there is in themeability. Let's rip it out. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
