[jira] [Commented] (MAPREDUCE-4367) mapred job -kill tries to connect to history server
[ https://issues.apache.org/jira/browse/MAPREDUCE-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13454645#comment-13454645 ] Mayank Bansal commented on MAPREDUCE-4367: -- Hi Vinod, Thanks for the review. Let me explain why I did the changes the way it is in the patch. In CLI.java, Kill job code path calls this Job job = cluster.getJob(JobID.forName(jobid)); Which actually result in to the client.getstatus. When we create the client object it checks if the history server is configured and if yes then it creates the proxy. Once the client is created it gets cached in the client cache which is been used for all the calls. Now, for any call we use this client object from the cache and in kill command we use that as well and thats when all the calls are transferred to History server. What we are trying to do here is for kill only we dont want to go to History server so we can not use the same client object from the cache otherwise it will go to HS. However we need client object which has History server references for all other calls because think about the situation when client get the job status with HS which returns counters etc in this case if we replace client object (without HS) then client code will start failing (Thanks to Sid pointing this case out to me). So for kill command we need client object without HS. As you suggested ClientServiceDelegate.getProxy() should take some parameter however it can not be done as actually the call is not kill it is getjobstatus. For minimrcluster I think we can not get the History server handle directly and tharts the reason I made that change. Let me do the change for KillTask. Let me know your thoughts. Thanks, Mayank > mapred job -kill tries to connect to history server > --- > > Key: MAPREDUCE-4367 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4367 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: client, mrv2 >Affects Versions: 0.23.3 >Reporter: Jason Lowe >Assignee: Mayank Bansal >Priority: Minor > Attachments: MAPREDUCE-4367-trunk-v1.patch, > MAPREDUCE-4367-trunk-v2.patch > > > The {{mapred job -kill}} command attempts to connect to the history server, > even though it is unrelated to the process of killing a job. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4367) mapred job -kill tries to connect to history server
[ https://issues.apache.org/jira/browse/MAPREDUCE-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449478#comment-13449478 ] Mayank Bansal commented on MAPREDUCE-4367: -- Adding Arun for his comments. Thanks, Mayank > mapred job -kill tries to connect to history server > --- > > Key: MAPREDUCE-4367 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4367 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: client, mrv2 >Affects Versions: 0.23.3 >Reporter: Jason Lowe >Assignee: Mayank Bansal >Priority: Minor > Fix For: trunk > > Attachments: MAPREDUCE-4367-trunk-v1.patch, > MAPREDUCE-4367-trunk-v2.patch > > > The {{mapred job -kill}} command attempts to connect to the history server, > even though it is unrelated to the process of killing a job. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4367) mapred job -kill tries to connect to history server
[ https://issues.apache.org/jira/browse/MAPREDUCE-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434371#comment-13434371 ] Mayank Bansal commented on MAPREDUCE-4367: -- Found the JIRA which addresses above issue MAPREDUCE-4470 Thanks, Mayank > mapred job -kill tries to connect to history server > --- > > Key: MAPREDUCE-4367 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4367 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: client, mrv2 >Affects Versions: 0.23.3 >Reporter: Jason Lowe >Assignee: Mayank Bansal >Priority: Minor > Fix For: trunk > > Attachments: MAPREDUCE-4367-trunk-v1.patch, > MAPREDUCE-4367-trunk-v2.patch > > > The {{mapred job -kill}} command attempts to connect to the history server, > even though it is unrelated to the process of killing a job. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4367) mapred job -kill tries to connect to history server
[ https://issues.apache.org/jira/browse/MAPREDUCE-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434361#comment-13434361 ] Mayank Bansal commented on MAPREDUCE-4367: -- This test is already failing in the trunk and unrelated to this change. I am not able to find the JIRA number which introduced this change. Thanks, Mayank > mapred job -kill tries to connect to history server > --- > > Key: MAPREDUCE-4367 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4367 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: client, mrv2 >Affects Versions: 0.23.3 >Reporter: Jason Lowe >Assignee: Mayank Bansal >Priority: Minor > Fix For: trunk > > Attachments: MAPREDUCE-4367-trunk-v1.patch, > MAPREDUCE-4367-trunk-v2.patch > > > The {{mapred job -kill}} command attempts to connect to the history server, > even though it is unrelated to the process of killing a job. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4367) mapred job -kill tries to connect to history server
[ https://issues.apache.org/jira/browse/MAPREDUCE-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433785#comment-13433785 ] Hadoop QA commented on MAPREDUCE-4367: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12540794/MAPREDUCE-4367-trunk-v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient: org.apache.hadoop.mapreduce.lib.input.TestCombineFileInputFormat +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2726//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2726//console This message is automatically generated. > mapred job -kill tries to connect to history server > --- > > Key: MAPREDUCE-4367 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4367 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: client, mrv2 >Affects Versions: 0.23.3 >Reporter: Jason Lowe >Assignee: Mayank Bansal >Priority: Minor > Fix For: trunk > > Attachments: MAPREDUCE-4367-trunk-v1.patch, > MAPREDUCE-4367-trunk-v2.patch > > > The {{mapred job -kill}} command attempts to connect to the history server, > even though it is unrelated to the process of killing a job. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4367) mapred job -kill tries to connect to history server
[ https://issues.apache.org/jira/browse/MAPREDUCE-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432301#comment-13432301 ] Hadoop QA commented on MAPREDUCE-4367: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12540123/MAPREDUCE-4367-trunk-v1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified test files. -1 javac. The applied patch generated 2071 javac compiler warnings (more than the trunk's current 2070 warnings). +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient: org.apache.hadoop.mapreduce.lib.input.TestCombineFileInputFormat org.apache.hadoop.mapreduce.v2.TestYARNRunner +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2722//testReport/ Javac warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2722//artifact/trunk/patchprocess/diffJavacWarnings.txt Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2722//console This message is automatically generated. > mapred job -kill tries to connect to history server > --- > > Key: MAPREDUCE-4367 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4367 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: client, mrv2 >Affects Versions: 0.23.3 >Reporter: Jason Lowe >Assignee: Mayank Bansal >Priority: Minor > Fix For: trunk > > Attachments: MAPREDUCE-4367-trunk-v1.patch > > > The {{mapred job -kill}} command attempts to connect to the history server, > even though it is unrelated to the process of killing a job. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4367) mapred job -kill tries to connect to history server
[ https://issues.apache.org/jira/browse/MAPREDUCE-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432139#comment-13432139 ] Mayank Bansal commented on MAPREDUCE-4367: -- The issue as reported without HISTORY server up if configured , user can not kill the job. History server does not do anyways in case of kill so in my patch I am short circuiting the History server in case of kill. Adding the test case for testing this scenario in case of History server is up and down. Thanks, Mayank > mapred job -kill tries to connect to history server > --- > > Key: MAPREDUCE-4367 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4367 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: client, mrv2 >Affects Versions: 0.23.3 >Reporter: Jason Lowe >Assignee: Mayank Bansal >Priority: Minor > Attachments: MAPREDUCE-4367-trunk-v1.patch > > > The {{mapred job -kill}} command attempts to connect to the history server, > even though it is unrelated to the process of killing a job. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4367) mapred job -kill tries to connect to history server
[ https://issues.apache.org/jira/browse/MAPREDUCE-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431300#comment-13431300 ] Mayank Bansal commented on MAPREDUCE-4367: -- Yeah I am able to reproduce the issue, taking a look. Thanks, Mayank > mapred job -kill tries to connect to history server > --- > > Key: MAPREDUCE-4367 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4367 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: client, mrv2 >Affects Versions: 0.23.3 >Reporter: Jason Lowe >Priority: Minor > > The {{mapred job -kill}} command attempts to connect to the history server, > even though it is unrelated to the process of killing a job. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4367) mapred job -kill tries to connect to history server
[ https://issues.apache.org/jira/browse/MAPREDUCE-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428492#comment-13428492 ] Jason Lowe commented on MAPREDUCE-4367: --- Yes, it's still happening for me. From a recent trunk pull on a single-node cluster where the history server isn't running yet: {noformat} $ mapred job -kill job_1344038428359_0002 2012-08-04 00:09:56,871 INFO mapred.ClientServiceDelegate (ClientServiceDelegate.java:getProxy(255)) - Application state is completed. FinalApplicationStatus=SUCCEEDED. Redirecting to job history server 2012-08-04 00:09:57,886 INFO ipc.Client (Client.java:handleConnectionFailure(715)) - Retrying connect to server: includespoke.champ.corp.yahoo.com/10.74.91.112:10020. Already tried 0 time(s); retry policy is RetryUpToMaximumCountWithFixedSleep(maxRetries=10, sleepTime=1 SECONDS) 2012-08-04 00:09:58,887 INFO ipc.Client (Client.java:handleConnectionFailure(715)) - Retrying connect to server: includespoke.champ.corp.yahoo.com/10.74.91.112:10020. Already tried 1 time(s); retry policy is RetryUpToMaximumCountWithFixedSleep(maxRetries=10, sleepTime=1 SECONDS) 2012-08-04 00:09:59,890 INFO ipc.Client (Client.java:handleConnectionFailure(715)) - Retrying connect to server: includespoke.champ.corp.yahoo.com/10.74.91.112:10020. Already tried 2 time(s); retry policy is RetryUpToMaximumCountWithFixedSleep(maxRetries=10, sleepTime=1 SECONDS) 2012-08-04 00:10:00,891 INFO ipc.Client (Client.java:handleConnectionFailure(715)) - Retrying connect to server: includespoke.champ.corp.yahoo.com/10.74.91.112:10020. Already tried 3 time(s); retry policy is RetryUpToMaximumCountWithFixedSleep(maxRetries=10, sleepTime=1 SECONDS) ... {noformat} And here's what it says after I start the history server: {noformat} $ mapred job -kill job_1344038428359_0002 2012-08-04 00:12:52,226 INFO mapred.ClientServiceDelegate (ClientServiceDelegate.java:getProxy(255)) - Application state is completed. FinalApplicationStatus=SUCCEEDED. Redirecting to job history server 2012-08-04 00:12:53,195 INFO mapred.ResourceMgrDelegate (ResourceMgrDelegate.java:killApplication(329)) - Killing application application_1344038428359_0002 Killed job job_1344038428359_0002 {noformat} Note that in both cases it says the application state is completed and is redirecting. If the application state is completed, there's no point in redirecting to the history server if we're trying to kill the application. Knowing the application state is completed means we can short-circuit the kill attempt before the redirect. > mapred job -kill tries to connect to history server > --- > > Key: MAPREDUCE-4367 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4367 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: client, mrv2 >Affects Versions: 0.23.3 >Reporter: Jason Lowe >Priority: Minor > > The {{mapred job -kill}} command attempts to connect to the history server, > even though it is unrelated to the process of killing a job. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4367) mapred job -kill tries to connect to history server
[ https://issues.apache.org/jira/browse/MAPREDUCE-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428482#comment-13428482 ] Mayank Bansal commented on MAPREDUCE-4367: -- I don't see this in trunk. Is it still the issue? Thanks, Mayank > mapred job -kill tries to connect to history server > --- > > Key: MAPREDUCE-4367 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4367 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: client, mrv2 >Affects Versions: 0.23.3 >Reporter: Jason Lowe >Priority: Minor > > The {{mapred job -kill}} command attempts to connect to the history server, > even though it is unrelated to the process of killing a job. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4367) mapred job -kill tries to connect to history server
[ https://issues.apache.org/jira/browse/MAPREDUCE-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400604#comment-13400604 ] Jason Lowe commented on MAPREDUCE-4367: --- If the history server isn't running or there are issues connecting to the history server, the kill command produces many retry messages. For example: {noformat} $ mapred job -kill job_1340642510012_0003 2012-06-25 16:42:26,626 INFO mapred.ClientServiceDelegate (ClientServiceDelegate.java:getProxy(254)) - Application state is completed. FinalApplicationStatus=FAILED. Redirecting to job history server 2012-06-25 16:42:27,629 INFO ipc.Client (Client.java:handleConnectionFailure(714)) - Retrying connect to server: xx:10020. Already tried 0 time(s); retry policy is RetryUpToMaximumCountWithFixedSleep(maxRetries=10, sleepTime=1 SECONDS) 2012-06-25 16:42:28,630 INFO ipc.Client (Client.java:handleConnectionFailure(714)) - Retrying connect to server: xx:10020. Already tried 1 time(s); retry policy is RetryUpToMaximumCountWithFixedSleep(maxRetries=10, sleepTime=1 SECONDS) 2012-06-25 16:42:29,631 INFO ipc.Client (Client.java:handleConnectionFailure(714)) - Retrying connect to server: xx:10020. Already tried 2 time(s); retry policy is RetryUpToMaximumCountWithFixedSleep(maxRetries=10, sleepTime=1 SECONDS) 2012-06-25 16:42:30,632 INFO ipc.Client (Client.java:handleConnectionFailure(714)) - Retrying connect to server: xx:10020. Already tried 3 time(s); retry policy is RetryUpToMaximumCountWithFixedSleep(maxRetries=10, sleepTime=1 SECONDS) 2012-06-25 16:42:31,633 INFO ipc.Client (Client.java:handleConnectionFailure(714)) - Retrying connect to server: xx:10020. Already tried 4 time(s); retry policy is RetryUpToMaximumCountWithFixedSleep(maxRetries=10, sleepTime=1 SECONDS) 2012-06-25 16:42:32,633 INFO ipc.Client (Client.java:handleConnectionFailure(714)) - Retrying connect to server: xx:10020. Already tried 5 time(s); retry policy is RetryUpToMaximumCountWithFixedSleep(maxRetries=10, sleepTime=1 SECONDS) 2012-06-25 16:42:33,634 INFO ipc.Client (Client.java:handleConnectionFailure(714)) - Retrying connect to server: xx:10020. Already tried 6 time(s); retry policy is RetryUpToMaximumCountWithFixedSleep(maxRetries=10, sleepTime=1 SECONDS) 2012-06-25 16:42:34,635 INFO ipc.Client (Client.java:handleConnectionFailure(714)) - Retrying connect to server: xx:10020. Already tried 7 time(s); retry policy is RetryUpToMaximumCountWithFixedSleep(maxRetries=10, sleepTime=1 SECONDS) 2012-06-25 16:42:35,636 INFO ipc.Client (Client.java:handleConnectionFailure(714)) - Retrying connect to server: xx:10020. Already tried 8 time(s); retry policy is RetryUpToMaximumCountWithFixedSleep(maxRetries=10, sleepTime=1 SECONDS) 2012-06-25 16:42:36,637 INFO ipc.Client (Client.java:handleConnectionFailure(714)) - Retrying connect to server: xx:10020. Already tried 9 time(s); retry policy is RetryUpToMaximumCountWithFixedSleep(maxRetries=10, sleepTime=1 SECONDS) 2012-06-25 16:42:36,642 INFO mapred.ClientServiceDelegate (ClientServiceDelegate.java:getProxy(254)) - Application state is completed. FinalApplicationStatus=FAILED. Redirecting to job history server 2012-06-25 16:42:37,643 INFO ipc.Client (Client.java:handleConnectionFailure(714)) - Retrying connect to server: xx:10020. Already tried 0 time(s); retry policy is RetryUpToMaximumCountWithFixedSleep(maxRetries=10, sleepTime=1 SECONDS) 2012-06-25 16:42:38,644 INFO ipc.Client (Client.java:handleConnectionFailure(714)) - Retrying connect to server: xx:10020. Already tried 1 time(s); retry policy is RetryUpToMaximumCountWithFixedSleep(maxRetries=10, sleepTime=1 SECONDS) 2012-06-25 16:42:39,644 INFO ipc.Client (Client.java:handleConnectionFailure(714)) - Retrying connect to server: xx:10020. Already tried 2 time(s); retry policy is RetryUpToMaximumCountWithFixedSleep(maxRetries=10, sleepTime=1 SECONDS) 2012-06-25 16:42:40,645 INFO ipc.Client (Client.java:handleConnectionFailure(714)) - Retrying connect to server: xx:10020. Already tried 3 time(s); retry policy is RetryUpToMaximumCountWithFixedSleep(maxRetries=10, sleepTime=1 SECONDS) 2012-06-25 16:42:41,646 INFO ipc.Client (Client.java:handleConnectionFailure(714)) - Retrying connect to server: xx:10020. Already tried 4 time(s); retry policy is RetryUpToMaximumCountWithFixedSleep(maxRetries=10, sleepTime=1 SECONDS) 2012-06-25 16:42:42,647 INFO ipc.Client (Client.java:handleConnectionFailure(714)) - Retrying connect to server: xx:10020. Already tried 5 time(s); retry policy is RetryUpToMaximumCountWithFixedSleep(maxRetries=10, sleepTime=1 SECONDS) 2012-06-25 16:42:43,648 INFO ipc.Client (Client.java:handleConnectionFailure(714)) - Retrying connect to server: xx:10020. Already tried 6 time(s); retry policy is RetryUpToMaximumCountWithFixedSleep(maxRetries=10, sleepTime=1 SECONDS) 2012-06-25 16:42:44,649 INFO ipc.Client (Clie