[jira] [Commented] (MAPREDUCE-4371) Check for cyclic dependencies in Jobcontrol job DAG
[ https://issues.apache.org/jira/browse/MAPREDUCE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407132#comment-13407132 ] Hudson commented on MAPREDUCE-4371: --- Integrated in Hadoop-Mapreduce-trunk #1127 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1127/]) MAPREDUCE-4371. Check for cyclic dependencies in Jobcontrol job DAG (madhukara phatak via bobby) (Revision 1356414) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356414 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/jobcontrol/JobControl.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/jobcontrol/TestJobControl.java > Check for cyclic dependencies in Jobcontrol job DAG > --- > > Key: MAPREDUCE-4371 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4371 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: mrv1 >Affects Versions: 3.0.0 >Reporter: madhukara phatak > Fix For: 3.0.0 > > Attachments: MAPREDUCE-4371-1.patch, MAPREDUCE-4371-2.patch, > MAPREDUCE-4371-2.patch, MAPREDUCE-4371.patch > > > In current implementation of JobControl, whenever there is a cyclic > dependency between the jobs it throws a Stack overflow exception. This jira > adds a cyclic check to jobcontrol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4371) Check for cyclic dependencies in Jobcontrol job DAG
[ https://issues.apache.org/jira/browse/MAPREDUCE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407009#comment-13407009 ] Hudson commented on MAPREDUCE-4371: --- Integrated in Hadoop-Hdfs-trunk #1094 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1094/]) MAPREDUCE-4371. Check for cyclic dependencies in Jobcontrol job DAG (madhukara phatak via bobby) (Revision 1356414) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356414 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/jobcontrol/JobControl.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/jobcontrol/TestJobControl.java > Check for cyclic dependencies in Jobcontrol job DAG > --- > > Key: MAPREDUCE-4371 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4371 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: mrv1 >Affects Versions: 3.0.0 >Reporter: madhukara phatak > Fix For: 3.0.0 > > Attachments: MAPREDUCE-4371-1.patch, MAPREDUCE-4371-2.patch, > MAPREDUCE-4371-2.patch, MAPREDUCE-4371.patch > > > In current implementation of JobControl, whenever there is a cyclic > dependency between the jobs it throws a Stack overflow exception. This jira > adds a cyclic check to jobcontrol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4371) Check for cyclic dependencies in Jobcontrol job DAG
[ https://issues.apache.org/jira/browse/MAPREDUCE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13405246#comment-13405246 ] Robert Joseph Evans commented on MAPREDUCE-4371: Thanks for the updated fix +1. I put this into trunk yet again. > Check for cyclic dependencies in Jobcontrol job DAG > --- > > Key: MAPREDUCE-4371 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4371 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: mrv1 >Affects Versions: 3.0.0 >Reporter: madhukara phatak > Fix For: 3.0.0 > > Attachments: MAPREDUCE-4371-1.patch, MAPREDUCE-4371-2.patch, > MAPREDUCE-4371-2.patch, MAPREDUCE-4371.patch > > > In current implementation of JobControl, whenever there is a cyclic > dependency between the jobs it throws a Stack overflow exception. This jira > adds a cyclic check to jobcontrol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4371) Check for cyclic dependencies in Jobcontrol job DAG
[ https://issues.apache.org/jira/browse/MAPREDUCE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404500#comment-13404500 ] Hudson commented on MAPREDUCE-4371: --- Integrated in Hadoop-Mapreduce-trunk #1125 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1125/]) Reverting MAPREDUCE-4371 to address test failures. (Revision 1355382) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355382 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/jobcontrol/JobControl.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/jobcontrol/TestJobControl.java > Check for cyclic dependencies in Jobcontrol job DAG > --- > > Key: MAPREDUCE-4371 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4371 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: mrv1 >Affects Versions: 3.0.0 >Reporter: madhukara phatak > Fix For: 3.0.0 > > Attachments: MAPREDUCE-4371-1.patch, MAPREDUCE-4371-2.patch, > MAPREDUCE-4371-2.patch, MAPREDUCE-4371.patch > > > In current implementation of JobControl, whenever there is a cyclic > dependency between the jobs it throws a Stack overflow exception. This jira > adds a cyclic check to jobcontrol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4371) Check for cyclic dependencies in Jobcontrol job DAG
[ https://issues.apache.org/jira/browse/MAPREDUCE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404463#comment-13404463 ] Hudson commented on MAPREDUCE-4371: --- Integrated in Hadoop-Hdfs-trunk #1092 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1092/]) Reverting MAPREDUCE-4371 to address test failures. (Revision 1355382) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355382 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/jobcontrol/JobControl.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/jobcontrol/TestJobControl.java > Check for cyclic dependencies in Jobcontrol job DAG > --- > > Key: MAPREDUCE-4371 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4371 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: mrv1 >Affects Versions: 3.0.0 >Reporter: madhukara phatak > Fix For: 3.0.0 > > Attachments: MAPREDUCE-4371-1.patch, MAPREDUCE-4371-2.patch, > MAPREDUCE-4371-2.patch, MAPREDUCE-4371.patch > > > In current implementation of JobControl, whenever there is a cyclic > dependency between the jobs it throws a Stack overflow exception. This jira > adds a cyclic check to jobcontrol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4371) Check for cyclic dependencies in Jobcontrol job DAG
[ https://issues.apache.org/jira/browse/MAPREDUCE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403951#comment-13403951 ] Hudson commented on MAPREDUCE-4371: --- Integrated in Hadoop-Mapreduce-trunk-Commit #2427 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2427/]) Reverting MAPREDUCE-4371 to address test failures. (Revision 1355382) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355382 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/jobcontrol/JobControl.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/jobcontrol/TestJobControl.java > Check for cyclic dependencies in Jobcontrol job DAG > --- > > Key: MAPREDUCE-4371 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4371 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: mrv1 >Affects Versions: 3.0.0 >Reporter: madhukara phatak > Fix For: 3.0.0 > > Attachments: MAPREDUCE-4371-1.patch, MAPREDUCE-4371-2.patch, > MAPREDUCE-4371-2.patch, MAPREDUCE-4371.patch > > > In current implementation of JobControl, whenever there is a cyclic > dependency between the jobs it throws a Stack overflow exception. This jira > adds a cyclic check to jobcontrol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4371) Check for cyclic dependencies in Jobcontrol job DAG
[ https://issues.apache.org/jira/browse/MAPREDUCE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403933#comment-13403933 ] Hadoop QA commented on MAPREDUCE-4371: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12533985/MAPREDUCE-4371-2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2533//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2533//console This message is automatically generated. > Check for cyclic dependencies in Jobcontrol job DAG > --- > > Key: MAPREDUCE-4371 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4371 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: mrv1 >Affects Versions: 3.0.0 >Reporter: madhukara phatak > Fix For: 3.0.0 > > Attachments: MAPREDUCE-4371-1.patch, MAPREDUCE-4371-2.patch, > MAPREDUCE-4371-2.patch, MAPREDUCE-4371.patch > > > In current implementation of JobControl, whenever there is a cyclic > dependency between the jobs it throws a Stack overflow exception. This jira > adds a cyclic check to jobcontrol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4371) Check for cyclic dependencies in Jobcontrol job DAG
[ https://issues.apache.org/jira/browse/MAPREDUCE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403926#comment-13403926 ] Hudson commented on MAPREDUCE-4371: --- Integrated in Hadoop-Mapreduce-trunk #1124 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1124/]) MAPREDUCE-4371. Check for cyclic dependencies in Jobcontrol job DAG (madhukara phatak via bobby) (Revision 1355139) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355139 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/jobcontrol/JobControl.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/jobcontrol * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/jobcontrol/TestJobControl.java > Check for cyclic dependencies in Jobcontrol job DAG > --- > > Key: MAPREDUCE-4371 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4371 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: mrv1 >Affects Versions: 3.0.0 >Reporter: madhukara phatak > Fix For: 3.0.0 > > Attachments: MAPREDUCE-4371-1.patch, MAPREDUCE-4371-2.patch, > MAPREDUCE-4371-2.patch, MAPREDUCE-4371.patch > > > In current implementation of JobControl, whenever there is a cyclic > dependency between the jobs it throws a Stack overflow exception. This jira > adds a cyclic check to jobcontrol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4371) Check for cyclic dependencies in Jobcontrol job DAG
[ https://issues.apache.org/jira/browse/MAPREDUCE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403912#comment-13403912 ] Hudson commented on MAPREDUCE-4371: --- Integrated in Hadoop-Common-trunk-Commit #2410 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2410/]) Reverting MAPREDUCE-4371 to address test failures. (Revision 1355382) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355382 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/jobcontrol/JobControl.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/jobcontrol/TestJobControl.java > Check for cyclic dependencies in Jobcontrol job DAG > --- > > Key: MAPREDUCE-4371 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4371 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: mrv1 >Affects Versions: 3.0.0 >Reporter: madhukara phatak > Fix For: 3.0.0 > > Attachments: MAPREDUCE-4371-1.patch, MAPREDUCE-4371-2.patch, > MAPREDUCE-4371-2.patch, MAPREDUCE-4371.patch > > > In current implementation of JobControl, whenever there is a cyclic > dependency between the jobs it throws a Stack overflow exception. This jira > adds a cyclic check to jobcontrol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4371) Check for cyclic dependencies in Jobcontrol job DAG
[ https://issues.apache.org/jira/browse/MAPREDUCE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403911#comment-13403911 ] Hudson commented on MAPREDUCE-4371: --- Integrated in Hadoop-Hdfs-trunk-Commit #2478 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2478/]) Reverting MAPREDUCE-4371 to address test failures. (Revision 1355382) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355382 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/jobcontrol/JobControl.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/jobcontrol/TestJobControl.java > Check for cyclic dependencies in Jobcontrol job DAG > --- > > Key: MAPREDUCE-4371 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4371 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: mrv1 >Affects Versions: 3.0.0 >Reporter: madhukara phatak > Fix For: 3.0.0 > > Attachments: MAPREDUCE-4371-1.patch, MAPREDUCE-4371-2.patch, > MAPREDUCE-4371-2.patch, MAPREDUCE-4371.patch > > > In current implementation of JobControl, whenever there is a cyclic > dependency between the jobs it throws a Stack overflow exception. This jira > adds a cyclic check to jobcontrol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4371) Check for cyclic dependencies in Jobcontrol job DAG
[ https://issues.apache.org/jira/browse/MAPREDUCE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403906#comment-13403906 ] Robert Joseph Evans commented on MAPREDUCE-4371: The new patch seems to fix the test issues. Madhukara, could you please upload the patch again and hit the submit patch button to kick Jenkins to rerun the precommit build tests on your new patch? > Check for cyclic dependencies in Jobcontrol job DAG > --- > > Key: MAPREDUCE-4371 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4371 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: mrv1 >Affects Versions: 3.0.0 >Reporter: madhukara phatak > Fix For: 3.0.0 > > Attachments: MAPREDUCE-4371-1.patch, MAPREDUCE-4371-2.patch, > MAPREDUCE-4371.patch > > > In current implementation of JobControl, whenever there is a cyclic > dependency between the jobs it throws a Stack overflow exception. This jira > adds a cyclic check to jobcontrol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4371) Check for cyclic dependencies in Jobcontrol job DAG
[ https://issues.apache.org/jira/browse/MAPREDUCE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403897#comment-13403897 ] Robert Joseph Evans commented on MAPREDUCE-4371: Sorry about that it looks like the circular dependency check cannot handle some cases where there are incorrect dependencies. Reverting the change so that the issues can be addressed. > Check for cyclic dependencies in Jobcontrol job DAG > --- > > Key: MAPREDUCE-4371 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4371 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: mrv1 >Affects Versions: 3.0.0 >Reporter: madhukara phatak > Fix For: 3.0.0 > > Attachments: MAPREDUCE-4371-1.patch, MAPREDUCE-4371-2.patch, > MAPREDUCE-4371.patch > > > In current implementation of JobControl, whenever there is a cyclic > dependency between the jobs it throws a Stack overflow exception. This jira > adds a cyclic check to jobcontrol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4371) Check for cyclic dependencies in Jobcontrol job DAG
[ https://issues.apache.org/jira/browse/MAPREDUCE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403853#comment-13403853 ] Hudson commented on MAPREDUCE-4371: --- Integrated in Hadoop-Hdfs-trunk #1091 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1091/]) MAPREDUCE-4371. Check for cyclic dependencies in Jobcontrol job DAG (madhukara phatak via bobby) (Revision 1355139) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355139 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/jobcontrol/JobControl.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/jobcontrol * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/jobcontrol/TestJobControl.java > Check for cyclic dependencies in Jobcontrol job DAG > --- > > Key: MAPREDUCE-4371 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4371 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: mrv1 >Affects Versions: 3.0.0 >Reporter: madhukara phatak > Fix For: 3.0.0 > > Attachments: MAPREDUCE-4371-1.patch, MAPREDUCE-4371-2.patch, > MAPREDUCE-4371.patch > > > In current implementation of JobControl, whenever there is a cyclic > dependency between the jobs it throws a Stack overflow exception. This jira > adds a cyclic check to jobcontrol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4371) Check for cyclic dependencies in Jobcontrol job DAG
[ https://issues.apache.org/jira/browse/MAPREDUCE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403791#comment-13403791 ] madhukara phatak commented on MAPREDUCE-4371: - Seems like the earlier commit has to reverted in order to apply the patch. Cancelling patch as of now. > Check for cyclic dependencies in Jobcontrol job DAG > --- > > Key: MAPREDUCE-4371 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4371 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: mrv1 >Affects Versions: 3.0.0 >Reporter: madhukara phatak > Fix For: 3.0.0 > > Attachments: MAPREDUCE-4371-1.patch, MAPREDUCE-4371-2.patch, > MAPREDUCE-4371.patch > > > In current implementation of JobControl, whenever there is a cyclic > dependency between the jobs it throws a Stack overflow exception. This jira > adds a cyclic check to jobcontrol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4371) Check for cyclic dependencies in Jobcontrol job DAG
[ https://issues.apache.org/jira/browse/MAPREDUCE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403787#comment-13403787 ] Hadoop QA commented on MAPREDUCE-4371: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12533952/MAPREDUCE-4371-2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2532//console This message is automatically generated. > Check for cyclic dependencies in Jobcontrol job DAG > --- > > Key: MAPREDUCE-4371 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4371 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: mrv1 >Affects Versions: 3.0.0 >Reporter: madhukara phatak > Fix For: 3.0.0 > > Attachments: MAPREDUCE-4371-1.patch, MAPREDUCE-4371-2.patch, > MAPREDUCE-4371.patch > > > In current implementation of JobControl, whenever there is a cyclic > dependency between the jobs it throws a Stack overflow exception. This jira > adds a cyclic check to jobcontrol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4371) Check for cyclic dependencies in Jobcontrol job DAG
[
https://issues.apache.org/jira/browse/MAPREDUCE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403692#comment-13403692
]
Kihwal Lee commented on MAPREDUCE-4371:
---
{{TestLocalJobControl}} and {{TestMapReduceJobControl}} are failing in trunk
due to NPE from JobControl#isCircular().
> Check for cyclic dependencies in Jobcontrol job DAG
> ---
>
> Key: MAPREDUCE-4371
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4371
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv1
>Affects Versions: 3.0.0
>Reporter: madhukara phatak
> Fix For: 3.0.0
>
> Attachments: MAPREDUCE-4371-1.patch, MAPREDUCE-4371.patch
>
>
> In current implementation of JobControl, whenever there is a cyclic
> dependency between the jobs it throws a Stack overflow exception. This jira
> adds a cyclic check to jobcontrol.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4371) Check for cyclic dependencies in Jobcontrol job DAG
[ https://issues.apache.org/jira/browse/MAPREDUCE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403477#comment-13403477 ] Hudson commented on MAPREDUCE-4371: --- Integrated in Hadoop-Mapreduce-trunk-Commit #2423 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2423/]) MAPREDUCE-4371. Check for cyclic dependencies in Jobcontrol job DAG (madhukara phatak via bobby) (Revision 1355139) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355139 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/jobcontrol/JobControl.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/jobcontrol * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/jobcontrol/TestJobControl.java > Check for cyclic dependencies in Jobcontrol job DAG > --- > > Key: MAPREDUCE-4371 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4371 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: mrv1 >Affects Versions: 3.0.0 >Reporter: madhukara phatak > Fix For: 3.0.0 > > Attachments: MAPREDUCE-4371-1.patch, MAPREDUCE-4371.patch > > > In current implementation of JobControl, whenever there is a cyclic > dependency between the jobs it throws a Stack overflow exception. This jira > adds a cyclic check to jobcontrol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4371) Check for cyclic dependencies in Jobcontrol job DAG
[ https://issues.apache.org/jira/browse/MAPREDUCE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403447#comment-13403447 ] Hudson commented on MAPREDUCE-4371: --- Integrated in Hadoop-Common-trunk-Commit #2405 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2405/]) MAPREDUCE-4371. Check for cyclic dependencies in Jobcontrol job DAG (madhukara phatak via bobby) (Revision 1355139) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355139 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/jobcontrol/JobControl.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/jobcontrol * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/jobcontrol/TestJobControl.java > Check for cyclic dependencies in Jobcontrol job DAG > --- > > Key: MAPREDUCE-4371 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4371 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: mrv1 >Affects Versions: 3.0.0 >Reporter: madhukara phatak > Fix For: 3.0.0 > > Attachments: MAPREDUCE-4371-1.patch, MAPREDUCE-4371.patch > > > In current implementation of JobControl, whenever there is a cyclic > dependency between the jobs it throws a Stack overflow exception. This jira > adds a cyclic check to jobcontrol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4371) Check for cyclic dependencies in Jobcontrol job DAG
[ https://issues.apache.org/jira/browse/MAPREDUCE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403446#comment-13403446 ] Hudson commented on MAPREDUCE-4371: --- Integrated in Hadoop-Hdfs-trunk-Commit #2473 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2473/]) MAPREDUCE-4371. Check for cyclic dependencies in Jobcontrol job DAG (madhukara phatak via bobby) (Revision 1355139) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355139 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/jobcontrol/JobControl.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/jobcontrol * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/jobcontrol/TestJobControl.java > Check for cyclic dependencies in Jobcontrol job DAG > --- > > Key: MAPREDUCE-4371 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4371 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: mrv1 >Affects Versions: 3.0.0 >Reporter: madhukara phatak > Fix For: 3.0.0 > > Attachments: MAPREDUCE-4371-1.patch, MAPREDUCE-4371.patch > > > In current implementation of JobControl, whenever there is a cyclic > dependency between the jobs it throws a Stack overflow exception. This jira > adds a cyclic check to jobcontrol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4371) Check for cyclic dependencies in Jobcontrol job DAG
[ https://issues.apache.org/jira/browse/MAPREDUCE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403432#comment-13403432 ] Robert Joseph Evans commented on MAPREDUCE-4371: The change looks good to me and the javadoc warnings appear to be caused by a different patch. +1 I'll check this in for you. I am going to put it in trunk because that is what the target version is set to. If you want this to go into branch-2 I think that should be fine, just post another comment to let me know. > Check for cyclic dependencies in Jobcontrol job DAG > --- > > Key: MAPREDUCE-4371 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4371 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: mrv1 >Affects Versions: 3.0.0 >Reporter: madhukara phatak > Attachments: MAPREDUCE-4371-1.patch, MAPREDUCE-4371.patch > > > In current implementation of JobControl, whenever there is a cyclic > dependency between the jobs it throws a Stack overflow exception. This jira > adds a cyclic check to jobcontrol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4371) Check for cyclic dependencies in Jobcontrol job DAG
[ https://issues.apache.org/jira/browse/MAPREDUCE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402328#comment-13402328 ] Hadoop QA commented on MAPREDUCE-4371: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12533666/MAPREDUCE-4371-1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 javadoc. The javadoc tool appears to have generated 2 warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2522//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2522//console This message is automatically generated. > Check for cyclic dependencies in Jobcontrol job DAG > --- > > Key: MAPREDUCE-4371 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4371 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: mrv1 >Affects Versions: 3.0.0 >Reporter: madhukara phatak > Attachments: MAPREDUCE-4371-1.patch, MAPREDUCE-4371.patch > > > In current implementation of JobControl, whenever there is a cyclic > dependency between the jobs it throws a Stack overflow exception. This jira > adds a cyclic check to jobcontrol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4371) Check for cyclic dependencies in Jobcontrol job DAG
[ https://issues.apache.org/jira/browse/MAPREDUCE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402282#comment-13402282 ] Hadoop QA commented on MAPREDUCE-4371: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12533455/MAPREDUCE-4371.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 javadoc. The javadoc tool appears to have generated 2 warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2521//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2521//console This message is automatically generated. > Check for cyclic dependencies in Jobcontrol job DAG > --- > > Key: MAPREDUCE-4371 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4371 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: mrv1 >Affects Versions: 3.0.0 >Reporter: madhukara phatak > Attachments: MAPREDUCE-4371.patch > > > In current implementation of JobControl, whenever there is a cyclic > dependency between the jobs it throws a Stack overflow exception. This jira > adds a cyclic check to jobcontrol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4371) Check for cyclic dependencies in Jobcontrol job DAG
[ https://issues.apache.org/jira/browse/MAPREDUCE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402268#comment-13402268 ] Robert Joseph Evans commented on MAPREDUCE-4371: Just a few comments about the patch. # the new file needs an apache license comment at the top. # It would be nice to have a comment in the test about what the test class is intended to cover. # The test looks like it is passing, but without any exceptions ever being caught in the test. The run method catches all exceptions and then kills all of the jobs. This is because run is intended to potentially be called on its own thread. Please instead verify that all of the jobs are marked as failed at the end. # Inside the patch itself it looks like there are a few places where the formatting is off. We use 2 spaces for indentation and try to wrap the lines at under 80 characters. Other then that it looks good. Also a bit of process in when you upload a patch please mark the box indicating that it is intended for inclusion in Apache, also please then hit the submit patch button. This will trigger Jenkins to try and test the patch against trunk. I am going to hit submit patch for you, but the checkbox you have to do because it is your code and your copyright. > Check for cyclic dependencies in Jobcontrol job DAG > --- > > Key: MAPREDUCE-4371 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4371 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: mrv1 >Affects Versions: 3.0.0 >Reporter: madhukara phatak > Attachments: MAPREDUCE-4371.patch > > > In current implementation of JobControl, whenever there is a cyclic > dependency between the jobs it throws a Stack overflow exception. This jira > adds a cyclic check to jobcontrol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
