[jira] [Commented] (MAPREDUCE-4415) Backport the Job.getInstance methods from MAPREDUCE-1505 to branch-1
[ https://issues.apache.org/jira/browse/MAPREDUCE-4415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13421419#comment-13421419 ] Tom White commented on MAPREDUCE-4415: -- +1 looks good to me. Backport the Job.getInstance methods from MAPREDUCE-1505 to branch-1 Key: MAPREDUCE-4415 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4415 Project: Hadoop Map/Reduce Issue Type: Improvement Components: mrv1 Affects Versions: 1.0.0 Reporter: Harsh J Assignee: Harsh J Attachments: MAPREDUCE-4415.patch In 2.x MR, the Job constructors have all been deprecated in favor of Job.getInstance() calls to get a Job object. However, these getInstance methods do not appear to be present in the 1.x MR API, and thereby may cause additional pain to users moving from 1.x to 2.x going forward. This patch proposes to add in the getInstance style of methods with suitable test coverage for both style of constructors, while not pulling in anything else from MAPREDUCE-1505 (as we lack 'Cluster' in 1.x). As we're not going to be deprecating the regular ctors in a 1.x release, this is not an incompatible change in any way. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4415) Backport the Job.getInstance methods from MAPREDUCE-1505 to branch-1
[ https://issues.apache.org/jira/browse/MAPREDUCE-4415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13421587#comment-13421587 ] Harsh J commented on MAPREDUCE-4415: (Committed to branch-1 via r1365193) Backport the Job.getInstance methods from MAPREDUCE-1505 to branch-1 Key: MAPREDUCE-4415 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4415 Project: Hadoop Map/Reduce Issue Type: Improvement Components: mrv1 Affects Versions: 1.0.0 Reporter: Harsh J Assignee: Harsh J Fix For: 1.2.0 Attachments: MAPREDUCE-4415.patch In 2.x MR, the Job constructors have all been deprecated in favor of Job.getInstance() calls to get a Job object. However, these getInstance methods do not appear to be present in the 1.x MR API, and thereby may cause additional pain to users moving from 1.x to 2.x going forward. This patch proposes to add in the getInstance style of methods with suitable test coverage for both style of constructors, while not pulling in anything else from MAPREDUCE-1505 (as we lack 'Cluster' in 1.x). As we're not going to be deprecating the regular ctors in a 1.x release, this is not an incompatible change in any way. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4415) Backport the Job.getInstance methods from MAPREDUCE-1505 to branch-1
[ https://issues.apache.org/jira/browse/MAPREDUCE-4415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13413962#comment-13413962 ] Harsh J commented on MAPREDUCE-4415: Arun - Ping? Backport the Job.getInstance methods from MAPREDUCE-1505 to branch-1 Key: MAPREDUCE-4415 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4415 Project: Hadoop Map/Reduce Issue Type: Improvement Components: mrv1 Affects Versions: 1.0.0 Reporter: Harsh J Assignee: Harsh J Attachments: MAPREDUCE-4415.patch In 2.x MR, the Job constructors have all been deprecated in favor of Job.getInstance() calls to get a Job object. However, these getInstance methods do not appear to be present in the 1.x MR API, and thereby may cause additional pain to users moving from 1.x to 2.x going forward. This patch proposes to add in the getInstance style of methods with suitable test coverage for both style of constructors, while not pulling in anything else from MAPREDUCE-1505 (as we lack 'Cluster' in 1.x). As we're not going to be deprecating the regular ctors in a 1.x release, this is not an incompatible change in any way. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4415) Backport the Job.getInstance methods from MAPREDUCE-1505 to branch-1
[
https://issues.apache.org/jira/browse/MAPREDUCE-4415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13409837#comment-13409837
]
Harsh J commented on MAPREDUCE-4415:
test-patch results:
{code}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 12 new or
modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] -1 findbugs. The patch appears to introduce 218 new Findbugs
(version 2.0.1-rc3) warnings.
{code}
Backport the Job.getInstance methods from MAPREDUCE-1505 to branch-1
Key: MAPREDUCE-4415
URL: https://issues.apache.org/jira/browse/MAPREDUCE-4415
Project: Hadoop Map/Reduce
Issue Type: Improvement
Components: mrv1
Affects Versions: 1.0.0
Reporter: Harsh J
Assignee: Harsh J
Attachments: MAPREDUCE-4415.patch
In 2.x MR, the Job constructors have all been deprecated in favor of
Job.getInstance() calls to get a Job object.
However, these getInstance methods do not appear to be present in the 1.x MR
API, and thereby may cause additional pain to users moving from 1.x to 2.x
going forward.
This patch proposes to add in the getInstance style of methods with suitable
test coverage for both style of constructors, while not pulling in anything
else from MAPREDUCE-1505 (as we lack 'Cluster' in 1.x). As we're not going to
be deprecating the regular ctors in a 1.x release, this is not an
incompatible change in any way.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4415) Backport the Job.getInstance methods from MAPREDUCE-1505 to branch-1
[ https://issues.apache.org/jira/browse/MAPREDUCE-4415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13409838#comment-13409838 ] Harsh J commented on MAPREDUCE-4415: bq. -1 findbugs. The patch appears to introduce 218 new Findbugs (version 2.0.1-rc3) warnings. Same count as the one I received on HDFS-3617 earlier today. None of these findbugs are caused by my code. Hence that -1 can be ignored for this patch. Backport the Job.getInstance methods from MAPREDUCE-1505 to branch-1 Key: MAPREDUCE-4415 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4415 Project: Hadoop Map/Reduce Issue Type: Improvement Components: mrv1 Affects Versions: 1.0.0 Reporter: Harsh J Assignee: Harsh J Attachments: MAPREDUCE-4415.patch In 2.x MR, the Job constructors have all been deprecated in favor of Job.getInstance() calls to get a Job object. However, these getInstance methods do not appear to be present in the 1.x MR API, and thereby may cause additional pain to users moving from 1.x to 2.x going forward. This patch proposes to add in the getInstance style of methods with suitable test coverage for both style of constructors, while not pulling in anything else from MAPREDUCE-1505 (as we lack 'Cluster' in 1.x). As we're not going to be deprecating the regular ctors in a 1.x release, this is not an incompatible change in any way. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4415) Backport the Job.getInstance methods from MAPREDUCE-1505 to branch-1
[ https://issues.apache.org/jira/browse/MAPREDUCE-4415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13409855#comment-13409855 ] Arun C Murthy commented on MAPREDUCE-4415: -- Harsh - there are many more instances of 'new Job()' ? Do you plan to fix all of them? Backport the Job.getInstance methods from MAPREDUCE-1505 to branch-1 Key: MAPREDUCE-4415 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4415 Project: Hadoop Map/Reduce Issue Type: Improvement Components: mrv1 Affects Versions: 1.0.0 Reporter: Harsh J Assignee: Harsh J Attachments: MAPREDUCE-4415.patch In 2.x MR, the Job constructors have all been deprecated in favor of Job.getInstance() calls to get a Job object. However, these getInstance methods do not appear to be present in the 1.x MR API, and thereby may cause additional pain to users moving from 1.x to 2.x going forward. This patch proposes to add in the getInstance style of methods with suitable test coverage for both style of constructors, while not pulling in anything else from MAPREDUCE-1505 (as we lack 'Cluster' in 1.x). As we're not going to be deprecating the regular ctors in a 1.x release, this is not an incompatible change in any way. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4415) Backport the Job.getInstance methods from MAPREDUCE-1505 to branch-1
[ https://issues.apache.org/jira/browse/MAPREDUCE-4415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13409862#comment-13409862 ] Harsh J commented on MAPREDUCE-4415: Arun - I thought I'd leave some to not mess with test coverage for that ctor, as it has not been deprecated/replaced by this change. If you feel we should change it all, I'll go ahead. Let me know! Backport the Job.getInstance methods from MAPREDUCE-1505 to branch-1 Key: MAPREDUCE-4415 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4415 Project: Hadoop Map/Reduce Issue Type: Improvement Components: mrv1 Affects Versions: 1.0.0 Reporter: Harsh J Assignee: Harsh J Attachments: MAPREDUCE-4415.patch In 2.x MR, the Job constructors have all been deprecated in favor of Job.getInstance() calls to get a Job object. However, these getInstance methods do not appear to be present in the 1.x MR API, and thereby may cause additional pain to users moving from 1.x to 2.x going forward. This patch proposes to add in the getInstance style of methods with suitable test coverage for both style of constructors, while not pulling in anything else from MAPREDUCE-1505 (as we lack 'Cluster' in 1.x). As we're not going to be deprecating the regular ctors in a 1.x release, this is not an incompatible change in any way. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
