[jira] [Commented] (MAPREDUCE-4416) Some tests fail if Clover is enabled
[ https://issues.apache.org/jira/browse/MAPREDUCE-4416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413761#comment-13413761 ] Hudson commented on MAPREDUCE-4416: --- Integrated in Hadoop-Mapreduce-trunk #1135 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1135/]) MAPREDUCE-4416. Some tests fail if Clover is enabled (Kihwal Lee via bobby) (Revision 1360735) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1360735 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestIndexCache.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/pom.xml * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/pom.xml * /hadoop/common/trunk/hadoop-project/pom.xml > Some tests fail if Clover is enabled > > > Key: MAPREDUCE-4416 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4416 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: client, mrv2 >Affects Versions: 2.0.0-alpha, 3.0.0 >Reporter: Kihwal Lee >Assignee: Kihwal Lee >Priority: Critical > Fix For: 2.0.1-alpha, 3.0.0 > > Attachments: mapreduce-4416.patch.txt, mapreduce-4416.patch.txt > > > There are number of tests running under hadoop-mapreduce-client-jobclient > that fail if Clover is enabled. Whenever a job is launched, AM doesn't start > because it can't locate the clover jar file. > I thought MAPREDUCE-4253 had something to do with this, but I can reproduce > the issue on an older revision. Although unrelated, MAPREDUCE-4253 does have > a problem and it has been reported to the jira. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4416) Some tests fail if Clover is enabled
[ https://issues.apache.org/jira/browse/MAPREDUCE-4416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413671#comment-13413671 ] Hudson commented on MAPREDUCE-4416: --- Integrated in Hadoop-Hdfs-trunk #1102 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1102/]) MAPREDUCE-4416. Some tests fail if Clover is enabled (Kihwal Lee via bobby) (Revision 1360735) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1360735 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestIndexCache.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/pom.xml * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/pom.xml * /hadoop/common/trunk/hadoop-project/pom.xml > Some tests fail if Clover is enabled > > > Key: MAPREDUCE-4416 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4416 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: client, mrv2 >Affects Versions: 2.0.0-alpha, 3.0.0 >Reporter: Kihwal Lee >Assignee: Kihwal Lee >Priority: Critical > Fix For: 2.0.1-alpha, 3.0.0 > > Attachments: mapreduce-4416.patch.txt, mapreduce-4416.patch.txt > > > There are number of tests running under hadoop-mapreduce-client-jobclient > that fail if Clover is enabled. Whenever a job is launched, AM doesn't start > because it can't locate the clover jar file. > I thought MAPREDUCE-4253 had something to do with this, but I can reproduce > the issue on an older revision. Although unrelated, MAPREDUCE-4253 does have > a problem and it has been reported to the jira. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4416) Some tests fail if Clover is enabled
[ https://issues.apache.org/jira/browse/MAPREDUCE-4416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412934#comment-13412934 ] Hudson commented on MAPREDUCE-4416: --- Integrated in Hadoop-Mapreduce-trunk-Commit #2475 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2475/]) MAPREDUCE-4416. Some tests fail if Clover is enabled (Kihwal Lee via bobby) (Revision 1360735) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1360735 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestIndexCache.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/pom.xml * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/pom.xml * /hadoop/common/trunk/hadoop-project/pom.xml > Some tests fail if Clover is enabled > > > Key: MAPREDUCE-4416 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4416 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: client, mrv2 >Affects Versions: 2.0.0-alpha, 3.0.0 >Reporter: Kihwal Lee >Assignee: Kihwal Lee >Priority: Critical > Fix For: 2.0.1-alpha, 3.0.0 > > Attachments: mapreduce-4416.patch.txt > > > There are number of tests running under hadoop-mapreduce-client-jobclient > that fail if Clover is enabled. Whenever a job is launched, AM doesn't start > because it can't locate the clover jar file. > I thought MAPREDUCE-4253 had something to do with this, but I can reproduce > the issue on an older revision. Although unrelated, MAPREDUCE-4253 does have > a problem and it has been reported to the jira. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4416) Some tests fail if Clover is enabled
[ https://issues.apache.org/jira/browse/MAPREDUCE-4416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412896#comment-13412896 ] Hudson commented on MAPREDUCE-4416: --- Integrated in Hadoop-Common-trunk-Commit #2456 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2456/]) MAPREDUCE-4416. Some tests fail if Clover is enabled (Kihwal Lee via bobby) (Revision 1360735) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1360735 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestIndexCache.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/pom.xml * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/pom.xml * /hadoop/common/trunk/hadoop-project/pom.xml > Some tests fail if Clover is enabled > > > Key: MAPREDUCE-4416 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4416 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: client, mrv2 >Affects Versions: 2.0.0-alpha, 3.0.0 >Reporter: Kihwal Lee >Assignee: Kihwal Lee >Priority: Critical > Fix For: 2.0.1-alpha, 3.0.0 > > Attachments: mapreduce-4416.patch.txt > > > There are number of tests running under hadoop-mapreduce-client-jobclient > that fail if Clover is enabled. Whenever a job is launched, AM doesn't start > because it can't locate the clover jar file. > I thought MAPREDUCE-4253 had something to do with this, but I can reproduce > the issue on an older revision. Although unrelated, MAPREDUCE-4253 does have > a problem and it has been reported to the jira. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4416) Some tests fail if Clover is enabled
[ https://issues.apache.org/jira/browse/MAPREDUCE-4416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412895#comment-13412895 ] Hudson commented on MAPREDUCE-4416: --- Integrated in Hadoop-Hdfs-trunk-Commit #2522 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2522/]) MAPREDUCE-4416. Some tests fail if Clover is enabled (Kihwal Lee via bobby) (Revision 1360735) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1360735 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestIndexCache.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/pom.xml * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/pom.xml * /hadoop/common/trunk/hadoop-project/pom.xml > Some tests fail if Clover is enabled > > > Key: MAPREDUCE-4416 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4416 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: client, mrv2 >Affects Versions: 2.0.0-alpha, 3.0.0 >Reporter: Kihwal Lee >Assignee: Kihwal Lee >Priority: Critical > Fix For: 2.0.1-alpha, 3.0.0 > > Attachments: mapreduce-4416.patch.txt > > > There are number of tests running under hadoop-mapreduce-client-jobclient > that fail if Clover is enabled. Whenever a job is launched, AM doesn't start > because it can't locate the clover jar file. > I thought MAPREDUCE-4253 had something to do with this, but I can reproduce > the issue on an older revision. Although unrelated, MAPREDUCE-4253 does have > a problem and it has been reported to the jira. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4416) Some tests fail if Clover is enabled
[ https://issues.apache.org/jira/browse/MAPREDUCE-4416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412889#comment-13412889 ] Robert Joseph Evans commented on MAPREDUCE-4416: +1 the patch looks good, the tests pass, and clover now works. I verified this manually. > Some tests fail if Clover is enabled > > > Key: MAPREDUCE-4416 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4416 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: client, mrv2 >Affects Versions: 2.0.0-alpha, 3.0.0 >Reporter: Kihwal Lee >Priority: Critical > Fix For: 2.0.1-alpha, 3.0.0 > > Attachments: mapreduce-4416.patch.txt > > > There are number of tests running under hadoop-mapreduce-client-jobclient > that fail if Clover is enabled. Whenever a job is launched, AM doesn't start > because it can't locate the clover jar file. > I thought MAPREDUCE-4253 had something to do with this, but I can reproduce > the issue on an older revision. Although unrelated, MAPREDUCE-4253 does have > a problem and it has been reported to the jira. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4416) Some tests fail if Clover is enabled
[ https://issues.apache.org/jira/browse/MAPREDUCE-4416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412878#comment-13412878 ] Hadoop QA commented on MAPREDUCE-4416: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12536228/mapreduce-4416.patch.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2579//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2579//console This message is automatically generated. > Some tests fail if Clover is enabled > > > Key: MAPREDUCE-4416 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4416 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: client, mrv2 >Affects Versions: 2.0.0-alpha, 3.0.0 >Reporter: Kihwal Lee >Priority: Critical > Fix For: 2.0.1-alpha, 3.0.0 > > Attachments: mapreduce-4416.patch.txt > > > There are number of tests running under hadoop-mapreduce-client-jobclient > that fail if Clover is enabled. Whenever a job is launched, AM doesn't start > because it can't locate the clover jar file. > I thought MAPREDUCE-4253 had something to do with this, but I can reproduce > the issue on an older revision. Although unrelated, MAPREDUCE-4253 does have > a problem and it has been reported to the jira. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4416) Some tests fail if Clover is enabled
[ https://issues.apache.org/jira/browse/MAPREDUCE-4416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412381#comment-13412381 ] Kihwal Lee commented on MAPREDUCE-4416: --- Patrick, thanks for the comment. That might work, but the fact that it's not really an app-level dependency bothers me. So I ended up adding the dependency inside the clover profile in hadoop-project/pom.xml. This causes each module to have clover jar as a dependency when -Pclover is specified. All mrapp-generated-classpath files will include the path to the clover jar. The package build will copy and include the clover jar, but we can't really use instrumented packages anyway. As an alternative to globally adding the dependency, we can do it per module whenever necessary. At least the following two needs the dependency specified. - hadoop-yarn-applications - hadoop-mapreduce-client-jobclient > Some tests fail if Clover is enabled > > > Key: MAPREDUCE-4416 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4416 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: client, mrv2 >Affects Versions: 2.0.0-alpha, 3.0.0 >Reporter: Kihwal Lee >Priority: Critical > Fix For: 2.0.1-alpha, 3.0.0 > > > There are number of tests running under hadoop-mapreduce-client-jobclient > that fail if Clover is enabled. Whenever a job is launched, AM doesn't start > because it can't locate the clover jar file. > I thought MAPREDUCE-4253 had something to do this, but I can reproduce the > issue on an older revision. Although unrelated, MAPREDUCE-4253 does have a > problem and it has been reported to the jira. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4416) Some tests fail if Clover is enabled
[ https://issues.apache.org/jira/browse/MAPREDUCE-4416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411705#comment-13411705 ] Patrick Hunt commented on MAPREDUCE-4416: - I don't believe 4141 is the issue, as that was a build change, not something that should effect containers. I might be way off here but have you looked at "yarn.application.classpath" ? I ran into a similar sounding issue the other day with MAPREDUCE-4250. Ensure that clover jars are on the application classpath. > Some tests fail if Clover is enabled > > > Key: MAPREDUCE-4416 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4416 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: client, mrv2 >Affects Versions: 2.0.0-alpha, 3.0.0 >Reporter: Kihwal Lee >Priority: Critical > Fix For: 2.0.1-alpha, 3.0.0 > > > There are number of tests running under hadoop-mapreduce-client-jobclient > that fail if Clover is enabled. Whenever a job is launched, AM doesn't start > because it can't locate the clover jar file. > I thought MAPREDUCE-4253 had something to do this, but I can reproduce the > issue on an older revision. Although unrelated, MAPREDUCE-4253 does have a > problem and it has been reported to the jira. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4416) Some tests fail if Clover is enabled
[
https://issues.apache.org/jira/browse/MAPREDUCE-4416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411372#comment-13411372
]
Kihwal Lee commented on MAPREDUCE-4416:
---
AM as well as mapper/reudcer fails, if run tests (e.g. {{TestChild}}) normally
with {{-Pclover}}.
{noformat}
[CLOVER] FATAL ERROR: Clover could not be initialised. Are you sure you have
Clover in the runtime classpath? (class
java.lang.NoClassDefFoundError:com_cenqua_clover/CloverVersionInfo)
Exception in thread "main" java.lang.NoClassDefFoundError:
com_cenqua_clover/CoverageRecorder
at
org.apache.hadoop.mapreduce.v2.app.MRAppMaster.main(MRAppMaster.java:1017)
{noformat}
> Some tests fail if Clover is enabled
>
>
> Key: MAPREDUCE-4416
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4416
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: client, mrv2
>Affects Versions: 2.0.0-alpha, 3.0.0
>Reporter: Kihwal Lee
>Priority: Critical
> Fix For: 2.0.1-alpha, 3.0.0
>
>
> There are number of tests running under hadoop-mapreduce-client-jobclient
> that fail if Clover is enabled. Whenever a job is launched, AM doesn't start
> because it can't locate the clover jar file.
> It seems this started happening after MAPREDUCE-4253.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4416) Some tests fail if Clover is enabled
[ https://issues.apache.org/jira/browse/MAPREDUCE-4416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411354#comment-13411354 ] Kihwal Lee commented on MAPREDUCE-4416: --- The failing tests are using MiniMRCluster and submit jobs. Jobs fail because containers' classpath does not contain the clover jar. If I make the leaf project to pick up non-clovered mr-client-app, at least AM works. But custom mapper, reducers, etc. defined in mr-client-jobclient will be instrumented and be part of the code running inside containers, so the containers should be able to locate the clover jar. We have a record of these tests working with clover at least on June 24. So I went back and tried the old revision but it didn't work this time... I wonder how it ever worked. Before MAPREDUCE-4082, it seems the classpath in mr-client-app contained the clover jar. The jira comments also shows clover being in the generated classpath. The now problematic clovered tests might have worked okay back then. Some tests were also being ignored. There is MAPREDUCE-4141 that removed the hard dependency on clover. If these tests accidentally worked before, this might have stopped it. Maybe running clovered test code in yarn containers does not make sense. They are separate processes launched by something other than the test framework. The clover instrumentation doesn't seem to be designed to naturally cover them. We could exclude some of test helper classes from instrumentation. > Some tests fail if Clover is enabled > > > Key: MAPREDUCE-4416 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4416 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: client, mrv2 >Affects Versions: 2.0.0-alpha, 3.0.0 >Reporter: Kihwal Lee >Priority: Critical > Fix For: 2.0.1-alpha, 3.0.0 > > > There are number of tests running under hadoop-mapreduce-client-jobclient > that fail if Clover is enabled. Whenever a job is launched, AM doesn't start > because it can't locate the clover jar file. > It seems this started happening after MAPREDUCE-4253. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
