[jira] [Commented] (MAPREDUCE-4432) Confusing warning message when GenericOptionsParser is not used
[ https://issues.apache.org/jira/browse/MAPREDUCE-4432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414410#comment-13414410 ] Hudson commented on MAPREDUCE-4432: --- Integrated in Hadoop-Mapreduce-trunk #1136 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1136/]) MAPREDUCE-4432. Confusing warning message when GenericOptionsParser is not used. Contributed by Gabriel Reid. (harsh) (Revision 1361273) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361273 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobSubmitter.java > Confusing warning message when GenericOptionsParser is not used > --- > > Key: MAPREDUCE-4432 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4432 > Project: Hadoop Map/Reduce > Issue Type: Bug >Affects Versions: 2.0.0-alpha >Reporter: Gabriel Reid >Priority: Trivial > Fix For: 2.0.1-alpha > > Attachments: MAPREDUCE-4432.patch, MAPREDUCE-4432.patch > > > The warning that is issued in JobSubmitter -- "Use GenericOptionsParser for > parsing the arguments. Applications should implement Tool for the same." -- > is confusing and (probably) grammatically incorrect. > This can be improved by having an updated warning message which gives clearer > directions on what can be improved in the application to avoid the warning in > the future. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4432) Confusing warning message when GenericOptionsParser is not used
[ https://issues.apache.org/jira/browse/MAPREDUCE-4432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414356#comment-13414356 ] Hudson commented on MAPREDUCE-4432: --- Integrated in Hadoop-Hdfs-trunk #1103 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1103/]) MAPREDUCE-4432. Confusing warning message when GenericOptionsParser is not used. Contributed by Gabriel Reid. (harsh) (Revision 1361273) Result = FAILURE harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361273 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobSubmitter.java > Confusing warning message when GenericOptionsParser is not used > --- > > Key: MAPREDUCE-4432 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4432 > Project: Hadoop Map/Reduce > Issue Type: Bug >Affects Versions: 2.0.0-alpha >Reporter: Gabriel Reid >Priority: Trivial > Fix For: 2.0.1-alpha > > Attachments: MAPREDUCE-4432.patch, MAPREDUCE-4432.patch > > > The warning that is issued in JobSubmitter -- "Use GenericOptionsParser for > parsing the arguments. Applications should implement Tool for the same." -- > is confusing and (probably) grammatically incorrect. > This can be improved by having an updated warning message which gives clearer > directions on what can be improved in the application to avoid the warning in > the future. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4432) Confusing warning message when GenericOptionsParser is not used
[ https://issues.apache.org/jira/browse/MAPREDUCE-4432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413855#comment-13413855 ] Hudson commented on MAPREDUCE-4432: --- Integrated in Hadoop-Mapreduce-trunk-Commit #2483 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2483/]) MAPREDUCE-4432. Confusing warning message when GenericOptionsParser is not used. Contributed by Gabriel Reid. (harsh) (Revision 1361273) Result = FAILURE harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361273 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobSubmitter.java > Confusing warning message when GenericOptionsParser is not used > --- > > Key: MAPREDUCE-4432 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4432 > Project: Hadoop Map/Reduce > Issue Type: Bug >Affects Versions: 2.0.0-alpha >Reporter: Gabriel Reid >Priority: Trivial > Fix For: 2.0.1-alpha > > Attachments: MAPREDUCE-4432.patch, MAPREDUCE-4432.patch > > > The warning that is issued in JobSubmitter -- "Use GenericOptionsParser for > parsing the arguments. Applications should implement Tool for the same." -- > is confusing and (probably) grammatically incorrect. > This can be improved by having an updated warning message which gives clearer > directions on what can be improved in the application to avoid the warning in > the future. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4432) Confusing warning message when GenericOptionsParser is not used
[ https://issues.apache.org/jira/browse/MAPREDUCE-4432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413823#comment-13413823 ] Hudson commented on MAPREDUCE-4432: --- Integrated in Hadoop-Common-trunk-Commit #2463 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2463/]) MAPREDUCE-4432. Confusing warning message when GenericOptionsParser is not used. Contributed by Gabriel Reid. (harsh) (Revision 1361273) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361273 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobSubmitter.java > Confusing warning message when GenericOptionsParser is not used > --- > > Key: MAPREDUCE-4432 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4432 > Project: Hadoop Map/Reduce > Issue Type: Bug >Affects Versions: 2.0.0-alpha >Reporter: Gabriel Reid >Priority: Trivial > Fix For: 2.0.1-alpha > > Attachments: MAPREDUCE-4432.patch, MAPREDUCE-4432.patch > > > The warning that is issued in JobSubmitter -- "Use GenericOptionsParser for > parsing the arguments. Applications should implement Tool for the same." -- > is confusing and (probably) grammatically incorrect. > This can be improved by having an updated warning message which gives clearer > directions on what can be improved in the application to avoid the warning in > the future. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4432) Confusing warning message when GenericOptionsParser is not used
[ https://issues.apache.org/jira/browse/MAPREDUCE-4432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413821#comment-13413821 ] Hudson commented on MAPREDUCE-4432: --- Integrated in Hadoop-Hdfs-trunk-Commit #2529 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2529/]) MAPREDUCE-4432. Confusing warning message when GenericOptionsParser is not used. Contributed by Gabriel Reid. (harsh) (Revision 1361273) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361273 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobSubmitter.java > Confusing warning message when GenericOptionsParser is not used > --- > > Key: MAPREDUCE-4432 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4432 > Project: Hadoop Map/Reduce > Issue Type: Bug >Affects Versions: 2.0.0-alpha >Reporter: Gabriel Reid >Priority: Trivial > Fix For: 2.0.1-alpha > > Attachments: MAPREDUCE-4432.patch, MAPREDUCE-4432.patch > > > The warning that is issued in JobSubmitter -- "Use GenericOptionsParser for > parsing the arguments. Applications should implement Tool for the same." -- > is confusing and (probably) grammatically incorrect. > This can be improved by having an updated warning message which gives clearer > directions on what can be improved in the application to avoid the warning in > the future. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4432) Confusing warning message when GenericOptionsParser is not used
[ https://issues.apache.org/jira/browse/MAPREDUCE-4432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413802#comment-13413802 ] Robert Joseph Evans commented on MAPREDUCE-4432: I am +1 on this patch too. Thanks Gabriel for helping to make Hadoop better. > Confusing warning message when GenericOptionsParser is not used > --- > > Key: MAPREDUCE-4432 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4432 > Project: Hadoop Map/Reduce > Issue Type: Bug >Affects Versions: 2.0.0-alpha >Reporter: Gabriel Reid >Priority: Trivial > Attachments: MAPREDUCE-4432.patch, MAPREDUCE-4432.patch > > > The warning that is issued in JobSubmitter -- "Use GenericOptionsParser for > parsing the arguments. Applications should implement Tool for the same." -- > is confusing and (probably) grammatically incorrect. > This can be improved by having an updated warning message which gives clearer > directions on what can be improved in the application to avoid the warning in > the future. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4432) Confusing warning message when GenericOptionsParser is not used
[ https://issues.apache.org/jira/browse/MAPREDUCE-4432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413491#comment-13413491 ] Gabriel Reid commented on MAPREDUCE-4432: - Justification for the lack of new tests on this patch is that the patch is only changing the wording of a warning message, and therefore not a candidate for automated testing. > Confusing warning message when GenericOptionsParser is not used > --- > > Key: MAPREDUCE-4432 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4432 > Project: Hadoop Map/Reduce > Issue Type: Bug >Affects Versions: 2.0.0-alpha >Reporter: Gabriel Reid >Priority: Trivial > Attachments: MAPREDUCE-4432.patch, MAPREDUCE-4432.patch > > > The warning that is issued in JobSubmitter -- "Use GenericOptionsParser for > parsing the arguments. Applications should implement Tool for the same." -- > is confusing and (probably) grammatically incorrect. > This can be improved by having an updated warning message which gives clearer > directions on what can be improved in the application to avoid the warning in > the future. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4432) Confusing warning message when GenericOptionsParser is not used
[ https://issues.apache.org/jira/browse/MAPREDUCE-4432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413480#comment-13413480 ] Hadoop QA commented on MAPREDUCE-4432: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12536261/MAPREDUCE-4432.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2584//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2584//console This message is automatically generated. > Confusing warning message when GenericOptionsParser is not used > --- > > Key: MAPREDUCE-4432 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4432 > Project: Hadoop Map/Reduce > Issue Type: Bug >Affects Versions: 2.0.0-alpha >Reporter: Gabriel Reid >Priority: Trivial > Attachments: MAPREDUCE-4432.patch, MAPREDUCE-4432.patch > > > The warning that is issued in JobSubmitter -- "Use GenericOptionsParser for > parsing the arguments. Applications should implement Tool for the same." -- > is confusing and (probably) grammatically incorrect. > This can be improved by having an updated warning message which gives clearer > directions on what can be improved in the application to avoid the warning in > the future. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4432) Confusing warning message when GenericOptionsParser is not used
[ https://issues.apache.org/jira/browse/MAPREDUCE-4432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413077#comment-13413077 ] Gabriel Reid commented on MAPREDUCE-4432: - Good point about GOP -- I'll upload a new patch that only mentions Tool and ToolRunner. > Confusing warning message when GenericOptionsParser is not used > --- > > Key: MAPREDUCE-4432 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4432 > Project: Hadoop Map/Reduce > Issue Type: Bug >Reporter: Gabriel Reid >Priority: Trivial > Attachments: MAPREDUCE-4432.patch > > > The warning that is issued in JobSubmitter -- "Use GenericOptionsParser for > parsing the arguments. Applications should implement Tool for the same." -- > is confusing and (probably) grammatically incorrect. > This can be improved by having an updated warning message which gives clearer > directions on what can be improved in the application to avoid the warning in > the future. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4432) Confusing warning message when GenericOptionsParser is not used
[ https://issues.apache.org/jira/browse/MAPREDUCE-4432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412856#comment-13412856 ] Harsh J commented on MAPREDUCE-4432: Gabriel, Thanks for filing this! I agree we should improve it. Your improvement is much nicer to read and understand as well :) Given that GenericOptionsParser is a non-public API class, and Tool was the real to-be-used class for users, I think we should not suggest GOP at all and rather show the message just with Tool? > Confusing warning message when GenericOptionsParser is not used > --- > > Key: MAPREDUCE-4432 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4432 > Project: Hadoop Map/Reduce > Issue Type: Bug >Reporter: Gabriel Reid >Priority: Trivial > Attachments: MAPREDUCE-4432.patch > > > The warning that is issued in JobSubmitter -- "Use GenericOptionsParser for > parsing the arguments. Applications should implement Tool for the same." -- > is confusing and (probably) grammatically incorrect. > This can be improved by having an updated warning message which gives clearer > directions on what can be improved in the application to avoid the warning in > the future. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
