[jira] [Commented] (MAPREDUCE-4455) RMAppImpl state machine does not handle event ATTEMPT_KILLED at ACCEPTED
[ https://issues.apache.org/jira/browse/MAPREDUCE-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13436249#comment-13436249 ] Hadoop QA commented on MAPREDUCE-4455: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12541263/MAPREDUCE-4455-YARN-trunk-v3.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2746//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2746//console This message is automatically generated. RMAppImpl state machine does not handle event ATTEMPT_KILLED at ACCEPTED Key: MAPREDUCE-4455 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4455 Project: Hadoop Map/Reduce Issue Type: Bug Components: mrv2, resourcemanager Reporter: Jason Lowe Assignee: Mayank Bansal Priority: Minor Attachments: MAPREDUCE-4455-trunk-v1.patch, MAPREDUCE-4455-trunk-v2.patch, MAPREDUCE-4455-YARN-trunk-v2.patch, MAPREDUCE-4455-YARN-trunk-v3.patch TestRMAppTransitions#testAppSubmittedKilled causes an invalid event exception but the test doesn't catch the error since the final app state is still killed. Killed for the wrong reason, but the final state is the same. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4455) RMAppImpl state machine does not handle event ATTEMPT_KILLED at ACCEPTED
[ https://issues.apache.org/jira/browse/MAPREDUCE-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13435483#comment-13435483 ] Hadoop QA commented on MAPREDUCE-4455: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12541112/MAPREDUCE-4455-YARN-trunk-v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2738//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2738//console This message is automatically generated. RMAppImpl state machine does not handle event ATTEMPT_KILLED at ACCEPTED Key: MAPREDUCE-4455 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4455 Project: Hadoop Map/Reduce Issue Type: Bug Components: mrv2, resourcemanager Reporter: Jason Lowe Assignee: Mayank Bansal Priority: Minor Attachments: MAPREDUCE-4455-trunk-v1.patch, MAPREDUCE-4455-trunk-v2.patch, MAPREDUCE-4455-YARN-trunk-v2.patch TestRMAppTransitions#testAppSubmittedKilled causes an invalid event exception but the test doesn't catch the error since the final app state is still killed. Killed for the wrong reason, but the final state is the same. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4455) RMAppImpl state machine does not handle event ATTEMPT_KILLED at ACCEPTED
[ https://issues.apache.org/jira/browse/MAPREDUCE-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13434640#comment-13434640 ] Hadoop QA commented on MAPREDUCE-4455: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12540973/MAPREDUCE-4455-trunk-v2.patch against trunk revision . -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2729//console This message is automatically generated. RMAppImpl state machine does not handle event ATTEMPT_KILLED at ACCEPTED Key: MAPREDUCE-4455 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4455 Project: Hadoop Map/Reduce Issue Type: Bug Components: mrv2, resourcemanager Reporter: Jason Lowe Assignee: Mayank Bansal Priority: Minor Attachments: MAPREDUCE-4455-trunk-v1.patch, MAPREDUCE-4455-trunk-v2.patch TestRMAppTransitions#testAppSubmittedKilled causes an invalid event exception but the test doesn't catch the error since the final app state is still killed. Killed for the wrong reason, but the final state is the same. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4455) RMAppImpl state machine does not handle event ATTEMPT_KILLED at ACCEPTED
[ https://issues.apache.org/jira/browse/MAPREDUCE-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13427748#comment-13427748 ] Hadoop QA commented on MAPREDUCE-4455: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12538971/MAPREDUCE-4455-trunk-v1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. -1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2701//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2701//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2701//console This message is automatically generated. RMAppImpl state machine does not handle event ATTEMPT_KILLED at ACCEPTED Key: MAPREDUCE-4455 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4455 Project: Hadoop Map/Reduce Issue Type: Bug Components: mrv2, resourcemanager Reporter: Jason Lowe Assignee: Mayank Bansal Priority: Minor Fix For: trunk Attachments: MAPREDUCE-4455-trunk-v1.patch TestRMAppTransitions#testAppSubmittedKilled causes an invalid event exception but the test doesn't catch the error since the final app state is still killed. Killed for the wrong reason, but the final state is the same. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4455) RMAppImpl state machine does not handle event ATTEMPT_KILLED at ACCEPTED
[ https://issues.apache.org/jira/browse/MAPREDUCE-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13427759#comment-13427759 ] Mayank Bansal commented on MAPREDUCE-4455: -- These find bug warnings are already addressed in MAPREDUCE-4452 Thanks, Mayank RMAppImpl state machine does not handle event ATTEMPT_KILLED at ACCEPTED Key: MAPREDUCE-4455 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4455 Project: Hadoop Map/Reduce Issue Type: Bug Components: mrv2, resourcemanager Reporter: Jason Lowe Assignee: Mayank Bansal Priority: Minor Fix For: trunk Attachments: MAPREDUCE-4455-trunk-v1.patch TestRMAppTransitions#testAppSubmittedKilled causes an invalid event exception but the test doesn't catch the error since the final app state is still killed. Killed for the wrong reason, but the final state is the same. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4455) RMAppImpl state machine does not handle event ATTEMPT_KILLED at ACCEPTED
[ https://issues.apache.org/jira/browse/MAPREDUCE-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13417628#comment-13417628 ] Jason Lowe commented on MAPREDUCE-4455: --- Output from the test: {noformat} 2012-07-18 19:30:15,528 INFO [main] rmapp.TestRMAppTransitions (TestRMAppTransitions.java:testAppSubmittedKill(363)) - --- START: testAppSubmittedKill--- 2012-07-18 19:30:15,768 INFO [main] resourcetracker.InlineDispatcher (InlineDispatcher.java:dispatch(38)) - Dispatching the event org.apache.hadoop.yarn.server.resourcemanager.rmapp.attempt.RMAppAttemptEvent.EventType: START 2012-07-18 19:30:15,768 INFO [main] rmapp.RMAppImpl (RMAppImpl.java:handle(499)) - application_1342639815540_0001 State change from NEW to SUBMITTED 2012-07-18 19:30:15,769 INFO [main] rmapp.RMAppImpl (RMAppImpl.java:handle(499)) - application_1342639815540_0001 State change from SUBMITTED to ACCEPTED 2012-07-18 19:30:15,769 INFO [main] resourcetracker.InlineDispatcher (InlineDispatcher.java:dispatch(38)) - Dispatching the event org.apache.hadoop.yarn.server.resourcemanager.rmapp.attempt.RMAppAttemptEvent.EventType: KILL 2012-07-18 19:30:15,770 INFO [main] resourcetracker.InlineDispatcher (InlineDispatcher.java:dispatch(38)) - Dispatching the event org.apache.hadoop.yarn.server.resourcemanager.rmapp.RMAppFailedAttemptEvent.EventType: ATTEMPT_KILLED 2012-07-18 19:30:15,773 ERROR [main] rmapp.RMAppImpl (RMAppImpl.java:handle(494)) - Can't handle this event at current state org.apache.hadoop.yarn.state.InvalidStateTransitonException: Invalid event: ATTEMPT_KILLED at ACCEPTED at org.apache.hadoop.yarn.state.StateMachineFactory.doTransition(StateMachineFactory.java:301) at org.apache.hadoop.yarn.state.StateMachineFactory.access$300(StateMachineFactory.java:43) at org.apache.hadoop.yarn.state.StateMachineFactory$InternalStateMachine.doTransition(StateMachineFactory.java:443) at org.apache.hadoop.yarn.server.resourcemanager.rmapp.RMAppImpl.handle(RMAppImpl.java:492) at org.apache.hadoop.yarn.server.resourcemanager.rmapp.RMAppImpl.handle(RMAppImpl.java:70) at org.apache.hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions$TestApplicationEventDispatcher.handle(TestRMAppTransitions.java:103) at org.apache.hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions$TestApplicationEventDispatcher.handle(TestRMAppTransitions.java:89) at org.apache.hadoop.yarn.server.resourcemanager.resourcetracker.InlineDispatcher.dispatch(InlineDispatcher.java:43) at org.apache.hadoop.yarn.server.resourcemanager.resourcetracker.InlineDispatcher$TestEventHandler.handle(InlineDispatcher.java:33) at org.apache.hadoop.yarn.server.resourcemanager.rmapp.attempt.RMAppAttemptImpl$BaseFinalTransition.transition(RMAppAttemptImpl.java:701) at org.apache.hadoop.yarn.server.resourcemanager.rmapp.attempt.RMAppAttemptImpl$BaseFinalTransition.transition(RMAppAttemptImpl.java:651) at org.apache.hadoop.yarn.state.StateMachineFactory$SingleInternalArc.doTransition(StateMachineFactory.java:357) at org.apache.hadoop.yarn.state.StateMachineFactory.doTransition(StateMachineFactory.java:298) at org.apache.hadoop.yarn.state.StateMachineFactory.access$300(StateMachineFactory.java:43) at org.apache.hadoop.yarn.state.StateMachineFactory$InternalStateMachine.doTransition(StateMachineFactory.java:443) at org.apache.hadoop.yarn.server.resourcemanager.rmapp.attempt.RMAppAttemptImpl.handle(RMAppAttemptImpl.java:485) at org.apache.hadoop.yarn.server.resourcemanager.rmapp.attempt.RMAppAttemptImpl.handle(RMAppAttemptImpl.java:80) at org.apache.hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions$TestApplicationAttemptEventDispatcher.handle(TestRMAppTransitions.java:79) at org.apache.hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions$TestApplicationAttemptEventDispatcher.handle(TestRMAppTransitions.java:65) at org.apache.hadoop.yarn.server.resourcemanager.resourcetracker.InlineDispatcher.dispatch(InlineDispatcher.java:43) at org.apache.hadoop.yarn.server.resourcemanager.resourcetracker.InlineDispatcher$TestEventHandler.handle(InlineDispatcher.java:33) at org.apache.hadoop.yarn.server.resourcemanager.rmapp.RMAppImpl$KillAppAndAttemptTransition.transition(RMAppImpl.java:563) at org.apache.hadoop.yarn.server.resourcemanager.rmapp.RMAppImpl$KillAppAndAttemptTransition.transition(RMAppImpl.java:559) at org.apache.hadoop.yarn.state.StateMachineFactory$SingleInternalArc.doTransition(StateMachineFactory.java:357) at org.apache.hadoop.yarn.state.StateMachineFactory.doTransition(StateMachineFactory.java:298) at org.apache.hadoop.yarn.state.StateMachineFactory.access$300(StateMachineFactory.java:43) at