[jira] [Commented] (MAPREDUCE-4879) TeraOutputFormat may overwrite an existing output directory
[ https://issues.apache.org/jira/browse/MAPREDUCE-4879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14245891#comment-14245891 ] Hudson commented on MAPREDUCE-4879: --- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #41 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/41/]) MAPREDUCE-4879. TeraOutputFormat may overwrite an existing output directory. (gera) (gera: rev 25a04402389dce0222938df4375d4545f8c1f34f) * hadoop-mapreduce-project/CHANGES.txt * hadoop-mapreduce-project/hadoop-mapreduce-examples/src/test/java/org/apache/hadoop/examples/terasort/TestTeraSort.java * hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraOutputFormat.java * hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraGen.java TeraOutputFormat may overwrite an existing output directory --- Key: MAPREDUCE-4879 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4879 Project: Hadoop Map/Reduce Issue Type: Bug Components: examples Affects Versions: 1.2.1, 2.6.0 Reporter: Gera Shegalov Assignee: Gera Shegalov Fix For: 2.7.0 Attachments: MAPREDUCE-4879-trunk-rev1.patch, MAPREDUCE-4879-trunk.patch, MAPREDUCE-4879.003.patch, MAPREDUCE-4879.004.patch Unlike FileOutputFormat, TeraOutputFormat does not prevent TeraGen/Sort jobs from writing into an existing directory, and potentially overwriting previous runs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-4879) TeraOutputFormat may overwrite an existing output directory
[ https://issues.apache.org/jira/browse/MAPREDUCE-4879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14245895#comment-14245895 ] Hudson commented on MAPREDUCE-4879: --- SUCCESS: Integrated in Hadoop-Yarn-trunk #775 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/775/]) MAPREDUCE-4879. TeraOutputFormat may overwrite an existing output directory. (gera) (gera: rev 25a04402389dce0222938df4375d4545f8c1f34f) * hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraOutputFormat.java * hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraGen.java * hadoop-mapreduce-project/hadoop-mapreduce-examples/src/test/java/org/apache/hadoop/examples/terasort/TestTeraSort.java * hadoop-mapreduce-project/CHANGES.txt TeraOutputFormat may overwrite an existing output directory --- Key: MAPREDUCE-4879 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4879 Project: Hadoop Map/Reduce Issue Type: Bug Components: examples Affects Versions: 1.2.1, 2.6.0 Reporter: Gera Shegalov Assignee: Gera Shegalov Fix For: 2.7.0 Attachments: MAPREDUCE-4879-trunk-rev1.patch, MAPREDUCE-4879-trunk.patch, MAPREDUCE-4879.003.patch, MAPREDUCE-4879.004.patch Unlike FileOutputFormat, TeraOutputFormat does not prevent TeraGen/Sort jobs from writing into an existing directory, and potentially overwriting previous runs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-4879) TeraOutputFormat may overwrite an existing output directory
[ https://issues.apache.org/jira/browse/MAPREDUCE-4879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14245925#comment-14245925 ] Hudson commented on MAPREDUCE-4879: --- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #38 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/38/]) MAPREDUCE-4879. TeraOutputFormat may overwrite an existing output directory. (gera) (gera: rev 25a04402389dce0222938df4375d4545f8c1f34f) * hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraOutputFormat.java * hadoop-mapreduce-project/hadoop-mapreduce-examples/src/test/java/org/apache/hadoop/examples/terasort/TestTeraSort.java * hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraGen.java * hadoop-mapreduce-project/CHANGES.txt TeraOutputFormat may overwrite an existing output directory --- Key: MAPREDUCE-4879 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4879 Project: Hadoop Map/Reduce Issue Type: Bug Components: examples Affects Versions: 1.2.1, 2.6.0 Reporter: Gera Shegalov Assignee: Gera Shegalov Fix For: 2.7.0 Attachments: MAPREDUCE-4879-trunk-rev1.patch, MAPREDUCE-4879-trunk.patch, MAPREDUCE-4879.003.patch, MAPREDUCE-4879.004.patch Unlike FileOutputFormat, TeraOutputFormat does not prevent TeraGen/Sort jobs from writing into an existing directory, and potentially overwriting previous runs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-4879) TeraOutputFormat may overwrite an existing output directory
[ https://issues.apache.org/jira/browse/MAPREDUCE-4879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14245927#comment-14245927 ] Hudson commented on MAPREDUCE-4879: --- SUCCESS: Integrated in Hadoop-Hdfs-trunk #1973 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1973/]) MAPREDUCE-4879. TeraOutputFormat may overwrite an existing output directory. (gera) (gera: rev 25a04402389dce0222938df4375d4545f8c1f34f) * hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraGen.java * hadoop-mapreduce-project/hadoop-mapreduce-examples/src/test/java/org/apache/hadoop/examples/terasort/TestTeraSort.java * hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraOutputFormat.java * hadoop-mapreduce-project/CHANGES.txt TeraOutputFormat may overwrite an existing output directory --- Key: MAPREDUCE-4879 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4879 Project: Hadoop Map/Reduce Issue Type: Bug Components: examples Affects Versions: 1.2.1, 2.6.0 Reporter: Gera Shegalov Assignee: Gera Shegalov Fix For: 2.7.0 Attachments: MAPREDUCE-4879-trunk-rev1.patch, MAPREDUCE-4879-trunk.patch, MAPREDUCE-4879.003.patch, MAPREDUCE-4879.004.patch Unlike FileOutputFormat, TeraOutputFormat does not prevent TeraGen/Sort jobs from writing into an existing directory, and potentially overwriting previous runs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-4879) TeraOutputFormat may overwrite an existing output directory
[ https://issues.apache.org/jira/browse/MAPREDUCE-4879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14245936#comment-14245936 ] Hudson commented on MAPREDUCE-4879: --- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #42 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/42/]) MAPREDUCE-4879. TeraOutputFormat may overwrite an existing output directory. (gera) (gera: rev 25a04402389dce0222938df4375d4545f8c1f34f) * hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraGen.java * hadoop-mapreduce-project/CHANGES.txt * hadoop-mapreduce-project/hadoop-mapreduce-examples/src/test/java/org/apache/hadoop/examples/terasort/TestTeraSort.java * hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraOutputFormat.java TeraOutputFormat may overwrite an existing output directory --- Key: MAPREDUCE-4879 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4879 Project: Hadoop Map/Reduce Issue Type: Bug Components: examples Affects Versions: 1.2.1, 2.6.0 Reporter: Gera Shegalov Assignee: Gera Shegalov Fix For: 2.7.0 Attachments: MAPREDUCE-4879-trunk-rev1.patch, MAPREDUCE-4879-trunk.patch, MAPREDUCE-4879.003.patch, MAPREDUCE-4879.004.patch Unlike FileOutputFormat, TeraOutputFormat does not prevent TeraGen/Sort jobs from writing into an existing directory, and potentially overwriting previous runs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-4879) TeraOutputFormat may overwrite an existing output directory
[ https://issues.apache.org/jira/browse/MAPREDUCE-4879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14245943#comment-14245943 ] Hudson commented on MAPREDUCE-4879: --- FAILURE: Integrated in Hadoop-Mapreduce-trunk #1992 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1992/]) MAPREDUCE-4879. TeraOutputFormat may overwrite an existing output directory. (gera) (gera: rev 25a04402389dce0222938df4375d4545f8c1f34f) * hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraOutputFormat.java * hadoop-mapreduce-project/hadoop-mapreduce-examples/src/test/java/org/apache/hadoop/examples/terasort/TestTeraSort.java * hadoop-mapreduce-project/CHANGES.txt * hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraGen.java TeraOutputFormat may overwrite an existing output directory --- Key: MAPREDUCE-4879 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4879 Project: Hadoop Map/Reduce Issue Type: Bug Components: examples Affects Versions: 1.2.1, 2.6.0 Reporter: Gera Shegalov Assignee: Gera Shegalov Fix For: 2.7.0 Attachments: MAPREDUCE-4879-trunk-rev1.patch, MAPREDUCE-4879-trunk.patch, MAPREDUCE-4879.003.patch, MAPREDUCE-4879.004.patch Unlike FileOutputFormat, TeraOutputFormat does not prevent TeraGen/Sort jobs from writing into an existing directory, and potentially overwriting previous runs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-4879) TeraOutputFormat may overwrite an existing output directory
[ https://issues.apache.org/jira/browse/MAPREDUCE-4879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14245781#comment-14245781 ] Hudson commented on MAPREDUCE-4879: --- FAILURE: Integrated in Hadoop-trunk-Commit #6715 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/6715/]) MAPREDUCE-4879. TeraOutputFormat may overwrite an existing output directory. (gera) (gera: rev 25a04402389dce0222938df4375d4545f8c1f34f) * hadoop-mapreduce-project/CHANGES.txt * hadoop-mapreduce-project/hadoop-mapreduce-examples/src/test/java/org/apache/hadoop/examples/terasort/TestTeraSort.java * hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraGen.java * hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraOutputFormat.java TeraOutputFormat may overwrite an existing output directory --- Key: MAPREDUCE-4879 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4879 Project: Hadoop Map/Reduce Issue Type: Bug Components: examples Affects Versions: 1.2.1, 2.6.0 Reporter: Gera Shegalov Assignee: Gera Shegalov Fix For: 2.7.0 Attachments: MAPREDUCE-4879-trunk-rev1.patch, MAPREDUCE-4879-trunk.patch, MAPREDUCE-4879.003.patch, MAPREDUCE-4879.004.patch Unlike FileOutputFormat, TeraOutputFormat does not prevent TeraGen/Sort jobs from writing into an existing directory, and potentially overwriting previous runs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-4879) TeraOutputFormat may overwrite an existing output directory
[
https://issues.apache.org/jira/browse/MAPREDUCE-4879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14244708#comment-14244708
]
Hadoop QA commented on MAPREDUCE-4879:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12686922/MAPREDUCE-4879.003.patch
against trunk revision 3681de2.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:red}-1 javac{color}. The applied patch generated 1222 javac
compiler warnings (more than the trunk's current 1221 warnings).
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-examples.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5077//testReport/
Javac warnings:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5077//artifact/patchprocess/diffJavacWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5077//console
This message is automatically generated.
TeraOutputFormat may overwrite an existing output directory
---
Key: MAPREDUCE-4879
URL: https://issues.apache.org/jira/browse/MAPREDUCE-4879
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: examples
Affects Versions: 1.2.1, 2.6.0
Reporter: Gera Shegalov
Assignee: Gera Shegalov
Attachments: MAPREDUCE-4879-trunk-rev1.patch,
MAPREDUCE-4879-trunk.patch, MAPREDUCE-4879.003.patch
Unlike FileOutputFormat, TeraOutputFormat does not prevent TeraGen/Sort jobs
from writing into an existing directory, and potentially overwriting previous
runs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-4879) TeraOutputFormat may overwrite an existing output directory
[
https://issues.apache.org/jira/browse/MAPREDUCE-4879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14245131#comment-14245131
]
Hadoop QA commented on MAPREDUCE-4879:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12687005/MAPREDUCE-4879.004.patch
against trunk revision 0e37bbc.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-examples.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5078//testReport/
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5078//console
This message is automatically generated.
TeraOutputFormat may overwrite an existing output directory
---
Key: MAPREDUCE-4879
URL: https://issues.apache.org/jira/browse/MAPREDUCE-4879
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: examples
Affects Versions: 1.2.1, 2.6.0
Reporter: Gera Shegalov
Assignee: Gera Shegalov
Attachments: MAPREDUCE-4879-trunk-rev1.patch,
MAPREDUCE-4879-trunk.patch, MAPREDUCE-4879.003.patch, MAPREDUCE-4879.004.patch
Unlike FileOutputFormat, TeraOutputFormat does not prevent TeraGen/Sort jobs
from writing into an existing directory, and potentially overwriting previous
runs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-4879) TeraOutputFormat may overwrite an existing output directory
[
https://issues.apache.org/jira/browse/MAPREDUCE-4879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14242927#comment-14242927
]
Chris Nauroth commented on MAPREDUCE-4879:
--
Hi, [~jira.shegalov]. This looks good. Could you please throw
{{FileAlreadyExistsException}} instead of {{IOException}}? That would exactly
match the behavior of {{FileOutputFormat}} when it checks the output directory.
Thanks!
TeraOutputFormat may overwrite an existing output directory
---
Key: MAPREDUCE-4879
URL: https://issues.apache.org/jira/browse/MAPREDUCE-4879
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: examples
Affects Versions: trunk
Reporter: Gera Shegalov
Assignee: Gera Shegalov
Attachments: MAPREDUCE-4879-trunk-rev1.patch,
MAPREDUCE-4879-trunk.patch
Unlike FileOutputFormat, TeraOutputFormat does not prevent TeraGen/Sort jobs
from writing into an existing directory, and potentially overwriting previous
runs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-4879) TeraOutputFormat may overwrite an existing output directory
[ https://issues.apache.org/jira/browse/MAPREDUCE-4879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13625123#comment-13625123 ] Gelesh commented on MAPREDUCE-4879: --- [~jira.shegalov] Since TeraOutputFormat extends FileOutputFormat, it must be in compliance with checkOutputSpecs(), of FileOutputFormat. And checkOutputSpecs() is supposed to be called from Job Client. If there is any issue, I feel it would be better to fix it within the existing control flow. TeraOutputFormat may overwrite an existing output directory --- Key: MAPREDUCE-4879 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4879 Project: Hadoop Map/Reduce Issue Type: Bug Components: examples Affects Versions: trunk Reporter: Gera Shegalov Attachments: MAPREDUCE-4879-trunk.patch, MAPREDUCE-4879-trunk-rev1.patch Unlike FileOutputFormat, TeraOutputFormat does not prevent TeraGen/Sort jobs from writing into an existing directory, and potentially overwriting previous runs. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4879) TeraOutputFormat may overwrite an existing output directory
[ https://issues.apache.org/jira/browse/MAPREDUCE-4879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13625124#comment-13625124 ] Gelesh commented on MAPREDUCE-4879: --- Could you please , post the same over review board, so that we could get a better insight about the code change. TeraOutputFormat may overwrite an existing output directory --- Key: MAPREDUCE-4879 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4879 Project: Hadoop Map/Reduce Issue Type: Bug Components: examples Affects Versions: trunk Reporter: Gera Shegalov Attachments: MAPREDUCE-4879-trunk.patch, MAPREDUCE-4879-trunk-rev1.patch Unlike FileOutputFormat, TeraOutputFormat does not prevent TeraGen/Sort jobs from writing into an existing directory, and potentially overwriting previous runs. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
