[jira] [Commented] (MAPREDUCE-4942) mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13678119#comment-13678119 ] Alejandro Abdelnur commented on MAPREDUCE-4942: --- [~jlowe], MAPREDUCE-5281 MAPREDUCE-5284 have been resolved as won't fix. [~acmurthy], can we re-resolve this one as fixed or do you still have reservations? mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1 - Key: MAPREDUCE-4942 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4942 Project: Hadoop Map/Reduce Issue Type: Sub-task Components: mrv2 Affects Versions: 2.0.2-alpha Reporter: Robert Kanter Assignee: Robert Kanter Fix For: 2.1.0-beta Attachments: MAPREDUCE-4942.patch The following methods in MR2's {{org.apache.hadoop.mapreduce.Job}} throw an {{InterruptedException}} but don't in MR1, which makes them incompatible. (Their Javadoc comments are also missing that they throw an {{InterruptedException}} anyway) I propose that we wrap the {{InterruptedException}} in a {{RuntimeException}}. {code} public float setupProgress() throws IOException, InterruptedException public float mapProgress() throws IOException, InterruptedException public float reduceProgress() throws IOException, InterruptedException public boolean isComplete() throws IOException, InterruptedException public boolean isSuccessful() throws IOException, InterruptedException public void killJob() throws IOException, InterruptedException public void killTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public void failTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public Counters getCounters() throws IOException, InterruptedException {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4942) mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13677091#comment-13677091 ] Jason Lowe commented on MAPREDUCE-4942: --- From a 0.23 perspective, this shouldn't be a big deal in practice because it doesn't break binary compatibility and it's very straightforward to fix the source incompatibility for a recompile. Basically it comes down to this: the more we break the compatibility path from 0.23 to 2.x, the longer it will take users of 0.23 to move to 2.x. Some changes, such as this, will probably have a minimal impact, where other proposed changes, such as MAPREDUCE-5281 and MAPREDUCE-5284 would have a major impact. mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1 - Key: MAPREDUCE-4942 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4942 Project: Hadoop Map/Reduce Issue Type: Sub-task Components: mrv2 Affects Versions: 2.0.2-alpha Reporter: Robert Kanter Assignee: Robert Kanter Fix For: 2.1.0-beta Attachments: MAPREDUCE-4942.patch The following methods in MR2's {{org.apache.hadoop.mapreduce.Job}} throw an {{InterruptedException}} but don't in MR1, which makes them incompatible. (Their Javadoc comments are also missing that they throw an {{InterruptedException}} anyway) I propose that we wrap the {{InterruptedException}} in a {{RuntimeException}}. {code} public float setupProgress() throws IOException, InterruptedException public float mapProgress() throws IOException, InterruptedException public float reduceProgress() throws IOException, InterruptedException public boolean isComplete() throws IOException, InterruptedException public boolean isSuccessful() throws IOException, InterruptedException public void killJob() throws IOException, InterruptedException public void killTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public void failTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public Counters getCounters() throws IOException, InterruptedException {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4942) mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13676197#comment-13676197 ] Alejandro Abdelnur commented on MAPREDUCE-4942: --- [~zjshen], thanks for tracking this down, created MAPREDUCE-5304 to fix it. mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1 - Key: MAPREDUCE-4942 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4942 Project: Hadoop Map/Reduce Issue Type: Sub-task Components: mrv2 Affects Versions: 2.0.2-alpha Reporter: Robert Kanter Assignee: Robert Kanter Fix For: 2.1.0-beta Attachments: MAPREDUCE-4942.patch The following methods in MR2's {{org.apache.hadoop.mapreduce.Job}} throw an {{InterruptedException}} but don't in MR1, which makes them incompatible. (Their Javadoc comments are also missing that they throw an {{InterruptedException}} anyway) I propose that we wrap the {{InterruptedException}} in a {{RuntimeException}}. {code} public float setupProgress() throws IOException, InterruptedException public float mapProgress() throws IOException, InterruptedException public float reduceProgress() throws IOException, InterruptedException public boolean isComplete() throws IOException, InterruptedException public boolean isSuccessful() throws IOException, InterruptedException public void killJob() throws IOException, InterruptedException public void killTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public void failTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public Counters getCounters() throws IOException, InterruptedException {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4942) mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13673667#comment-13673667 ] Zhijie Shen commented on MAPREDUCE-4942: Just found three more methods that have to break either MR1 or 0.23 binary compatibility. * boolean failTask(TaskAttemptID): Change in return type from void to boolean. * boolean killTask(TaskAttemptID): Change in return type from void to boolean. * TaskCompletionEvent[] getTaskCompletionEvents(int): Change in return type from org.apache.hadoop.mapred.TaskCompletionEvent[] to org.apache.hadoop.mapreduce.TaskCompletionEvent[]. mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1 - Key: MAPREDUCE-4942 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4942 Project: Hadoop Map/Reduce Issue Type: Sub-task Components: mrv2 Affects Versions: 2.0.2-alpha Reporter: Robert Kanter Assignee: Robert Kanter Fix For: 2.1.0-beta Attachments: MAPREDUCE-4942.patch The following methods in MR2's {{org.apache.hadoop.mapreduce.Job}} throw an {{InterruptedException}} but don't in MR1, which makes them incompatible. (Their Javadoc comments are also missing that they throw an {{InterruptedException}} anyway) I propose that we wrap the {{InterruptedException}} in a {{RuntimeException}}. {code} public float setupProgress() throws IOException, InterruptedException public float mapProgress() throws IOException, InterruptedException public float reduceProgress() throws IOException, InterruptedException public boolean isComplete() throws IOException, InterruptedException public boolean isSuccessful() throws IOException, InterruptedException public void killJob() throws IOException, InterruptedException public void killTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public void failTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public Counters getCounters() throws IOException, InterruptedException {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4942) mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13664539#comment-13664539 ] Arun C Murthy commented on MAPREDUCE-4942: -- I assume we are in agreement. I'll revert this end of the week unless someone beats me to it, [~tucu00]? Thanks. mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1 - Key: MAPREDUCE-4942 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4942 Project: Hadoop Map/Reduce Issue Type: Sub-task Components: mrv2 Affects Versions: 2.0.2-alpha Reporter: Robert Kanter Assignee: Robert Kanter Fix For: 2.0.5-beta Attachments: MAPREDUCE-4942.patch The following methods in MR2's {{org.apache.hadoop.mapreduce.Job}} throw an {{InterruptedException}} but don't in MR1, which makes them incompatible. (Their Javadoc comments are also missing that they throw an {{InterruptedException}} anyway) I propose that we wrap the {{InterruptedException}} in a {{RuntimeException}}. {code} public float setupProgress() throws IOException, InterruptedException public float mapProgress() throws IOException, InterruptedException public float reduceProgress() throws IOException, InterruptedException public boolean isComplete() throws IOException, InterruptedException public boolean isSuccessful() throws IOException, InterruptedException public void killJob() throws IOException, InterruptedException public void killTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public void failTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public Counters getCounters() throws IOException, InterruptedException {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4942) mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13664571#comment-13664571 ] Alejandro Abdelnur commented on MAPREDUCE-4942: --- [~acmurthy], AFAIK what we were saying regarding compatibility between Hadoop 1 and Hadoop 2 is: * applications written using Hadoop 1 mapred API are binary compatible. * applications written using Hadoop 1 mapreduce API are source compatible (required only recompilation). Without this patch, the second bullet item does not hold. IMO, we screwed up and we don't have clean way out. I understand keeping this patch impacts early adopters of YARN, and I'm not happy about it. Still, I think we have to consider how this affects the whole Hadoop user base and make a decision towards their interest. Because of this, I think we should keep this patch not to break people moving from Hadoop 1 to Hadoop 2. mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1 - Key: MAPREDUCE-4942 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4942 Project: Hadoop Map/Reduce Issue Type: Sub-task Components: mrv2 Affects Versions: 2.0.2-alpha Reporter: Robert Kanter Assignee: Robert Kanter Fix For: 2.0.5-beta Attachments: MAPREDUCE-4942.patch The following methods in MR2's {{org.apache.hadoop.mapreduce.Job}} throw an {{InterruptedException}} but don't in MR1, which makes them incompatible. (Their Javadoc comments are also missing that they throw an {{InterruptedException}} anyway) I propose that we wrap the {{InterruptedException}} in a {{RuntimeException}}. {code} public float setupProgress() throws IOException, InterruptedException public float mapProgress() throws IOException, InterruptedException public float reduceProgress() throws IOException, InterruptedException public boolean isComplete() throws IOException, InterruptedException public boolean isSuccessful() throws IOException, InterruptedException public void killJob() throws IOException, InterruptedException public void killTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public void failTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public Counters getCounters() throws IOException, InterruptedException {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4942) mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13664678#comment-13664678 ] Alejandro Abdelnur commented on MAPREDUCE-4942: --- And we are already 'breaking things' for 0.23, MAPREDUCE-5233. mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1 - Key: MAPREDUCE-4942 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4942 Project: Hadoop Map/Reduce Issue Type: Sub-task Components: mrv2 Affects Versions: 2.0.2-alpha Reporter: Robert Kanter Assignee: Robert Kanter Fix For: 2.0.5-beta Attachments: MAPREDUCE-4942.patch The following methods in MR2's {{org.apache.hadoop.mapreduce.Job}} throw an {{InterruptedException}} but don't in MR1, which makes them incompatible. (Their Javadoc comments are also missing that they throw an {{InterruptedException}} anyway) I propose that we wrap the {{InterruptedException}} in a {{RuntimeException}}. {code} public float setupProgress() throws IOException, InterruptedException public float mapProgress() throws IOException, InterruptedException public float reduceProgress() throws IOException, InterruptedException public boolean isComplete() throws IOException, InterruptedException public boolean isSuccessful() throws IOException, InterruptedException public void killJob() throws IOException, InterruptedException public void killTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public void failTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public Counters getCounters() throws IOException, InterruptedException {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4942) mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13664686#comment-13664686 ] Vinod Kumar Vavilapalli commented on MAPREDUCE-4942: bq. And we are already 'breaking things' for 0.23, MAPREDUCE-5233. Not sure about this particular JIRA anyways given it is focusing on mapreduce.Job and so far I/we have focused extensively on mapred APIs. And MAPREDUCE-5233 (among others) is related to mapred APIs. I've added folks from Y!(who the only ones mostly looking at 0.23 compatibility) to all those JIRAs which I saw to be breaking 0.23. We are looking at it on a case-by-case basis. mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1 - Key: MAPREDUCE-4942 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4942 Project: Hadoop Map/Reduce Issue Type: Sub-task Components: mrv2 Affects Versions: 2.0.2-alpha Reporter: Robert Kanter Assignee: Robert Kanter Fix For: 2.0.5-beta Attachments: MAPREDUCE-4942.patch The following methods in MR2's {{org.apache.hadoop.mapreduce.Job}} throw an {{InterruptedException}} but don't in MR1, which makes them incompatible. (Their Javadoc comments are also missing that they throw an {{InterruptedException}} anyway) I propose that we wrap the {{InterruptedException}} in a {{RuntimeException}}. {code} public float setupProgress() throws IOException, InterruptedException public float mapProgress() throws IOException, InterruptedException public float reduceProgress() throws IOException, InterruptedException public boolean isComplete() throws IOException, InterruptedException public boolean isSuccessful() throws IOException, InterruptedException public void killJob() throws IOException, InterruptedException public void killTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public void failTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public Counters getCounters() throws IOException, InterruptedException {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4942) mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13664712#comment-13664712 ] Alejandro Abdelnur commented on MAPREDUCE-4942: --- I think it is important we are consistent on this, it would be quite confusing we have different rules for the different API sets. mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1 - Key: MAPREDUCE-4942 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4942 Project: Hadoop Map/Reduce Issue Type: Sub-task Components: mrv2 Affects Versions: 2.0.2-alpha Reporter: Robert Kanter Assignee: Robert Kanter Fix For: 2.0.5-beta Attachments: MAPREDUCE-4942.patch The following methods in MR2's {{org.apache.hadoop.mapreduce.Job}} throw an {{InterruptedException}} but don't in MR1, which makes them incompatible. (Their Javadoc comments are also missing that they throw an {{InterruptedException}} anyway) I propose that we wrap the {{InterruptedException}} in a {{RuntimeException}}. {code} public float setupProgress() throws IOException, InterruptedException public float mapProgress() throws IOException, InterruptedException public float reduceProgress() throws IOException, InterruptedException public boolean isComplete() throws IOException, InterruptedException public boolean isSuccessful() throws IOException, InterruptedException public void killJob() throws IOException, InterruptedException public void killTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public void failTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public Counters getCounters() throws IOException, InterruptedException {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4942) mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13656106#comment-13656106 ] Alejandro Abdelnur commented on MAPREDUCE-4942: --- Arun, this is then a catch22. If we don't fix it, we are breaking Hadoop 1 users moving to Hadoop 2. I guess we'll have have to decide what is more important, to keep compatibility with Hadoop 1 or Hadoop 0.23. Y! folks may not be happy with the following, but given the adoption of Hadoop 1 and Hadoop 0.23, we should incline to Hadoop 1. Thoughts? mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1 - Key: MAPREDUCE-4942 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4942 Project: Hadoop Map/Reduce Issue Type: Bug Components: mrv2 Affects Versions: 2.0.2-alpha Reporter: Robert Kanter Assignee: Robert Kanter Fix For: 2.0.5-beta Attachments: MAPREDUCE-4942.patch The following methods in MR2's {{org.apache.hadoop.mapreduce.Job}} throw an {{InterruptedException}} but don't in MR1, which makes them incompatible. (Their Javadoc comments are also missing that they throw an {{InterruptedException}} anyway) I propose that we wrap the {{InterruptedException}} in a {{RuntimeException}}. {code} public float setupProgress() throws IOException, InterruptedException public float mapProgress() throws IOException, InterruptedException public float reduceProgress() throws IOException, InterruptedException public boolean isComplete() throws IOException, InterruptedException public boolean isSuccessful() throws IOException, InterruptedException public void killJob() throws IOException, InterruptedException public void killTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public void failTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public Counters getCounters() throws IOException, InterruptedException {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4942) mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13656278#comment-13656278 ] Robert Joseph Evans commented on MAPREDUCE-4942: This is one of the odd places where the code is binary compatible but not source compatible. 0.23 binaries should run against the 2.0 API, but they are likely to not compile against the changed API unless they are catching Exception :). I can see your reasoning about wanting to maintain compatibility with 1.0, we got so much flack from asking everyone to recompile that we are not going to be able to do it again for a long time. Because of that I personally am against putting in any changes that are incompatible with 0.23. If we do it will either delay Yahoo adopting 2.0 significantly or it will force us to fork until we can build up enough good will that we can risk asking everyone to recompile again. I am not going to -1 this because I don't think that is good for the community, but it will mean that Yahoo! is not going to be able to run on stock 2.0 for a while. mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1 - Key: MAPREDUCE-4942 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4942 Project: Hadoop Map/Reduce Issue Type: Sub-task Components: mrv2 Affects Versions: 2.0.2-alpha Reporter: Robert Kanter Assignee: Robert Kanter Fix For: 2.0.5-beta Attachments: MAPREDUCE-4942.patch The following methods in MR2's {{org.apache.hadoop.mapreduce.Job}} throw an {{InterruptedException}} but don't in MR1, which makes them incompatible. (Their Javadoc comments are also missing that they throw an {{InterruptedException}} anyway) I propose that we wrap the {{InterruptedException}} in a {{RuntimeException}}. {code} public float setupProgress() throws IOException, InterruptedException public float mapProgress() throws IOException, InterruptedException public float reduceProgress() throws IOException, InterruptedException public boolean isComplete() throws IOException, InterruptedException public boolean isSuccessful() throws IOException, InterruptedException public void killJob() throws IOException, InterruptedException public void killTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public void failTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public Counters getCounters() throws IOException, InterruptedException {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4942) mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13656340#comment-13656340 ] Arun C Murthy commented on MAPREDUCE-4942: -- [~tucu00] Unfortunately, as we have talked about, it's well beyond a point where we can support compatibility for o.a.h.mapreduce vis-a-vis MR1. Too much water down the pipe with MAPREDUCE-777 etc. Given that, I'd rather make it easy for Yahoo and other early adopters of YARN. Makes sense? mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1 - Key: MAPREDUCE-4942 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4942 Project: Hadoop Map/Reduce Issue Type: Sub-task Components: mrv2 Affects Versions: 2.0.2-alpha Reporter: Robert Kanter Assignee: Robert Kanter Fix For: 2.0.5-beta Attachments: MAPREDUCE-4942.patch The following methods in MR2's {{org.apache.hadoop.mapreduce.Job}} throw an {{InterruptedException}} but don't in MR1, which makes them incompatible. (Their Javadoc comments are also missing that they throw an {{InterruptedException}} anyway) I propose that we wrap the {{InterruptedException}} in a {{RuntimeException}}. {code} public float setupProgress() throws IOException, InterruptedException public float mapProgress() throws IOException, InterruptedException public float reduceProgress() throws IOException, InterruptedException public boolean isComplete() throws IOException, InterruptedException public boolean isSuccessful() throws IOException, InterruptedException public void killJob() throws IOException, InterruptedException public void killTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public void failTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public Counters getCounters() throws IOException, InterruptedException {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4942) mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13654362#comment-13654362 ] Hudson commented on MAPREDUCE-4942: --- Integrated in Hadoop-Yarn-trunk #205 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/205/]) MAPREDUCE-4942. mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1. (rkanter via tucu) (Revision 1480748) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1480748 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/Job.java * /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/test/java/org/apache/hadoop/mapred/gridmix/TestGridmixSummary.java mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1 - Key: MAPREDUCE-4942 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4942 Project: Hadoop Map/Reduce Issue Type: Bug Components: mrv2 Affects Versions: 2.0.2-alpha Reporter: Robert Kanter Assignee: Robert Kanter Fix For: 2.0.5-beta Attachments: MAPREDUCE-4942.patch The following methods in MR2's {{org.apache.hadoop.mapreduce.Job}} throw an {{InterruptedException}} but don't in MR1, which makes them incompatible. (Their Javadoc comments are also missing that they throw an {{InterruptedException}} anyway) I propose that we wrap the {{InterruptedException}} in a {{RuntimeException}}. {code} public float setupProgress() throws IOException, InterruptedException public float mapProgress() throws IOException, InterruptedException public float reduceProgress() throws IOException, InterruptedException public boolean isComplete() throws IOException, InterruptedException public boolean isSuccessful() throws IOException, InterruptedException public void killJob() throws IOException, InterruptedException public void killTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public void failTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public Counters getCounters() throws IOException, InterruptedException {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4942) mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13654447#comment-13654447 ] Hudson commented on MAPREDUCE-4942: --- Integrated in Hadoop-Hdfs-trunk #1394 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1394/]) MAPREDUCE-4942. mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1. (rkanter via tucu) (Revision 1480748) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1480748 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/Job.java * /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/test/java/org/apache/hadoop/mapred/gridmix/TestGridmixSummary.java mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1 - Key: MAPREDUCE-4942 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4942 Project: Hadoop Map/Reduce Issue Type: Bug Components: mrv2 Affects Versions: 2.0.2-alpha Reporter: Robert Kanter Assignee: Robert Kanter Fix For: 2.0.5-beta Attachments: MAPREDUCE-4942.patch The following methods in MR2's {{org.apache.hadoop.mapreduce.Job}} throw an {{InterruptedException}} but don't in MR1, which makes them incompatible. (Their Javadoc comments are also missing that they throw an {{InterruptedException}} anyway) I propose that we wrap the {{InterruptedException}} in a {{RuntimeException}}. {code} public float setupProgress() throws IOException, InterruptedException public float mapProgress() throws IOException, InterruptedException public float reduceProgress() throws IOException, InterruptedException public boolean isComplete() throws IOException, InterruptedException public boolean isSuccessful() throws IOException, InterruptedException public void killJob() throws IOException, InterruptedException public void killTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public void failTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public Counters getCounters() throws IOException, InterruptedException {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4942) mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13654491#comment-13654491 ] Hudson commented on MAPREDUCE-4942: --- Integrated in Hadoop-Mapreduce-trunk #1421 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1421/]) MAPREDUCE-4942. mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1. (rkanter via tucu) (Revision 1480748) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1480748 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/Job.java * /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/test/java/org/apache/hadoop/mapred/gridmix/TestGridmixSummary.java mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1 - Key: MAPREDUCE-4942 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4942 Project: Hadoop Map/Reduce Issue Type: Bug Components: mrv2 Affects Versions: 2.0.2-alpha Reporter: Robert Kanter Assignee: Robert Kanter Fix For: 2.0.5-beta Attachments: MAPREDUCE-4942.patch The following methods in MR2's {{org.apache.hadoop.mapreduce.Job}} throw an {{InterruptedException}} but don't in MR1, which makes them incompatible. (Their Javadoc comments are also missing that they throw an {{InterruptedException}} anyway) I propose that we wrap the {{InterruptedException}} in a {{RuntimeException}}. {code} public float setupProgress() throws IOException, InterruptedException public float mapProgress() throws IOException, InterruptedException public float reduceProgress() throws IOException, InterruptedException public boolean isComplete() throws IOException, InterruptedException public boolean isSuccessful() throws IOException, InterruptedException public void killJob() throws IOException, InterruptedException public void killTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public void failTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public Counters getCounters() throws IOException, InterruptedException {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4942) mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13653113#comment-13653113 ] Alejandro Abdelnur commented on MAPREDUCE-4942: --- +1 mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1 - Key: MAPREDUCE-4942 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4942 Project: Hadoop Map/Reduce Issue Type: Bug Components: mrv2 Affects Versions: 2.0.2-alpha Reporter: Robert Kanter Assignee: Robert Kanter Attachments: MAPREDUCE-4942.patch The following methods in MR2's {{org.apache.hadoop.mapreduce.Job}} throw an {{InterruptedException}} but don't in MR1, which makes them incompatible. (Their Javadoc comments are also missing that they throw an {{InterruptedException}} anyway) I propose that we wrap the {{InterruptedException}} in a {{RuntimeException}}. {code} public float setupProgress() throws IOException, InterruptedException public float mapProgress() throws IOException, InterruptedException public float reduceProgress() throws IOException, InterruptedException public boolean isComplete() throws IOException, InterruptedException public boolean isSuccessful() throws IOException, InterruptedException public void killJob() throws IOException, InterruptedException public void killTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public void failTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public Counters getCounters() throws IOException, InterruptedException {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4942) mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13653125#comment-13653125 ] Hudson commented on MAPREDUCE-4942: --- Integrated in Hadoop-trunk-Commit #3725 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/3725/]) MAPREDUCE-4942. mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1. (rkanter via tucu) (Revision 1480748) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1480748 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobClient.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/Job.java * /hadoop/common/trunk/hadoop-tools/hadoop-gridmix/src/test/java/org/apache/hadoop/mapred/gridmix/TestGridmixSummary.java mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1 - Key: MAPREDUCE-4942 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4942 Project: Hadoop Map/Reduce Issue Type: Bug Components: mrv2 Affects Versions: 2.0.2-alpha Reporter: Robert Kanter Assignee: Robert Kanter Attachments: MAPREDUCE-4942.patch The following methods in MR2's {{org.apache.hadoop.mapreduce.Job}} throw an {{InterruptedException}} but don't in MR1, which makes them incompatible. (Their Javadoc comments are also missing that they throw an {{InterruptedException}} anyway) I propose that we wrap the {{InterruptedException}} in a {{RuntimeException}}. {code} public float setupProgress() throws IOException, InterruptedException public float mapProgress() throws IOException, InterruptedException public float reduceProgress() throws IOException, InterruptedException public boolean isComplete() throws IOException, InterruptedException public boolean isSuccessful() throws IOException, InterruptedException public void killJob() throws IOException, InterruptedException public void killTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public void failTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public Counters getCounters() throws IOException, InterruptedException {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4942) mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13650511#comment-13650511 ] Hadoop QA commented on MAPREDUCE-4942: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12582037/MAPREDUCE-4942.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-tools/hadoop-gridmix: org.apache.hadoop.mapred.gridmix.TestDistCacheEmulation {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3575//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3575//console This message is automatically generated. mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1 - Key: MAPREDUCE-4942 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4942 Project: Hadoop Map/Reduce Issue Type: Bug Components: mrv2 Affects Versions: 2.0.2-alpha Reporter: Robert Kanter Assignee: Robert Kanter Attachments: MAPREDUCE-4942.patch The following methods in MR2's {{org.apache.hadoop.mapreduce.Job}} throw an {{InterruptedException}} but don't in MR1, which makes them incompatible. (Their Javadoc comments are also missing that they throw an {{InterruptedException}} anyway) I propose that we wrap the {{InterruptedException}} in a {{RuntimeException}}. {code} public float setupProgress() throws IOException, InterruptedException public float mapProgress() throws IOException, InterruptedException public float reduceProgress() throws IOException, InterruptedException public boolean isComplete() throws IOException, InterruptedException public boolean isSuccessful() throws IOException, InterruptedException public void killJob() throws IOException, InterruptedException public void killTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public void failTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public Counters getCounters() throws IOException, InterruptedException {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4942) mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13650520#comment-13650520 ] Robert Kanter commented on MAPREDUCE-4942: -- Test failure is unrelated; it fails on trunk even without the patch. (On branch-2 is passes with and without the patch) mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1 - Key: MAPREDUCE-4942 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4942 Project: Hadoop Map/Reduce Issue Type: Bug Components: mrv2 Affects Versions: 2.0.2-alpha Reporter: Robert Kanter Assignee: Robert Kanter Attachments: MAPREDUCE-4942.patch The following methods in MR2's {{org.apache.hadoop.mapreduce.Job}} throw an {{InterruptedException}} but don't in MR1, which makes them incompatible. (Their Javadoc comments are also missing that they throw an {{InterruptedException}} anyway) I propose that we wrap the {{InterruptedException}} in a {{RuntimeException}}. {code} public float setupProgress() throws IOException, InterruptedException public float mapProgress() throws IOException, InterruptedException public float reduceProgress() throws IOException, InterruptedException public boolean isComplete() throws IOException, InterruptedException public boolean isSuccessful() throws IOException, InterruptedException public void killJob() throws IOException, InterruptedException public void killTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public void failTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public Counters getCounters() throws IOException, InterruptedException {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4942) mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13625571#comment-13625571 ] Robert Kanter commented on MAPREDUCE-4942: -- Looking at this some more, it seemed that {{cluster.getClient().getJobStatus}} was the issue. Its signature in the {{ClientProtocol}} interface throws the {{InterruptedException}}, but none of its implementations seem to actually throw this exception. However, {{ugi.doAs}} is also throwing the {{InterruptedException}} and I'd be more reluctant to change this because its used all over the place. mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1 - Key: MAPREDUCE-4942 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4942 Project: Hadoop Map/Reduce Issue Type: Bug Components: mrv2 Affects Versions: 2.0.2-alpha Reporter: Robert Kanter Assignee: Robert Kanter The following methods in MR2's {{org.apache.hadoop.mapreduce.Job}} throw an {{InterruptedException}} but don't in MR1, which makes them incompatible. (Their Javadoc comments are also missing that they throw an {{InterruptedException}} anyway) I propose that we wrap the {{InterruptedException}} in a {{RuntimeException}}. {code} public float setupProgress() throws IOException, InterruptedException public float mapProgress() throws IOException, InterruptedException public float reduceProgress() throws IOException, InterruptedException public boolean isComplete() throws IOException, InterruptedException public boolean isSuccessful() throws IOException, InterruptedException public void killJob() throws IOException, InterruptedException public void killTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public void failTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public Counters getCounters() throws IOException, InterruptedException {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4942) mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554056#comment-13554056 ] Robert Kanter commented on MAPREDUCE-4942: -- That makes sense mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1 - Key: MAPREDUCE-4942 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4942 Project: Hadoop Map/Reduce Issue Type: Bug Components: mrv2 Affects Versions: 2.0.2-alpha Reporter: Robert Kanter Assignee: Robert Kanter The following methods in MR2's {{org.apache.hadoop.mapreduce.Job}} throw an {{InterruptedException}} but don't in MR1, which makes them incompatible. (Their Javadoc comments are also missing that they throw an {{InterruptedException}} anyway) I propose that we wrap the {{InterruptedException}} in a {{RuntimeException}}. {code} public float setupProgress() throws IOException, InterruptedException public float mapProgress() throws IOException, InterruptedException public float reduceProgress() throws IOException, InterruptedException public boolean isComplete() throws IOException, InterruptedException public boolean isSuccessful() throws IOException, InterruptedException public void killJob() throws IOException, InterruptedException public TaskCompletionEvent[] getTaskCompletionEvents(int, int) throws IOException, InterruptedException public void killTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public void failTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public Counters getCounters() throws IOException, InterruptedException {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4942) mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554380#comment-13554380 ] Eli Collins commented on MAPREDUCE-4942: bq. I propose that we wrap the InterruptedException in a RuntimeException. What change added the InterruptedException? It may be that it was inadvertently exposed by a method all these APIs use and rather than catch the IE it was exposed. mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1 - Key: MAPREDUCE-4942 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4942 Project: Hadoop Map/Reduce Issue Type: Bug Components: mrv2 Affects Versions: 2.0.2-alpha Reporter: Robert Kanter Assignee: Robert Kanter The following methods in MR2's {{org.apache.hadoop.mapreduce.Job}} throw an {{InterruptedException}} but don't in MR1, which makes them incompatible. (Their Javadoc comments are also missing that they throw an {{InterruptedException}} anyway) I propose that we wrap the {{InterruptedException}} in a {{RuntimeException}}. {code} public float setupProgress() throws IOException, InterruptedException public float mapProgress() throws IOException, InterruptedException public float reduceProgress() throws IOException, InterruptedException public boolean isComplete() throws IOException, InterruptedException public boolean isSuccessful() throws IOException, InterruptedException public void killJob() throws IOException, InterruptedException public void killTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public void failTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public Counters getCounters() throws IOException, InterruptedException {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4942) mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554565#comment-13554565 ] Robert Kanter commented on MAPREDUCE-4942: -- Those methods all eventually call the {{updateStatus}} method, which uses {{UserGroupInformation}} and can throw the {{InterruptedException}}. Though the JavaDoc for {{updateStatus}} doesn't mention the {{InterruptedException}} either, only the {{IOException}}. {code} /** Some methods need to update status immediately. So, refresh * immediately * @throws IOException */ synchronized void updateStatus() throws IOException, InterruptedException { this.status = ugi.doAs(new PrivilegedExceptionActionJobStatus() { @Override public JobStatus run() throws IOException, InterruptedException { return cluster.getClient().getJobStatus(status.getJobID()); } }); if (this.status == null) { throw new IOException(Job status not available ); } this.statustime = System.currentTimeMillis(); } {code} Perhaps it would be better and simpler to make {{updateStatus}} not throw an InterruptedException? mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1 - Key: MAPREDUCE-4942 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4942 Project: Hadoop Map/Reduce Issue Type: Bug Components: mrv2 Affects Versions: 2.0.2-alpha Reporter: Robert Kanter Assignee: Robert Kanter The following methods in MR2's {{org.apache.hadoop.mapreduce.Job}} throw an {{InterruptedException}} but don't in MR1, which makes them incompatible. (Their Javadoc comments are also missing that they throw an {{InterruptedException}} anyway) I propose that we wrap the {{InterruptedException}} in a {{RuntimeException}}. {code} public float setupProgress() throws IOException, InterruptedException public float mapProgress() throws IOException, InterruptedException public float reduceProgress() throws IOException, InterruptedException public boolean isComplete() throws IOException, InterruptedException public boolean isSuccessful() throws IOException, InterruptedException public void killJob() throws IOException, InterruptedException public void killTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public void failTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public Counters getCounters() throws IOException, InterruptedException {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4942) mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13553383#comment-13553383 ] Sandy Ryza commented on MAPREDUCE-4942: --- How was it dealt with in MR1? mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1 - Key: MAPREDUCE-4942 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4942 Project: Hadoop Map/Reduce Issue Type: Bug Components: mrv2 Affects Versions: 2.0.2-alpha Reporter: Robert Kanter Assignee: Robert Kanter The following methods in MR2's {{org.apache.hadoop.mapreduce.Job}} throw an {{InterruptedException}} but don't in MR1, which makes them incompatible. (Their Javadoc comments are also missing that they throw an {{InterruptedException}} anyway) I propose that we wrap the {{InterruptedException}} in a {{RuntimeException}}. {code} public float setupProgress() throws IOException, InterruptedException public float mapProgress() throws IOException, InterruptedException public float reduceProgress() throws IOException, InterruptedException public boolean isComplete() throws IOException, InterruptedException public boolean isSuccessful() throws IOException, InterruptedException public void killJob() throws IOException, InterruptedException public TaskCompletionEvent[] getTaskCompletionEvents(int, int) throws IOException, InterruptedException public void killTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public void failTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public Counters getCounters() throws IOException, InterruptedException {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4942) mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13553385#comment-13553385 ] Robert Kanter commented on MAPREDUCE-4942: -- In MR1, those methods don't do anything that could cause an {{InterruptedException}}, so it wasn't an issue. mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1 - Key: MAPREDUCE-4942 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4942 Project: Hadoop Map/Reduce Issue Type: Bug Components: mrv2 Affects Versions: 2.0.2-alpha Reporter: Robert Kanter Assignee: Robert Kanter The following methods in MR2's {{org.apache.hadoop.mapreduce.Job}} throw an {{InterruptedException}} but don't in MR1, which makes them incompatible. (Their Javadoc comments are also missing that they throw an {{InterruptedException}} anyway) I propose that we wrap the {{InterruptedException}} in a {{RuntimeException}}. {code} public float setupProgress() throws IOException, InterruptedException public float mapProgress() throws IOException, InterruptedException public float reduceProgress() throws IOException, InterruptedException public boolean isComplete() throws IOException, InterruptedException public boolean isSuccessful() throws IOException, InterruptedException public void killJob() throws IOException, InterruptedException public TaskCompletionEvent[] getTaskCompletionEvents(int, int) throws IOException, InterruptedException public void killTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public void failTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public Counters getCounters() throws IOException, InterruptedException {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4942) mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13553442#comment-13553442 ] Karthik Kambatla commented on MAPREDUCE-4942: - Hey Robert - from MAPREDUCE-4932, it seems like getTaskCompletionEvents(int, int) doesn't exist in MR1. Shouldn't we skip it from this list here? In MAPREDUCE-4932, we can implement getTaskCompletionEvents(int) without an InterruptedException. What do you think? mapreduce.Job has a bunch of methods that throw InterruptedException so its incompatible with MR1 - Key: MAPREDUCE-4942 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4942 Project: Hadoop Map/Reduce Issue Type: Bug Components: mrv2 Affects Versions: 2.0.2-alpha Reporter: Robert Kanter Assignee: Robert Kanter The following methods in MR2's {{org.apache.hadoop.mapreduce.Job}} throw an {{InterruptedException}} but don't in MR1, which makes them incompatible. (Their Javadoc comments are also missing that they throw an {{InterruptedException}} anyway) I propose that we wrap the {{InterruptedException}} in a {{RuntimeException}}. {code} public float setupProgress() throws IOException, InterruptedException public float mapProgress() throws IOException, InterruptedException public float reduceProgress() throws IOException, InterruptedException public boolean isComplete() throws IOException, InterruptedException public boolean isSuccessful() throws IOException, InterruptedException public void killJob() throws IOException, InterruptedException public TaskCompletionEvent[] getTaskCompletionEvents(int, int) throws IOException, InterruptedException public void killTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public void failTask(org.apache.hadoop.mapreduce.TaskAttemptID) throws IOException, InterruptedException public Counters getCounters() throws IOException, InterruptedException {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira