[jira] [Commented] (MAPREDUCE-5008) Merger progress miscounts with respect to EOF_MARKER
[ https://issues.apache.org/jira/browse/MAPREDUCE-5008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13589427#comment-13589427 ] Hudson commented on MAPREDUCE-5008: --- Integrated in Hadoop-Yarn-trunk #141 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/141/]) MAPREDUCE-5008. Merger progress miscounts with respect to EOF_MARKER. Contributed by Sandy Ryza. (Revision 1450723) Result = SUCCESS tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1450723 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/task/reduce/MergeManagerImpl.java Merger progress miscounts with respect to EOF_MARKER Key: MAPREDUCE-5008 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5008 Project: Hadoop Map/Reduce Issue Type: Bug Affects Versions: 2.0.3-alpha Reporter: Sandy Ryza Assignee: Sandy Ryza Fix For: 1.2.0, 2.0.4-beta Attachments: MAPREDUCE-5008-branch-1.patch, MAPREDUCE-5008.patch, MAPREDUCE-5008.patch After MAPREDUCE-2264, a segment's raw data length is calculated without the EOF_MARKER bytes. However, when the merge is counting how many bytes it processed, it includes the marker. This can cause the merge progress to go above 100%. Whether these EOF_MARKER bytes should count should be consistent between the two. This a JIRA instead of an amendment because MAPREDUCE-2264 already went into 2.0.3. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5008) Merger progress miscounts with respect to EOF_MARKER
[ https://issues.apache.org/jira/browse/MAPREDUCE-5008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13588210#comment-13588210 ] Hudson commented on MAPREDUCE-5008: --- Integrated in Hadoop-trunk-Commit #3389 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/3389/]) MAPREDUCE-5008. Merger progress miscounts with respect to EOF_MARKER. Contributed by Sandy Ryza. (Revision 1450723) Result = SUCCESS tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1450723 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/task/reduce/MergeManagerImpl.java Merger progress miscounts with respect to EOF_MARKER Key: MAPREDUCE-5008 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5008 Project: Hadoop Map/Reduce Issue Type: Bug Affects Versions: 2.0.3-alpha Reporter: Sandy Ryza Assignee: Sandy Ryza Fix For: 1.2.0, 2.0.4-beta Attachments: MAPREDUCE-5008-branch-1.patch, MAPREDUCE-5008.patch, MAPREDUCE-5008.patch After MAPREDUCE-2264, a segment's raw data length is calculated without the EOF_MARKER bytes. However, when the merge is counting how many bytes it processed, it includes the marker. This can cause the merge progress to go above 100%. Whether these EOF_MARKER bytes should count should be consistent between the two. This a JIRA instead of an amendment because MAPREDUCE-2264 already went into 2.0.3. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5008) Merger progress miscounts with respect to EOF_MARKER
[ https://issues.apache.org/jira/browse/MAPREDUCE-5008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13588293#comment-13588293 ] Hudson commented on MAPREDUCE-5008: --- Integrated in Hadoop-Hdfs-trunk #1329 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1329/]) MAPREDUCE-5008. Merger progress miscounts with respect to EOF_MARKER. Contributed by Sandy Ryza. (Revision 1450723) Result = SUCCESS tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1450723 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/task/reduce/MergeManagerImpl.java Merger progress miscounts with respect to EOF_MARKER Key: MAPREDUCE-5008 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5008 Project: Hadoop Map/Reduce Issue Type: Bug Affects Versions: 2.0.3-alpha Reporter: Sandy Ryza Assignee: Sandy Ryza Fix For: 1.2.0, 2.0.4-beta Attachments: MAPREDUCE-5008-branch-1.patch, MAPREDUCE-5008.patch, MAPREDUCE-5008.patch After MAPREDUCE-2264, a segment's raw data length is calculated without the EOF_MARKER bytes. However, when the merge is counting how many bytes it processed, it includes the marker. This can cause the merge progress to go above 100%. Whether these EOF_MARKER bytes should count should be consistent between the two. This a JIRA instead of an amendment because MAPREDUCE-2264 already went into 2.0.3. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5008) Merger progress miscounts with respect to EOF_MARKER
[ https://issues.apache.org/jira/browse/MAPREDUCE-5008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13588360#comment-13588360 ] Hudson commented on MAPREDUCE-5008: --- Integrated in Hadoop-Mapreduce-trunk #1357 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1357/]) MAPREDUCE-5008. Merger progress miscounts with respect to EOF_MARKER. Contributed by Sandy Ryza. (Revision 1450723) Result = SUCCESS tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1450723 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/task/reduce/MergeManagerImpl.java Merger progress miscounts with respect to EOF_MARKER Key: MAPREDUCE-5008 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5008 Project: Hadoop Map/Reduce Issue Type: Bug Affects Versions: 2.0.3-alpha Reporter: Sandy Ryza Assignee: Sandy Ryza Fix For: 1.2.0, 2.0.4-beta Attachments: MAPREDUCE-5008-branch-1.patch, MAPREDUCE-5008.patch, MAPREDUCE-5008.patch After MAPREDUCE-2264, a segment's raw data length is calculated without the EOF_MARKER bytes. However, when the merge is counting how many bytes it processed, it includes the marker. This can cause the merge progress to go above 100%. Whether these EOF_MARKER bytes should count should be consistent between the two. This a JIRA instead of an amendment because MAPREDUCE-2264 already went into 2.0.3. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5008) Merger progress miscounts with respect to EOF_MARKER
[ https://issues.apache.org/jira/browse/MAPREDUCE-5008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13583125#comment-13583125 ] Tom White commented on MAPREDUCE-5008: -- Is there a way to test this, manual or otherwise? Merger progress miscounts with respect to EOF_MARKER Key: MAPREDUCE-5008 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5008 Project: Hadoop Map/Reduce Issue Type: Bug Affects Versions: 2.0.3-alpha Reporter: Sandy Ryza Assignee: Sandy Ryza Attachments: MAPREDUCE-5008-branch-1.patch, MAPREDUCE-5008.patch, MAPREDUCE-5008.patch After MAPREDUCE-2264, a segment's raw data length is calculated without the EOF_MARKER bytes. However, when the merge is counting how many bytes it processed, it includes the marker. This can cause the merge progress to go above 100%. Whether these EOF_MARKER bytes should count should be consistent between the two. This a JIRA instead of an amendment because MAPREDUCE-2264 already went into 2.0.3. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5008) Merger progress miscounts with respect to EOF_MARKER
[ https://issues.apache.org/jira/browse/MAPREDUCE-5008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13583357#comment-13583357 ] Sandy Ryza commented on MAPREDUCE-5008: --- With the merge turned on in the local job runner (MAPREDUCE-434), TestReporter, which includes progress counting, fails. With this patch and MAPREDUCE-434, it passes. Does that sound sufficient to you Tom? Merger progress miscounts with respect to EOF_MARKER Key: MAPREDUCE-5008 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5008 Project: Hadoop Map/Reduce Issue Type: Bug Affects Versions: 2.0.3-alpha Reporter: Sandy Ryza Assignee: Sandy Ryza Attachments: MAPREDUCE-5008-branch-1.patch, MAPREDUCE-5008.patch, MAPREDUCE-5008.patch After MAPREDUCE-2264, a segment's raw data length is calculated without the EOF_MARKER bytes. However, when the merge is counting how many bytes it processed, it includes the marker. This can cause the merge progress to go above 100%. Whether these EOF_MARKER bytes should count should be consistent between the two. This a JIRA instead of an amendment because MAPREDUCE-2264 already went into 2.0.3. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5008) Merger progress miscounts with respect to EOF_MARKER
[ https://issues.apache.org/jira/browse/MAPREDUCE-5008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13583388#comment-13583388 ] Tom White commented on MAPREDUCE-5008: -- Yes, that is fine. +1 for the patch. Merger progress miscounts with respect to EOF_MARKER Key: MAPREDUCE-5008 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5008 Project: Hadoop Map/Reduce Issue Type: Bug Affects Versions: 2.0.3-alpha Reporter: Sandy Ryza Assignee: Sandy Ryza Attachments: MAPREDUCE-5008-branch-1.patch, MAPREDUCE-5008.patch, MAPREDUCE-5008.patch After MAPREDUCE-2264, a segment's raw data length is calculated without the EOF_MARKER bytes. However, when the merge is counting how many bytes it processed, it includes the marker. This can cause the merge progress to go above 100%. Whether these EOF_MARKER bytes should count should be consistent between the two. This a JIRA instead of an amendment because MAPREDUCE-2264 already went into 2.0.3. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5008) Merger progress miscounts with respect to EOF_MARKER
[
https://issues.apache.org/jira/browse/MAPREDUCE-5008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13581020#comment-13581020
]
Hadoop QA commented on MAPREDUCE-5008:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12569897/MAPREDUCE-5008.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3339//testReport/
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3339//console
This message is automatically generated.
Merger progress miscounts with respect to EOF_MARKER
Key: MAPREDUCE-5008
URL: https://issues.apache.org/jira/browse/MAPREDUCE-5008
Project: Hadoop Map/Reduce
Issue Type: Bug
Affects Versions: 2.0.3-alpha
Reporter: Sandy Ryza
Assignee: Sandy Ryza
Attachments: MAPREDUCE-5008-branch-1.patch, MAPREDUCE-5008.patch,
MAPREDUCE-5008.patch
After MAPREDUCE-2264, a segment's raw data length is calculated without the
EOF_MARKER bytes. However, when the merge is counting how many bytes it
processed, it includes the marker. This can cause the merge progress to go
above 100%.
Whether these EOF_MARKER bytes should count should be consistent between the
two.
This a JIRA instead of an amendment because MAPREDUCE-2264 already went into
2.0.3.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5008) Merger progress miscounts with respect to EOF_MARKER
[
https://issues.apache.org/jira/browse/MAPREDUCE-5008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13580025#comment-13580025
]
Hadoop QA commented on MAPREDUCE-5008:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12569684/MAPREDUCE-5008-branch-1.patch
against trunk revision .
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3337//console
This message is automatically generated.
Merger progress miscounts with respect to EOF_MARKER
Key: MAPREDUCE-5008
URL: https://issues.apache.org/jira/browse/MAPREDUCE-5008
Project: Hadoop Map/Reduce
Issue Type: Bug
Affects Versions: 2.0.3-alpha
Reporter: Sandy Ryza
Assignee: Sandy Ryza
Attachments: MAPREDUCE-5008-branch-1.patch, MAPREDUCE-5008.patch
After MAPREDUCE-2264, a segment's raw data length is calculated without the
EOF_MARKER bytes. However, when the merge is counting how many bytes it
processed, it includes the marker. This can cause the merge progress to go
above 100%.
Whether these EOF_MARKER bytes should count should be consistent between the
two.
This a JIRA instead of an amendment because MAPREDUCE-2264 already went into
2.0.3.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
