[jira] [Commented] (MAPREDUCE-5234) Signature changes for getTaskId of TaskReport in mapred
[ https://issues.apache.org/jira/browse/MAPREDUCE-5234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13661332#comment-13661332 ] Hudson commented on MAPREDUCE-5234: --- Integrated in Hadoop-Yarn-trunk #213 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/213/]) MAPREDUCE-5234. Change mapred.TaskReport and mapreduce.TaskReport for binary compatibility with mapred in 1.x but incompatible with 0.23.x. Contributed by Mayank Bansal. (Revision 1483940) Result = FAILURE vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1483940 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/TaskReport.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/TaskReport.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestJobInfo.java Signature changes for getTaskId of TaskReport in mapred --- Key: MAPREDUCE-5234 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5234 Project: Hadoop Map/Reduce Issue Type: Sub-task Reporter: Zhijie Shen Assignee: Mayank Bansal Fix For: 2.0.5-beta Attachments: MAPREDUCE-5234-trunk-1.patch, MAPREDUCE-5234-trunk-2.patch, MAPREDUCE-5234-trunk-3.patch, MAPREDUCE-5234-trunk-4.patch, MAPREDUCE-5234-trunk-5.patch TaskReport in mapred of MR2 extends TaskReport in mapreduce, and inherits getTaskId, which return TaskID object. in MR1, this function returns String. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5234) Signature changes for getTaskId of TaskReport in mapred
[ https://issues.apache.org/jira/browse/MAPREDUCE-5234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13661355#comment-13661355 ] Hudson commented on MAPREDUCE-5234: --- Integrated in Hadoop-Hdfs-trunk #1402 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1402/]) MAPREDUCE-5234. Change mapred.TaskReport and mapreduce.TaskReport for binary compatibility with mapred in 1.x but incompatible with 0.23.x. Contributed by Mayank Bansal. (Revision 1483940) Result = FAILURE vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1483940 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/TaskReport.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/TaskReport.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestJobInfo.java Signature changes for getTaskId of TaskReport in mapred --- Key: MAPREDUCE-5234 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5234 Project: Hadoop Map/Reduce Issue Type: Sub-task Reporter: Zhijie Shen Assignee: Mayank Bansal Fix For: 2.0.5-beta Attachments: MAPREDUCE-5234-trunk-1.patch, MAPREDUCE-5234-trunk-2.patch, MAPREDUCE-5234-trunk-3.patch, MAPREDUCE-5234-trunk-4.patch, MAPREDUCE-5234-trunk-5.patch TaskReport in mapred of MR2 extends TaskReport in mapreduce, and inherits getTaskId, which return TaskID object. in MR1, this function returns String. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5234) Signature changes for getTaskId of TaskReport in mapred
[ https://issues.apache.org/jira/browse/MAPREDUCE-5234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13661360#comment-13661360 ] Hudson commented on MAPREDUCE-5234: --- Integrated in Hadoop-Mapreduce-trunk #1429 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1429/]) MAPREDUCE-5234. Change mapred.TaskReport and mapreduce.TaskReport for binary compatibility with mapred in 1.x but incompatible with 0.23.x. Contributed by Mayank Bansal. (Revision 1483940) Result = FAILURE vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1483940 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/TaskReport.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/TaskReport.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestJobInfo.java Signature changes for getTaskId of TaskReport in mapred --- Key: MAPREDUCE-5234 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5234 Project: Hadoop Map/Reduce Issue Type: Sub-task Reporter: Zhijie Shen Assignee: Mayank Bansal Fix For: 2.0.5-beta Attachments: MAPREDUCE-5234-trunk-1.patch, MAPREDUCE-5234-trunk-2.patch, MAPREDUCE-5234-trunk-3.patch, MAPREDUCE-5234-trunk-4.patch, MAPREDUCE-5234-trunk-5.patch TaskReport in mapred of MR2 extends TaskReport in mapreduce, and inherits getTaskId, which return TaskID object. in MR1, this function returns String. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5234) Signature changes for getTaskId of TaskReport in mapred
[ https://issues.apache.org/jira/browse/MAPREDUCE-5234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13660901#comment-13660901 ] Vinod Kumar Vavilapalli commented on MAPREDUCE-5234: Looks good to me too. Checking this in. Signature changes for getTaskId of TaskReport in mapred --- Key: MAPREDUCE-5234 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5234 Project: Hadoop Map/Reduce Issue Type: Sub-task Reporter: Zhijie Shen Assignee: Mayank Bansal Attachments: MAPREDUCE-5234-trunk-1.patch, MAPREDUCE-5234-trunk-2.patch, MAPREDUCE-5234-trunk-3.patch, MAPREDUCE-5234-trunk-4.patch, MAPREDUCE-5234-trunk-5.patch TaskReport in mapred of MR2 extends TaskReport in mapreduce, and inherits getTaskId, which return TaskID object. in MR1, this function returns String. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5234) Signature changes for getTaskId of TaskReport in mapred
[ https://issues.apache.org/jira/browse/MAPREDUCE-5234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13660933#comment-13660933 ] Hudson commented on MAPREDUCE-5234: --- Integrated in Hadoop-trunk-Commit #3765 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/3765/]) MAPREDUCE-5234. Change mapred.TaskReport and mapreduce.TaskReport for binary compatibility with mapred in 1.x but incompatible with 0.23.x. Contributed by Mayank Bansal. (Revision 1483940) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1483940 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/TaskReport.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/TaskReport.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestJobInfo.java Signature changes for getTaskId of TaskReport in mapred --- Key: MAPREDUCE-5234 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5234 Project: Hadoop Map/Reduce Issue Type: Sub-task Reporter: Zhijie Shen Assignee: Mayank Bansal Fix For: 2.0.5-beta Attachments: MAPREDUCE-5234-trunk-1.patch, MAPREDUCE-5234-trunk-2.patch, MAPREDUCE-5234-trunk-3.patch, MAPREDUCE-5234-trunk-4.patch, MAPREDUCE-5234-trunk-5.patch TaskReport in mapred of MR2 extends TaskReport in mapreduce, and inherits getTaskId, which return TaskID object. in MR1, this function returns String. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5234) Signature changes for getTaskId of TaskReport in mapred
[
https://issues.apache.org/jira/browse/MAPREDUCE-5234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13659308#comment-13659308
]
Hadoop QA commented on MAPREDUCE-5234:
--
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12583438/MAPREDUCE-5234-trunk-3.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3644//testReport/
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3644//console
This message is automatically generated.
Signature changes for getTaskId of TaskReport in mapred
---
Key: MAPREDUCE-5234
URL: https://issues.apache.org/jira/browse/MAPREDUCE-5234
Project: Hadoop Map/Reduce
Issue Type: Sub-task
Reporter: Zhijie Shen
Assignee: Mayank Bansal
Attachments: MAPREDUCE-5234-trunk-1.patch,
MAPREDUCE-5234-trunk-2.patch, MAPREDUCE-5234-trunk-3.patch
TaskReport in mapred of MR2 extends TaskReport in mapreduce, and inherits
getTaskId, which return TaskID object. in MR1, this function returns String.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5234) Signature changes for getTaskId of TaskReport in mapred
[
https://issues.apache.org/jira/browse/MAPREDUCE-5234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13659728#comment-13659728
]
Zhijie Shen commented on MAPREDUCE-5234:
It's mapreduce.TaskReport, not mapred.TaskReport, as the test class is in the
mapreduce package as well.
{code}
---
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/TestJob.java
+++
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/TestJob.java
{code}
{code}
+TaskReport treport =
+new TaskReport(tid1, 0.0f, State.FAILED.toString(), null,
+ TIPStatus.FAILED, 100, 100, new Counters());
{code}
The following code seems irrelevant. TaskReport can be tested independently.
{code}
+Cluster cluster = mock(Cluster.class);
+ClientProtocol client = mock(ClientProtocol.class);
{code}
{code}
+when(client.getJobStatus(jobid)).thenReturn(status);
+TaskReport[] tr = new TaskReport[1];
+tr[0] = treport;
+when(client.getTaskReports(jobid, TaskType.MAP)).thenReturn(tr);
+when(client.getTaskReports(jobid, TaskType.REDUCE)).thenReturn(tr);
+when(client.getTaskCompletionEvents(jobid, 0, 10)).thenReturn(
+ new TaskCompletionEvent[0]);
+Job job = Job.getInstance(cluster, status, new JobConf());
+Assert.assertNotNull(job.toString());
+TaskReport[] tr1 = client.getTaskReports(jobid, TaskType.MAP);
{code}
Signature changes for getTaskId of TaskReport in mapred
---
Key: MAPREDUCE-5234
URL: https://issues.apache.org/jira/browse/MAPREDUCE-5234
Project: Hadoop Map/Reduce
Issue Type: Sub-task
Reporter: Zhijie Shen
Assignee: Mayank Bansal
Attachments: MAPREDUCE-5234-trunk-1.patch,
MAPREDUCE-5234-trunk-2.patch, MAPREDUCE-5234-trunk-3.patch
TaskReport in mapred of MR2 extends TaskReport in mapreduce, and inherits
getTaskId, which return TaskID object. in MR1, this function returns String.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5234) Signature changes for getTaskId of TaskReport in mapred
[
https://issues.apache.org/jira/browse/MAPREDUCE-5234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13659891#comment-13659891
]
Hadoop QA commented on MAPREDUCE-5234:
--
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12583529/MAPREDUCE-5234-trunk-4.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3647//testReport/
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3647//console
This message is automatically generated.
Signature changes for getTaskId of TaskReport in mapred
---
Key: MAPREDUCE-5234
URL: https://issues.apache.org/jira/browse/MAPREDUCE-5234
Project: Hadoop Map/Reduce
Issue Type: Sub-task
Reporter: Zhijie Shen
Assignee: Mayank Bansal
Attachments: MAPREDUCE-5234-trunk-1.patch,
MAPREDUCE-5234-trunk-2.patch, MAPREDUCE-5234-trunk-3.patch,
MAPREDUCE-5234-trunk-4.patch
TaskReport in mapred of MR2 extends TaskReport in mapreduce, and inherits
getTaskId, which return TaskID object. in MR1, this function returns String.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5234) Signature changes for getTaskId of TaskReport in mapred
[ https://issues.apache.org/jira/browse/MAPREDUCE-5234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13659924#comment-13659924 ] Vinod Kumar Vavilapalli commented on MAPREDUCE-5234: Please don't make the constructor public, we don't want users to create TaskReports. You can move the test to other test-cases in the same package. Signature changes for getTaskId of TaskReport in mapred --- Key: MAPREDUCE-5234 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5234 Project: Hadoop Map/Reduce Issue Type: Sub-task Reporter: Zhijie Shen Assignee: Mayank Bansal Attachments: MAPREDUCE-5234-trunk-1.patch, MAPREDUCE-5234-trunk-2.patch, MAPREDUCE-5234-trunk-3.patch, MAPREDUCE-5234-trunk-4.patch TaskReport in mapred of MR2 extends TaskReport in mapreduce, and inherits getTaskId, which return TaskID object. in MR1, this function returns String. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5234) Signature changes for getTaskId of TaskReport in mapred
[
https://issues.apache.org/jira/browse/MAPREDUCE-5234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13660019#comment-13660019
]
Zhijie Shen commented on MAPREDUCE-5234:
The following code seems unnecessary as well. Either cluster or client is used
afterwards.
{code}
+Cluster cluster = mock(Cluster.class);
+ClientProtocol client = mock(ClientProtocol.class);
+when(cluster.getClient()).thenReturn(client);
{code}
Signature changes for getTaskId of TaskReport in mapred
---
Key: MAPREDUCE-5234
URL: https://issues.apache.org/jira/browse/MAPREDUCE-5234
Project: Hadoop Map/Reduce
Issue Type: Sub-task
Reporter: Zhijie Shen
Assignee: Mayank Bansal
Attachments: MAPREDUCE-5234-trunk-1.patch,
MAPREDUCE-5234-trunk-2.patch, MAPREDUCE-5234-trunk-3.patch,
MAPREDUCE-5234-trunk-4.patch
TaskReport in mapred of MR2 extends TaskReport in mapreduce, and inherits
getTaskId, which return TaskID object. in MR1, this function returns String.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5234) Signature changes for getTaskId of TaskReport in mapred
[
https://issues.apache.org/jira/browse/MAPREDUCE-5234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13660102#comment-13660102
]
Hadoop QA commented on MAPREDUCE-5234:
--
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12583553/MAPREDUCE-5234-trunk-5.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3648//testReport/
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3648//console
This message is automatically generated.
Signature changes for getTaskId of TaskReport in mapred
---
Key: MAPREDUCE-5234
URL: https://issues.apache.org/jira/browse/MAPREDUCE-5234
Project: Hadoop Map/Reduce
Issue Type: Sub-task
Reporter: Zhijie Shen
Assignee: Mayank Bansal
Attachments: MAPREDUCE-5234-trunk-1.patch,
MAPREDUCE-5234-trunk-2.patch, MAPREDUCE-5234-trunk-3.patch,
MAPREDUCE-5234-trunk-4.patch, MAPREDUCE-5234-trunk-5.patch
TaskReport in mapred of MR2 extends TaskReport in mapreduce, and inherits
getTaskId, which return TaskID object. in MR1, this function returns String.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5234) Signature changes for getTaskId of TaskReport in mapred
[ https://issues.apache.org/jira/browse/MAPREDUCE-5234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13660131#comment-13660131 ] Zhijie Shen commented on MAPREDUCE-5234: +1. It look goot to me. Signature changes for getTaskId of TaskReport in mapred --- Key: MAPREDUCE-5234 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5234 Project: Hadoop Map/Reduce Issue Type: Sub-task Reporter: Zhijie Shen Assignee: Mayank Bansal Attachments: MAPREDUCE-5234-trunk-1.patch, MAPREDUCE-5234-trunk-2.patch, MAPREDUCE-5234-trunk-3.patch, MAPREDUCE-5234-trunk-4.patch, MAPREDUCE-5234-trunk-5.patch TaskReport in mapred of MR2 extends TaskReport in mapreduce, and inherits getTaskId, which return TaskID object. in MR1, this function returns String. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5234) Signature changes for getTaskId of TaskReport in mapred
[ https://issues.apache.org/jira/browse/MAPREDUCE-5234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13658884#comment-13658884 ] Vinod Kumar Vavilapalli commented on MAPREDUCE-5234: bq. Vinod, I think unfortunately we need to change mapreduce.TaskReport, where TaskID getTaskId() gets inherited by mapred.TaskReport. Sigh, I missed that. Yeah, in this case, don't think we have a choice. Mayank, please see if you can just fix the double underscore issue. That should be enough. Signature changes for getTaskId of TaskReport in mapred --- Key: MAPREDUCE-5234 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5234 Project: Hadoop Map/Reduce Issue Type: Sub-task Reporter: Zhijie Shen Assignee: Mayank Bansal Attachments: MAPREDUCE-5234-trunk-1.patch TaskReport in mapred of MR2 extends TaskReport in mapreduce, and inherits getTaskId, which return TaskID object. in MR1, this function returns String. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5234) Signature changes for getTaskId of TaskReport in mapred
[ https://issues.apache.org/jira/browse/MAPREDUCE-5234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13659025#comment-13659025 ] Mayank Bansal commented on MAPREDUCE-5234: -- Sure , Fixed the double underscore issue. Thanks, Mayank Signature changes for getTaskId of TaskReport in mapred --- Key: MAPREDUCE-5234 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5234 Project: Hadoop Map/Reduce Issue Type: Sub-task Reporter: Zhijie Shen Assignee: Mayank Bansal Attachments: MAPREDUCE-5234-trunk-1.patch TaskReport in mapred of MR2 extends TaskReport in mapreduce, and inherits getTaskId, which return TaskID object. in MR1, this function returns String. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5234) Signature changes for getTaskId of TaskReport in mapred
[
https://issues.apache.org/jira/browse/MAPREDUCE-5234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13659066#comment-13659066
]
Hadoop QA commented on MAPREDUCE-5234:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12583404/MAPREDUCE-5234-trunk-2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:red}-1 javac{color}. The applied patch generated 1367 javac
compiler warnings (more than the trunk's current 1366 warnings).
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3643//testReport/
Javac warnings:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3643//artifact/trunk/patchprocess/diffJavacWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3643//console
This message is automatically generated.
Signature changes for getTaskId of TaskReport in mapred
---
Key: MAPREDUCE-5234
URL: https://issues.apache.org/jira/browse/MAPREDUCE-5234
Project: Hadoop Map/Reduce
Issue Type: Sub-task
Reporter: Zhijie Shen
Assignee: Mayank Bansal
Attachments: MAPREDUCE-5234-trunk-1.patch,
MAPREDUCE-5234-trunk-2.patch
TaskReport in mapred of MR2 extends TaskReport in mapreduce, and inherits
getTaskId, which return TaskID object. in MR1, this function returns String.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5234) Signature changes for getTaskId of TaskReport in mapred
[ https://issues.apache.org/jira/browse/MAPREDUCE-5234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13659256#comment-13659256 ] Vinod Kumar Vavilapalli commented on MAPREDUCE-5234: Can you check the javac warning? Signature changes for getTaskId of TaskReport in mapred --- Key: MAPREDUCE-5234 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5234 Project: Hadoop Map/Reduce Issue Type: Sub-task Reporter: Zhijie Shen Assignee: Mayank Bansal Attachments: MAPREDUCE-5234-trunk-1.patch, MAPREDUCE-5234-trunk-2.patch TaskReport in mapred of MR2 extends TaskReport in mapreduce, and inherits getTaskId, which return TaskID object. in MR1, this function returns String. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5234) Signature changes for getTaskId of TaskReport in mapred
[ https://issues.apache.org/jira/browse/MAPREDUCE-5234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13657295#comment-13657295 ] Mayank Bansal commented on MAPREDUCE-5234: -- Taking it over Thanks, Mayank Signature changes for getTaskId of TaskReport in mapred --- Key: MAPREDUCE-5234 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5234 Project: Hadoop Map/Reduce Issue Type: Sub-task Reporter: Zhijie Shen Assignee: Mayank Bansal TaskReport in mapred of MR2 extends TaskReport in mapreduce, and inherits getTaskId, which return TaskID object. in MR1, this function returns String. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5234) Signature changes for getTaskId of TaskReport in mapred
[
https://issues.apache.org/jira/browse/MAPREDUCE-5234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13657618#comment-13657618
]
Hadoop QA commented on MAPREDUCE-5234:
--
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12583222/MAPREDUCE-5234-trunk-1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3641//testReport/
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3641//console
This message is automatically generated.
Signature changes for getTaskId of TaskReport in mapred
---
Key: MAPREDUCE-5234
URL: https://issues.apache.org/jira/browse/MAPREDUCE-5234
Project: Hadoop Map/Reduce
Issue Type: Sub-task
Reporter: Zhijie Shen
Assignee: Mayank Bansal
Attachments: MAPREDUCE-5234-trunk-1.patch
TaskReport in mapred of MR2 extends TaskReport in mapreduce, and inherits
getTaskId, which return TaskID object. in MR1, this function returns String.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5234) Signature changes for getTaskId of TaskReport in mapred
[ https://issues.apache.org/jira/browse/MAPREDUCE-5234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13657640#comment-13657640 ] Vinod Kumar Vavilapalli commented on MAPREDUCE-5234: +1, looks good. Will check it in to trunk now and later to branch when all the noise resolves to something w.r.t branches. Signature changes for getTaskId of TaskReport in mapred --- Key: MAPREDUCE-5234 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5234 Project: Hadoop Map/Reduce Issue Type: Sub-task Reporter: Zhijie Shen Assignee: Mayank Bansal Attachments: MAPREDUCE-5234-trunk-1.patch TaskReport in mapred of MR2 extends TaskReport in mapreduce, and inherits getTaskId, which return TaskID object. in MR1, this function returns String. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5234) Signature changes for getTaskId of TaskReport in mapred
[ https://issues.apache.org/jira/browse/MAPREDUCE-5234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13657647#comment-13657647 ] Vinod Kumar Vavilapalli commented on MAPREDUCE-5234: bq. +1, looks good. Will check it in to trunk now and later to branch when all the noise resolves to something w.r.t branches. Wrong JIRA :) Signature changes for getTaskId of TaskReport in mapred --- Key: MAPREDUCE-5234 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5234 Project: Hadoop Map/Reduce Issue Type: Sub-task Reporter: Zhijie Shen Assignee: Mayank Bansal Attachments: MAPREDUCE-5234-trunk-1.patch TaskReport in mapred of MR2 extends TaskReport in mapreduce, and inherits getTaskId, which return TaskID object. in MR1, this function returns String. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5234) Signature changes for getTaskId of TaskReport in mapred
[ https://issues.apache.org/jira/browse/MAPREDUCE-5234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13657672#comment-13657672 ] Zhijie Shen commented on MAPREDUCE-5234: Vinod, I think unfortunately we need to change mapreduce.TaskReport, where TaskID getTaskId() gets inherited by mapred.TaskReport. However, in MR1, getTaskId() returns String. The return type cannot be overloaded. Like MAPREDUCE-5156, we have to choose one to break, either MR1 or early MR2 versions. Signature changes for getTaskId of TaskReport in mapred --- Key: MAPREDUCE-5234 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5234 Project: Hadoop Map/Reduce Issue Type: Sub-task Reporter: Zhijie Shen Assignee: Mayank Bansal Attachments: MAPREDUCE-5234-trunk-1.patch TaskReport in mapred of MR2 extends TaskReport in mapreduce, and inherits getTaskId, which return TaskID object. in MR1, this function returns String. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5234) Signature changes for getTaskId of TaskReport in mapred
[ https://issues.apache.org/jira/browse/MAPREDUCE-5234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13657704#comment-13657704 ] Karthik Kambatla commented on MAPREDUCE-5234: - In cases where hadoop-1 and hadoop-0.23 are incompatible, in the long term, it might be better to break the one with fewer users. It is kind of unfortunate, but seems like the lesser of the two evils. Signature changes for getTaskId of TaskReport in mapred --- Key: MAPREDUCE-5234 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5234 Project: Hadoop Map/Reduce Issue Type: Sub-task Reporter: Zhijie Shen Assignee: Mayank Bansal Attachments: MAPREDUCE-5234-trunk-1.patch TaskReport in mapred of MR2 extends TaskReport in mapreduce, and inherits getTaskId, which return TaskID object. in MR1, this function returns String. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5234) Signature changes for getTaskId of TaskReport in mapred
[ https://issues.apache.org/jira/browse/MAPREDUCE-5234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13653287#comment-13653287 ] Zhijie Shen commented on MAPREDUCE-5234: Note that there's another function getTaskID, which was and is supposed to return TaskID. Signature changes for getTaskId of TaskReport in mapred --- Key: MAPREDUCE-5234 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5234 Project: Hadoop Map/Reduce Issue Type: Sub-task Reporter: Zhijie Shen Assignee: Zhijie Shen Fix For: 2.0.5-beta TaskReport in mapred of MR2 extends TaskReport in mapreduce, and inherits getTaskId, which return TaskID object. in MR1, this function returns String. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
