[jira] [Commented] (MAPREDUCE-5275) Mapreduce API: TokenCache incompatibility issues with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683951#comment-13683951 ] Karthik Kambatla commented on MAPREDUCE-5275: - The only issue with adding the methods to Hadoop-2 is that we are expected to support it for Hadoop-2 and Hadoop-3 at the least. I understand the point of adding the methods, but think they should at least be marked @Deprecated. What do you think? Not suggesting we reopen this. I can address this in MAPREDUCE-5213. Mapreduce API: TokenCache incompatibility issues with MR1 - Key: MAPREDUCE-5275 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5275 Project: Hadoop Map/Reduce Issue Type: Sub-task Reporter: Zhijie Shen Assignee: Mayank Bansal Fix For: 2.1.0-beta Attachments: MAPREDUCE-5275-trunk-1.patch, MAPREDUCE-5275-trunk-2.patch, MAPREDUCE-5275-trunk-3.patch, MAPREDUCE-5275-trunk-4.patch There're following incompatibility issues: * TokenDelegationTokenIdentifier getDelegationToken(Credentials, String) is removed * Credentials loadTokens(String, Configuration) changes to Credentials loadTokens(String, JobConf) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5275) Mapreduce API: TokenCache incompatibility issues with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683967#comment-13683967 ] Zhijie Shen commented on MAPREDUCE-5275: [~kkambatl], make sense. Probably we want to mark them @private as well if the comment in branch-1 intentionally mean the methods should be used internally. Mapreduce API: TokenCache incompatibility issues with MR1 - Key: MAPREDUCE-5275 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5275 Project: Hadoop Map/Reduce Issue Type: Sub-task Reporter: Zhijie Shen Assignee: Mayank Bansal Fix For: 2.1.0-beta Attachments: MAPREDUCE-5275-trunk-1.patch, MAPREDUCE-5275-trunk-2.patch, MAPREDUCE-5275-trunk-3.patch, MAPREDUCE-5275-trunk-4.patch There're following incompatibility issues: * TokenDelegationTokenIdentifier getDelegationToken(Credentials, String) is removed * Credentials loadTokens(String, Configuration) changes to Credentials loadTokens(String, JobConf) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5275) Mapreduce API: TokenCache incompatibility issues with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683976#comment-13683976 ] Karthik Kambatla commented on MAPREDUCE-5275: - Yep. Let us do that then. I ll upload a patch on MAPREDUCE-5213 those methods marked @private and @Deprecated (even though deprecation is redundant for private API). Mapreduce API: TokenCache incompatibility issues with MR1 - Key: MAPREDUCE-5275 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5275 Project: Hadoop Map/Reduce Issue Type: Sub-task Reporter: Zhijie Shen Assignee: Mayank Bansal Fix For: 2.1.0-beta Attachments: MAPREDUCE-5275-trunk-1.patch, MAPREDUCE-5275-trunk-2.patch, MAPREDUCE-5275-trunk-3.patch, MAPREDUCE-5275-trunk-4.patch There're following incompatibility issues: * TokenDelegationTokenIdentifier getDelegationToken(Credentials, String) is removed * Credentials loadTokens(String, Configuration) changes to Credentials loadTokens(String, JobConf) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5275) Mapreduce API: TokenCache incompatibility issues with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13678222#comment-13678222 ] Mayank Bansal commented on MAPREDUCE-5275: -- [~kkambatl] 1) In Hadoop 1, I see Loadtokens method is public and can be used by anybody so I will try to maintian compatibility with Hadoop 1. I don't think we should remove LoadTokens. 2) getDelegationToken was also public and can be used by anybody and removing method will break source compatibility with Hadoop 1. Thanks, Mayank Mapreduce API: TokenCache incompatibility issues with MR1 - Key: MAPREDUCE-5275 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5275 Project: Hadoop Map/Reduce Issue Type: Sub-task Reporter: Zhijie Shen Assignee: Mayank Bansal Fix For: 2.1.0-beta Attachments: MAPREDUCE-5275-trunk-1.patch, MAPREDUCE-5275-trunk-2.patch, MAPREDUCE-5275-trunk-3.patch, MAPREDUCE-5275-trunk-4.patch There're following incompatibility issues: * TokenDelegationTokenIdentifier getDelegationToken(Credentials, String) is removed * Credentials loadTokens(String, Configuration) changes to Credentials loadTokens(String, JobConf) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5275) Mapreduce API: TokenCache incompatibility issues with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13677619#comment-13677619 ] Karthik Kambatla commented on MAPREDUCE-5275: - +1 on removing the newly introduced @Private methods which are not used. Also, noticed that the previously existing loadTokens() is also @Private and not used anywhere. Was planning to remove it through MAPREDUCE-5213. Based on the decision to revert this, I can work on a patch for MAPREDUCE-5213. Mapreduce API: TokenCache incompatibility issues with MR1 - Key: MAPREDUCE-5275 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5275 Project: Hadoop Map/Reduce Issue Type: Sub-task Reporter: Zhijie Shen Assignee: Mayank Bansal Fix For: 2.1.0-beta Attachments: MAPREDUCE-5275-trunk-1.patch, MAPREDUCE-5275-trunk-2.patch, MAPREDUCE-5275-trunk-3.patch, MAPREDUCE-5275-trunk-4.patch There're following incompatibility issues: * TokenDelegationTokenIdentifier getDelegationToken(Credentials, String) is removed * Credentials loadTokens(String, Configuration) changes to Credentials loadTokens(String, JobConf) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5275) Mapreduce API: TokenCache incompatibility issues with MR1
[
https://issues.apache.org/jira/browse/MAPREDUCE-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13673373#comment-13673373
]
Daryn Sharp commented on MAPREDUCE-5275:
Retro -1.
Why are we resurrecting APIs marked @InterfaceAudience.Private in 1.x? And
now making them public in 2.x?
{{TokenCache#getDelegationToken}} was intentionally removed since it is
fundamentally incompatible with multi-token filesystems like viewfs. It's also
not legitimate for external callers to be guessing/assuming the token key for a
fs. In fact, it's about to change soon, so this method cannot be retained.
Mapreduce API: TokenCache incompatibility issues with MR1
-
Key: MAPREDUCE-5275
URL: https://issues.apache.org/jira/browse/MAPREDUCE-5275
Project: Hadoop Map/Reduce
Issue Type: Sub-task
Reporter: Zhijie Shen
Assignee: Mayank Bansal
Fix For: 2.1.0-beta
Attachments: MAPREDUCE-5275-trunk-1.patch,
MAPREDUCE-5275-trunk-2.patch, MAPREDUCE-5275-trunk-3.patch,
MAPREDUCE-5275-trunk-4.patch
There're following incompatibility issues:
* TokenDelegationTokenIdentifier getDelegationToken(Credentials, String) is
removed
* Credentials loadTokens(String, Configuration) changes to Credentials
loadTokens(String, JobConf)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5275) Mapreduce API: TokenCache incompatibility issues with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13673391#comment-13673391 ] Vinod Kumar Vavilapalli commented on MAPREDUCE-5275: I just verified again and it IS public in 1.x. If and when 'it changes soon', you can remove it and mark it as incompatible at that point of time. Even so, the API is taking in a 'namenode', so it can be supported even for viewfs. Mapreduce API: TokenCache incompatibility issues with MR1 - Key: MAPREDUCE-5275 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5275 Project: Hadoop Map/Reduce Issue Type: Sub-task Reporter: Zhijie Shen Assignee: Mayank Bansal Fix For: 2.1.0-beta Attachments: MAPREDUCE-5275-trunk-1.patch, MAPREDUCE-5275-trunk-2.patch, MAPREDUCE-5275-trunk-3.patch, MAPREDUCE-5275-trunk-4.patch There're following incompatibility issues: * TokenDelegationTokenIdentifier getDelegationToken(Credentials, String) is removed * Credentials loadTokens(String, Configuration) changes to Credentials loadTokens(String, JobConf) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5275) Mapreduce API: TokenCache incompatibility issues with MR1
[
https://issues.apache.org/jira/browse/MAPREDUCE-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13673470#comment-13673470
]
Daryn Sharp commented on MAPREDUCE-5275:
bq. I just verified again and it IS public in 1.x.
Yes, in 1.x it has the {{public}} keyword, but it's annotated
{{@InterfaceAudience.Private}} and the class is annotated
{{@InterfaceStability.Evolving}}. A method assuming a 1-to-1 fs to token
mapping cannot work with viewfs and 1-to-many.
The real question is why are we re-adding evolving/private methods removed 9
months ago? What broke? Because it's already broken for viewfs, based on
fragile assumptions if not broken in other cases, and soon the whole assumption
changes. It won't be a problem if a retired private api stays retired.
Mapreduce API: TokenCache incompatibility issues with MR1
-
Key: MAPREDUCE-5275
URL: https://issues.apache.org/jira/browse/MAPREDUCE-5275
Project: Hadoop Map/Reduce
Issue Type: Sub-task
Reporter: Zhijie Shen
Assignee: Mayank Bansal
Fix For: 2.1.0-beta
Attachments: MAPREDUCE-5275-trunk-1.patch,
MAPREDUCE-5275-trunk-2.patch, MAPREDUCE-5275-trunk-3.patch,
MAPREDUCE-5275-trunk-4.patch
There're following incompatibility issues:
* TokenDelegationTokenIdentifier getDelegationToken(Credentials, String) is
removed
* Credentials loadTokens(String, Configuration) changes to Credentials
loadTokens(String, JobConf)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5275) Mapreduce API: TokenCache incompatibility issues with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13673491#comment-13673491 ] Vinod Kumar Vavilapalli commented on MAPREDUCE-5275: bq. Yes, in 1.x it has the public keyword, but it's annotated @InterfaceAudience.Private and the class is annotated @InterfaceStability.Evolving. A method assuming a 1-to-1 fs to token mapping cannot work with viewfs and 1-to-many. I didn't mean java public. I don't see the annotation in branch-1. It is commented in code - that doesn't mean it is private. Which branch are you seeing? bq. The real question is why are we re-adding evolving/private methods removed 9 months ago? We are just comparing 1.x with 2.x and fixing all changes *if possible*. Mapreduce API: TokenCache incompatibility issues with MR1 - Key: MAPREDUCE-5275 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5275 Project: Hadoop Map/Reduce Issue Type: Sub-task Reporter: Zhijie Shen Assignee: Mayank Bansal Fix For: 2.1.0-beta Attachments: MAPREDUCE-5275-trunk-1.patch, MAPREDUCE-5275-trunk-2.patch, MAPREDUCE-5275-trunk-3.patch, MAPREDUCE-5275-trunk-4.patch There're following incompatibility issues: * TokenDelegationTokenIdentifier getDelegationToken(Credentials, String) is removed * Credentials loadTokens(String, Configuration) changes to Credentials loadTokens(String, JobConf) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5275) Mapreduce API: TokenCache incompatibility issues with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13673560#comment-13673560 ] Daryn Sharp commented on MAPREDUCE-5275: It's been annotated, although commented out, as far back as branch-0.20.203. The annotations are not commented out in branch-21 and later. A number of methods in the TC were added in Jan 2010 to branch-21 via MAPREDUCE-143. The methods were annotated private. The backport of the patch to branch-20 commented out the annotations, as seemed somewhat common at the time - probably dependency issues. If you agree there's not a compelling reason to restore broken methods never intended to be public, could you please revert the patch? Mapreduce API: TokenCache incompatibility issues with MR1 - Key: MAPREDUCE-5275 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5275 Project: Hadoop Map/Reduce Issue Type: Sub-task Reporter: Zhijie Shen Assignee: Mayank Bansal Fix For: 2.1.0-beta Attachments: MAPREDUCE-5275-trunk-1.patch, MAPREDUCE-5275-trunk-2.patch, MAPREDUCE-5275-trunk-3.patch, MAPREDUCE-5275-trunk-4.patch There're following incompatibility issues: * TokenDelegationTokenIdentifier getDelegationToken(Credentials, String) is removed * Credentials loadTokens(String, Configuration) changes to Credentials loadTokens(String, JobConf) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5275) Mapreduce API: TokenCache incompatibility issues with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13672047#comment-13672047 ] Hudson commented on MAPREDUCE-5275: --- Integrated in Hadoop-Yarn-trunk #227 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/227/]) MAPREDUCE-5275. Bring back a couple of APIs in mapreduce.security.TokenCache for binary compatibility with 1.x mapreduce APIs. Contributed by Mayank Bansal. (Revision 1488369) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1488369 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/security/TokenCache.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/security/TestTokenCache.java Mapreduce API: TokenCache incompatibility issues with MR1 - Key: MAPREDUCE-5275 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5275 Project: Hadoop Map/Reduce Issue Type: Sub-task Reporter: Zhijie Shen Assignee: Mayank Bansal Fix For: 2.1.0-beta Attachments: MAPREDUCE-5275-trunk-1.patch, MAPREDUCE-5275-trunk-2.patch, MAPREDUCE-5275-trunk-3.patch, MAPREDUCE-5275-trunk-4.patch There're following incompatibility issues: * TokenDelegationTokenIdentifier getDelegationToken(Credentials, String) is removed * Credentials loadTokens(String, Configuration) changes to Credentials loadTokens(String, JobConf) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5275) Mapreduce API: TokenCache incompatibility issues with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13672092#comment-13672092 ] Hudson commented on MAPREDUCE-5275: --- Integrated in Hadoop-Hdfs-trunk #1417 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1417/]) MAPREDUCE-5275. Bring back a couple of APIs in mapreduce.security.TokenCache for binary compatibility with 1.x mapreduce APIs. Contributed by Mayank Bansal. (Revision 1488369) Result = FAILURE vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1488369 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/security/TokenCache.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/security/TestTokenCache.java Mapreduce API: TokenCache incompatibility issues with MR1 - Key: MAPREDUCE-5275 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5275 Project: Hadoop Map/Reduce Issue Type: Sub-task Reporter: Zhijie Shen Assignee: Mayank Bansal Fix For: 2.1.0-beta Attachments: MAPREDUCE-5275-trunk-1.patch, MAPREDUCE-5275-trunk-2.patch, MAPREDUCE-5275-trunk-3.patch, MAPREDUCE-5275-trunk-4.patch There're following incompatibility issues: * TokenDelegationTokenIdentifier getDelegationToken(Credentials, String) is removed * Credentials loadTokens(String, Configuration) changes to Credentials loadTokens(String, JobConf) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5275) Mapreduce API: TokenCache incompatibility issues with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13672111#comment-13672111 ] Hudson commented on MAPREDUCE-5275: --- Integrated in Hadoop-Mapreduce-trunk #1443 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1443/]) MAPREDUCE-5275. Bring back a couple of APIs in mapreduce.security.TokenCache for binary compatibility with 1.x mapreduce APIs. Contributed by Mayank Bansal. (Revision 1488369) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1488369 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/security/TokenCache.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/security/TestTokenCache.java Mapreduce API: TokenCache incompatibility issues with MR1 - Key: MAPREDUCE-5275 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5275 Project: Hadoop Map/Reduce Issue Type: Sub-task Reporter: Zhijie Shen Assignee: Mayank Bansal Fix For: 2.1.0-beta Attachments: MAPREDUCE-5275-trunk-1.patch, MAPREDUCE-5275-trunk-2.patch, MAPREDUCE-5275-trunk-3.patch, MAPREDUCE-5275-trunk-4.patch There're following incompatibility issues: * TokenDelegationTokenIdentifier getDelegationToken(Credentials, String) is removed * Credentials loadTokens(String, Configuration) changes to Credentials loadTokens(String, JobConf) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5275) Mapreduce API: TokenCache incompatibility issues with MR1
[
https://issues.apache.org/jira/browse/MAPREDUCE-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13671208#comment-13671208
]
Hadoop QA commented on MAPREDUCE-5275:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12585558/MAPREDUCE-5275-trunk-3.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3707//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3707//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3707//console
This message is automatically generated.
Mapreduce API: TokenCache incompatibility issues with MR1
-
Key: MAPREDUCE-5275
URL: https://issues.apache.org/jira/browse/MAPREDUCE-5275
Project: Hadoop Map/Reduce
Issue Type: Sub-task
Reporter: Zhijie Shen
Assignee: Mayank Bansal
Attachments: MAPREDUCE-5275-trunk-1.patch,
MAPREDUCE-5275-trunk-2.patch, MAPREDUCE-5275-trunk-3.patch
There're following incompatibility issues:
* TokenDelegationTokenIdentifier getDelegationToken(Credentials, String) is
removed
* Credentials loadTokens(String, Configuration) changes to Credentials
loadTokens(String, JobConf)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5275) Mapreduce API: TokenCache incompatibility issues with MR1
[
https://issues.apache.org/jira/browse/MAPREDUCE-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13671246#comment-13671246
]
Hadoop QA commented on MAPREDUCE-5275:
--
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12585561/MAPREDUCE-5275-trunk-4.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3708//testReport/
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3708//console
This message is automatically generated.
Mapreduce API: TokenCache incompatibility issues with MR1
-
Key: MAPREDUCE-5275
URL: https://issues.apache.org/jira/browse/MAPREDUCE-5275
Project: Hadoop Map/Reduce
Issue Type: Sub-task
Reporter: Zhijie Shen
Assignee: Mayank Bansal
Attachments: MAPREDUCE-5275-trunk-1.patch,
MAPREDUCE-5275-trunk-2.patch, MAPREDUCE-5275-trunk-3.patch,
MAPREDUCE-5275-trunk-4.patch
There're following incompatibility issues:
* TokenDelegationTokenIdentifier getDelegationToken(Credentials, String) is
removed
* Credentials loadTokens(String, Configuration) changes to Credentials
loadTokens(String, JobConf)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5275) Mapreduce API: TokenCache incompatibility issues with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13671774#comment-13671774 ] Vinod Kumar Vavilapalli commented on MAPREDUCE-5275: +1, looks good now. Checking this in.. Mapreduce API: TokenCache incompatibility issues with MR1 - Key: MAPREDUCE-5275 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5275 Project: Hadoop Map/Reduce Issue Type: Sub-task Reporter: Zhijie Shen Assignee: Mayank Bansal Attachments: MAPREDUCE-5275-trunk-1.patch, MAPREDUCE-5275-trunk-2.patch, MAPREDUCE-5275-trunk-3.patch, MAPREDUCE-5275-trunk-4.patch There're following incompatibility issues: * TokenDelegationTokenIdentifier getDelegationToken(Credentials, String) is removed * Credentials loadTokens(String, Configuration) changes to Credentials loadTokens(String, JobConf) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5275) Mapreduce API: TokenCache incompatibility issues with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13671782#comment-13671782 ] Hudson commented on MAPREDUCE-5275: --- Integrated in Hadoop-trunk-Commit #3822 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/3822/]) MAPREDUCE-5275. Bring back a couple of APIs in mapreduce.security.TokenCache for binary compatibility with 1.x mapreduce APIs. Contributed by Mayank Bansal. (Revision 1488369) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1488369 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/security/TokenCache.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/security/TestTokenCache.java Mapreduce API: TokenCache incompatibility issues with MR1 - Key: MAPREDUCE-5275 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5275 Project: Hadoop Map/Reduce Issue Type: Sub-task Reporter: Zhijie Shen Assignee: Mayank Bansal Fix For: 2.1.0-beta Attachments: MAPREDUCE-5275-trunk-1.patch, MAPREDUCE-5275-trunk-2.patch, MAPREDUCE-5275-trunk-3.patch, MAPREDUCE-5275-trunk-4.patch There're following incompatibility issues: * TokenDelegationTokenIdentifier getDelegationToken(Credentials, String) is removed * Credentials loadTokens(String, Configuration) changes to Credentials loadTokens(String, JobConf) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5275) Mapreduce API: TokenCache incompatibility issues with MR1
[
https://issues.apache.org/jira/browse/MAPREDUCE-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13670949#comment-13670949
]
Zhijie Shen commented on MAPREDUCE-5275:
bq. I had an offline discussion with vinod, For this to work we would need
build time dependency. What we should do here?
One way to walk around is as follows:
{code}
public static Token?
getDelegationToken(Credentials credentials, String namenode) {
return (Token?)
credentials.getToken(new Text(namenode));
}
{code}
No additional dependency is required, but is binary compatible.
Mapreduce API: TokenCache incompatibility issues with MR1
-
Key: MAPREDUCE-5275
URL: https://issues.apache.org/jira/browse/MAPREDUCE-5275
Project: Hadoop Map/Reduce
Issue Type: Sub-task
Reporter: Zhijie Shen
Assignee: Mayank Bansal
Attachments: MAPREDUCE-5275-trunk-1.patch
There're following incompatibility issues:
* TokenDelegationTokenIdentifier getDelegationToken(Credentials, String) is
removed
* Credentials loadTokens(String, Configuration) changes to Credentials
loadTokens(String, JobConf)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5275) Mapreduce API: TokenCache incompatibility issues with MR1
[
https://issues.apache.org/jira/browse/MAPREDUCE-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13670988#comment-13670988
]
Hadoop QA commented on MAPREDUCE-5275:
--
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12585503/MAPREDUCE-5275-trunk-2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3702//testReport/
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3702//console
This message is automatically generated.
Mapreduce API: TokenCache incompatibility issues with MR1
-
Key: MAPREDUCE-5275
URL: https://issues.apache.org/jira/browse/MAPREDUCE-5275
Project: Hadoop Map/Reduce
Issue Type: Sub-task
Reporter: Zhijie Shen
Assignee: Mayank Bansal
Attachments: MAPREDUCE-5275-trunk-1.patch,
MAPREDUCE-5275-trunk-2.patch
There're following incompatibility issues:
* TokenDelegationTokenIdentifier getDelegationToken(Credentials, String) is
removed
* Credentials loadTokens(String, Configuration) changes to Credentials
loadTokens(String, JobConf)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5275) Mapreduce API: TokenCache incompatibility issues with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13670993#comment-13670993 ] Zhijie Shen commented on MAPREDUCE-5275: +1. Looks good to me now. Mapreduce API: TokenCache incompatibility issues with MR1 - Key: MAPREDUCE-5275 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5275 Project: Hadoop Map/Reduce Issue Type: Sub-task Reporter: Zhijie Shen Assignee: Mayank Bansal Attachments: MAPREDUCE-5275-trunk-1.patch, MAPREDUCE-5275-trunk-2.patch There're following incompatibility issues: * TokenDelegationTokenIdentifier getDelegationToken(Credentials, String) is removed * Credentials loadTokens(String, Configuration) changes to Credentials loadTokens(String, JobConf) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5275) Mapreduce API: TokenCache incompatibility issues with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13670999#comment-13670999 ] Vinod Kumar Vavilapalli commented on MAPREDUCE-5275: I think the changes to loadTokens will breaking binary compatibility. Why not just add a new method which calls the existing method? Mapreduce API: TokenCache incompatibility issues with MR1 - Key: MAPREDUCE-5275 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5275 Project: Hadoop Map/Reduce Issue Type: Sub-task Reporter: Zhijie Shen Assignee: Mayank Bansal Attachments: MAPREDUCE-5275-trunk-1.patch, MAPREDUCE-5275-trunk-2.patch There're following incompatibility issues: * TokenDelegationTokenIdentifier getDelegationToken(Credentials, String) is removed * Credentials loadTokens(String, Configuration) changes to Credentials loadTokens(String, JobConf) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5275) Mapreduce API: TokenCache incompatibility issues with MR1
[ https://issues.apache.org/jira/browse/MAPREDUCE-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13669642#comment-13669642 ] Mayank Bansal commented on MAPREDUCE-5275: -- TokenDelegationTokenIdentifier getDelegationToken(Credentials, String) is removed I had an offline discussion with vinod, For this to work we would need build time dependency. What we should do here? For the other one updating the trivial patch. Thanks, Mayank Mapreduce API: TokenCache incompatibility issues with MR1 - Key: MAPREDUCE-5275 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5275 Project: Hadoop Map/Reduce Issue Type: Sub-task Reporter: Zhijie Shen Assignee: Mayank Bansal There're following incompatibility issues: * TokenDelegationTokenIdentifier getDelegationToken(Credentials, String) is removed * Credentials loadTokens(String, Configuration) changes to Credentials loadTokens(String, JobConf) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-5275) Mapreduce API: TokenCache incompatibility issues with MR1
[
https://issues.apache.org/jira/browse/MAPREDUCE-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13669695#comment-13669695
]
Hadoop QA commented on MAPREDUCE-5275:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12585287/MAPREDUCE-5275-trunk-1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3688//testReport/
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3688//console
This message is automatically generated.
Mapreduce API: TokenCache incompatibility issues with MR1
-
Key: MAPREDUCE-5275
URL: https://issues.apache.org/jira/browse/MAPREDUCE-5275
Project: Hadoop Map/Reduce
Issue Type: Sub-task
Reporter: Zhijie Shen
Assignee: Mayank Bansal
Attachments: MAPREDUCE-5275-trunk-1.patch
There're following incompatibility issues:
* TokenDelegationTokenIdentifier getDelegationToken(Credentials, String) is
removed
* Credentials loadTokens(String, Configuration) changes to Credentials
loadTokens(String, JobConf)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
