[jira] [Commented] (MAPREDUCE-5708) Duplicate String.format in getSpillFileForWrite
[
https://issues.apache.org/jira/browse/MAPREDUCE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525483#comment-14525483
]
Hadoop QA commented on MAPREDUCE-5708:
--
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 39s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 29s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 35s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 35s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 0m 57s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | mapreduce tests | 9m 12s | Tests passed in
hadoop-mapreduce-client-app. |
| | | 44m 58s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12621475/0001-Removed-duplicate-String.format.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 6ae2a0d |
| hadoop-mapreduce-client-app test log |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5599/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5599/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5599/console |
This message was automatically generated.
> Duplicate String.format in getSpillFileForWrite
> ---
>
> Key: MAPREDUCE-5708
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5708
> Project: Hadoop Map/Reduce
> Issue Type: Bug
>Reporter: Konstantin Weitz
>Priority: Minor
> Attachments: 0001-Removed-duplicate-String.format.patch
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> The code responsible for formatting the spill file name (namely
> _getSpillFileForWrite_) unnecessarily calls _String.format_ twice. This does
> not only affect performance, but leads to the weird requirement that task
> attempt ids cannot contain _%_ characters (because these would be interpreted
> as format specifiers in the outside _String.format_ call).
> I assume this was done by mistake, as it could only be useful if task attempt
> ids contained _%n_.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MAPREDUCE-5708) Duplicate String.format in getSpillFileForWrite
[ https://issues.apache.org/jira/browse/MAPREDUCE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13872700#comment-13872700 ] Konstantin Weitz commented on MAPREDUCE-5708: - Because of the simplicity of the fix, writing a test case would not be worthwhile. Because of the locality and size of the change, I used manual inspection to verify that the patch fixes the problem and does not introduce new problems. > Duplicate String.format in getSpillFileForWrite > --- > > Key: MAPREDUCE-5708 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5708 > Project: Hadoop Map/Reduce > Issue Type: Bug >Reporter: Konstantin Weitz >Priority: Minor > Attachments: 0001-Removed-duplicate-String.format.patch > > Original Estimate: 10m > Remaining Estimate: 10m > > The code responsible for formatting the spill file name (namely > _getSpillFileForWrite_) unnecessarily calls _String.format_ twice. This does > not only affect performance, but leads to the weird requirement that task > attempt ids cannot contain _%_ characters (because these would be interpreted > as format specifiers in the outside _String.format_ call). > I assume this was done by mistake, as it could only be useful if task attempt > ids contained _%n_. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (MAPREDUCE-5708) Duplicate String.format in getSpillFileForWrite
[
https://issues.apache.org/jira/browse/MAPREDUCE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13862379#comment-13862379
]
Hadoop QA commented on MAPREDUCE-5708:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12621475/0001-Removed-duplicate-String.format.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4302//testReport/
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4302//console
This message is automatically generated.
> Duplicate String.format in getSpillFileForWrite
> ---
>
> Key: MAPREDUCE-5708
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5708
> Project: Hadoop Map/Reduce
> Issue Type: Bug
>Reporter: Konstantin Weitz
>Priority: Minor
> Attachments: 0001-Removed-duplicate-String.format.patch
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> The code responsible for formatting the spill file name (namely
> _getSpillFileForWrite_) unnecessarily calls _String.format_ twice. This does
> not only affect performance, but leads to the weird requirement that task
> attempt ids cannot contain _%_ characters (because these would be interpreted
> as format specifiers in the outside _String.format_ call).
> I assume this was done by mistake, as it could only be useful if task attempt
> ids contained _%n_.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
